You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@cxf.apache.org by vbogatyrov <bo...@ymail.com> on 2016/08/24 10:37:10 UTC
Metrics feature doesn't count faults on provider side
I use cxf-rt-features-metrics feature on provider side of a SOAP service.
When RuntimeException is thrown in provider's business code and soap:fault
is returned to consumer, all the fault counters show 0.
Debugging shows that when a fault check is performed
https://github.com/apache/cxf/blob/master/rt/features/metrics/src/main/java/org/apache/cxf/metrics/codahale/CodahaleMetricsContext.java#L91
exchange object doens't contain FaultMode object, but corresponding message
object does, so that ex.getInMessage().get(FaultMode.class) returns non null
object.
It would be good to have this working.
--
View this message in context: http://cxf.547215.n5.nabble.com/Metrics-feature-doesn-t-count-faults-on-provider-side-tp5771827.html
Sent from the cxf-user mailing list archive at Nabble.com.
Re: Metrics feature doesn't count faults on provider side
Posted by Daniel Kulp <dk...@apache.org>.
Just pushed a fix for this. Should be all set.
Dan
> On Aug 24, 2016, at 6:37 AM, vbogatyrov <bo...@ymail.com> wrote:
>
> I use cxf-rt-features-metrics feature on provider side of a SOAP service.
> When RuntimeException is thrown in provider's business code and soap:fault
> is returned to consumer, all the fault counters show 0.
>
>
> Debugging shows that when a fault check is performed
>
> https://github.com/apache/cxf/blob/master/rt/features/metrics/src/main/java/org/apache/cxf/metrics/codahale/CodahaleMetricsContext.java#L91
>
> exchange object doens't contain FaultMode object, but corresponding message
> object does, so that ex.getInMessage().get(FaultMode.class) returns non null
> object.
>
> It would be good to have this working.
>
>
>
> --
> View this message in context: http://cxf.547215.n5.nabble.com/Metrics-feature-doesn-t-count-faults-on-provider-side-tp5771827.html
> Sent from the cxf-user mailing list archive at Nabble.com.
--
Daniel Kulp
dkulp@apache.org <ma...@apache.org> - http://dankulp.com/blog <http://dankulp.com/blog>
Talend Community Coder - http://coders.talend.com <http://coders.talend.com/>