You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by "H. Hernan Moraldo" <ga...@moraldo.com.ar> on 2004/03/12 23:10:40 UTC
[PATCH] including stdlib in source files
Log message:
Include stdlib.h on files that were including this indirectly, through
svn_types.h.
* subversion/svnadmin/main.c
* subversion/svnlook/main.c
* subversion/clients/cmdline/main.c
* subversion/tests/libsvn_subr/target-test.c
* subversion/svndumpfilter/main.c
* subversion/svnserve/main.c
* subversion/svnversion/main.c
stdlib.h is now directly #included on these
files.
(end of log)
The patch is the same that in my latest message, but here is again, with
a new mail subject and its respective log message. Now I'll look for
more significative changes to the SVN code.
Best regards,
--
H. Hernan Moraldo
Moraldo Games
http://games.moraldo.com.ar/
Re: [PATCH] including stdlib in source files
Posted by "H. Hernan Moraldo" <ga...@moraldo.com.ar>.
> This patch is incomplete. Those are only a few of the files that should include <stdlib.h> directly. There are many more. Remove "#include <stdlib.h>" from svn_types.h and then look for warnings like this:
>
> /home/julianfoad/src/subversion/subversion/libsvn_delta/path_driver.c:158: warning: implicit declaration of function `qsort'
Sorry, I hadn't noticed it. I'll correct it and send another patch soon.
Best regards,
--
H. Hernan Moraldo
Moraldo Games
http://games.moraldo.com.ar/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] including stdlib in source files
Posted by Julian Foad <ju...@btopenworld.com>.
H. Hernan Moraldo wrote:
> Log message:
>
> Include stdlib.h on files that were including this indirectly, through
> svn_types.h.
>
> * subversion/svnadmin/main.c
> * subversion/svnlook/main.c
> * subversion/clients/cmdline/main.c
> * subversion/tests/libsvn_subr/target-test.c
> * subversion/svndumpfilter/main.c
> * subversion/svnserve/main.c
> * subversion/svnversion/main.c
> stdlib.h is now directly #included on these
> files.
This patch is incomplete. Those are only a few of the files that should include <stdlib.h> directly. There are many more. Remove "#include <stdlib.h>" from svn_types.h and then look for warnings like this:
/home/julianfoad/src/subversion/subversion/libsvn_delta/path_driver.c:158: warning: implicit declaration of function `qsort'
- Julian
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org