[GitHub] [geode] pdxrunner commented on pull request #3187: DO NOT REVIEW Geode 6174 idempotency

["pdxrunner (GitHub)" <gi...@apache.org>]

Thanks for the thoughtful comments. WRT idempotency: In our context, is the command idempotent if the cluster state doesn't change and the persisted configuration doesn't change, even if the text portion of the command response is different? 

In the legacy geode commands we have considered the command idempotent if nothing in the cluster changes even though them textual result from the command differs between the original and repeat executions.

If we need to not make cluster changes AND respond with identical `ClusterManagementResult` java objects and JSON strings in the REST request repsonse bodies, than that will be difficult to achieve because the underlying operations on the cluster members handle initial and repeat calls differently, even though the repeat calls don't make any changes in the cluster state.

Another point to consider is what is a repeated request. In this initial implementation we are on;y considering the region name being the same. We don't look at the region type parameter.


[ Full content available at: https://github.com/apache/geode/pull/3187 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org