You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by jl...@apache.org on 2019/06/28 11:53:56 UTC

svn commit: r1862278 - in /ofbiz/ofbiz-framework/trunk/applications/manufacturing: config/ManufacturingUiLabels.xml webapp/manufacturing/WEB-INF/controller.xml widget/manufacturing/MrpScreens.xml

Author: jleroux
Date: Fri Jun 28 11:53:55 2019
New Revision: 1862278

URL: http://svn.apache.org/viewvc?rev=1862278&view=rev
Log:
Fixed: User should be notified with success message on MRP run in manufacturing component
(OFBIZ-9533)

Steps to regenerate:
1. Go to Manufacturing component (manufacturing/control/main)
2. Click on Mrp sub menu (manufacturing/control/FindInventoryEventPlan)
3. Click on Run Mrp button.(manufacturing/control/RunMrp)
4. Select Facility/Facility Group and Click Submit button.
On success, the user should be notified with success message like 
"Mrp run is scheduled".

jleroux: despite being a sub-task of an improvement I decided to backport. 
It works well and nothing could go wrong, only UI changes.

Thanks: Aditya Sharma for report, Humera Khan for the fix, Prachi Shastri for
testing and Pierre Smits for noticing this could be backported (despite being
a sub-task of an improvement)

Modified:
    ofbiz/ofbiz-framework/trunk/applications/manufacturing/config/ManufacturingUiLabels.xml
    ofbiz/ofbiz-framework/trunk/applications/manufacturing/webapp/manufacturing/WEB-INF/controller.xml
    ofbiz/ofbiz-framework/trunk/applications/manufacturing/widget/manufacturing/MrpScreens.xml

Modified: ofbiz/ofbiz-framework/trunk/applications/manufacturing/config/ManufacturingUiLabels.xml
URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/manufacturing/config/ManufacturingUiLabels.xml?rev=1862278&r1=1862277&r2=1862278&view=diff
==============================================================================
--- ofbiz/ofbiz-framework/trunk/applications/manufacturing/config/ManufacturingUiLabels.xml (original)
+++ ofbiz/ofbiz-framework/trunk/applications/manufacturing/config/ManufacturingUiLabels.xml Fri Jun 28 11:53:55 2019
@@ -3112,6 +3112,10 @@
         <value xml:lang="zh">生产资源计划名称</value>
         <value xml:lang="zh-TW">生產資源計劃名稱</value>
     </property>
+    <property key="ManufacturingMrpRunScheduledSuccessfully">
+        <value xml:lang="en">Mrp run scheduled successfully</value>
+        <value xml:lang="fr">Exécution de Mrp programmée avec succès</value>
+    </property>
     <property key="ManufacturingNewCalendar">
         <value xml:lang="de">Neuer Kalender</value>
         <value xml:lang="en">New calendar</value>

Modified: ofbiz/ofbiz-framework/trunk/applications/manufacturing/webapp/manufacturing/WEB-INF/controller.xml
URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/manufacturing/webapp/manufacturing/WEB-INF/controller.xml?rev=1862278&r1=1862277&r2=1862278&view=diff
==============================================================================
--- ofbiz/ofbiz-framework/trunk/applications/manufacturing/webapp/manufacturing/WEB-INF/controller.xml (original)
+++ ofbiz/ofbiz-framework/trunk/applications/manufacturing/webapp/manufacturing/WEB-INF/controller.xml Fri Jun 28 11:53:55 2019
@@ -465,7 +465,7 @@ under the License.
     <request-map uri="runMrpGo">
         <security https="true" auth="true"/>
         <event type="service" invoke="executeMrp" path="async"/>
-        <response name="success" type="view" value="MrpExecution"/>
+        <response name="success" type="view" value="RunMrpGo"/>
         <response name="error" type="view" value="MrpExecution"/>
     </request-map>
 
@@ -871,6 +871,7 @@ under the License.
     <!-- MRP view mappings -->
     <view-map name="FindMrpPlannedEvents" type="screen" page="component://manufacturing/widget/manufacturing/MrpScreens.xml#FindMrpPlannedEvents"/>
     <view-map name="MrpExecution" type="screen" page="component://manufacturing/widget/manufacturing/MrpScreens.xml#MrpExecution"/>
+    <view-map name="RunMrpGo" page="component://manufacturing/widget/manufacturing/MrpScreens.xml#RunMrpGo" type="screen"/>
     <view-map name="ManufacturingReports" type="screen" page="component://manufacturing/widget/manufacturing/ReportScreens.xml#ManufacturingReports"/>
 
     <!-- JobShop Management view mappings -->

Modified: ofbiz/ofbiz-framework/trunk/applications/manufacturing/widget/manufacturing/MrpScreens.xml
URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/manufacturing/widget/manufacturing/MrpScreens.xml?rev=1862278&r1=1862277&r2=1862278&view=diff
==============================================================================
--- ofbiz/ofbiz-framework/trunk/applications/manufacturing/widget/manufacturing/MrpScreens.xml (original)
+++ ofbiz/ofbiz-framework/trunk/applications/manufacturing/widget/manufacturing/MrpScreens.xml Fri Jun 28 11:53:55 2019
@@ -54,6 +54,25 @@ under the License.
             </widgets>
         </section>
     </screen>
+    <screen name="RunMrpGo">
+        <section>
+            <actions>
+                <set field="titleProperty" value="ManufacturingRunMrp"/>
+                <set field="tabButtonItem" value="RunMrp"/>
+                <set field="headerItem" value="mrp"/>
+                <set field="eventMessage" value="${groovy: org.apache.ofbiz.base.util.UtilProperties.getMessage('ManufacturingUiLabels', 'ManufacturingMrpRunScheduledSuccessfully', locale)}"/>
+            </actions>
+            <widgets>
+                <decorator-screen name="CommonMrpDecorator">
+                    <decorator-section name="body">
+                        <screenlet title="${uiLabelMap.ManufacturingRunMrp}">
+                            <include-form name="RunMrp" location="component://manufacturing/widget/manufacturing/MrpForms.xml"/>
+                        </screenlet>
+                    </decorator-section>
+                </decorator-screen>
+            </widgets>
+        </section>
+    </screen>
     <screen name="FindMrpPlannedEvents">
         <section>
             <actions>