You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by pa...@apache.org on 2021/11/05 05:06:49 UTC
[shardingsphere] branch master updated: Fix column value match
shadow algorithm bug. (#13469)
This is an automated email from the ASF dual-hosted git repository.
panjuan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git
The following commit(s) were added to refs/heads/master by this push:
new c82e1a4 Fix column value match shadow algorithm bug. (#13469)
c82e1a4 is described below
commit c82e1a490887ac38a6b91efa479d5e0bdc8d2f37
Author: gin <ja...@163.com>
AuthorDate: Fri Nov 5 13:05:47 2021 +0800
Fix column value match shadow algorithm bug. (#13469)
---
.../shadow/algorithm/shadow/column/ColumnValueMatchShadowAlgorithm.java | 2 +-
.../shadow/algorithm/shadow/note/SimpleSQLNoteShadowAlgorithm.java | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/shardingsphere-features/shardingsphere-shadow/shardingsphere-shadow-core/src/main/java/org/apache/shardingsphere/shadow/algorithm/shadow/column/ColumnValueMatchShadowAlgorithm.java b/shardingsphere-features/shardingsphere-shadow/shardingsphere-shadow-core/src/main/java/org/apache/shardingsphere/shadow/algorithm/shadow/column/ColumnValueMatchShadowAlgorithm.java
index d11759b..e934b6d 100644
--- a/shardingsphere-features/shardingsphere-shadow/shardingsphere-shadow-core/src/main/java/org/apache/shardingsphere/shadow/algorithm/shadow/column/ColumnValueMatchShadowAlgorithm.java
+++ b/shardingsphere-features/shardingsphere-shadow/shardingsphere-shadow-core/src/main/java/org/apache/shardingsphere/shadow/algorithm/shadow/column/ColumnValueMatchShadowAlgorithm.java
@@ -80,7 +80,7 @@ public final class ColumnValueMatchShadowAlgorithm implements ColumnShadowAlgori
boolean containTable = shadowTableNames.contains(shadowValue.getLogicTableName());
boolean isSameOperation = shadowOperationType == shadowValue.getShadowOperationType();
boolean isSameColumnName = Objects.equals(props.get(COLUMN), shadowValue.getColumnName());
- boolean isSameColumnValue = props.get(VALUE).toString().equals(shadowValue.getValue());
+ boolean isSameColumnValue = props.get(VALUE).toString().equals(String.valueOf(shadowValue.getValue()));
return containTable && isSameOperation && isSameColumnName && isSameColumnValue;
}
diff --git a/shardingsphere-features/shardingsphere-shadow/shardingsphere-shadow-core/src/main/java/org/apache/shardingsphere/shadow/algorithm/shadow/note/SimpleSQLNoteShadowAlgorithm.java b/shardingsphere-features/shardingsphere-shadow/shardingsphere-shadow-core/src/main/java/org/apache/shardingsphere/shadow/algorithm/shadow/note/SimpleSQLNoteShadowAlgorithm.java
index e657f0c..c301c92 100644
--- a/shardingsphere-features/shardingsphere-shadow/shardingsphere-shadow-core/src/main/java/org/apache/shardingsphere/shadow/algorithm/shadow/note/SimpleSQLNoteShadowAlgorithm.java
+++ b/shardingsphere-features/shardingsphere-shadow/shardingsphere-shadow-core/src/main/java/org/apache/shardingsphere/shadow/algorithm/shadow/note/SimpleSQLNoteShadowAlgorithm.java
@@ -45,7 +45,7 @@ public final class SimpleSQLNoteShadowAlgorithm implements NoteShadowAlgorithm<S
}
private void checkPropsSize() {
- Preconditions.checkState(!props.isEmpty(), "Simple note shadow algorithm props cannot be empty.");
+ Preconditions.checkState(!props.isEmpty(), "Simple hint shadow algorithm props cannot be empty.");
}
@Override