[GitHub] [arrow] pitrou commented on a diff in pull request #14370: ARROW-17973: [C++] Expression::ToString wrong for nullary function call

[GitBox <gi...@apache.org>]

pitrou commented on code in PR #14370:
URL: https://github.com/apache/arrow/pull/14370#discussion_r992046795


##########
cpp/src/arrow/compute/exec/expression_test.cc:
##########
@@ -284,8 +284,7 @@ TEST(Expression, ToString) {
       "allow_time_overflow=false, allow_decimal_truncate=false, "
       "allow_float_truncate=false, allow_invalid_utf8=false})");
 
-  // NB: corrupted for nullary functions but we don't have any of those
-  EXPECT_EQ(call("widgetify", {}).ToString(), "widgetif)");
+  EXPECT_EQ(call("widgetify", {}).ToString(), "widgetify()");

Review Comment:
   Can you also add a test with options?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org