You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/03/25 10:38:17 UTC

[GitHub] [flink] AHeise opened a new pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

AHeise opened a new pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507
 
 
   <!--
   *Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
   
   *Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
   
   ## Contribution Checklist
   
     - Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
     
     - Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
     Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
   
     - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
     
     - Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Travis CI to do that following [this guide](https://flink.apache.org/contributing/contribute-code.html#open-a-pull-request).
   
     - Each pull request should address only one issue, not mix up code from multiple issues.
     
     - Each commit in the pull request has a meaningful commit message (including the JIRA id)
   
     - Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
   
   
   **(The sections below can be removed for hotfixes of typos)**
   -->
   
   ## What is the purpose of the change
   
   This PR adds a `CheckpointBarrierUnaligner` as a central building block to unaligned checkpoints, which allows checkpoint barriers to overtake inflight data and write inflight data as part of a checkpoint.
   
   ## Brief change log
   
   - Making all channel-related classes aware of their index and allow positional access to all related classes (gates, input channels, (sub)partitions).
   - Adding feature toggle (turned off by default)
   - Allow buffers and barriers on input channels be handled by `CheckpointBarrierUnaligner`
   - Adding the basic `CheckpointBarrierUnaligner`
   - Allow checkpoint barriers to overtake input and output buffers
   - Passing inflight input and output buffers that have been skipped to the ChannelStateWriter
   
   ## Verifying this change
   
   - Added unit tests for non-trivial commits (WIP)
   - Added basic integration tests (smoke tests for now as the actual persisting of data is not implemented)
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (**yes** / no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (**yes** / no)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (**yes** / no / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (**yes** / no / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (**yes** / no)
     - If yes, how is the feature documented? (FLIP-76)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] pnowojski commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
pnowojski commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r399236422
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/AvailabilityProvider.java
 ##########
 @@ -66,6 +66,16 @@ default boolean isApproximatelyAvailable() {
 		return getAvailableFuture() == AVAILABLE;
 	}
 
+	/**
 
 Review comment:
   > Fix non-blocking output availability logic.
   
   I guess good catch, but deserves it's own Jira ticket and it's really missing a unit test.
   
   Can we extract this out of this PR and move it out from the MVP scope, to not block them?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zhijiangW commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
zhijiangW commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r400792947
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/ResultSubpartition.java
 ##########
 @@ -69,11 +64,15 @@ ResultSubpartitionInfo getSubpartitionInfo() {
 
 	protected abstract long getTotalNumberOfBytes();
 
+	public final int getSubPartitionIndex() {
 
 Review comment:
   nit: is it necessary to define `final` for method?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#issuecomment-603776093
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6621",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155064201",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155877268",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6755",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6839",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156597180",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6846",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156864478",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6873",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156994047",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157330632",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6900",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157451694",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6916",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157494634",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6933",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157589655",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6944",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6991",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157754467",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158102285",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7007",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7023",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158153241",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158188400",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7040",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7048",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158276096",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158831429",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7117",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7121",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158855200",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159112519",
       "triggerID" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7172",
       "triggerID" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159143719",
       "triggerID" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7175",
       "triggerID" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "triggerType" : "PUSH"
     }, {
       "hash" : "35ec088ef24e841beae78c33488975d2d8d0a40d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "35ec088ef24e841beae78c33488975d2d8d0a40d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7194",
       "triggerID" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159244661",
       "triggerID" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "triggerType" : "PUSH"
     }, {
       "hash" : "334458afaa98b601eec12c490e71caa8274be055",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "334458afaa98b601eec12c490e71caa8274be055",
       "triggerType" : "PUSH"
     }, {
       "hash" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7212",
       "triggerID" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "triggerType" : "PUSH"
     }, {
       "hash" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159269141",
       "triggerID" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7226",
       "triggerID" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159307415",
       "triggerID" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7297",
       "triggerID" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159652918",
       "triggerID" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "559816dcea4999dd46b09ee1091ddc0e1a5a7a54",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "559816dcea4999dd46b09ee1091ddc0e1a5a7a54",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6cd76afe4990f56a5166e1592374aa8f86fe883f",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "6cd76afe4990f56a5166e1592374aa8f86fe883f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7302",
       "triggerID" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159678447",
       "triggerID" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159695914",
       "triggerID" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7305",
       "triggerID" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ac996f5c703560ecbe6cad7394cc8ad54d6f0029",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "ac996f5c703560ecbe6cad7394cc8ad54d6f0029",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7347",
       "triggerID" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159875195",
       "triggerID" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "75c8130873e9b91e21e1e833d3d05f1ad9b5d2b8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7354",
       "triggerID" : "75c8130873e9b91e21e1e833d3d05f1ad9b5d2b8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7369",
       "triggerID" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "triggerType" : "PUSH"
     }, {
       "hash" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159960514",
       "triggerID" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7373",
       "triggerID" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159990549",
       "triggerID" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "triggerType" : "PUSH"
     }, {
       "hash" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7443",
       "triggerID" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160172375",
       "triggerID" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "536d9fb04a7a8142c04c94344dd0b3c0f2c10999",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160215439",
       "triggerID" : "536d9fb04a7a8142c04c94344dd0b3c0f2c10999",
       "triggerType" : "PUSH"
     }, {
       "hash" : "536d9fb04a7a8142c04c94344dd0b3c0f2c10999",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7469",
       "triggerID" : "536d9fb04a7a8142c04c94344dd0b3c0f2c10999",
       "triggerType" : "PUSH"
     }, {
       "hash" : "67018bacf5bc2daa8a03a1aafa880efc1db86808",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7500",
       "triggerID" : "67018bacf5bc2daa8a03a1aafa880efc1db86808",
       "triggerType" : "PUSH"
     }, {
       "hash" : "67018bacf5bc2daa8a03a1aafa880efc1db86808",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160347006",
       "triggerID" : "67018bacf5bc2daa8a03a1aafa880efc1db86808",
       "triggerType" : "PUSH"
     }, {
       "hash" : "79c116a6a1f5fe314f801e81f0265dea8b9ac1a7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7522",
       "triggerID" : "79c116a6a1f5fe314f801e81f0265dea8b9ac1a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "79c116a6a1f5fe314f801e81f0265dea8b9ac1a7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160377553",
       "triggerID" : "79c116a6a1f5fe314f801e81f0265dea8b9ac1a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "27ce4bfad8e99989dd64f8c636c934727da8a062",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "27ce4bfad8e99989dd64f8c636c934727da8a062",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ce0dfc7324679ebf2da84278eac8f5f59d748319",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7539",
       "triggerID" : "ce0dfc7324679ebf2da84278eac8f5f59d748319",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ce0dfc7324679ebf2da84278eac8f5f59d748319",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160418181",
       "triggerID" : "ce0dfc7324679ebf2da84278eac8f5f59d748319",
       "triggerType" : "PUSH"
     }, {
       "hash" : "05c934bf483d4fb673496783ef8ff85b40b86708",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "05c934bf483d4fb673496783ef8ff85b40b86708",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4bbe67a13a75f4491898fbb1cd2315237dbca30e",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160443829",
       "triggerID" : "4bbe67a13a75f4491898fbb1cd2315237dbca30e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4bbe67a13a75f4491898fbb1cd2315237dbca30e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7543",
       "triggerID" : "4bbe67a13a75f4491898fbb1cd2315237dbca30e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "cb5258f13c64ed033db7b8476122721ac418d798",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160496434",
       "triggerID" : "cb5258f13c64ed033db7b8476122721ac418d798",
       "triggerType" : "PUSH"
     }, {
       "hash" : "cb5258f13c64ed033db7b8476122721ac418d798",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7560",
       "triggerID" : "cb5258f13c64ed033db7b8476122721ac418d798",
       "triggerType" : "PUSH"
     }, {
       "hash" : "fdc673b8583650ce40a6f13b8a44d9773e14c370",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7597",
       "triggerID" : "fdc673b8583650ce40a6f13b8a44d9773e14c370",
       "triggerType" : "PUSH"
     }, {
       "hash" : "fdc673b8583650ce40a6f13b8a44d9773e14c370",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160543449",
       "triggerID" : "fdc673b8583650ce40a6f13b8a44d9773e14c370",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1123cc69ed817c9935bae5ffbba5e48f5bbe0f25",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7611",
       "triggerID" : "1123cc69ed817c9935bae5ffbba5e48f5bbe0f25",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1123cc69ed817c9935bae5ffbba5e48f5bbe0f25",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160619473",
       "triggerID" : "1123cc69ed817c9935bae5ffbba5e48f5bbe0f25",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dd5b4999b59b53950c2fb3784fc50ed97617f5aa",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "dd5b4999b59b53950c2fb3784fc50ed97617f5aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9e118a737919fb9c784d171ae06567030a5a9ecd",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160633665",
       "triggerID" : "9e118a737919fb9c784d171ae06567030a5a9ecd",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9e118a737919fb9c784d171ae06567030a5a9ecd",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7612",
       "triggerID" : "9e118a737919fb9c784d171ae06567030a5a9ecd",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7fc44ff1be1eaf8394b5b89735c412041c806407",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7631",
       "triggerID" : "7fc44ff1be1eaf8394b5b89735c412041c806407",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7fc44ff1be1eaf8394b5b89735c412041c806407",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160682148",
       "triggerID" : "7fc44ff1be1eaf8394b5b89735c412041c806407",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * dee2b337e5e72d8f7b1f5098b74f2958d000fb3c UNKNOWN
   * 80b7f76f24b5fb6704a4b2292543f8764ec19053 UNKNOWN
   * 35ec088ef24e841beae78c33488975d2d8d0a40d UNKNOWN
   * 334458afaa98b601eec12c490e71caa8274be055 UNKNOWN
   * 559816dcea4999dd46b09ee1091ddc0e1a5a7a54 UNKNOWN
   * 6cd76afe4990f56a5166e1592374aa8f86fe883f UNKNOWN
   * ac996f5c703560ecbe6cad7394cc8ad54d6f0029 UNKNOWN
   * 27ce4bfad8e99989dd64f8c636c934727da8a062 UNKNOWN
   * 05c934bf483d4fb673496783ef8ff85b40b86708 UNKNOWN
   * dd5b4999b59b53950c2fb3784fc50ed97617f5aa UNKNOWN
   * 9e118a737919fb9c784d171ae06567030a5a9ecd Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/160633665) Azure: [CANCELED](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7612) 
   * 7fc44ff1be1eaf8394b5b89735c412041c806407 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/160682148) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7631) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#issuecomment-603776093
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6621",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155064201",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155877268",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6755",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6839",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156597180",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6846",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156864478",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6873",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156994047",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157330632",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6900",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157451694",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6916",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157494634",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6933",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157589655",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6944",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6991",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157754467",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158102285",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7007",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7023",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158153241",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "FAILURE",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158188400",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7040",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7048",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158276096",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * dee2b337e5e72d8f7b1f5098b74f2958d000fb3c UNKNOWN
   * 80b7f76f24b5fb6704a4b2292543f8764ec19053 UNKNOWN
   * 49d5d3e1e8e1bf962716241b79db1f2e28e506b4 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/158188400) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7040) 
   * a8335f0def293f04fd74bfc47c1b31fc98a46a23 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/158276096) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7048) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] rkhachatryan commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r398957647
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/SingleInputGate.java
 ##########
 @@ -318,14 +345,16 @@ public void assignExclusiveSegments() throws IOException {
 		}
 	}
 
-	public void setInputChannel(InputChannel inputChannel) {
-		checkNotNull(inputChannel);
-		IntermediateResultPartitionID partitionId = inputChannel.getPartitionId().getPartitionId();
+	public void setInputChannels(InputChannel... channels) {
 		synchronized (requestLock) {
-			if (inputChannels.put(partitionId, inputChannel) == null
+			System.arraycopy(channels, 0, this.channels, 0, numberOfInputChannels);
 
 Review comment:
   Looks like this method should be part of constructor (though I see it's a pre-existing method and may require refactoring).
   
   If not, should we check that new length equals to `numberOfInputChannels`?
   If not, should we "truncate" the old values if the new array is shorter?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r408165079
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/SingleInputGate.java
 ##########
 @@ -170,9 +173,14 @@
 
 	private final CompletableFuture<Void> closeFuture;
 
+	@Nullable
+	protected BufferReceivedListener bufferReceivedListener;
 
 Review comment:
   This approach is an elegant solution in the case of unaligned checkpoints. However, on aligned checkpoint, it adds a volatile access to each access (as it's currently never non-null). 
   I could make the aligned case use a no-op listener, but that would cause unnecessary buffer copying in `RemoteInputChannel`...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#issuecomment-603776093
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6621",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155064201",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 46c39891af3d5ae037620c384f15d01b77419b1b Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/155064201) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6621) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#issuecomment-603776093
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6621",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155064201",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155877268",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6755",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6839",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156597180",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6846",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156864478",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6873",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "FAILURE",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156994047",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157330632",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6900",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * dee2b337e5e72d8f7b1f5098b74f2958d000fb3c UNKNOWN
   * 80b7f76f24b5fb6704a4b2292543f8764ec19053 UNKNOWN
   * ed38c05c90208ed62c1c5bd2bc769cf8844356a0 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/156994047) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6873) 
   * f18687d568167f3d70715fc67762564bb9757ee6 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/157330632) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6900) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#issuecomment-603776093
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6621",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155064201",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155877268",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6755",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6839",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156597180",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6846",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156864478",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6873",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156994047",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157330632",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6900",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157451694",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6916",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157494634",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6933",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157589655",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6944",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6991",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157754467",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158102285",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7007",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7023",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158153241",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158188400",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7040",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7048",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158276096",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158831429",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7117",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7121",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158855200",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159112519",
       "triggerID" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7172",
       "triggerID" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159143719",
       "triggerID" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7175",
       "triggerID" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "triggerType" : "PUSH"
     }, {
       "hash" : "35ec088ef24e841beae78c33488975d2d8d0a40d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "35ec088ef24e841beae78c33488975d2d8d0a40d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7194",
       "triggerID" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159244661",
       "triggerID" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "triggerType" : "PUSH"
     }, {
       "hash" : "334458afaa98b601eec12c490e71caa8274be055",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "334458afaa98b601eec12c490e71caa8274be055",
       "triggerType" : "PUSH"
     }, {
       "hash" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7212",
       "triggerID" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "triggerType" : "PUSH"
     }, {
       "hash" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159269141",
       "triggerID" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7226",
       "triggerID" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "status" : "FAILURE",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159307415",
       "triggerID" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * dee2b337e5e72d8f7b1f5098b74f2958d000fb3c UNKNOWN
   * 80b7f76f24b5fb6704a4b2292543f8764ec19053 UNKNOWN
   * 35ec088ef24e841beae78c33488975d2d8d0a40d UNKNOWN
   * 334458afaa98b601eec12c490e71caa8274be055 UNKNOWN
   * 06eece5430689d2da418e0cea10eedae22c6fbb1 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/159307415) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7226) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] pnowojski commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
pnowojski commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r397911871
 
 

 ##########
 File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/CheckpointBarrierUnaligner.java
 ##########
 @@ -0,0 +1,242 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.streaming.runtime.io;
+
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.runtime.checkpoint.channel.ChannelStateWriter;
+import org.apache.flink.runtime.checkpoint.channel.InputChannelInfo;
+import org.apache.flink.runtime.io.network.api.CancelCheckpointMarker;
+import org.apache.flink.runtime.io.network.api.CheckpointBarrier;
+import org.apache.flink.runtime.io.network.buffer.Buffer;
+import org.apache.flink.runtime.jobgraph.tasks.AbstractInvokable;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import javax.annotation.Nullable;
+
+import java.util.Arrays;
+import java.util.concurrent.CompletableFuture;
+
+import static org.apache.flink.util.Preconditions.checkNotNull;
+
+/**
+ * {@link CheckpointBarrierUnaligner} is used for triggering checkpoint while reading the first barrier
+ * and keeping track of the number of received barriers and consumed barriers.
+ */
+@Internal
+public class CheckpointBarrierUnaligner extends CheckpointBarrierHandler {
 
 Review comment:
   `CheckpointBarrierUnaligner` -> `CheckpointBarrierUnalignedHandler`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] rkhachatryan commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r408113954
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
 ##########
 @@ -513,8 +540,15 @@ public void onBuffer(Buffer buffer, int sequenceNumber, int backlog) throws IOEx
 		boolean recycleBuffer = true;
 
 		try {
+			if (expectedSequenceNumber != sequenceNumber) {
+				onError(new BufferReorderingException(expectedSequenceNumber, sequenceNumber));
+				return;
+			}
 
 			final boolean wasEmpty;
+			CheckpointBarrier notifyReceivedBarrier = null;
+			Buffer notifyReceivedBuffer = null;
+			final boolean hasListener = inputGate.bufferReceivedListener != null;
 
 Review comment:
   Answered to the previous comment (please unresolve it and resolve this one).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r402555571
 
 

 ##########
 File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/CheckpointBarrierUnaligner.java
 ##########
 @@ -0,0 +1,338 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.streaming.runtime.io;
+
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.runtime.checkpoint.CheckpointException;
+import org.apache.flink.runtime.checkpoint.CheckpointFailureReason;
+import org.apache.flink.runtime.checkpoint.channel.ChannelStateWriter;
+import org.apache.flink.runtime.checkpoint.channel.InputChannelInfo;
+import org.apache.flink.runtime.io.network.api.CancelCheckpointMarker;
+import org.apache.flink.runtime.io.network.api.CheckpointBarrier;
+import org.apache.flink.runtime.io.network.buffer.Buffer;
+import org.apache.flink.runtime.jobgraph.tasks.AbstractInvokable;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.IOException;
+import java.util.Arrays;
+import java.util.concurrent.CompletableFuture;
+
+import static org.apache.flink.util.Preconditions.checkNotNull;
+
+/**
+ * {@link CheckpointBarrierUnaligner} is used for triggering checkpoint while reading the first barrier
+ * and keeping track of the number of received barriers and consumed barriers.
+ */
+@Internal
+public class CheckpointBarrierUnaligner extends CheckpointBarrierHandler {
+
+	private static final Logger LOG = LoggerFactory.getLogger(CheckpointBarrierUnaligner.class);
+	public static final CompletableFuture<Void> DONE = CompletableFuture.completedFuture(null);
+
+	private final String taskName;
+
+	/**
+	 * Tag the state of which input channel has read the barrier. If one channel has read the barrier by task,
+	 * the respective in-flight input buffers should be empty when triggering unaligned checkpoint.
+	 */
+	private final boolean[] barrierConsumedChannels;
+
+	/**
+	 * Tag the state of which input channel has received the barrier. Until the barrier of a specific channel is
+	 * received, all new buffers need to be persisted after unaligned checkpointing has been started.
+	 */
+	private final boolean[] barrierReceivedChannels;
+
+	/**
+	 * Contains the offsets of the channel indices for each gate when flattening the channels of all gates.
+	 *
+	 * <p>For example, consider 3 gates with 4 channels, {@code gateChannelOffsets = [0, 4, 8]}.
+	 */
+	private final int[] gateChannelOffsets;
+
+	/**
+	 * The number of input channels which has read the barrier by task.
+	 */
+	private int numBarriersReceived;
+
+	/**
+	 * The checkpoint id to guarantee that we would trigger only one checkpoint when reading the same barrier from
+	 * different channels.
+	 */
+	private long currentCheckpointId = -1L;
+
+	/** The number of opened channels. */
+	private int numOpenChannels;
+
+	/** A future indicating that all barriers of the a given checkpoint have been read. */
+	private CompletableFuture<Void> allBarriersReceivedFuture = DONE;
+
+	private final ChannelStateWriter channelStateWriter;
+
+	CheckpointBarrierUnaligner(
+			int[] numberOfInputChannelsPerGate,
+			ChannelStateWriter channelStateWriter,
+			String taskName,
+			AbstractInvokable toNotifyOnCheckpoint) {
+		super(toNotifyOnCheckpoint);
+
+		this.taskName = taskName;
+		this.channelStateWriter = checkNotNull(channelStateWriter);
+
+		final int numGates = numberOfInputChannelsPerGate.length;
+
+		gateChannelOffsets = new int[numGates];
+		for (int index = 1; index < numGates; index++) {
+			gateChannelOffsets[index] = gateChannelOffsets[index - 1] + numberOfInputChannelsPerGate[index - 1];
+		}
+
+		final int totalNumChannels = gateChannelOffsets[numGates - 1] + numberOfInputChannelsPerGate[numGates - 1];
+		barrierConsumedChannels = new boolean[totalNumChannels];
+		Arrays.fill(barrierConsumedChannels, true);
+		barrierReceivedChannels = new boolean[totalNumChannels];
+		Arrays.fill(barrierReceivedChannels, true);
+		numOpenChannels = totalNumChannels;
+	}
+
+	@Override
+	public void releaseBlocksAndResetBarriers() {
+		// make sure no additional data is persisted
+		Arrays.fill(barrierConsumedChannels, true);
+		Arrays.fill(barrierReceivedChannels, true);
+	}
+
+	/**
+	 * For unaligned checkpoint, it never blocks processing from the task aspect.
+	 *
+	 * <p>For PoC, we do not consider the possibility that the unaligned checkpoint would
+	 * not perform due to the max configured unaligned checkpoint size.
+	 */
+	@Override
+	public boolean isBlocked(int channelIndex) {
+		return false;
+	}
+
+	/**
+	 * We still need to trigger checkpoint while reading the first barrier from one channel, because this might happen
+	 * earlier than the previous async trigger via mailbox by netty thread. And the {@link AbstractInvokable} has the
+	 * deduplication logic to guarantee trigger checkpoint only once finally.
+	 *
+	 * <p>Note this is also suitable for the trigger case of local input channel.
+	 */
+	@Override
+	public boolean processBarrier(
+			CheckpointBarrier receivedBarrier,
+			int channelIndex,
+			long bufferedBytes) throws Exception {
+		long barrierId = receivedBarrier.getId();
+		if (currentCheckpointId < barrierId) {
+			handleNewCheckpoint(barrierId);
+			notifyCheckpointAsync(receivedBarrier, bufferedBytes, 0);
 
 Review comment:
   I replaced all *Async by calling the newly added `StreamTask#runInTaskThread` which only goes to mailbox if we are not in task thread.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#issuecomment-603776093
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6621",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155064201",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155877268",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6755",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6839",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156597180",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6846",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156864478",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6873",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156994047",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157330632",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6900",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157451694",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6916",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157494634",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6933",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157589655",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6944",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6991",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "FAILURE",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157754467",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * dee2b337e5e72d8f7b1f5098b74f2958d000fb3c UNKNOWN
   * 80b7f76f24b5fb6704a4b2292543f8764ec19053 UNKNOWN
   * e148bdc935791d691e3d09c6576c3e3fa04e2ac8 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/157754467) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6991) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#issuecomment-603776093
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6621",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155064201",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155877268",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6755",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6839",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156597180",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6846",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156864478",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6873",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156994047",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157330632",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6900",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "FAILURE",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157451694",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6916",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157494634",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6933",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * dee2b337e5e72d8f7b1f5098b74f2958d000fb3c UNKNOWN
   * 80b7f76f24b5fb6704a4b2292543f8764ec19053 UNKNOWN
   * d5d714a4d954b82862972864805a151d04c3a513 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/157451694) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6916) 
   * 734812c326634e1fd0da63465dcfbffa53cff792 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/157494634) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6933) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#issuecomment-603776093
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6621",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155064201",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155877268",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6755",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6839",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156597180",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6846",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156864478",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6873",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156994047",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157330632",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6900",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157451694",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6916",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157494634",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6933",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157589655",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6944",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6991",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157754467",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158102285",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7007",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * dee2b337e5e72d8f7b1f5098b74f2958d000fb3c UNKNOWN
   * 80b7f76f24b5fb6704a4b2292543f8764ec19053 UNKNOWN
   * 77476642d8fe2f648f2079fc9e4b43c9506c2024 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/158102285) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7007) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r402582748
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/LocalInputChannel.java
 ##########
 @@ -270,4 +277,18 @@ public int unsynchronizedGetNumberOfQueuedBuffers() {
 	public String toString() {
 		return "LocalInputChannel [" + partitionId + "]";
 	}
+
+	@Override
+	public EnqueueAction priorityEvent(AbstractEvent event, BufferConsumer eventBufferConsumer) throws IOException {
+		if (inputGate.bufferReceivedListener == null) {
 
 Review comment:
   Some leftover from POC.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r399255086
 
 

 ##########
 File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/CheckpointBarrierUnaligner.java
 ##########
 @@ -0,0 +1,242 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.streaming.runtime.io;
+
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.runtime.checkpoint.channel.ChannelStateWriter;
+import org.apache.flink.runtime.checkpoint.channel.InputChannelInfo;
+import org.apache.flink.runtime.io.network.api.CancelCheckpointMarker;
+import org.apache.flink.runtime.io.network.api.CheckpointBarrier;
+import org.apache.flink.runtime.io.network.buffer.Buffer;
+import org.apache.flink.runtime.jobgraph.tasks.AbstractInvokable;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import javax.annotation.Nullable;
+
+import java.util.Arrays;
+import java.util.concurrent.CompletableFuture;
+
+import static org.apache.flink.util.Preconditions.checkNotNull;
+
+/**
+ * {@link CheckpointBarrierUnaligner} is used for triggering checkpoint while reading the first barrier
+ * and keeping track of the number of received barriers and consumed barriers.
+ */
+@Internal
+public class CheckpointBarrierUnaligner extends CheckpointBarrierHandler {
 
 Review comment:
   Any strong preference for `CheckpointBarrierUnaligner` or `UnalignedCheckpointBarrierHandler`. I like both but kinda got used to `CheckpointBarrierUnaligner`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zhijiangW commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
zhijiangW commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r400641076
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/LocalInputChannel.java
 ##########
 @@ -270,4 +277,18 @@ public int unsynchronizedGetNumberOfQueuedBuffers() {
 	public String toString() {
 		return "LocalInputChannel [" + partitionId + "]";
 	}
+
+	@Override
+	public EnqueueAction priorityEvent(AbstractEvent event, BufferConsumer eventBufferConsumer) throws IOException {
+		if (inputGate.bufferReceivedListener == null) {
 
 Review comment:
   I think this path should never happen in practice. Although we can not make `bufferReceivedListener` as final in form, we should still guarantee the listener is ready before requesting partition from local channel. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#issuecomment-603776093
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6621",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155064201",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155877268",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6755",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6839",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156597180",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6846",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156864478",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6873",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156994047",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157330632",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6900",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157451694",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6916",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157494634",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6933",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157589655",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6944",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6991",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157754467",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158102285",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7007",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7023",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158153241",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158188400",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7040",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7048",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158276096",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158831429",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7117",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7121",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158855200",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159112519",
       "triggerID" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7172",
       "triggerID" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159143719",
       "triggerID" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7175",
       "triggerID" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "triggerType" : "PUSH"
     }, {
       "hash" : "35ec088ef24e841beae78c33488975d2d8d0a40d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "35ec088ef24e841beae78c33488975d2d8d0a40d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7194",
       "triggerID" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159244661",
       "triggerID" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "triggerType" : "PUSH"
     }, {
       "hash" : "334458afaa98b601eec12c490e71caa8274be055",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "334458afaa98b601eec12c490e71caa8274be055",
       "triggerType" : "PUSH"
     }, {
       "hash" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7212",
       "triggerID" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "triggerType" : "PUSH"
     }, {
       "hash" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159269141",
       "triggerID" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7226",
       "triggerID" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159307415",
       "triggerID" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7297",
       "triggerID" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "status" : "CANCELED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159652918",
       "triggerID" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "559816dcea4999dd46b09ee1091ddc0e1a5a7a54",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "559816dcea4999dd46b09ee1091ddc0e1a5a7a54",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6cd76afe4990f56a5166e1592374aa8f86fe883f",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "6cd76afe4990f56a5166e1592374aa8f86fe883f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * dee2b337e5e72d8f7b1f5098b74f2958d000fb3c UNKNOWN
   * 80b7f76f24b5fb6704a4b2292543f8764ec19053 UNKNOWN
   * 35ec088ef24e841beae78c33488975d2d8d0a40d UNKNOWN
   * 334458afaa98b601eec12c490e71caa8274be055 UNKNOWN
   * 9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7 Travis: [CANCELED](https://travis-ci.com/github/flink-ci/flink/builds/159652918) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7297) 
   * 559816dcea4999dd46b09ee1091ddc0e1a5a7a54 UNKNOWN
   * 6cd76afe4990f56a5166e1592374aa8f86fe883f UNKNOWN
   * 71a489567e8b02abdf0ccc7ec56f85d93549eedb UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zhijiangW commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
zhijiangW commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r404696405
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/NettyShuffleEnvironment.java
 ##########
 @@ -184,17 +184,18 @@ public ShuffleIOOwnerContext createShuffleIOOwnerContext(
 	}
 
 	@Override
-	public Collection<ResultPartition> createResultPartitionWriters(
 
 Review comment:
   Yes, your above comments are exactly right. 
   
   There were no ordering requirements when this interface was introduced firstly.  Considering the recovery issue of unaligned checkpoint, the ordering issue was already guaranteed while constructing the collections of `ResultPartition` via argument `List<ResultPartitionDeploymentDescriptor>`, done by a separate PR before.  
   
   Now even though we return a `HashSet` as a result, it would not impact the unaligned checkpoint. Because as long as we create the `ResultPartition` in determined index, it does not matter to access them in any order from the collection.
   
   I am also fine if you further want to guarantee the order from return type, for the potential future usages, but I guess that is not the blocker for current unaligned checkpoint.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] rkhachatryan commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r399517876
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PriorityEventListener.java
 ##########
 @@ -0,0 +1,54 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.io.network.partition;
+
+import org.apache.flink.runtime.event.AbstractEvent;
+import org.apache.flink.runtime.io.network.buffer.BufferConsumer;
+
+import java.io.IOException;
+
+/**
+ * Listens to priority events (e.g., checkpoint barriers) of subpartitions. The listener can completely process the
+ * event without the buffer queue or let the subpartition enqueue the event in the front or back of the buffer queue.
+ */
+public interface PriorityEventListener {
+	/**
+	 * Allows the listener to react to a priority event independent of the outgoing buffer queue.
+	 *
+	 * @return the action to be performed by the caller.
+	 */
+	EventAction priorityEvent(AbstractEvent event, BufferConsumer eventBufferConsumer) throws IOException;
+
+	/**
+	 * The action to be performed by the caller of the {@link PriorityEventListener}.
+	 */
+	enum EventAction {
+		/**
+		 * The event should be added in the front of the buffer queue (to be consumed next).
+		 */
+		ENQUEUE_AS_FIRST_BUFFER,
+		/**
+		 * The event should be added in the back of the buffer queue (to be consumed last).
+		 */
+		ENQUEUE_AS_LAST_BUFFER,
+		/**
+		 * The event was already handled and should not be added to the buffer queue at all.
+		 */
+		DONT_INSERT
 
 Review comment:
   Just `ENQUEUE_AS_FIRST / LAST`? Or `ENQUEUE_AS_HEAD / TAIL`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] rkhachatryan commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r408010727
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
 ##########
 @@ -206,6 +214,25 @@ void retriggerSubpartitionRequest(int subpartitionIndex) throws IOException {
 		return Optional.of(new BufferAndAvailability(next, moreAvailable, getSenderBacklog()));
 	}
 
+	@Override
+	public List<Buffer> requestInflightBuffers(long checkpointId) throws IOException {
+		synchronized (receivedBuffers) {
+			checkState(checkpointId > lastRequestedCheckpointId, "Need to request the next checkpointId");
+
+			final List<Buffer> inflightBuffers = new ArrayList<>(receivedBuffers.size());
+			for (Buffer buffer : receivedBuffers) {
+				if (!buffer.isBuffer() && parseCheckpointBarrierOrNull(buffer) != null) {
 
 Review comment:
   Some possible optimizations (not sure if it's worth it):
   1. `buffer.isBuffer` is not needed here as it's done inside `parseCheckpointBarrierOrNull`
   1. first check that `receivedCheckpointId > checkpointId`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#issuecomment-603776093
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6621",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155064201",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155877268",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6755",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6839",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156597180",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6846",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156864478",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6873",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156994047",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157330632",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6900",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157451694",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6916",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157494634",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6933",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157589655",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6944",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6991",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157754467",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158102285",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7007",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7023",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158153241",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158188400",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7040",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7048",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158276096",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158831429",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7117",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7121",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158855200",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159112519",
       "triggerID" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7172",
       "triggerID" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159143719",
       "triggerID" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7175",
       "triggerID" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "triggerType" : "PUSH"
     }, {
       "hash" : "35ec088ef24e841beae78c33488975d2d8d0a40d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "35ec088ef24e841beae78c33488975d2d8d0a40d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7194",
       "triggerID" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159244661",
       "triggerID" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "triggerType" : "PUSH"
     }, {
       "hash" : "334458afaa98b601eec12c490e71caa8274be055",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "334458afaa98b601eec12c490e71caa8274be055",
       "triggerType" : "PUSH"
     }, {
       "hash" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7212",
       "triggerID" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "triggerType" : "PUSH"
     }, {
       "hash" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159269141",
       "triggerID" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7226",
       "triggerID" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159307415",
       "triggerID" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7297",
       "triggerID" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159652918",
       "triggerID" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "559816dcea4999dd46b09ee1091ddc0e1a5a7a54",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "559816dcea4999dd46b09ee1091ddc0e1a5a7a54",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6cd76afe4990f56a5166e1592374aa8f86fe883f",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "6cd76afe4990f56a5166e1592374aa8f86fe883f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7302",
       "triggerID" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159678447",
       "triggerID" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159695914",
       "triggerID" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7305",
       "triggerID" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ac996f5c703560ecbe6cad7394cc8ad54d6f0029",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "ac996f5c703560ecbe6cad7394cc8ad54d6f0029",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7347",
       "triggerID" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159875195",
       "triggerID" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "75c8130873e9b91e21e1e833d3d05f1ad9b5d2b8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7354",
       "triggerID" : "75c8130873e9b91e21e1e833d3d05f1ad9b5d2b8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7369",
       "triggerID" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "triggerType" : "PUSH"
     }, {
       "hash" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159960514",
       "triggerID" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7373",
       "triggerID" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159990549",
       "triggerID" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "triggerType" : "PUSH"
     }, {
       "hash" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7443",
       "triggerID" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160172375",
       "triggerID" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "536d9fb04a7a8142c04c94344dd0b3c0f2c10999",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160215439",
       "triggerID" : "536d9fb04a7a8142c04c94344dd0b3c0f2c10999",
       "triggerType" : "PUSH"
     }, {
       "hash" : "536d9fb04a7a8142c04c94344dd0b3c0f2c10999",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7469",
       "triggerID" : "536d9fb04a7a8142c04c94344dd0b3c0f2c10999",
       "triggerType" : "PUSH"
     }, {
       "hash" : "67018bacf5bc2daa8a03a1aafa880efc1db86808",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7500",
       "triggerID" : "67018bacf5bc2daa8a03a1aafa880efc1db86808",
       "triggerType" : "PUSH"
     }, {
       "hash" : "67018bacf5bc2daa8a03a1aafa880efc1db86808",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160347006",
       "triggerID" : "67018bacf5bc2daa8a03a1aafa880efc1db86808",
       "triggerType" : "PUSH"
     }, {
       "hash" : "79c116a6a1f5fe314f801e81f0265dea8b9ac1a7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7522",
       "triggerID" : "79c116a6a1f5fe314f801e81f0265dea8b9ac1a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "79c116a6a1f5fe314f801e81f0265dea8b9ac1a7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160377553",
       "triggerID" : "79c116a6a1f5fe314f801e81f0265dea8b9ac1a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "27ce4bfad8e99989dd64f8c636c934727da8a062",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "27ce4bfad8e99989dd64f8c636c934727da8a062",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ce0dfc7324679ebf2da84278eac8f5f59d748319",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7539",
       "triggerID" : "ce0dfc7324679ebf2da84278eac8f5f59d748319",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ce0dfc7324679ebf2da84278eac8f5f59d748319",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160418181",
       "triggerID" : "ce0dfc7324679ebf2da84278eac8f5f59d748319",
       "triggerType" : "PUSH"
     }, {
       "hash" : "05c934bf483d4fb673496783ef8ff85b40b86708",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "05c934bf483d4fb673496783ef8ff85b40b86708",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4bbe67a13a75f4491898fbb1cd2315237dbca30e",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160443829",
       "triggerID" : "4bbe67a13a75f4491898fbb1cd2315237dbca30e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4bbe67a13a75f4491898fbb1cd2315237dbca30e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7543",
       "triggerID" : "4bbe67a13a75f4491898fbb1cd2315237dbca30e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "cb5258f13c64ed033db7b8476122721ac418d798",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160496434",
       "triggerID" : "cb5258f13c64ed033db7b8476122721ac418d798",
       "triggerType" : "PUSH"
     }, {
       "hash" : "cb5258f13c64ed033db7b8476122721ac418d798",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7560",
       "triggerID" : "cb5258f13c64ed033db7b8476122721ac418d798",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * dee2b337e5e72d8f7b1f5098b74f2958d000fb3c UNKNOWN
   * 80b7f76f24b5fb6704a4b2292543f8764ec19053 UNKNOWN
   * 35ec088ef24e841beae78c33488975d2d8d0a40d UNKNOWN
   * 334458afaa98b601eec12c490e71caa8274be055 UNKNOWN
   * 559816dcea4999dd46b09ee1091ddc0e1a5a7a54 UNKNOWN
   * 6cd76afe4990f56a5166e1592374aa8f86fe883f UNKNOWN
   * ac996f5c703560ecbe6cad7394cc8ad54d6f0029 UNKNOWN
   * 27ce4bfad8e99989dd64f8c636c934727da8a062 UNKNOWN
   * 05c934bf483d4fb673496783ef8ff85b40b86708 UNKNOWN
   * cb5258f13c64ed033db7b8476122721ac418d798 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/160496434) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7560) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#issuecomment-603776093
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6621",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155064201",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155877268",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6755",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6839",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156597180",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6846",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156864478",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6873",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156994047",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157330632",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6900",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157451694",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6916",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157494634",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6933",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157589655",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6944",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6991",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157754467",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158102285",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7007",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7023",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158153241",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158188400",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7040",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7048",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158276096",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "FAILURE",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158831429",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7117",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * dee2b337e5e72d8f7b1f5098b74f2958d000fb3c UNKNOWN
   * 80b7f76f24b5fb6704a4b2292543f8764ec19053 UNKNOWN
   * a3eed025c7faad5d680ab09e83d8af2819f0048b Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/158831429) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7117) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] rkhachatryan commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r408277189
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/SingleInputGate.java
 ##########
 @@ -170,9 +173,14 @@
 
 	private final CompletableFuture<Void> closeFuture;
 
+	@Nullable
+	protected BufferReceivedListener bufferReceivedListener;
 
 Review comment:
   I don't think `synchronized` will speed up `volatile` read. But I'm also not sure what the performance impact is in the first place so I'm fine with this approach.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#issuecomment-603776093
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6621",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155064201",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155877268",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6755",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6839",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156597180",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6846",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156864478",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6873",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156994047",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157330632",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6900",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157451694",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6916",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157494634",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6933",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157589655",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6944",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6991",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157754467",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158102285",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7007",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7023",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158153241",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158188400",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7040",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7048",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158276096",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158831429",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7117",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7121",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158855200",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159112519",
       "triggerID" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7172",
       "triggerID" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159143719",
       "triggerID" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7175",
       "triggerID" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "triggerType" : "PUSH"
     }, {
       "hash" : "35ec088ef24e841beae78c33488975d2d8d0a40d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "35ec088ef24e841beae78c33488975d2d8d0a40d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7194",
       "triggerID" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159244661",
       "triggerID" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "triggerType" : "PUSH"
     }, {
       "hash" : "334458afaa98b601eec12c490e71caa8274be055",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "334458afaa98b601eec12c490e71caa8274be055",
       "triggerType" : "PUSH"
     }, {
       "hash" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7212",
       "triggerID" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "triggerType" : "PUSH"
     }, {
       "hash" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159269141",
       "triggerID" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7226",
       "triggerID" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159307415",
       "triggerID" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7297",
       "triggerID" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159652918",
       "triggerID" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "559816dcea4999dd46b09ee1091ddc0e1a5a7a54",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "559816dcea4999dd46b09ee1091ddc0e1a5a7a54",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6cd76afe4990f56a5166e1592374aa8f86fe883f",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "6cd76afe4990f56a5166e1592374aa8f86fe883f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7302",
       "triggerID" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159678447",
       "triggerID" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159695914",
       "triggerID" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7305",
       "triggerID" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ac996f5c703560ecbe6cad7394cc8ad54d6f0029",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "ac996f5c703560ecbe6cad7394cc8ad54d6f0029",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7347",
       "triggerID" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159875195",
       "triggerID" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "75c8130873e9b91e21e1e833d3d05f1ad9b5d2b8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7354",
       "triggerID" : "75c8130873e9b91e21e1e833d3d05f1ad9b5d2b8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7369",
       "triggerID" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "triggerType" : "PUSH"
     }, {
       "hash" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159960514",
       "triggerID" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7373",
       "triggerID" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159990549",
       "triggerID" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "triggerType" : "PUSH"
     }, {
       "hash" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7443",
       "triggerID" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160172375",
       "triggerID" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "536d9fb04a7a8142c04c94344dd0b3c0f2c10999",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160215439",
       "triggerID" : "536d9fb04a7a8142c04c94344dd0b3c0f2c10999",
       "triggerType" : "PUSH"
     }, {
       "hash" : "536d9fb04a7a8142c04c94344dd0b3c0f2c10999",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7469",
       "triggerID" : "536d9fb04a7a8142c04c94344dd0b3c0f2c10999",
       "triggerType" : "PUSH"
     }, {
       "hash" : "67018bacf5bc2daa8a03a1aafa880efc1db86808",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7500",
       "triggerID" : "67018bacf5bc2daa8a03a1aafa880efc1db86808",
       "triggerType" : "PUSH"
     }, {
       "hash" : "67018bacf5bc2daa8a03a1aafa880efc1db86808",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160347006",
       "triggerID" : "67018bacf5bc2daa8a03a1aafa880efc1db86808",
       "triggerType" : "PUSH"
     }, {
       "hash" : "79c116a6a1f5fe314f801e81f0265dea8b9ac1a7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7522",
       "triggerID" : "79c116a6a1f5fe314f801e81f0265dea8b9ac1a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "79c116a6a1f5fe314f801e81f0265dea8b9ac1a7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160377553",
       "triggerID" : "79c116a6a1f5fe314f801e81f0265dea8b9ac1a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "27ce4bfad8e99989dd64f8c636c934727da8a062",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "27ce4bfad8e99989dd64f8c636c934727da8a062",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ce0dfc7324679ebf2da84278eac8f5f59d748319",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7539",
       "triggerID" : "ce0dfc7324679ebf2da84278eac8f5f59d748319",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ce0dfc7324679ebf2da84278eac8f5f59d748319",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160418181",
       "triggerID" : "ce0dfc7324679ebf2da84278eac8f5f59d748319",
       "triggerType" : "PUSH"
     }, {
       "hash" : "05c934bf483d4fb673496783ef8ff85b40b86708",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "05c934bf483d4fb673496783ef8ff85b40b86708",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4bbe67a13a75f4491898fbb1cd2315237dbca30e",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160443829",
       "triggerID" : "4bbe67a13a75f4491898fbb1cd2315237dbca30e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4bbe67a13a75f4491898fbb1cd2315237dbca30e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7543",
       "triggerID" : "4bbe67a13a75f4491898fbb1cd2315237dbca30e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "cb5258f13c64ed033db7b8476122721ac418d798",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160496434",
       "triggerID" : "cb5258f13c64ed033db7b8476122721ac418d798",
       "triggerType" : "PUSH"
     }, {
       "hash" : "cb5258f13c64ed033db7b8476122721ac418d798",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7560",
       "triggerID" : "cb5258f13c64ed033db7b8476122721ac418d798",
       "triggerType" : "PUSH"
     }, {
       "hash" : "fdc673b8583650ce40a6f13b8a44d9773e14c370",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7597",
       "triggerID" : "fdc673b8583650ce40a6f13b8a44d9773e14c370",
       "triggerType" : "PUSH"
     }, {
       "hash" : "fdc673b8583650ce40a6f13b8a44d9773e14c370",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160543449",
       "triggerID" : "fdc673b8583650ce40a6f13b8a44d9773e14c370",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1123cc69ed817c9935bae5ffbba5e48f5bbe0f25",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7611",
       "triggerID" : "1123cc69ed817c9935bae5ffbba5e48f5bbe0f25",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1123cc69ed817c9935bae5ffbba5e48f5bbe0f25",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160619473",
       "triggerID" : "1123cc69ed817c9935bae5ffbba5e48f5bbe0f25",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dd5b4999b59b53950c2fb3784fc50ed97617f5aa",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "dd5b4999b59b53950c2fb3784fc50ed97617f5aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9e118a737919fb9c784d171ae06567030a5a9ecd",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160633665",
       "triggerID" : "9e118a737919fb9c784d171ae06567030a5a9ecd",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9e118a737919fb9c784d171ae06567030a5a9ecd",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7612",
       "triggerID" : "9e118a737919fb9c784d171ae06567030a5a9ecd",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7fc44ff1be1eaf8394b5b89735c412041c806407",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "7fc44ff1be1eaf8394b5b89735c412041c806407",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * dee2b337e5e72d8f7b1f5098b74f2958d000fb3c UNKNOWN
   * 80b7f76f24b5fb6704a4b2292543f8764ec19053 UNKNOWN
   * 35ec088ef24e841beae78c33488975d2d8d0a40d UNKNOWN
   * 334458afaa98b601eec12c490e71caa8274be055 UNKNOWN
   * 559816dcea4999dd46b09ee1091ddc0e1a5a7a54 UNKNOWN
   * 6cd76afe4990f56a5166e1592374aa8f86fe883f UNKNOWN
   * ac996f5c703560ecbe6cad7394cc8ad54d6f0029 UNKNOWN
   * 27ce4bfad8e99989dd64f8c636c934727da8a062 UNKNOWN
   * 05c934bf483d4fb673496783ef8ff85b40b86708 UNKNOWN
   * dd5b4999b59b53950c2fb3784fc50ed97617f5aa UNKNOWN
   * 9e118a737919fb9c784d171ae06567030a5a9ecd Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/160633665) Azure: [CANCELED](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7612) 
   * 7fc44ff1be1eaf8394b5b89735c412041c806407 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#issuecomment-603776093
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6621",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155064201",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155877268",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6755",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c45c6a352fc2f7760dcf942a75728d4d1f1777a7 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/155877268) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6755) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#issuecomment-603776093
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6621",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155064201",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155877268",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6755",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6839",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156597180",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6846",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156864478",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6873",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156994047",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157330632",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6900",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157451694",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6916",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157494634",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6933",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157589655",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6944",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6991",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157754467",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158102285",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7007",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7023",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158153241",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158188400",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7040",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7048",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158276096",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158831429",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7117",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7121",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158855200",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159112519",
       "triggerID" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7172",
       "triggerID" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159143719",
       "triggerID" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7175",
       "triggerID" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "triggerType" : "PUSH"
     }, {
       "hash" : "35ec088ef24e841beae78c33488975d2d8d0a40d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "35ec088ef24e841beae78c33488975d2d8d0a40d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7194",
       "triggerID" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159244661",
       "triggerID" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "triggerType" : "PUSH"
     }, {
       "hash" : "334458afaa98b601eec12c490e71caa8274be055",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "334458afaa98b601eec12c490e71caa8274be055",
       "triggerType" : "PUSH"
     }, {
       "hash" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7212",
       "triggerID" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "triggerType" : "PUSH"
     }, {
       "hash" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159269141",
       "triggerID" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7226",
       "triggerID" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159307415",
       "triggerID" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7297",
       "triggerID" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159652918",
       "triggerID" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "559816dcea4999dd46b09ee1091ddc0e1a5a7a54",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "559816dcea4999dd46b09ee1091ddc0e1a5a7a54",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6cd76afe4990f56a5166e1592374aa8f86fe883f",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "6cd76afe4990f56a5166e1592374aa8f86fe883f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7302",
       "triggerID" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159678447",
       "triggerID" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159695914",
       "triggerID" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7305",
       "triggerID" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ac996f5c703560ecbe6cad7394cc8ad54d6f0029",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "ac996f5c703560ecbe6cad7394cc8ad54d6f0029",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7347",
       "triggerID" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159875195",
       "triggerID" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "75c8130873e9b91e21e1e833d3d05f1ad9b5d2b8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7354",
       "triggerID" : "75c8130873e9b91e21e1e833d3d05f1ad9b5d2b8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7369",
       "triggerID" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "triggerType" : "PUSH"
     }, {
       "hash" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "status" : "FAILURE",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159960514",
       "triggerID" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * dee2b337e5e72d8f7b1f5098b74f2958d000fb3c UNKNOWN
   * 80b7f76f24b5fb6704a4b2292543f8764ec19053 UNKNOWN
   * 35ec088ef24e841beae78c33488975d2d8d0a40d UNKNOWN
   * 334458afaa98b601eec12c490e71caa8274be055 UNKNOWN
   * 559816dcea4999dd46b09ee1091ddc0e1a5a7a54 UNKNOWN
   * 6cd76afe4990f56a5166e1592374aa8f86fe883f UNKNOWN
   * ac996f5c703560ecbe6cad7394cc8ad54d6f0029 UNKNOWN
   * 54a27acd416fbed48aa7876fda85036b90c641ab Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/159960514) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7369) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#issuecomment-603776093
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6621",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155064201",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "FAILURE",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155877268",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6755",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c45c6a352fc2f7760dcf942a75728d4d1f1777a7 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/155877268) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6755) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] pnowojski edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
pnowojski edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#issuecomment-612878225
 
 
   `RecordDeserializer#getUnconsumedBuffer` is also not covered by tests, but I will add coverage as part of: https://issues.apache.org/jira/browse/FLINK-17051
   
   edit: `#getUnconsumedBuffer` is broken. It always return empty buffers (with size = 0).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] AHeise commented on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
AHeise commented on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#issuecomment-613290981
 
 
   > `RecordDeserializer#getUnconsumedBuffer` is also not covered by tests, but I will add coverage as part of: https://issues.apache.org/jira/browse/FLINK-17051
   > 
   > edit: `#getUnconsumedBuffer` is broken. It always returns empty buffers (with size = 0).
   
   Do we want to tackle both in FLINK-17051?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] pnowojski closed pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
pnowojski closed pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zhijiangW commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
zhijiangW commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r400645765
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/writer/RecordWriter.java
 ##########
 @@ -153,13 +153,17 @@ protected boolean copyFromSerializerToTargetChannel(int targetChannel) throws IO
 		return pruneTriggered;
 	}
 
-	public void broadcastEvent(AbstractEvent event) throws IOException {
+	public void broadcastEvent(AbstractEvent event, boolean isPriorityEvent) throws IOException {
 		try (BufferConsumer eventBufferConsumer = EventSerializer.toBufferConsumer(event)) {
 			for (int targetChannel = 0; targetChannel < numberOfChannels; targetChannel++) {
 				tryFinishCurrentBufferBuilder(targetChannel);
 
-				// Retain the buffer so that it can be recycled by each channel of targetPartition
-				targetPartition.addBufferConsumer(eventBufferConsumer.copy(), targetChannel);
+				if (isPriorityEvent) {
+					targetPartition.addPriorityEvent(event, targetChannel, eventBufferConsumer);
 
 Review comment:
   I am a bit torn about passing both event and buffer in the interface method. It seems not very clean on my side. 
   I guess we can make it happen to guarantee that `CheckpointBarrier` should be inserted in head for unaligned option in any cases. Then it would make things easy. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] rkhachatryan commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r398974123
 
 

 ##########
 File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/CheckpointBarrierUnaligner.java
 ##########
 @@ -0,0 +1,242 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.streaming.runtime.io;
+
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.runtime.checkpoint.channel.ChannelStateWriter;
+import org.apache.flink.runtime.checkpoint.channel.InputChannelInfo;
+import org.apache.flink.runtime.io.network.api.CancelCheckpointMarker;
+import org.apache.flink.runtime.io.network.api.CheckpointBarrier;
+import org.apache.flink.runtime.io.network.buffer.Buffer;
+import org.apache.flink.runtime.jobgraph.tasks.AbstractInvokable;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import javax.annotation.Nullable;
+
+import java.util.Arrays;
+import java.util.concurrent.CompletableFuture;
+
+import static org.apache.flink.util.Preconditions.checkNotNull;
+
+/**
+ * {@link CheckpointBarrierUnaligner} is used for triggering checkpoint while reading the first barrier
+ * and keeping track of the number of received barriers and consumed barriers.
+ */
+@Internal
+public class CheckpointBarrierUnaligner extends CheckpointBarrierHandler {
+
+	private static final Logger LOG = LoggerFactory.getLogger(CheckpointBarrierUnaligner.class);
+
+	private final String taskName;
+
+	/**
+	 * Tag the state of which input channel has read the barrier. If one channel has read the barrier by task,
+	 * the respective in-flight input buffers should be empty when triggering unaligned checkpoint.
+	 */
+	private final boolean[] barrierConsumedChannels;
+
+	/**
+	 * Tag the state of which input channel has received the barrier. Until the barrier of a specific channel is
+	 * received, all new buffers need to be persisted after unaligned checkpointing has been started.
+	 */
+	private final boolean[] barrierReceivedChannels;
+
+	/**
+	 * Contains the offsets of the channel indices for each gate when flattening the channels of all gates.
+	 *
+	 * <p>For example, consider 3 gates with 4 channels, {@code gateChannelOffsets = [0, 4, 8]}.
+	 */
+	private final int[] gateChannelOffsets;
+
+	/**
+	 * The number of input channels which has read the barrier by task.
+	 */
+	private int numBarriersReceived;
+
+	/**
+	 * The checkpoint id to guarantee that we would trigger only one checkpoint when reading the same barrier from
+	 * different channels.
+	 */
+	private long currentCheckpointId = -1L;
+
+	private final ChannelStateWriter channelStateWriter;
+
+	private CompletableFuture<?> allBarriersReceivedFuture;
+
+	CheckpointBarrierUnaligner(
+			int[] numberOfInputChannelsPerGate,
+			ChannelStateWriter channelStateWriter,
+			String taskName,
+			@Nullable AbstractInvokable toNotifyOnCheckpoint) {
+		super(toNotifyOnCheckpoint);
+
+		this.taskName = taskName;
+		this.channelStateWriter = checkNotNull(channelStateWriter);
+
+		final int numGates = numberOfInputChannelsPerGate.length;
+
+		gateChannelOffsets = new int[numGates];
+		for (int index = 1; index < numGates; index++) {
+			gateChannelOffsets[index] = gateChannelOffsets[index - 1] + numberOfInputChannelsPerGate[index - 1];
+		}
+
+		final int totalNumChannels = gateChannelOffsets[numGates - 1] + numberOfInputChannelsPerGate[numGates - 1];
+		barrierConsumedChannels = new boolean[totalNumChannels];
+		Arrays.fill(barrierConsumedChannels, true);
+		barrierReceivedChannels = new boolean[totalNumChannels];
+		Arrays.fill(barrierReceivedChannels, true);
+	}
+
+	@Override
+	public void releaseBlocksAndResetBarriers() {
+	}
+
+	/**
+	 * For unaligned checkpoint, it never blocks processing from the task aspect.
+	 *
+	 * <p>For PoC, we do not consider the possibility that the unaligned checkpoint would
+	 * not perform due to the max configured unaligned checkpoint size.
+	 */
+	@Override
+	public boolean isBlocked(int channelIndex) {
+		return false;
+	}
+
+	/**
+	 * We still need to trigger checkpoint while reading the first barrier from one channel, because this might happen
+	 * earlier than the previous async trigger via mailbox by netty thread. And the {@link AbstractInvokable} has the
+	 * deduplication logic to guarantee trigger checkpoint only once finally.
+	 *
+	 * <p>Note this is also suitable for the trigger case of local input channel.
+	 */
+	@Override
+	public synchronized boolean processBarrier(
+			CheckpointBarrier receivedBarrier,
+			int channelIndex,
+			long bufferedBytes) {
+		long barrierId = receivedBarrier.getId();
+		if (checkNewCheckpoint(barrierId)) {
+			notifyCheckpointAsync(receivedBarrier, bufferedBytes, 0);
+		}
+		barrierConsumedChannels[channelIndex] = true;
+		return false;
+	}
+
+	@Override
+	public boolean processCancellationBarrier(CancelCheckpointMarker cancelBarrier) {
+		return false;
+	}
+
+	@Override
+	public boolean processEndOfPartition() {
+		return false;
+	}
+
+	@Override
+	public long getLatestCheckpointId() {
+		return currentCheckpointId;
+	}
+
+	@Override
+	public long getAlignmentDurationNanos() {
+		return 0;
+	}
+
+	@Override
+	public String toString() {
+		return String.format("%s: last checkpoint: %d", taskName, currentCheckpointId);
+	}
+
+	@Override
+	public void checkpointSizeLimitExceeded(long maxBufferedBytes) {
+	}
+
+	@Override
+	protected boolean isBarrierConsumed(long checkpointId, int channelIndex) {
+		if (checkpointId < currentCheckpointId) {
+			return true;
+		}
+		if (checkpointId > currentCheckpointId) {
+			return false;
+		}
+		return barrierConsumedChannels[channelIndex];
+	}
+
+	public CompletableFuture<?> getAllBarriersReceivedFuture(long checkpointId) {
 
 Review comment:
   1. Looks like we assign these variables it from the network thread, but read from task thread?
   2. Besides of visibility, is there a race condition?
   N writes to `currentCheckpointId` updated
   T reads `currentCheckpointId` (new value)
   T reads `allBarriersReceivedFuture` (null or old value)
   N writes to `allBarriersReceivedFuture` 
   3. nit: to me `} else if ()` would be more readable

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r399261889
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PriorityEventListener.java
 ##########
 @@ -0,0 +1,54 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.io.network.partition;
+
+import org.apache.flink.runtime.event.AbstractEvent;
+import org.apache.flink.runtime.io.network.buffer.BufferConsumer;
+
+import java.io.IOException;
+
+/**
+ * Listens to priority events (e.g., checkpoint barriers) of subpartitions. The listener can completely process the
+ * event without the buffer queue or let the subpartition enqueue the event in the front or back of the buffer queue.
+ */
+public interface PriorityEventListener {
+	/**
+	 * Allows the listener to react to a priority event independent of the outgoing buffer queue.
+	 *
+	 * @return the action to be performed by the caller.
+	 */
+	EventAction priorityEvent(AbstractEvent event, BufferConsumer eventBufferConsumer) throws IOException;
+
+	/**
+	 * The action to be performed by the caller of the {@link PriorityEventListener}.
+	 */
+	enum EventAction {
+		/**
+		 * The event should be added in the front of the buffer queue (to be consumed next).
+		 */
+		ENQUEUE_AS_FIRST_BUFFER,
+		/**
+		 * The event should be added in the back of the buffer queue (to be consumed last).
+		 */
+		ENQUEUE_AS_LAST_BUFFER,
+		/**
+		 * The event was already handled and should not be added to the buffer queue at all.
+		 */
+		DONT_INSERT
 
 Review comment:
   I tried to unify it a bit. But I don't know if I can resolve `buffer vs event`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zhijiangW commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
zhijiangW commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r400784511
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/LocalInputChannel.java
 ##########
 @@ -65,6 +66,7 @@
 	public LocalInputChannel(
 		SingleInputGate inputGate,
 		int channelIndex,
+		InputChannelInfo channelInfo,
 
 Review comment:
   unrelated change

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#issuecomment-603776093
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6621",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155064201",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155877268",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6755",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6839",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156597180",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6846",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156864478",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6873",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156994047",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157330632",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6900",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157451694",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6916",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157494634",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6933",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157589655",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6944",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6991",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157754467",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158102285",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7007",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7023",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158153241",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158188400",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7040",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7048",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158276096",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158831429",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7117",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7121",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158855200",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159112519",
       "triggerID" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7172",
       "triggerID" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159143719",
       "triggerID" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7175",
       "triggerID" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "triggerType" : "PUSH"
     }, {
       "hash" : "35ec088ef24e841beae78c33488975d2d8d0a40d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "35ec088ef24e841beae78c33488975d2d8d0a40d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7194",
       "triggerID" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159244661",
       "triggerID" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "triggerType" : "PUSH"
     }, {
       "hash" : "334458afaa98b601eec12c490e71caa8274be055",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "334458afaa98b601eec12c490e71caa8274be055",
       "triggerType" : "PUSH"
     }, {
       "hash" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7212",
       "triggerID" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "triggerType" : "PUSH"
     }, {
       "hash" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159269141",
       "triggerID" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7226",
       "triggerID" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159307415",
       "triggerID" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7297",
       "triggerID" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159652918",
       "triggerID" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "559816dcea4999dd46b09ee1091ddc0e1a5a7a54",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "559816dcea4999dd46b09ee1091ddc0e1a5a7a54",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6cd76afe4990f56a5166e1592374aa8f86fe883f",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "6cd76afe4990f56a5166e1592374aa8f86fe883f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7302",
       "triggerID" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159678447",
       "triggerID" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159695914",
       "triggerID" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7305",
       "triggerID" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ac996f5c703560ecbe6cad7394cc8ad54d6f0029",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "ac996f5c703560ecbe6cad7394cc8ad54d6f0029",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7347",
       "triggerID" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159875195",
       "triggerID" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "75c8130873e9b91e21e1e833d3d05f1ad9b5d2b8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7354",
       "triggerID" : "75c8130873e9b91e21e1e833d3d05f1ad9b5d2b8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7369",
       "triggerID" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "triggerType" : "PUSH"
     }, {
       "hash" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159960514",
       "triggerID" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7373",
       "triggerID" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159990549",
       "triggerID" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * dee2b337e5e72d8f7b1f5098b74f2958d000fb3c UNKNOWN
   * 80b7f76f24b5fb6704a4b2292543f8764ec19053 UNKNOWN
   * 35ec088ef24e841beae78c33488975d2d8d0a40d UNKNOWN
   * 334458afaa98b601eec12c490e71caa8274be055 UNKNOWN
   * 559816dcea4999dd46b09ee1091ddc0e1a5a7a54 UNKNOWN
   * 6cd76afe4990f56a5166e1592374aa8f86fe883f UNKNOWN
   * ac996f5c703560ecbe6cad7394cc8ad54d6f0029 UNKNOWN
   * 3242e942c07ec35f2532af7cd737af8bc1ce7749 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/159990549) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7373) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#issuecomment-603776093
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6621",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155064201",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155877268",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6755",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6839",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156597180",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6846",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156864478",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6873",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156994047",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157330632",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6900",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157451694",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6916",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157494634",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6933",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157589655",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6944",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6991",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157754467",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158102285",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7007",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7023",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158153241",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158188400",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7040",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7048",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158276096",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158831429",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7117",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7121",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158855200",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159112519",
       "triggerID" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7172",
       "triggerID" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159143719",
       "triggerID" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7175",
       "triggerID" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "triggerType" : "PUSH"
     }, {
       "hash" : "35ec088ef24e841beae78c33488975d2d8d0a40d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "35ec088ef24e841beae78c33488975d2d8d0a40d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7194",
       "triggerID" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159244661",
       "triggerID" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "triggerType" : "PUSH"
     }, {
       "hash" : "334458afaa98b601eec12c490e71caa8274be055",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "334458afaa98b601eec12c490e71caa8274be055",
       "triggerType" : "PUSH"
     }, {
       "hash" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7212",
       "triggerID" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "triggerType" : "PUSH"
     }, {
       "hash" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159269141",
       "triggerID" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7226",
       "triggerID" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159307415",
       "triggerID" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7297",
       "triggerID" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159652918",
       "triggerID" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "559816dcea4999dd46b09ee1091ddc0e1a5a7a54",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "559816dcea4999dd46b09ee1091ddc0e1a5a7a54",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6cd76afe4990f56a5166e1592374aa8f86fe883f",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "6cd76afe4990f56a5166e1592374aa8f86fe883f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7302",
       "triggerID" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159678447",
       "triggerID" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159695914",
       "triggerID" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7305",
       "triggerID" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ac996f5c703560ecbe6cad7394cc8ad54d6f0029",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "ac996f5c703560ecbe6cad7394cc8ad54d6f0029",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7347",
       "triggerID" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159875195",
       "triggerID" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "75c8130873e9b91e21e1e833d3d05f1ad9b5d2b8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7354",
       "triggerID" : "75c8130873e9b91e21e1e833d3d05f1ad9b5d2b8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7369",
       "triggerID" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "triggerType" : "PUSH"
     }, {
       "hash" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159960514",
       "triggerID" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7373",
       "triggerID" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159990549",
       "triggerID" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "triggerType" : "PUSH"
     }, {
       "hash" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7443",
       "triggerID" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160172375",
       "triggerID" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "536d9fb04a7a8142c04c94344dd0b3c0f2c10999",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160215439",
       "triggerID" : "536d9fb04a7a8142c04c94344dd0b3c0f2c10999",
       "triggerType" : "PUSH"
     }, {
       "hash" : "536d9fb04a7a8142c04c94344dd0b3c0f2c10999",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7469",
       "triggerID" : "536d9fb04a7a8142c04c94344dd0b3c0f2c10999",
       "triggerType" : "PUSH"
     }, {
       "hash" : "67018bacf5bc2daa8a03a1aafa880efc1db86808",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7500",
       "triggerID" : "67018bacf5bc2daa8a03a1aafa880efc1db86808",
       "triggerType" : "PUSH"
     }, {
       "hash" : "67018bacf5bc2daa8a03a1aafa880efc1db86808",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160347006",
       "triggerID" : "67018bacf5bc2daa8a03a1aafa880efc1db86808",
       "triggerType" : "PUSH"
     }, {
       "hash" : "79c116a6a1f5fe314f801e81f0265dea8b9ac1a7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7522",
       "triggerID" : "79c116a6a1f5fe314f801e81f0265dea8b9ac1a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "79c116a6a1f5fe314f801e81f0265dea8b9ac1a7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160377553",
       "triggerID" : "79c116a6a1f5fe314f801e81f0265dea8b9ac1a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "27ce4bfad8e99989dd64f8c636c934727da8a062",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "27ce4bfad8e99989dd64f8c636c934727da8a062",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ce0dfc7324679ebf2da84278eac8f5f59d748319",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7539",
       "triggerID" : "ce0dfc7324679ebf2da84278eac8f5f59d748319",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ce0dfc7324679ebf2da84278eac8f5f59d748319",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160418181",
       "triggerID" : "ce0dfc7324679ebf2da84278eac8f5f59d748319",
       "triggerType" : "PUSH"
     }, {
       "hash" : "05c934bf483d4fb673496783ef8ff85b40b86708",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "05c934bf483d4fb673496783ef8ff85b40b86708",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4bbe67a13a75f4491898fbb1cd2315237dbca30e",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160443829",
       "triggerID" : "4bbe67a13a75f4491898fbb1cd2315237dbca30e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4bbe67a13a75f4491898fbb1cd2315237dbca30e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7543",
       "triggerID" : "4bbe67a13a75f4491898fbb1cd2315237dbca30e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "cb5258f13c64ed033db7b8476122721ac418d798",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160496434",
       "triggerID" : "cb5258f13c64ed033db7b8476122721ac418d798",
       "triggerType" : "PUSH"
     }, {
       "hash" : "cb5258f13c64ed033db7b8476122721ac418d798",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7560",
       "triggerID" : "cb5258f13c64ed033db7b8476122721ac418d798",
       "triggerType" : "PUSH"
     }, {
       "hash" : "fdc673b8583650ce40a6f13b8a44d9773e14c370",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7597",
       "triggerID" : "fdc673b8583650ce40a6f13b8a44d9773e14c370",
       "triggerType" : "PUSH"
     }, {
       "hash" : "fdc673b8583650ce40a6f13b8a44d9773e14c370",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160543449",
       "triggerID" : "fdc673b8583650ce40a6f13b8a44d9773e14c370",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * dee2b337e5e72d8f7b1f5098b74f2958d000fb3c UNKNOWN
   * 80b7f76f24b5fb6704a4b2292543f8764ec19053 UNKNOWN
   * 35ec088ef24e841beae78c33488975d2d8d0a40d UNKNOWN
   * 334458afaa98b601eec12c490e71caa8274be055 UNKNOWN
   * 559816dcea4999dd46b09ee1091ddc0e1a5a7a54 UNKNOWN
   * 6cd76afe4990f56a5166e1592374aa8f86fe883f UNKNOWN
   * ac996f5c703560ecbe6cad7394cc8ad54d6f0029 UNKNOWN
   * 27ce4bfad8e99989dd64f8c636c934727da8a062 UNKNOWN
   * 05c934bf483d4fb673496783ef8ff85b40b86708 UNKNOWN
   * fdc673b8583650ce40a6f13b8a44d9773e14c370 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/160543449) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7597) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#issuecomment-603776093
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6621",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155064201",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155877268",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6755",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6839",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156597180",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6846",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "FAILURE",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156864478",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9a496a27a92e242519764b935012e44adade76a1 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/156864478) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6846) 
   * dee2b337e5e72d8f7b1f5098b74f2958d000fb3c UNKNOWN
   * 80b7f76f24b5fb6704a4b2292543f8764ec19053 UNKNOWN
   * ed38c05c90208ed62c1c5bd2bc769cf8844356a0 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zhijiangW commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
zhijiangW commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r400823738
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/UnionInputGate.java
 ##########
 @@ -77,37 +77,34 @@
 	 */
 	private final LinkedHashSet<InputGate> inputGatesWithData = new LinkedHashSet<>();
 
-	/** The total number of input channels across all unioned input gates. */
-	private final int totalNumberOfInputChannels;
+	/** Input channels across all unioned input gates. */
+	private final InputChannel[] inputChannels;
 
 	/**
 	 * A mapping from input gate to (logical) channel index offset. Valid channel indexes go from 0
 	 * (inclusive) to the total number of input channels (exclusive).
 	 */
-	private final Map<InputGate, Integer> inputGateToIndexOffsetMap;
+	private final int[] inputGateChannelIndexOffsets;
 
 	public UnionInputGate(InputGate... inputGates) {
 		this.inputGates = checkNotNull(inputGates);
 		checkArgument(inputGates.length > 1, "Union input gate should union at least two input gates.");
 
-		this.inputGateToIndexOffsetMap = Maps.newHashMapWithExpectedSize(inputGates.length);
 		this.inputGatesWithRemainingData = Sets.newHashSetWithExpectedSize(inputGates.length);
 
+		final int maxGateIndex = Arrays.stream(inputGates).mapToInt(InputGate::getGateIndex).max().orElse(0);
+		inputGateChannelIndexOffsets = new int[maxGateIndex + 1];
 		int currentNumberOfInputChannels = 0;
+		for (final InputGate inputGate : inputGates) {
+			currentNumberOfInputChannels += inputGate.getNumberOfInputChannels();
 
 Review comment:
   this should be done after `inputGateChannelIndexOffsets` setting value?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zhijiangW commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
zhijiangW commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r400777298
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/NettyShuffleEnvironment.java
 ##########
 @@ -184,17 +184,18 @@ public ShuffleIOOwnerContext createShuffleIOOwnerContext(
 	}
 
 	@Override
-	public Collection<ResultPartition> createResultPartitionWriters(
 
 Review comment:
   I think we do not really need this commit change for guaranteeing the consistent info during recovery.  There should be no order concerns inside the collection, and we only need to guarantee that the generated `ResultPartition` and `SingleInputGate` inside the collection has always consistent infos as before. And this guarantee has already been realized by making `ResultPartitionDeploymentDescriptor` as list.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r408098138
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
 ##########
 @@ -542,6 +579,13 @@ public void onBuffer(Buffer buffer, int sequenceNumber, int backlog) throws IOEx
 			if (backlog >= 0) {
 				onSenderBacklog(backlog);
 			}
+
+			if (notifyReceivedBarrier != null) {
+				receivedCheckpointId = notifyReceivedBarrier.getId();
 
 Review comment:
   `RemoteInputChannel#onBuffer` is only called by the same netty thread. Because `receivedCheckpointId` is only updated and read from this method, it is thread safe.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#issuecomment-603776093
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6621",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155064201",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155877268",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6755",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6839",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156597180",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6846",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156864478",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6873",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156994047",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157330632",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6900",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157451694",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6916",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157494634",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6933",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157589655",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6944",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6991",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157754467",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158102285",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7007",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7023",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158153241",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158188400",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7040",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7048",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158276096",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158831429",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7117",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7121",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158855200",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159112519",
       "triggerID" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7172",
       "triggerID" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159143719",
       "triggerID" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7175",
       "triggerID" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "triggerType" : "PUSH"
     }, {
       "hash" : "35ec088ef24e841beae78c33488975d2d8d0a40d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "35ec088ef24e841beae78c33488975d2d8d0a40d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7194",
       "triggerID" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159244661",
       "triggerID" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "triggerType" : "PUSH"
     }, {
       "hash" : "334458afaa98b601eec12c490e71caa8274be055",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "334458afaa98b601eec12c490e71caa8274be055",
       "triggerType" : "PUSH"
     }, {
       "hash" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7212",
       "triggerID" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "triggerType" : "PUSH"
     }, {
       "hash" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159269141",
       "triggerID" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7226",
       "triggerID" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159307415",
       "triggerID" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7297",
       "triggerID" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159652918",
       "triggerID" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "559816dcea4999dd46b09ee1091ddc0e1a5a7a54",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "559816dcea4999dd46b09ee1091ddc0e1a5a7a54",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6cd76afe4990f56a5166e1592374aa8f86fe883f",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "6cd76afe4990f56a5166e1592374aa8f86fe883f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7302",
       "triggerID" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159678447",
       "triggerID" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159695914",
       "triggerID" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7305",
       "triggerID" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ac996f5c703560ecbe6cad7394cc8ad54d6f0029",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "ac996f5c703560ecbe6cad7394cc8ad54d6f0029",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7347",
       "triggerID" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159875195",
       "triggerID" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "75c8130873e9b91e21e1e833d3d05f1ad9b5d2b8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7354",
       "triggerID" : "75c8130873e9b91e21e1e833d3d05f1ad9b5d2b8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7369",
       "triggerID" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "triggerType" : "PUSH"
     }, {
       "hash" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159960514",
       "triggerID" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7373",
       "triggerID" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159990549",
       "triggerID" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "triggerType" : "PUSH"
     }, {
       "hash" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7443",
       "triggerID" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160172375",
       "triggerID" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * dee2b337e5e72d8f7b1f5098b74f2958d000fb3c UNKNOWN
   * 80b7f76f24b5fb6704a4b2292543f8764ec19053 UNKNOWN
   * 35ec088ef24e841beae78c33488975d2d8d0a40d UNKNOWN
   * 334458afaa98b601eec12c490e71caa8274be055 UNKNOWN
   * 559816dcea4999dd46b09ee1091ddc0e1a5a7a54 UNKNOWN
   * 6cd76afe4990f56a5166e1592374aa8f86fe883f UNKNOWN
   * ac996f5c703560ecbe6cad7394cc8ad54d6f0029 UNKNOWN
   * 3242e942c07ec35f2532af7cd737af8bc1ce7749 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/159990549) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7373) 
   * 11d69a1fed933cd4894f84e429d91e9b965d121b Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/160172375) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7443) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r399244230
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/InputChannel.java
 ##########
 @@ -20,13 +20,18 @@
 
 import org.apache.flink.metrics.Counter;
 import org.apache.flink.runtime.checkpoint.channel.InputChannelInfo;
+import org.apache.flink.runtime.event.AbstractEvent;
 import org.apache.flink.runtime.event.TaskEvent;
 import org.apache.flink.runtime.execution.CancelTaskException;
+import org.apache.flink.runtime.io.network.api.CheckpointBarrier;
+import org.apache.flink.runtime.io.network.api.serialization.EventSerializer;
 import org.apache.flink.runtime.io.network.buffer.Buffer;
 import org.apache.flink.runtime.io.network.partition.PartitionException;
 import org.apache.flink.runtime.io.network.partition.ResultPartitionID;
 import org.apache.flink.runtime.io.network.partition.ResultSubpartitionView;
 
+import javax.annotation.Nullable;
 
 Review comment:
   Good catch. Will remove it. I'm not sure if we can/should squash everything (100 files affected).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r408062385
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
 ##########
 @@ -206,6 +214,25 @@ void retriggerSubpartitionRequest(int subpartitionIndex) throws IOException {
 		return Optional.of(new BufferAndAvailability(next, moreAvailable, getSenderBacklog()));
 	}
 
+	@Override
+	public List<Buffer> requestInflightBuffers(long checkpointId) throws IOException {
+		synchronized (receivedBuffers) {
+			checkState(checkpointId > lastRequestedCheckpointId, "Need to request the next checkpointId");
+
+			final List<Buffer> inflightBuffers = new ArrayList<>(receivedBuffers.size());
+			for (Buffer buffer : receivedBuffers) {
+				if (!buffer.isBuffer() && parseCheckpointBarrierOrNull(buffer) != null) {
+					break;
 
 Review comment:
   Good point, probably more relevant when we have concurrent checkpoints. But I added it anyways (it should be the same `checkpointId` currently, I made it safer with `>= checkpointId`).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#issuecomment-603776093
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6621",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155064201",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155877268",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6755",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6839",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156597180",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6846",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156864478",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6873",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156994047",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157330632",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6900",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157451694",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6916",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157494634",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6933",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157589655",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6944",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6991",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157754467",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158102285",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7007",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7023",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158153241",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158188400",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7040",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7048",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158276096",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158831429",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7117",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7121",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158855200",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159112519",
       "triggerID" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7172",
       "triggerID" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159143719",
       "triggerID" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7175",
       "triggerID" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "triggerType" : "PUSH"
     }, {
       "hash" : "35ec088ef24e841beae78c33488975d2d8d0a40d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "35ec088ef24e841beae78c33488975d2d8d0a40d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7194",
       "triggerID" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159244661",
       "triggerID" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "triggerType" : "PUSH"
     }, {
       "hash" : "334458afaa98b601eec12c490e71caa8274be055",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "334458afaa98b601eec12c490e71caa8274be055",
       "triggerType" : "PUSH"
     }, {
       "hash" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7212",
       "triggerID" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "triggerType" : "PUSH"
     }, {
       "hash" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159269141",
       "triggerID" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7226",
       "triggerID" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159307415",
       "triggerID" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7297",
       "triggerID" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159652918",
       "triggerID" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "559816dcea4999dd46b09ee1091ddc0e1a5a7a54",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "559816dcea4999dd46b09ee1091ddc0e1a5a7a54",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6cd76afe4990f56a5166e1592374aa8f86fe883f",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "6cd76afe4990f56a5166e1592374aa8f86fe883f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7302",
       "triggerID" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159678447",
       "triggerID" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159695914",
       "triggerID" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7305",
       "triggerID" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ac996f5c703560ecbe6cad7394cc8ad54d6f0029",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "ac996f5c703560ecbe6cad7394cc8ad54d6f0029",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7347",
       "triggerID" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159875195",
       "triggerID" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "75c8130873e9b91e21e1e833d3d05f1ad9b5d2b8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7354",
       "triggerID" : "75c8130873e9b91e21e1e833d3d05f1ad9b5d2b8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7369",
       "triggerID" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "triggerType" : "PUSH"
     }, {
       "hash" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159960514",
       "triggerID" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7373",
       "triggerID" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159990549",
       "triggerID" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "triggerType" : "PUSH"
     }, {
       "hash" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7443",
       "triggerID" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160172375",
       "triggerID" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "536d9fb04a7a8142c04c94344dd0b3c0f2c10999",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160215439",
       "triggerID" : "536d9fb04a7a8142c04c94344dd0b3c0f2c10999",
       "triggerType" : "PUSH"
     }, {
       "hash" : "536d9fb04a7a8142c04c94344dd0b3c0f2c10999",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7469",
       "triggerID" : "536d9fb04a7a8142c04c94344dd0b3c0f2c10999",
       "triggerType" : "PUSH"
     }, {
       "hash" : "67018bacf5bc2daa8a03a1aafa880efc1db86808",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7500",
       "triggerID" : "67018bacf5bc2daa8a03a1aafa880efc1db86808",
       "triggerType" : "PUSH"
     }, {
       "hash" : "67018bacf5bc2daa8a03a1aafa880efc1db86808",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160347006",
       "triggerID" : "67018bacf5bc2daa8a03a1aafa880efc1db86808",
       "triggerType" : "PUSH"
     }, {
       "hash" : "79c116a6a1f5fe314f801e81f0265dea8b9ac1a7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7522",
       "triggerID" : "79c116a6a1f5fe314f801e81f0265dea8b9ac1a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "79c116a6a1f5fe314f801e81f0265dea8b9ac1a7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160377553",
       "triggerID" : "79c116a6a1f5fe314f801e81f0265dea8b9ac1a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "27ce4bfad8e99989dd64f8c636c934727da8a062",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "27ce4bfad8e99989dd64f8c636c934727da8a062",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ce0dfc7324679ebf2da84278eac8f5f59d748319",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7539",
       "triggerID" : "ce0dfc7324679ebf2da84278eac8f5f59d748319",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ce0dfc7324679ebf2da84278eac8f5f59d748319",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160418181",
       "triggerID" : "ce0dfc7324679ebf2da84278eac8f5f59d748319",
       "triggerType" : "PUSH"
     }, {
       "hash" : "05c934bf483d4fb673496783ef8ff85b40b86708",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "05c934bf483d4fb673496783ef8ff85b40b86708",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4bbe67a13a75f4491898fbb1cd2315237dbca30e",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160443829",
       "triggerID" : "4bbe67a13a75f4491898fbb1cd2315237dbca30e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4bbe67a13a75f4491898fbb1cd2315237dbca30e",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7543",
       "triggerID" : "4bbe67a13a75f4491898fbb1cd2315237dbca30e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "cb5258f13c64ed033db7b8476122721ac418d798",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "cb5258f13c64ed033db7b8476122721ac418d798",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * dee2b337e5e72d8f7b1f5098b74f2958d000fb3c UNKNOWN
   * 80b7f76f24b5fb6704a4b2292543f8764ec19053 UNKNOWN
   * 35ec088ef24e841beae78c33488975d2d8d0a40d UNKNOWN
   * 334458afaa98b601eec12c490e71caa8274be055 UNKNOWN
   * 559816dcea4999dd46b09ee1091ddc0e1a5a7a54 UNKNOWN
   * 6cd76afe4990f56a5166e1592374aa8f86fe883f UNKNOWN
   * ac996f5c703560ecbe6cad7394cc8ad54d6f0029 UNKNOWN
   * 27ce4bfad8e99989dd64f8c636c934727da8a062 UNKNOWN
   * 05c934bf483d4fb673496783ef8ff85b40b86708 UNKNOWN
   * 4bbe67a13a75f4491898fbb1cd2315237dbca30e Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/160443829) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7543) 
   * cb5258f13c64ed033db7b8476122721ac418d798 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r402582241
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/writer/RecordWriter.java
 ##########
 @@ -153,13 +153,17 @@ protected boolean copyFromSerializerToTargetChannel(int targetChannel) throws IO
 		return pruneTriggered;
 	}
 
-	public void broadcastEvent(AbstractEvent event) throws IOException {
+	public void broadcastEvent(AbstractEvent event, boolean isPriorityEvent) throws IOException {
 		try (BufferConsumer eventBufferConsumer = EventSerializer.toBufferConsumer(event)) {
 			for (int targetChannel = 0; targetChannel < numberOfChannels; targetChannel++) {
 				tryFinishCurrentBufferBuilder(targetChannel);
 
-				// Retain the buffer so that it can be recycled by each channel of targetPartition
-				targetPartition.addBufferConsumer(eventBufferConsumer.copy(), targetChannel);
+				if (isPriorityEvent) {
+					targetPartition.addPriorityEvent(event, targetChannel, eventBufferConsumer);
 
 Review comment:
   My main motivation was to avoid unnecessary (de)serialization. In certain cases (local input channel), you can directly pass the event. In other cases, you need the buffer. So deciding on one would lead to extra work on the other case. For the same reason, `copy()` is not called, as the buffer may not be used at all and a copy is unnecessary work.
   In general, I think it's up to the consumer to copy a buffer or not. If it can immediately process the buffer, why copy and recycle at all?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r402523611
 
 

 ##########
 File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/CheckpointBarrierUnaligner.java
 ##########
 @@ -0,0 +1,338 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.streaming.runtime.io;
+
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.runtime.checkpoint.CheckpointException;
+import org.apache.flink.runtime.checkpoint.CheckpointFailureReason;
+import org.apache.flink.runtime.checkpoint.channel.ChannelStateWriter;
+import org.apache.flink.runtime.checkpoint.channel.InputChannelInfo;
+import org.apache.flink.runtime.io.network.api.CancelCheckpointMarker;
+import org.apache.flink.runtime.io.network.api.CheckpointBarrier;
+import org.apache.flink.runtime.io.network.buffer.Buffer;
+import org.apache.flink.runtime.jobgraph.tasks.AbstractInvokable;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.IOException;
+import java.util.Arrays;
+import java.util.concurrent.CompletableFuture;
+
+import static org.apache.flink.util.Preconditions.checkNotNull;
+
+/**
+ * {@link CheckpointBarrierUnaligner} is used for triggering checkpoint while reading the first barrier
+ * and keeping track of the number of received barriers and consumed barriers.
+ */
+@Internal
+public class CheckpointBarrierUnaligner extends CheckpointBarrierHandler {
+
+	private static final Logger LOG = LoggerFactory.getLogger(CheckpointBarrierUnaligner.class);
+	public static final CompletableFuture<Void> DONE = CompletableFuture.completedFuture(null);
+
+	private final String taskName;
+
+	/**
+	 * Tag the state of which input channel has read the barrier. If one channel has read the barrier by task,
+	 * the respective in-flight input buffers should be empty when triggering unaligned checkpoint.
+	 */
+	private final boolean[] barrierConsumedChannels;
+
+	/**
+	 * Tag the state of which input channel has received the barrier. Until the barrier of a specific channel is
+	 * received, all new buffers need to be persisted after unaligned checkpointing has been started.
+	 */
+	private final boolean[] barrierReceivedChannels;
+
+	/**
+	 * Contains the offsets of the channel indices for each gate when flattening the channels of all gates.
+	 *
+	 * <p>For example, consider 3 gates with 4 channels, {@code gateChannelOffsets = [0, 4, 8]}.
+	 */
+	private final int[] gateChannelOffsets;
+
+	/**
+	 * The number of input channels which has read the barrier by task.
+	 */
+	private int numBarriersReceived;
+
+	/**
+	 * The checkpoint id to guarantee that we would trigger only one checkpoint when reading the same barrier from
+	 * different channels.
+	 */
+	private long currentCheckpointId = -1L;
+
+	/** The number of opened channels. */
+	private int numOpenChannels;
+
+	/** A future indicating that all barriers of the a given checkpoint have been read. */
+	private CompletableFuture<Void> allBarriersReceivedFuture = DONE;
+
+	private final ChannelStateWriter channelStateWriter;
+
+	CheckpointBarrierUnaligner(
+			int[] numberOfInputChannelsPerGate,
+			ChannelStateWriter channelStateWriter,
+			String taskName,
+			AbstractInvokable toNotifyOnCheckpoint) {
+		super(toNotifyOnCheckpoint);
+
+		this.taskName = taskName;
+		this.channelStateWriter = checkNotNull(channelStateWriter);
+
+		final int numGates = numberOfInputChannelsPerGate.length;
+
+		gateChannelOffsets = new int[numGates];
+		for (int index = 1; index < numGates; index++) {
+			gateChannelOffsets[index] = gateChannelOffsets[index - 1] + numberOfInputChannelsPerGate[index - 1];
+		}
+
+		final int totalNumChannels = gateChannelOffsets[numGates - 1] + numberOfInputChannelsPerGate[numGates - 1];
+		barrierConsumedChannels = new boolean[totalNumChannels];
+		Arrays.fill(barrierConsumedChannels, true);
 
 Review comment:
   Since current checkpoint id is -1. `true` is closer to the semantics as we don't ever expect a(nother) barrier with that value to be consumed.
   `CheckpointedInputGate#getInFlightData` returns an empty list as expected iff we set it to `true`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#issuecomment-603776093
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6621",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155064201",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155877268",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6755",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6839",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156597180",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6846",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156864478",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6873",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156994047",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157330632",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6900",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157451694",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6916",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157494634",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6933",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157589655",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6944",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6991",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157754467",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158102285",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7007",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7023",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158153241",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158188400",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7040",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7048",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158276096",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158831429",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7117",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7121",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158855200",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159112519",
       "triggerID" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7172",
       "triggerID" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159143719",
       "triggerID" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7175",
       "triggerID" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "triggerType" : "PUSH"
     }, {
       "hash" : "35ec088ef24e841beae78c33488975d2d8d0a40d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "35ec088ef24e841beae78c33488975d2d8d0a40d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7194",
       "triggerID" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159244661",
       "triggerID" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "triggerType" : "PUSH"
     }, {
       "hash" : "334458afaa98b601eec12c490e71caa8274be055",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "334458afaa98b601eec12c490e71caa8274be055",
       "triggerType" : "PUSH"
     }, {
       "hash" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7212",
       "triggerID" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "triggerType" : "PUSH"
     }, {
       "hash" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "status" : "CANCELED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159269141",
       "triggerID" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7226",
       "triggerID" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159307415",
       "triggerID" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * dee2b337e5e72d8f7b1f5098b74f2958d000fb3c UNKNOWN
   * 80b7f76f24b5fb6704a4b2292543f8764ec19053 UNKNOWN
   * 35ec088ef24e841beae78c33488975d2d8d0a40d UNKNOWN
   * 334458afaa98b601eec12c490e71caa8274be055 UNKNOWN
   * 17d1689c8376c55a8c5e41f78908d047b14f5631 Travis: [CANCELED](https://travis-ci.com/github/flink-ci/flink/builds/159269141) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7212) 
   * 06eece5430689d2da418e0cea10eedae22c6fbb1 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/159307415) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7226) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r402533939
 
 

 ##########
 File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/CheckpointBarrierUnaligner.java
 ##########
 @@ -0,0 +1,338 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.streaming.runtime.io;
+
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.runtime.checkpoint.CheckpointException;
+import org.apache.flink.runtime.checkpoint.CheckpointFailureReason;
+import org.apache.flink.runtime.checkpoint.channel.ChannelStateWriter;
+import org.apache.flink.runtime.checkpoint.channel.InputChannelInfo;
+import org.apache.flink.runtime.io.network.api.CancelCheckpointMarker;
+import org.apache.flink.runtime.io.network.api.CheckpointBarrier;
+import org.apache.flink.runtime.io.network.buffer.Buffer;
+import org.apache.flink.runtime.jobgraph.tasks.AbstractInvokable;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.IOException;
+import java.util.Arrays;
+import java.util.concurrent.CompletableFuture;
+
+import static org.apache.flink.util.Preconditions.checkNotNull;
+
+/**
+ * {@link CheckpointBarrierUnaligner} is used for triggering checkpoint while reading the first barrier
+ * and keeping track of the number of received barriers and consumed barriers.
+ */
+@Internal
+public class CheckpointBarrierUnaligner extends CheckpointBarrierHandler {
+
+	private static final Logger LOG = LoggerFactory.getLogger(CheckpointBarrierUnaligner.class);
+	public static final CompletableFuture<Void> DONE = CompletableFuture.completedFuture(null);
+
+	private final String taskName;
+
+	/**
+	 * Tag the state of which input channel has read the barrier. If one channel has read the barrier by task,
+	 * the respective in-flight input buffers should be empty when triggering unaligned checkpoint.
+	 */
+	private final boolean[] barrierConsumedChannels;
+
+	/**
+	 * Tag the state of which input channel has received the barrier. Until the barrier of a specific channel is
+	 * received, all new buffers need to be persisted after unaligned checkpointing has been started.
+	 */
+	private final boolean[] barrierReceivedChannels;
+
+	/**
+	 * Contains the offsets of the channel indices for each gate when flattening the channels of all gates.
+	 *
+	 * <p>For example, consider 3 gates with 4 channels, {@code gateChannelOffsets = [0, 4, 8]}.
+	 */
+	private final int[] gateChannelOffsets;
+
+	/**
+	 * The number of input channels which has read the barrier by task.
+	 */
+	private int numBarriersReceived;
+
+	/**
+	 * The checkpoint id to guarantee that we would trigger only one checkpoint when reading the same barrier from
+	 * different channels.
+	 */
+	private long currentCheckpointId = -1L;
+
+	/** The number of opened channels. */
+	private int numOpenChannels;
+
+	/** A future indicating that all barriers of the a given checkpoint have been read. */
+	private CompletableFuture<Void> allBarriersReceivedFuture = DONE;
+
+	private final ChannelStateWriter channelStateWriter;
+
+	CheckpointBarrierUnaligner(
+			int[] numberOfInputChannelsPerGate,
+			ChannelStateWriter channelStateWriter,
+			String taskName,
+			AbstractInvokable toNotifyOnCheckpoint) {
+		super(toNotifyOnCheckpoint);
+
+		this.taskName = taskName;
+		this.channelStateWriter = checkNotNull(channelStateWriter);
+
+		final int numGates = numberOfInputChannelsPerGate.length;
+
+		gateChannelOffsets = new int[numGates];
+		for (int index = 1; index < numGates; index++) {
+			gateChannelOffsets[index] = gateChannelOffsets[index - 1] + numberOfInputChannelsPerGate[index - 1];
+		}
+
+		final int totalNumChannels = gateChannelOffsets[numGates - 1] + numberOfInputChannelsPerGate[numGates - 1];
+		barrierConsumedChannels = new boolean[totalNumChannels];
+		Arrays.fill(barrierConsumedChannels, true);
+		barrierReceivedChannels = new boolean[totalNumChannels];
+		Arrays.fill(barrierReceivedChannels, true);
+		numOpenChannels = totalNumChannels;
+	}
+
+	@Override
+	public void releaseBlocksAndResetBarriers() {
+		// make sure no additional data is persisted
+		Arrays.fill(barrierConsumedChannels, true);
 
 Review comment:
   Here, you are probably right for `barrierConsumedChannels`. I have done it to guard against `CheckpointInputGate#getInflightBuffers`, but that should happen in the same thread as `releaseBlocksAndResetBarriers`.
   
   Coming to think about it, I will probably change the semantics to unconsumed and unreceived.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#issuecomment-603776093
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6621",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155064201",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155877268",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6755",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6839",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156597180",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6846",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156864478",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6873",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156994047",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157330632",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6900",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157451694",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6916",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157494634",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6933",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157589655",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6944",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6991",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157754467",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158102285",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7007",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7023",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158153241",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158188400",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7040",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7048",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158276096",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158831429",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7117",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7121",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158855200",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159112519",
       "triggerID" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7172",
       "triggerID" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159143719",
       "triggerID" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7175",
       "triggerID" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "triggerType" : "PUSH"
     }, {
       "hash" : "35ec088ef24e841beae78c33488975d2d8d0a40d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "35ec088ef24e841beae78c33488975d2d8d0a40d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7194",
       "triggerID" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159244661",
       "triggerID" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "triggerType" : "PUSH"
     }, {
       "hash" : "334458afaa98b601eec12c490e71caa8274be055",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "334458afaa98b601eec12c490e71caa8274be055",
       "triggerType" : "PUSH"
     }, {
       "hash" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7212",
       "triggerID" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "triggerType" : "PUSH"
     }, {
       "hash" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159269141",
       "triggerID" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7226",
       "triggerID" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159307415",
       "triggerID" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7297",
       "triggerID" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159652918",
       "triggerID" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "559816dcea4999dd46b09ee1091ddc0e1a5a7a54",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "559816dcea4999dd46b09ee1091ddc0e1a5a7a54",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6cd76afe4990f56a5166e1592374aa8f86fe883f",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "6cd76afe4990f56a5166e1592374aa8f86fe883f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7302",
       "triggerID" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159678447",
       "triggerID" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159695914",
       "triggerID" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7305",
       "triggerID" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ac996f5c703560ecbe6cad7394cc8ad54d6f0029",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "ac996f5c703560ecbe6cad7394cc8ad54d6f0029",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7347",
       "triggerID" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159875195",
       "triggerID" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "75c8130873e9b91e21e1e833d3d05f1ad9b5d2b8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7354",
       "triggerID" : "75c8130873e9b91e21e1e833d3d05f1ad9b5d2b8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7369",
       "triggerID" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "triggerType" : "PUSH"
     }, {
       "hash" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159960514",
       "triggerID" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7373",
       "triggerID" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159990549",
       "triggerID" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "triggerType" : "PUSH"
     }, {
       "hash" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7443",
       "triggerID" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160172375",
       "triggerID" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "536d9fb04a7a8142c04c94344dd0b3c0f2c10999",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160215439",
       "triggerID" : "536d9fb04a7a8142c04c94344dd0b3c0f2c10999",
       "triggerType" : "PUSH"
     }, {
       "hash" : "536d9fb04a7a8142c04c94344dd0b3c0f2c10999",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7469",
       "triggerID" : "536d9fb04a7a8142c04c94344dd0b3c0f2c10999",
       "triggerType" : "PUSH"
     }, {
       "hash" : "67018bacf5bc2daa8a03a1aafa880efc1db86808",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7500",
       "triggerID" : "67018bacf5bc2daa8a03a1aafa880efc1db86808",
       "triggerType" : "PUSH"
     }, {
       "hash" : "67018bacf5bc2daa8a03a1aafa880efc1db86808",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160347006",
       "triggerID" : "67018bacf5bc2daa8a03a1aafa880efc1db86808",
       "triggerType" : "PUSH"
     }, {
       "hash" : "79c116a6a1f5fe314f801e81f0265dea8b9ac1a7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7522",
       "triggerID" : "79c116a6a1f5fe314f801e81f0265dea8b9ac1a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "79c116a6a1f5fe314f801e81f0265dea8b9ac1a7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160377553",
       "triggerID" : "79c116a6a1f5fe314f801e81f0265dea8b9ac1a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "27ce4bfad8e99989dd64f8c636c934727da8a062",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "27ce4bfad8e99989dd64f8c636c934727da8a062",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ce0dfc7324679ebf2da84278eac8f5f59d748319",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7539",
       "triggerID" : "ce0dfc7324679ebf2da84278eac8f5f59d748319",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ce0dfc7324679ebf2da84278eac8f5f59d748319",
       "status" : "FAILURE",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160418181",
       "triggerID" : "ce0dfc7324679ebf2da84278eac8f5f59d748319",
       "triggerType" : "PUSH"
     }, {
       "hash" : "05c934bf483d4fb673496783ef8ff85b40b86708",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "05c934bf483d4fb673496783ef8ff85b40b86708",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4bbe67a13a75f4491898fbb1cd2315237dbca30e",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "4bbe67a13a75f4491898fbb1cd2315237dbca30e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * dee2b337e5e72d8f7b1f5098b74f2958d000fb3c UNKNOWN
   * 80b7f76f24b5fb6704a4b2292543f8764ec19053 UNKNOWN
   * 35ec088ef24e841beae78c33488975d2d8d0a40d UNKNOWN
   * 334458afaa98b601eec12c490e71caa8274be055 UNKNOWN
   * 559816dcea4999dd46b09ee1091ddc0e1a5a7a54 UNKNOWN
   * 6cd76afe4990f56a5166e1592374aa8f86fe883f UNKNOWN
   * ac996f5c703560ecbe6cad7394cc8ad54d6f0029 UNKNOWN
   * 27ce4bfad8e99989dd64f8c636c934727da8a062 UNKNOWN
   * ce0dfc7324679ebf2da84278eac8f5f59d748319 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/160418181) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7539) 
   * 05c934bf483d4fb673496783ef8ff85b40b86708 UNKNOWN
   * 4bbe67a13a75f4491898fbb1cd2315237dbca30e UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] rkhachatryan commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r407975091
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
 ##########
 @@ -542,6 +579,13 @@ public void onBuffer(Buffer buffer, int sequenceNumber, int backlog) throws IOEx
 			if (backlog >= 0) {
 				onSenderBacklog(backlog);
 			}
+
+			if (notifyReceivedBarrier != null) {
+				receivedCheckpointId = notifyReceivedBarrier.getId();
 
 Review comment:
   I'm concerned about `receivedCheckpointId` thread-safety:
   1. we don't "flush" this write, so the other thread can never see it at line 564 above (even the other thread is in `synchronized` block, it doesn't force **this** thread write)
   2. if two threads arrive at this point with different barriers then one can override other's value; so we can get older `receivedCheckpointId` written (this is not prevented by `in-flight-barriers=1`)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#issuecomment-603776093
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6621",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155064201",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155877268",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6755",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6839",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156597180",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6846",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156864478",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6873",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156994047",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157330632",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6900",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * dee2b337e5e72d8f7b1f5098b74f2958d000fb3c UNKNOWN
   * 80b7f76f24b5fb6704a4b2292543f8764ec19053 UNKNOWN
   * f18687d568167f3d70715fc67762564bb9757ee6 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/157330632) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6900) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r408059152
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
 ##########
 @@ -523,15 +557,18 @@ public void onBuffer(Buffer buffer, int sequenceNumber, int backlog) throws IOEx
 					return;
 				}
 
-				if (expectedSequenceNumber != sequenceNumber) {
-					onError(new BufferReorderingException(expectedSequenceNumber, sequenceNumber));
-					return;
-				}
-
 				wasEmpty = receivedBuffers.isEmpty();
 				receivedBuffers.add(buffer);
-				recycleBuffer = false;
+
+				if (hasListener) {
+					if (buffer.isBuffer() && receivedCheckpointId < lastRequestedCheckpointId) {
+						notifyReceivedBuffer = buffer.retainBuffer();
+					} else {
+						notifyReceivedBarrier = parseCheckpointBarrierOrNull(buffer);
 
 Review comment:
   Parsing is only done for events, which are rare and small. To move parsing outside of the `synchronized`, we'd need to copy each event, which also has some cost.
   Given that we have not performed any benchmark with the current way, I'd say moving things outside is probably a case of premature optimization.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] rkhachatryan commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r404960796
 
 

 ##########
 File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/CheckpointBarrierUnaligner.java
 ##########
 @@ -0,0 +1,417 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.streaming.runtime.io;
+
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.runtime.checkpoint.CheckpointException;
+import org.apache.flink.runtime.checkpoint.CheckpointFailureReason;
+import org.apache.flink.runtime.checkpoint.channel.ChannelStateWriter;
+import org.apache.flink.runtime.checkpoint.channel.InputChannelInfo;
+import org.apache.flink.runtime.concurrent.FutureUtils;
+import org.apache.flink.runtime.io.network.api.CancelCheckpointMarker;
+import org.apache.flink.runtime.io.network.api.CheckpointBarrier;
+import org.apache.flink.runtime.io.network.buffer.Buffer;
+import org.apache.flink.runtime.io.network.buffer.BufferReceivedListener;
+import org.apache.flink.runtime.jobgraph.tasks.AbstractInvokable;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.Closeable;
+import java.io.IOException;
+import java.util.Arrays;
+import java.util.Optional;
+import java.util.concurrent.CompletableFuture;
+import java.util.function.Function;
+import java.util.stream.IntStream;
+
+import static org.apache.flink.util.Preconditions.checkNotNull;
+
+/**
+ * {@link CheckpointBarrierUnaligner} is used for triggering checkpoint while reading the first barrier
+ * and keeping track of the number of received barriers and consumed barriers.
+ */
+@Internal
+public class CheckpointBarrierUnaligner extends CheckpointBarrierHandler {
+
+	private static final Logger LOG = LoggerFactory.getLogger(CheckpointBarrierUnaligner.class);
+
+	private final String taskName;
+
+	/**
+	 * Tag the state of which input channel has read the barrier. If one channel has read the barrier by task,
+	 * the respective in-flight input buffers should be empty when triggering unaligned checkpoint.
+	 */
+	private final boolean[] barrierConsumedChannels;
+
+	private int numBarrierConsumed;
+
+	/**
+	 * Contains the offsets of the channel indices for each gate when flattening the channels of all gates.
+	 *
+	 * <p>For example, consider 3 gates with 4 channels, {@code gateChannelOffsets = [0, 4, 8]}.
+	 */
+	private final int[] gateChannelOffsets;
+
+	private final InputChannelInfo[] channelInfos;
+
+	/**
+	 * The checkpoint id to guarantee that we would trigger only one checkpoint when reading the same barrier from
+	 * different channels.
+	 *
+	 * <p>Note: this checkpoint is valid in respect to <b>consumed</b> barriers in contrast to
+	 * {@link ThreadSafeUnaligner#currentCheckpointId}.
+	 */
+	private long currentCheckpointId = -1L;
+
+	/** Encapsulates state that is shared between netty threads and task thread. */
+	private final ThreadSafeUnaligner threadSafeUnaligner;
+
+	CheckpointBarrierUnaligner(
+			int[] numberOfInputChannelsPerGate,
+			ChannelStateWriter channelStateWriter,
+			String taskName,
+			AbstractInvokable toNotifyOnCheckpoint) {
+		super(toNotifyOnCheckpoint);
+
+		this.taskName = taskName;
+
+		final int numGates = numberOfInputChannelsPerGate.length;
+
+		gateChannelOffsets = new int[numGates];
+		for (int index = 1; index < numGates; index++) {
+			gateChannelOffsets[index] = gateChannelOffsets[index - 1] + numberOfInputChannelsPerGate[index - 1];
+		}
+
+		final int totalNumChannels = gateChannelOffsets[numGates - 1] + numberOfInputChannelsPerGate[numGates - 1];
+		barrierConsumedChannels = new boolean[totalNumChannels];
+		Arrays.fill(barrierConsumedChannels, true);
+
+		channelInfos = IntStream.range(0, numGates)
+			.mapToObj(gateIndex -> IntStream.range(0, numberOfInputChannelsPerGate[gateIndex])
+				.mapToObj(channelIndex -> new InputChannelInfo(gateIndex, channelIndex)))
+			.flatMap(Function.identity())
+			.toArray(InputChannelInfo[]::new);
+
+		threadSafeUnaligner = new ThreadSafeUnaligner(totalNumChannels,	checkNotNull(channelStateWriter), this);
+	}
+
+	@Override
+	public void releaseBlocksAndResetBarriers() {
+		// make sure no additional data is persisted
+		Arrays.fill(barrierConsumedChannels, true);
+		// the next barrier that comes must assume it is the first
+		numBarrierConsumed = 0;
+		threadSafeUnaligner.releaseBlocksAndResetBarriers();
+	}
+
+	/**
+	 * For unaligned checkpoint, it never blocks processing from the task aspect.
+	 *
+	 * <p>For PoC, we do not consider the possibility that the unaligned checkpoint would
+	 * not perform due to the max configured unaligned checkpoint size.
+	 */
+	@Override
+	public boolean isBlocked(int channelIndex) {
+		return false;
+	}
+
+	/**
+	 * We still need to trigger checkpoint while reading the first barrier from one channel, because this might happen
+	 * earlier than the previous async trigger via mailbox by netty thread. And the {@link AbstractInvokable} has the
+	 * deduplication logic to guarantee trigger checkpoint only once finally.
+	 *
+	 * <p>Note this is also suitable for the trigger case of local input channel.
+	 */
+	@Override
+	public boolean processBarrier(
+			CheckpointBarrier receivedBarrier,
+			int channelIndex,
+			long bufferedBytes) throws IOException {
+		long barrierId = receivedBarrier.getId();
+		if (currentCheckpointId < barrierId) {
+			currentCheckpointId = barrierId;
+			numBarrierConsumed = 0;
+			Arrays.fill(barrierConsumedChannels, false);
+		}
+		if (currentCheckpointId == barrierId) {
+			barrierConsumedChannels[channelIndex] = true;
+			numBarrierConsumed++;
+		}
+		// processBarrier is called from task thread and can actually happen before notifyBarrierReceived on empty
+		// buffer queues
+		// to avoid replicating any logic, we simply call notifyBarrierReceived here as well
+		threadSafeUnaligner.notifyBarrierReceived(receivedBarrier, channelInfos[channelIndex]);
+		return false;
+	}
+
+	@Override
+	public boolean processCancellationBarrier(CancelCheckpointMarker cancelBarrier) throws Exception {
+		final long barrierId = cancelBarrier.getCheckpointId();
+
+		if (numBarrierConsumed > 0) {
+			// this is only true if some alignment is in progress and nothing was canceled
+
+			if (barrierId == currentCheckpointId) {
+				// cancel this alignment
+				if (LOG.isDebugEnabled()) {
+					LOG.debug("{}: Checkpoint {} canceled, aborting alignment.", taskName, barrierId);
+				}
+
+				releaseBlocksAndResetBarriers();
+				notifyAbortOnCancellationBarrier(barrierId);
+			}
+			else if (barrierId > currentCheckpointId) {
+				// we canceled the next which also cancels the current
+				LOG.warn("{}: Received cancellation barrier for checkpoint {} before completing current checkpoint {}. " +
+						"Skipping current checkpoint.",
+					taskName,
+					barrierId,
+					currentCheckpointId);
+
+				// this stops the current alignment
+				releaseBlocksAndResetBarriers();
+
+				// the next checkpoint starts as canceled
+				currentCheckpointId = barrierId;
+				threadSafeUnaligner.setCurrentCheckpointId(currentCheckpointId);
+				notifyAbortOnCancellationBarrier(barrierId);
+			}
+
+			// else: ignore trailing (cancellation) barrier from an earlier checkpoint (obsolete now)
+
+		}
+		else if (barrierId > currentCheckpointId) {
+			// first barrier of a new checkpoint is directly a cancellation
+
+			// by setting the currentCheckpointId to this checkpoint while keeping the numBarriers
+			// at zero means that no checkpoint barrier can start a new alignment
+			currentCheckpointId = barrierId;
+			threadSafeUnaligner.setCurrentCheckpointId(currentCheckpointId);
+
+			if (LOG.isDebugEnabled()) {
+				LOG.debug("{}: Checkpoint {} canceled, skipping alignment.", taskName, barrierId);
+			}
+
+			notifyAbortOnCancellationBarrier(barrierId);
+		}
+
+		// else: trailing barrier from either
+		//   - a previous (subsumed) checkpoint
+		//   - the current checkpoint if it was already canceled
+		return false;
+	}
+
+	@Override
+	public boolean processEndOfPartition() throws Exception {
+		threadSafeUnaligner.processEndOfPartition();
+
+		if (numBarrierConsumed > 0) {
+			// let the task know we skip a checkpoint
+			notifyAbort(
+				currentCheckpointId,
+				new CheckpointException(CheckpointFailureReason.CHECKPOINT_DECLINED_INPUT_END_OF_STREAM));
+			// no chance to complete this checkpoint
+			releaseBlocksAndResetBarriers();
+			return true;
+		}
+		return false;
+	}
+
+	@Override
+	public long getLatestCheckpointId() {
+		return currentCheckpointId;
+	}
+
+	@Override
+	public long getAlignmentDurationNanos() {
+		return 0;
+	}
+
+	@Override
+	public String toString() {
+		return String.format("%s: last checkpoint: %d", taskName, currentCheckpointId);
+	}
+
+	@Override
+	public void checkpointSizeLimitExceeded(long maxBufferedBytes) {
+	}
+
+	@Override
+	public void close() throws IOException {
+		super.close();
+		threadSafeUnaligner.close();
+	}
+
+	@Override
+	protected boolean isBarrierConsumed(long checkpointId, int channelIndex) {
+		if (checkpointId < currentCheckpointId) {
+			return true;
+		}
+		if (checkpointId > currentCheckpointId) {
+			return false;
+		}
+		return barrierConsumedChannels[channelIndex];
+	}
+
+	public CompletableFuture<Void> getAllBarriersReceivedFuture(long checkpointId) {
+		return threadSafeUnaligner.getAllBarriersReceivedFuture(checkpointId);
+	}
+
+	@Override
+	public Optional<BufferReceivedListener> getBufferReceivedListener() {
+		return Optional.of(threadSafeUnaligner);
+	}
+
+	private int getFlattenedChannelIndex(InputChannelInfo channelInfo) {
+		return gateChannelOffsets[channelInfo.getGateIdx()] + channelInfo.getInputChannelIdx();
+	}
+
+	private static class ThreadSafeUnaligner implements BufferReceivedListener, Closeable {
+
+		/**
+		 * Tag the state of which input channel has received the barrier. Until the barrier of a specific channel is
+		 * received, all new buffers need to be persisted after unaligned checkpointing has been started.
+		 */
+		private final boolean[] barrierReceivedChannels;
+
+		/**
+		 * The number of input channels which has read the barrier by task.
+		 */
+		private int numBarriersReceived;
+
+		/** A future indicating that all barriers of the a given checkpoint have been read. */
+		private CompletableFuture<Void> allBarriersReceivedFuture = FutureUtils.completedVoidFuture();
+
+		/**
+		 * The checkpoint id to guarantee that we would trigger only one checkpoint when reading the same barrier from
+		 * different channels.
+		 *
+		 * <p>Note: this checkpoint is valid in respect to <b>received</b> barriers in contrast to
+		 * {@link CheckpointBarrierUnaligner#currentCheckpointId}.
+		 */
+		private long currentCheckpointId = -1L;
+
+		/** The number of opened channels. */
+		private int numOpenChannels;
+
+		private final ChannelStateWriter channelStateWriter;
+
+		private final CheckpointBarrierUnaligner handler;
+
+		public ThreadSafeUnaligner(
+				int totalNumChannels,
+				ChannelStateWriter channelStateWriter,
+				CheckpointBarrierUnaligner handler) {
+			barrierReceivedChannels = new boolean[totalNumChannels];
+			this.channelStateWriter = channelStateWriter;
+			this.handler = handler;
+			Arrays.fill(barrierReceivedChannels, true);
+			numOpenChannels = totalNumChannels;
+		}
+
+		@Override
+		public synchronized void notifyBarrierReceived(CheckpointBarrier barrier, InputChannelInfo channelInfo) throws IOException {
+			long barrierId = barrier.getId();
+
+			if (currentCheckpointId < barrierId) {
+				handleNewCheckpoint(barrierId);
+				handler.runInTaskThread(() -> handler.notifyCheckpoint(barrier, 0, 0), "notifyCheckpoint");
+			}
+
+			int channelIndex = handler.getFlattenedChannelIndex(channelInfo);
+			if (barrierId == currentCheckpointId && !barrierReceivedChannels[channelIndex]) {
+				if (LOG.isDebugEnabled()) {
+					LOG.debug("{}: Received barrier from channel {} @ {}.", handler.taskName, channelIndex, barrierId);
+				}
+
+				barrierReceivedChannels[channelIndex] = true;
+
+				if (++numBarriersReceived == numOpenChannels) {
+					allBarriersReceivedFuture.complete(null);
+				}
+			}
+		}
+
+		@Override
+		public synchronized void notifyBufferReceived(Buffer buffer, InputChannelInfo channelInfo) {
+			if (!barrierReceivedChannels[handler.getFlattenedChannelIndex(channelInfo)]) {
+				channelStateWriter.addInputData(
+					currentCheckpointId,
+					channelInfo,
+					ChannelStateWriter.SEQUENCE_NUMBER_UNKNOWN,
+					buffer.retainBuffer());
+			}
+		}
+
+		@Override
+		public void close() throws IOException {
+			allBarriersReceivedFuture.completeExceptionally(new IllegalStateException("Closed CheckpointBarrierUnaligner"));
+		}
+
+		private synchronized void handleNewCheckpoint(long barrierId) throws IOException {
+			if (!allBarriersReceivedFuture.isDone()) {
 
 Review comment:
   Should we complete (exceptionally?) this future here?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#issuecomment-603776093
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 46c39891af3d5ae037620c384f15d01b77419b1b UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r404303608
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/NettyShuffleEnvironment.java
 ##########
 @@ -184,17 +184,18 @@ public ShuffleIOOwnerContext createShuffleIOOwnerContext(
 	}
 
 	@Override
-	public Collection<ResultPartition> createResultPartitionWriters(
 
 Review comment:
   Hm seems like my response got lost.
   In general, `Collection` gives no ordering guarantees. If the using code breaks if we return a `HashSet` instead of an `ArrayList`, then it's the wrong interface. We have been sloppy with this distinction in the past and I wanted to make it very explicit for our deep change into how channels are working.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zhijiangW commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
zhijiangW commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r400637920
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PriorityEventListener.java
 ##########
 @@ -0,0 +1,54 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.io.network.partition;
+
+import org.apache.flink.runtime.event.AbstractEvent;
+import org.apache.flink.runtime.io.network.buffer.BufferConsumer;
+
+import java.io.IOException;
+
+/**
+ * Listens to priority events (e.g., checkpoint barriers) of subpartitions. The listener can completely process the
+ * event without the buffer queue or let the subpartition enqueue the event in the front or back of the buffer queue.
+ */
+public interface PriorityEventListener {
+	/**
+	 * Allows the listener to react to a priority event independent of the outgoing buffer queue.
+	 *
+	 * @return the action to be performed by the caller.
+	 */
+	EnqueueAction priorityEvent(AbstractEvent event, BufferConsumer eventBufferConsumer) throws IOException;
 
 Review comment:
   I guess this return value actually not be used in practice now. Do we need to introduce it?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#issuecomment-603776093
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6621",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155064201",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155877268",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6755",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6839",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156597180",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6846",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156864478",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6873",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156994047",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157330632",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6900",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157451694",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6916",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * dee2b337e5e72d8f7b1f5098b74f2958d000fb3c UNKNOWN
   * 80b7f76f24b5fb6704a4b2292543f8764ec19053 UNKNOWN
   * d5d714a4d954b82862972864805a151d04c3a513 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/157451694) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6916) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] rkhachatryan commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r408113954
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
 ##########
 @@ -513,8 +540,15 @@ public void onBuffer(Buffer buffer, int sequenceNumber, int backlog) throws IOEx
 		boolean recycleBuffer = true;
 
 		try {
+			if (expectedSequenceNumber != sequenceNumber) {
+				onError(new BufferReorderingException(expectedSequenceNumber, sequenceNumber));
+				return;
+			}
 
 			final boolean wasEmpty;
+			CheckpointBarrier notifyReceivedBarrier = null;
+			Buffer notifyReceivedBuffer = null;
+			final boolean hasListener = inputGate.bufferReceivedListener != null;
 
 Review comment:
   Answered to the previous comment (please unresolved it and resolve this one).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r405061975
 
 

 ##########
 File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/CheckpointBarrierUnaligner.java
 ##########
 @@ -0,0 +1,420 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.streaming.runtime.io;
+
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.runtime.checkpoint.CheckpointException;
+import org.apache.flink.runtime.checkpoint.CheckpointFailureReason;
+import org.apache.flink.runtime.checkpoint.channel.ChannelStateWriter;
+import org.apache.flink.runtime.checkpoint.channel.InputChannelInfo;
+import org.apache.flink.runtime.concurrent.FutureUtils;
+import org.apache.flink.runtime.io.network.api.CancelCheckpointMarker;
+import org.apache.flink.runtime.io.network.api.CheckpointBarrier;
+import org.apache.flink.runtime.io.network.buffer.Buffer;
+import org.apache.flink.runtime.io.network.buffer.BufferReceivedListener;
+import org.apache.flink.runtime.jobgraph.tasks.AbstractInvokable;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.Closeable;
+import java.io.IOException;
+import java.util.Arrays;
+import java.util.Optional;
+import java.util.concurrent.CompletableFuture;
+import java.util.function.Function;
+import java.util.stream.IntStream;
+
+import static org.apache.flink.util.Preconditions.checkNotNull;
+
+/**
+ * {@link CheckpointBarrierUnaligner} is used for triggering checkpoint while reading the first barrier
+ * and keeping track of the number of received barriers and consumed barriers.
+ */
+@Internal
+public class CheckpointBarrierUnaligner extends CheckpointBarrierHandler {
+
+	private static final Logger LOG = LoggerFactory.getLogger(CheckpointBarrierUnaligner.class);
+
+	private final String taskName;
+
+	/**
+	 * Tag the state of which input channel has read the barrier. If one channel has read the barrier by task,
+	 * the respective in-flight input buffers should be empty when triggering unaligned checkpoint.
+	 */
+	private final boolean[] barrierConsumedChannels;
+
+	private int numBarrierConsumed;
+
+	/**
+	 * Contains the offsets of the channel indices for each gate when flattening the channels of all gates.
+	 *
+	 * <p>For example, consider 3 gates with 4 channels, {@code gateChannelOffsets = [0, 4, 8]}.
+	 */
+	private final int[] gateChannelOffsets;
+
+	private final InputChannelInfo[] channelInfos;
+
+	/**
+	 * The checkpoint id to guarantee that we would trigger only one checkpoint when reading the same barrier from
+	 * different channels.
+	 *
+	 * <p>Note: this checkpoint is valid in respect to <b>consumed</b> barriers in contrast to
+	 * {@link ThreadSafeUnaligner#currentCheckpointId}.
+	 */
+	private long currentCheckpointId = -1L;
+
+	/** Encapsulates state that is shared between netty threads and task thread. */
+	private final ThreadSafeUnaligner threadSafeUnaligner;
+
+	CheckpointBarrierUnaligner(
+			int[] numberOfInputChannelsPerGate,
+			ChannelStateWriter channelStateWriter,
+			String taskName,
+			AbstractInvokable toNotifyOnCheckpoint) {
+		super(toNotifyOnCheckpoint);
+
+		this.taskName = taskName;
+
+		final int numGates = numberOfInputChannelsPerGate.length;
+
+		gateChannelOffsets = new int[numGates];
+		for (int index = 1; index < numGates; index++) {
+			gateChannelOffsets[index] = gateChannelOffsets[index - 1] + numberOfInputChannelsPerGate[index - 1];
+		}
+
+		final int totalNumChannels = gateChannelOffsets[numGates - 1] + numberOfInputChannelsPerGate[numGates - 1];
+		barrierConsumedChannels = new boolean[totalNumChannels];
+		Arrays.fill(barrierConsumedChannels, true);
+
+		channelInfos = IntStream.range(0, numGates)
+			.mapToObj(gateIndex -> IntStream.range(0, numberOfInputChannelsPerGate[gateIndex])
+				.mapToObj(channelIndex -> new InputChannelInfo(gateIndex, channelIndex)))
+			.flatMap(Function.identity())
+			.toArray(InputChannelInfo[]::new);
+
+		threadSafeUnaligner = new ThreadSafeUnaligner(totalNumChannels,	checkNotNull(channelStateWriter), this);
+	}
+
+	@Override
+	public void releaseBlocksAndResetBarriers() {
+		// make sure no additional data is persisted
+		Arrays.fill(barrierConsumedChannels, true);
+		// the next barrier that comes must assume it is the first
+		numBarrierConsumed = 0;
+		threadSafeUnaligner.releaseBlocksAndResetBarriers();
+	}
+
+	/**
+	 * For unaligned checkpoint, it never blocks processing from the task aspect.
+	 *
+	 * <p>For PoC, we do not consider the possibility that the unaligned checkpoint would
+	 * not perform due to the max configured unaligned checkpoint size.
+	 */
+	@Override
+	public boolean isBlocked(int channelIndex) {
+		return false;
+	}
+
+	/**
+	 * We still need to trigger checkpoint while reading the first barrier from one channel, because this might happen
+	 * earlier than the previous async trigger via mailbox by netty thread. And the {@link AbstractInvokable} has the
+	 * deduplication logic to guarantee trigger checkpoint only once finally.
+	 *
+	 * <p>Note this is also suitable for the trigger case of local input channel.
+	 */
+	@Override
+	public boolean processBarrier(
+			CheckpointBarrier receivedBarrier,
+			int channelIndex,
+			long bufferedBytes) throws IOException {
+		long barrierId = receivedBarrier.getId();
+		if (currentCheckpointId < barrierId) {
+			currentCheckpointId = barrierId;
+			numBarrierConsumed = 0;
+			Arrays.fill(barrierConsumedChannels, false);
+		}
+		if (currentCheckpointId == barrierId) {
+			barrierConsumedChannels[channelIndex] = true;
+			numBarrierConsumed++;
+		}
+		// processBarrier is called from task thread and can actually happen before notifyBarrierReceived on empty
+		// buffer queues
+		// to avoid replicating any logic, we simply call notifyBarrierReceived here as well
+		threadSafeUnaligner.notifyBarrierReceived(receivedBarrier, channelInfos[channelIndex]);
+		return false;
+	}
+
+	@Override
+	public boolean processCancellationBarrier(CancelCheckpointMarker cancelBarrier) throws Exception {
+		final long barrierId = cancelBarrier.getCheckpointId();
+
+		if (numBarrierConsumed > 0) {
+			// this is only true if some alignment is in progress and nothing was canceled
+
+			if (barrierId == currentCheckpointId) {
+				// cancel this alignment
+				if (LOG.isDebugEnabled()) {
+					LOG.debug("{}: Checkpoint {} canceled, aborting alignment.", taskName, barrierId);
+				}
+
+				releaseBlocksAndResetBarriers();
+				notifyAbortOnCancellationBarrier(barrierId);
+			}
+			else if (barrierId > currentCheckpointId) {
+				// we canceled the next which also cancels the current
+				LOG.warn("{}: Received cancellation barrier for checkpoint {} before completing current checkpoint {}. " +
+						"Skipping current checkpoint.",
+					taskName,
+					barrierId,
+					currentCheckpointId);
+
+				// this stops the current alignment
+				releaseBlocksAndResetBarriers();
+
+				// the next checkpoint starts as canceled
+				currentCheckpointId = barrierId;
+				threadSafeUnaligner.setCurrentCheckpointId(currentCheckpointId);
+				notifyAbortOnCancellationBarrier(barrierId);
+			}
+
+			// else: ignore trailing (cancellation) barrier from an earlier checkpoint (obsolete now)
+
+		}
+		else if (barrierId > currentCheckpointId) {
+			// first barrier of a new checkpoint is directly a cancellation
+
+			// by setting the currentCheckpointId to this checkpoint while keeping the numBarriers
+			// at zero means that no checkpoint barrier can start a new alignment
+			currentCheckpointId = barrierId;
+			threadSafeUnaligner.setCurrentCheckpointId(currentCheckpointId);
+
+			if (LOG.isDebugEnabled()) {
+				LOG.debug("{}: Checkpoint {} canceled, skipping alignment.", taskName, barrierId);
+			}
+
+			notifyAbortOnCancellationBarrier(barrierId);
+		}
+
+		// else: trailing barrier from either
+		//   - a previous (subsumed) checkpoint
+		//   - the current checkpoint if it was already canceled
+		return false;
+	}
+
+	@Override
+	public boolean processEndOfPartition() throws Exception {
+		threadSafeUnaligner.processEndOfPartition();
+
+		if (numBarrierConsumed > 0) {
+			// let the task know we skip a checkpoint
+			notifyAbort(
+				currentCheckpointId,
+				new CheckpointException(CheckpointFailureReason.CHECKPOINT_DECLINED_INPUT_END_OF_STREAM));
+			// no chance to complete this checkpoint
+			releaseBlocksAndResetBarriers();
+			return true;
+		}
+		return false;
+	}
+
+	@Override
+	public long getLatestCheckpointId() {
+		return currentCheckpointId;
+	}
+
+	@Override
+	public long getAlignmentDurationNanos() {
+		return 0;
+	}
+
+	@Override
+	public String toString() {
+		return String.format("%s: last checkpoint: %d", taskName, currentCheckpointId);
+	}
+
+	@Override
+	public void checkpointSizeLimitExceeded(long maxBufferedBytes) {
+	}
+
+	@Override
+	public void close() throws IOException {
+		super.close();
+		threadSafeUnaligner.close();
+	}
+
+	@Override
+	protected boolean isBarrierConsumed(long checkpointId, int channelIndex) {
+		if (checkpointId < currentCheckpointId) {
+			return true;
+		}
+		if (checkpointId > currentCheckpointId) {
+			return false;
+		}
+		return barrierConsumedChannels[channelIndex];
+	}
+
+	public CompletableFuture<Void> getAllBarriersReceivedFuture(long checkpointId) {
+		return threadSafeUnaligner.getAllBarriersReceivedFuture(checkpointId);
+	}
+
+	@Override
+	public Optional<BufferReceivedListener> getBufferReceivedListener() {
+		return Optional.of(threadSafeUnaligner);
+	}
+
+	private int getFlattenedChannelIndex(InputChannelInfo channelInfo) {
+		return gateChannelOffsets[channelInfo.getGateIdx()] + channelInfo.getInputChannelIdx();
+	}
+
+	private static class ThreadSafeUnaligner implements BufferReceivedListener, Closeable {
+
+		/**
+		 * Tag the state of which input channel has received the barrier. Until the barrier of a specific channel is
+		 * received, all new buffers need to be persisted after unaligned checkpointing has been started.
+		 */
+		private final boolean[] barrierReceivedChannels;
+
+		/**
+		 * The number of input channels which has read the barrier by task.
+		 */
+		private int numBarriersReceived;
+
+		/** A future indicating that all barriers of the a given checkpoint have been read. */
+		private CompletableFuture<Void> allBarriersReceivedFuture = FutureUtils.completedVoidFuture();
+
+		/**
+		 * The checkpoint id to guarantee that we would trigger only one checkpoint when reading the same barrier from
+		 * different channels.
+		 *
+		 * <p>Note: this checkpoint is valid in respect to <b>received</b> barriers in contrast to
+		 * {@link CheckpointBarrierUnaligner#currentCheckpointId}.
+		 */
+		private long currentCheckpointId = -1L;
+
+		/** The number of opened channels. */
+		private int numOpenChannels;
+
+		private final ChannelStateWriter channelStateWriter;
+
+		private final CheckpointBarrierUnaligner handler;
+
+		public ThreadSafeUnaligner(
+				int totalNumChannels,
+				ChannelStateWriter channelStateWriter,
+				CheckpointBarrierUnaligner handler) {
+			barrierReceivedChannels = new boolean[totalNumChannels];
+			this.channelStateWriter = channelStateWriter;
+			this.handler = handler;
+			Arrays.fill(barrierReceivedChannels, true);
+			numOpenChannels = totalNumChannels;
+		}
+
+		@Override
+		public synchronized void notifyBarrierReceived(CheckpointBarrier barrier, InputChannelInfo channelInfo) {
+			long barrierId = barrier.getId();
+
+			if (currentCheckpointId < barrierId) {
+				handleNewCheckpoint(barrierId);
+				handler.runInTaskThread(() -> handler.notifyCheckpoint(barrier, 0, 0), "notifyCheckpoint");
+			}
+
+			int channelIndex = handler.getFlattenedChannelIndex(channelInfo);
+			if (barrierId == currentCheckpointId && !barrierReceivedChannels[channelIndex]) {
+				if (LOG.isDebugEnabled()) {
+					LOG.debug("{}: Received barrier from channel {} @ {}.", handler.taskName, channelIndex, barrierId);
+				}
+
+				barrierReceivedChannels[channelIndex] = true;
+
+				if (++numBarriersReceived == numOpenChannels) {
+					allBarriersReceivedFuture.complete(null);
+				}
+			}
+		}
+
+		@Override
+		public synchronized void notifyBufferReceived(Buffer buffer, InputChannelInfo channelInfo) {
+			if (!barrierReceivedChannels[handler.getFlattenedChannelIndex(channelInfo)]) {
+				channelStateWriter.addInputData(
+					currentCheckpointId,
+					channelInfo,
+					ChannelStateWriter.SEQUENCE_NUMBER_UNKNOWN,
+					buffer);
+			} else {
+				buffer.recycleBuffer();
+			}
+		}
+
+		@Override
+		public void close() throws IOException {
+			allBarriersReceivedFuture.completeExceptionally(new IllegalStateException("Closed CheckpointBarrierUnaligner"));
+		}
+
+		private synchronized void handleNewCheckpoint(long barrierId) {
+			if (!allBarriersReceivedFuture.isDone()) {
+				// we did not complete the current checkpoint, another started before
+				LOG.warn("{}: Received checkpoint barrier for checkpoint {} before completing current checkpoint {}. " +
+						"Skipping current checkpoint.",
+					handler.taskName,
+					barrierId,
+					currentCheckpointId);
+
+				// let the task know we are not completing this
+				long currentCheckpointId = this.currentCheckpointId;
+				handler.runInTaskThread(() ->
+					handler.notifyAbort(currentCheckpointId,
+						new CheckpointException(
+							"Barrier id: " + barrierId,
+							CheckpointFailureReason.CHECKPOINT_DECLINED_SUBSUMED)),
+					"notifyAbort");
+			}
+
+			currentCheckpointId = barrierId;
+			Arrays.fill(barrierReceivedChannels, false);
+			numBarriersReceived = 0;
+			allBarriersReceivedFuture = new CompletableFuture<>();
+			channelStateWriter.start(barrierId);
+		}
+
+		public synchronized void releaseBlocksAndResetBarriers() {
+			Arrays.fill(barrierReceivedChannels, true);
+			// the next barrier that comes must assume it is the first
+			numBarriersReceived = 0;
+		}
+
+		public synchronized CompletableFuture<Void> getAllBarriersReceivedFuture(long checkpointId) {
+			if (checkpointId < currentCheckpointId) {
+				return FutureUtils.completedVoidFuture();
+			}
+			if (checkpointId > currentCheckpointId) {
+				throw new IllegalStateException("Checkpoint " + checkpointId + " has not been started at all");
+			}
+			return this.allBarriersReceivedFuture;
+		}
+
+		public synchronized void processEndOfPartition() {
+			numOpenChannels--;
+		}
+
+		public void setCurrentCheckpointId(long currentCheckpointId) {
+			this.currentCheckpointId = currentCheckpointId;
+		}
 
 Review comment:
   1. Yes!
   2. Yes, but probably `>=` since it may have already peeked a barrier with the same id.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#issuecomment-603776093
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6621",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155064201",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155877268",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6755",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6839",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156597180",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6846",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156864478",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6873",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156994047",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157330632",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6900",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157451694",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6916",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157494634",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6933",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157589655",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6944",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6991",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157754467",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158102285",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7007",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7023",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158153241",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158188400",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7040",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7048",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158276096",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158831429",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7117",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7121",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158855200",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159112519",
       "triggerID" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7172",
       "triggerID" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159143719",
       "triggerID" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7175",
       "triggerID" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "triggerType" : "PUSH"
     }, {
       "hash" : "35ec088ef24e841beae78c33488975d2d8d0a40d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "35ec088ef24e841beae78c33488975d2d8d0a40d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7194",
       "triggerID" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159244661",
       "triggerID" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "triggerType" : "PUSH"
     }, {
       "hash" : "334458afaa98b601eec12c490e71caa8274be055",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "334458afaa98b601eec12c490e71caa8274be055",
       "triggerType" : "PUSH"
     }, {
       "hash" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7212",
       "triggerID" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "triggerType" : "PUSH"
     }, {
       "hash" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159269141",
       "triggerID" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7226",
       "triggerID" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "status" : "FAILURE",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159307415",
       "triggerID" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * dee2b337e5e72d8f7b1f5098b74f2958d000fb3c UNKNOWN
   * 80b7f76f24b5fb6704a4b2292543f8764ec19053 UNKNOWN
   * 35ec088ef24e841beae78c33488975d2d8d0a40d UNKNOWN
   * 334458afaa98b601eec12c490e71caa8274be055 UNKNOWN
   * 06eece5430689d2da418e0cea10eedae22c6fbb1 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/159307415) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7226) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] rkhachatryan commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r406409278
 
 

 ##########
 File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/CheckpointBarrierUnaligner.java
 ##########
 @@ -0,0 +1,430 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.streaming.runtime.io;
+
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.runtime.checkpoint.CheckpointException;
+import org.apache.flink.runtime.checkpoint.CheckpointFailureReason;
+import org.apache.flink.runtime.checkpoint.channel.ChannelStateWriter;
+import org.apache.flink.runtime.checkpoint.channel.InputChannelInfo;
+import org.apache.flink.runtime.concurrent.FutureUtils;
+import org.apache.flink.runtime.io.network.api.CancelCheckpointMarker;
+import org.apache.flink.runtime.io.network.api.CheckpointBarrier;
+import org.apache.flink.runtime.io.network.buffer.Buffer;
+import org.apache.flink.runtime.io.network.buffer.BufferReceivedListener;
+import org.apache.flink.runtime.jobgraph.tasks.AbstractInvokable;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import javax.annotation.concurrent.NotThreadSafe;
+import javax.annotation.concurrent.ThreadSafe;
+
+import java.io.Closeable;
+import java.io.IOException;
+import java.util.Arrays;
+import java.util.Optional;
+import java.util.concurrent.CompletableFuture;
+import java.util.function.Function;
+import java.util.stream.IntStream;
+
+import static org.apache.flink.util.Preconditions.checkNotNull;
+
+/**
+ * {@link CheckpointBarrierUnaligner} is used for triggering checkpoint while reading the first barrier
+ * and keeping track of the number of received barriers and consumed barriers.
+ */
+@Internal
+@NotThreadSafe
+public class CheckpointBarrierUnaligner extends CheckpointBarrierHandler {
+
+	private static final Logger LOG = LoggerFactory.getLogger(CheckpointBarrierUnaligner.class);
+
+	private final String taskName;
+
+	/**
+	 * Tag the state of which input channel has pending in-flight buffers; that is, already received buffers that
+	 * predate the checkpoint barrier of the current checkpoint.
+	 */
+	private final boolean[] hasInflightBuffers;
+
+	private int numBarrierConsumed;
+
+	/**
+	 * Contains the offsets of the channel indices for each gate when flattening the channels of all gates.
+	 *
+	 * <p>For example, consider 3 gates with 4 channels, {@code gateChannelOffsets = [0, 4, 8]}.
+	 */
+	private final int[] gateChannelOffsets;
+
+	private final InputChannelInfo[] channelInfos;
+
+	/**
+	 * The checkpoint id to guarantee that we would trigger only one checkpoint when reading the same barrier from
+	 * different channels.
+	 *
+	 * <p>Note: this checkpoint is valid in respect to <b>consumed</b> barriers in contrast to
+	 * {@link ThreadSafeUnaligner#currentReceivedCheckpointId}.
+	 */
+	private long currentConsumedCheckpointId = -1L;
+
+	/** Encapsulates state that is shared between netty threads and task thread. */
+	private final ThreadSafeUnaligner threadSafeUnaligner;
+
+	CheckpointBarrierUnaligner(
+			int[] numberOfInputChannelsPerGate,
+			ChannelStateWriter channelStateWriter,
+			String taskName,
+			AbstractInvokable toNotifyOnCheckpoint) {
+		super(toNotifyOnCheckpoint);
+
+		this.taskName = taskName;
+
+		final int numGates = numberOfInputChannelsPerGate.length;
+
+		gateChannelOffsets = new int[numGates];
+		for (int index = 1; index < numGates; index++) {
+			gateChannelOffsets[index] = gateChannelOffsets[index - 1] + numberOfInputChannelsPerGate[index - 1];
+		}
+
+		final int totalNumChannels = gateChannelOffsets[numGates - 1] + numberOfInputChannelsPerGate[numGates - 1];
+		hasInflightBuffers = new boolean[totalNumChannels];
+
+		channelInfos = IntStream.range(0, numGates)
+			.mapToObj(gateIndex -> IntStream.range(0, numberOfInputChannelsPerGate[gateIndex])
+				.mapToObj(channelIndex -> new InputChannelInfo(gateIndex, channelIndex)))
+			.flatMap(Function.identity())
+			.toArray(InputChannelInfo[]::new);
+
+		threadSafeUnaligner = new ThreadSafeUnaligner(totalNumChannels,	checkNotNull(channelStateWriter), this);
+	}
+
+	@Override
+	public void releaseBlocksAndResetBarriers() {
+		// make sure no additional data is persisted
+		Arrays.fill(hasInflightBuffers, false);
+		threadSafeUnaligner.resetReceivedBarriers(currentConsumedCheckpointId);
+		// the next barrier that comes must assume it is the first
+		numBarrierConsumed = 0;
+	}
+
+	/**
+	 * For unaligned checkpoint, it never blocks processing from the task aspect.
+	 *
+	 * <p>For PoC, we do not consider the possibility that the unaligned checkpoint would
+	 * not perform due to the max configured unaligned checkpoint size.
+	 */
+	@Override
+	public boolean isBlocked(int channelIndex) {
+		return false;
+	}
+
+	/**
+	 * We still need to trigger checkpoint while reading the first barrier from one channel, because this might happen
+	 * earlier than the previous async trigger via mailbox by netty thread. And the {@link AbstractInvokable} has the
+	 * deduplication logic to guarantee trigger checkpoint only once finally.
+	 *
+	 * <p>Note this is also suitable for the trigger case of local input channel.
+	 */
+	@Override
+	public boolean processBarrier(
+			CheckpointBarrier receivedBarrier,
+			int channelIndex,
+			long bufferedBytes) {
+		long barrierId = receivedBarrier.getId();
+		if (currentConsumedCheckpointId < barrierId) {
+			currentConsumedCheckpointId = barrierId;
+			numBarrierConsumed = 0;
+			Arrays.fill(hasInflightBuffers, true);
+		}
+		if (currentConsumedCheckpointId == barrierId) {
+			hasInflightBuffers[channelIndex] = false;
+			numBarrierConsumed++;
+		}
+		// processBarrier is called from task thread and can actually happen before notifyBarrierReceived on empty
+		// buffer queues
+		// to avoid replicating any logic, we simply call notifyBarrierReceived here as well
+		threadSafeUnaligner.notifyBarrierReceived(receivedBarrier, channelInfos[channelIndex]);
+		return false;
+	}
+
+	@Override
+	public boolean processCancellationBarrier(CancelCheckpointMarker cancelBarrier) throws Exception {
+		final long barrierId = cancelBarrier.getCheckpointId();
+
+		if (numBarrierConsumed > 0) {
+			// this is only true if some alignment is in progress and nothing was canceled
+
+			if (barrierId == currentConsumedCheckpointId) {
+				// cancel this alignment
+				if (LOG.isDebugEnabled()) {
+					LOG.debug("{}: Checkpoint {} canceled, aborting alignment.", taskName, barrierId);
+				}
+
+				releaseBlocksAndResetBarriers();
+				notifyAbortOnCancellationBarrier(barrierId);
+			}
+			else if (barrierId > currentConsumedCheckpointId) {
+				// we canceled the next which also cancels the current
+				LOG.warn("{}: Received cancellation barrier for checkpoint {} before completing current checkpoint {}. " +
+						"Skipping current checkpoint.",
+					taskName,
+					barrierId,
+					currentConsumedCheckpointId);
+
+				// this stops the current alignment
+				releaseBlocksAndResetBarriers();
+
+				// the next checkpoint starts as canceled
+				currentConsumedCheckpointId = barrierId;
+				threadSafeUnaligner.setCurrentReceivedCheckpointId(currentConsumedCheckpointId);
 
 Review comment:
   Shouldn't we have this call also for the above branch (`barrierId == currentConsumedCheckpointId`)? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] pnowojski commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
pnowojski commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r405478653
 
 

 ##########
 File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/CheckpointBarrierUnaligner.java
 ##########
 @@ -0,0 +1,242 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.streaming.runtime.io;
+
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.runtime.checkpoint.channel.ChannelStateWriter;
+import org.apache.flink.runtime.checkpoint.channel.InputChannelInfo;
+import org.apache.flink.runtime.io.network.api.CancelCheckpointMarker;
+import org.apache.flink.runtime.io.network.api.CheckpointBarrier;
+import org.apache.flink.runtime.io.network.buffer.Buffer;
+import org.apache.flink.runtime.jobgraph.tasks.AbstractInvokable;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import javax.annotation.Nullable;
+
+import java.util.Arrays;
+import java.util.concurrent.CompletableFuture;
+
+import static org.apache.flink.util.Preconditions.checkNotNull;
+
+/**
+ * {@link CheckpointBarrierUnaligner} is used for triggering checkpoint while reading the first barrier
+ * and keeping track of the number of received barriers and consumed barriers.
+ */
+@Internal
+public class CheckpointBarrierUnaligner extends CheckpointBarrierHandler {
+
+	private static final Logger LOG = LoggerFactory.getLogger(CheckpointBarrierUnaligner.class);
+
+	private final String taskName;
+
+	/**
+	 * Tag the state of which input channel has read the barrier. If one channel has read the barrier by task,
+	 * the respective in-flight input buffers should be empty when triggering unaligned checkpoint.
+	 */
+	private final boolean[] barrierConsumedChannels;
+
+	/**
+	 * Tag the state of which input channel has received the barrier. Until the barrier of a specific channel is
+	 * received, all new buffers need to be persisted after unaligned checkpointing has been started.
+	 */
+	private final boolean[] barrierReceivedChannels;
+
+	/**
+	 * Contains the offsets of the channel indices for each gate when flattening the channels of all gates.
+	 *
+	 * <p>For example, consider 3 gates with 4 channels, {@code gateChannelOffsets = [0, 4, 8]}.
+	 */
+	private final int[] gateChannelOffsets;
+
+	/**
+	 * The number of input channels which has read the barrier by task.
+	 */
+	private int numBarriersReceived;
+
+	/**
+	 * The checkpoint id to guarantee that we would trigger only one checkpoint when reading the same barrier from
+	 * different channels.
+	 */
+	private long currentCheckpointId = -1L;
+
+	private final ChannelStateWriter channelStateWriter;
+
+	private CompletableFuture<?> allBarriersReceivedFuture;
+
+	CheckpointBarrierUnaligner(
+			int[] numberOfInputChannelsPerGate,
+			ChannelStateWriter channelStateWriter,
+			String taskName,
+			@Nullable AbstractInvokable toNotifyOnCheckpoint) {
+		super(toNotifyOnCheckpoint);
+
+		this.taskName = taskName;
+		this.channelStateWriter = checkNotNull(channelStateWriter);
+
+		final int numGates = numberOfInputChannelsPerGate.length;
+
+		gateChannelOffsets = new int[numGates];
+		for (int index = 1; index < numGates; index++) {
+			gateChannelOffsets[index] = gateChannelOffsets[index - 1] + numberOfInputChannelsPerGate[index - 1];
+		}
+
+		final int totalNumChannels = gateChannelOffsets[numGates - 1] + numberOfInputChannelsPerGate[numGates - 1];
+		barrierConsumedChannels = new boolean[totalNumChannels];
+		Arrays.fill(barrierConsumedChannels, true);
+		barrierReceivedChannels = new boolean[totalNumChannels];
+		Arrays.fill(barrierReceivedChannels, true);
+	}
+
+	@Override
+	public void releaseBlocksAndResetBarriers() {
+	}
+
+	/**
+	 * For unaligned checkpoint, it never blocks processing from the task aspect.
+	 *
+	 * <p>For PoC, we do not consider the possibility that the unaligned checkpoint would
+	 * not perform due to the max configured unaligned checkpoint size.
+	 */
+	@Override
+	public boolean isBlocked(int channelIndex) {
+		return false;
+	}
+
+	/**
+	 * We still need to trigger checkpoint while reading the first barrier from one channel, because this might happen
+	 * earlier than the previous async trigger via mailbox by netty thread. And the {@link AbstractInvokable} has the
+	 * deduplication logic to guarantee trigger checkpoint only once finally.
+	 *
+	 * <p>Note this is also suitable for the trigger case of local input channel.
+	 */
+	@Override
+	public synchronized boolean processBarrier(
+			CheckpointBarrier receivedBarrier,
+			int channelIndex,
+			long bufferedBytes) {
+		long barrierId = receivedBarrier.getId();
+		if (checkNewCheckpoint(barrierId)) {
+			notifyCheckpointAsync(receivedBarrier, bufferedBytes, 0);
+		}
+		barrierConsumedChannels[channelIndex] = true;
+		return false;
+	}
+
+	@Override
+	public boolean processCancellationBarrier(CancelCheckpointMarker cancelBarrier) {
+		return false;
+	}
+
+	@Override
+	public boolean processEndOfPartition() {
+		return false;
+	}
+
+	@Override
+	public long getLatestCheckpointId() {
+		return currentCheckpointId;
+	}
+
+	@Override
+	public long getAlignmentDurationNanos() {
+		return 0;
+	}
+
+	@Override
+	public String toString() {
+		return String.format("%s: last checkpoint: %d", taskName, currentCheckpointId);
+	}
+
+	@Override
+	public void checkpointSizeLimitExceeded(long maxBufferedBytes) {
+	}
+
+	@Override
+	protected boolean isBarrierConsumed(long checkpointId, int channelIndex) {
+		if (checkpointId < currentCheckpointId) {
+			return true;
+		}
+		if (checkpointId > currentCheckpointId) {
+			return false;
+		}
+		return barrierConsumedChannels[channelIndex];
+	}
+
+	public CompletableFuture<?> getAllBarriersReceivedFuture(long checkpointId) {
 
 Review comment:
   👍 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] rkhachatryan commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r406418862
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
 ##########
 @@ -206,6 +214,23 @@ void retriggerSubpartitionRequest(int subpartitionIndex) throws IOException {
 		return Optional.of(new BufferAndAvailability(next, moreAvailable, getSenderBacklog()));
 	}
 
+	@Override
+	public List<Buffer> getInflightBuffers(long checkpointId) throws IOException {
+		synchronized (receivedBuffers) {
+			final List<Buffer> inflightBuffers = new ArrayList<>(receivedBuffers.size());
+			for (Buffer buffer : receivedBuffers) {
+				if (!buffer.isBuffer() && parseCheckpointBarrierOrNull(buffer) != null) {
+					break;
+				}
+				inflightBuffers.add(buffer.retainBuffer());
+			}
+
+			triggeredCheckpointId = checkpointId;
 
 Review comment:
   I think here it's impossible to get invalid `checkpointId` (less than triggered), but I'd add a check (`Precondition`).
   
   Also, naming is a bit confusing:
   1. `triggered` is ambiguous to me; `inProgressCheckpointId` ?
   1. `getInflightBuffers` suggests it doesn't modify anything;  `requestInflightBuffers`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r399291992
 
 

 ##########
 File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/StreamTaskNetworkInput.java
 ##########
 @@ -197,6 +205,29 @@ public int getInputIndex() {
 		return checkpointedInputGate.getAvailableFuture();
 	}
 
+	@Override
+	public CompletableFuture<?> prepareSnapshot(long checkpointId) throws IOException {
+		// Note that if considering recovery in future, we should guarantee that the spilled buffers in one channel
+		// should be close together because one record might span multiple buffers.
+		for (int channelIndex = 0; channelIndex < recordDeserializers.length; channelIndex++) {
+			final InputChannel channel = checkpointedInputGate.getChannel(channelIndex);
+
+			recordDeserializers[channelIndex].getUnconsumedBuffer().ifPresent(buffer ->
+				channelStateWriter.addInputData(
+					checkpointId,
+					channel.getChannelInfo(),
+					ChannelStateWriter.SEQUENCE_NUMBER_UNKNOWN,
+					buffer));
+
+			channelStateWriter.addInputData(
+				checkpointId,
+				channel.getChannelInfo(),
+				ChannelStateWriter.SEQUENCE_NUMBER_UNKNOWN,
+				checkpointedInputGate.getInflightBuffers(checkpointId, channelIndex).toArray(new Buffer[0]));
+		}
+		return checkpointedInputGate.getAllBarriersReceivedFuture(checkpointId);
+	}
+
 	@Override
 	public void close() throws IOException {
 
 Review comment:
   Interesting idea. However, would trigger `complete` not more harm than it would solve? When we trigger `complete`, it might create an incomplete checkpoint...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r402576918
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/writer/ResultPartitionWriter.java
 ##########
 @@ -67,6 +68,13 @@
 	 */
 	boolean addBufferConsumer(BufferConsumer bufferConsumer, int subpartitionIndex) throws IOException;
 
+	default void addPriorityEvent(
+			AbstractEvent event,
+			int subpartitionIndex,
+			BufferConsumer eventBufferConsumer) throws IOException {
+		getSubpartition(subpartitionIndex).priorityEvent(event, eventBufferConsumer);
 
 Review comment:
   The previous way did not work with `LocalInputChannel`, where I added `PriorityEventListener`. I figured it could be used everywhere. If you have concerns about the current way, I can of course revert to POC code.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#issuecomment-603776093
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6621",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155064201",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155877268",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6755",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6839",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156597180",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6846",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "FAILURE",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156864478",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9a496a27a92e242519764b935012e44adade76a1 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/156864478) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6846) 
   * dee2b337e5e72d8f7b1f5098b74f2958d000fb3c UNKNOWN
   * 80b7f76f24b5fb6704a4b2292543f8764ec19053 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#issuecomment-603776093
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6621",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155064201",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155877268",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6755",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6839",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156597180",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6846",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156864478",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6873",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156994047",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157330632",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6900",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157451694",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6916",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157494634",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6933",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * dee2b337e5e72d8f7b1f5098b74f2958d000fb3c UNKNOWN
   * 80b7f76f24b5fb6704a4b2292543f8764ec19053 UNKNOWN
   * 734812c326634e1fd0da63465dcfbffa53cff792 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/157494634) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6933) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#issuecomment-603776093
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6621",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155064201",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155877268",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6755",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6839",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156597180",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6846",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156864478",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6873",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156994047",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157330632",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6900",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157451694",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6916",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157494634",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6933",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157589655",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6944",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6991",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157754467",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158102285",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7007",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7023",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158153241",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158188400",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7040",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7048",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158276096",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158831429",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7117",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7121",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158855200",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159112519",
       "triggerID" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7172",
       "triggerID" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159143719",
       "triggerID" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7175",
       "triggerID" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "triggerType" : "PUSH"
     }, {
       "hash" : "35ec088ef24e841beae78c33488975d2d8d0a40d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "35ec088ef24e841beae78c33488975d2d8d0a40d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7194",
       "triggerID" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159244661",
       "triggerID" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "triggerType" : "PUSH"
     }, {
       "hash" : "334458afaa98b601eec12c490e71caa8274be055",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "334458afaa98b601eec12c490e71caa8274be055",
       "triggerType" : "PUSH"
     }, {
       "hash" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7212",
       "triggerID" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "triggerType" : "PUSH"
     }, {
       "hash" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159269141",
       "triggerID" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7226",
       "triggerID" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159307415",
       "triggerID" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7297",
       "triggerID" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159652918",
       "triggerID" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "559816dcea4999dd46b09ee1091ddc0e1a5a7a54",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "559816dcea4999dd46b09ee1091ddc0e1a5a7a54",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6cd76afe4990f56a5166e1592374aa8f86fe883f",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "6cd76afe4990f56a5166e1592374aa8f86fe883f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7302",
       "triggerID" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159678447",
       "triggerID" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159695914",
       "triggerID" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7305",
       "triggerID" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ac996f5c703560ecbe6cad7394cc8ad54d6f0029",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "ac996f5c703560ecbe6cad7394cc8ad54d6f0029",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7347",
       "triggerID" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159875195",
       "triggerID" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "75c8130873e9b91e21e1e833d3d05f1ad9b5d2b8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7354",
       "triggerID" : "75c8130873e9b91e21e1e833d3d05f1ad9b5d2b8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7369",
       "triggerID" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "triggerType" : "PUSH"
     }, {
       "hash" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159960514",
       "triggerID" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7373",
       "triggerID" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159990549",
       "triggerID" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "triggerType" : "PUSH"
     }, {
       "hash" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7443",
       "triggerID" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160172375",
       "triggerID" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "536d9fb04a7a8142c04c94344dd0b3c0f2c10999",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160215439",
       "triggerID" : "536d9fb04a7a8142c04c94344dd0b3c0f2c10999",
       "triggerType" : "PUSH"
     }, {
       "hash" : "536d9fb04a7a8142c04c94344dd0b3c0f2c10999",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7469",
       "triggerID" : "536d9fb04a7a8142c04c94344dd0b3c0f2c10999",
       "triggerType" : "PUSH"
     }, {
       "hash" : "67018bacf5bc2daa8a03a1aafa880efc1db86808",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7500",
       "triggerID" : "67018bacf5bc2daa8a03a1aafa880efc1db86808",
       "triggerType" : "PUSH"
     }, {
       "hash" : "67018bacf5bc2daa8a03a1aafa880efc1db86808",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160347006",
       "triggerID" : "67018bacf5bc2daa8a03a1aafa880efc1db86808",
       "triggerType" : "PUSH"
     }, {
       "hash" : "79c116a6a1f5fe314f801e81f0265dea8b9ac1a7",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "79c116a6a1f5fe314f801e81f0265dea8b9ac1a7",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * dee2b337e5e72d8f7b1f5098b74f2958d000fb3c UNKNOWN
   * 80b7f76f24b5fb6704a4b2292543f8764ec19053 UNKNOWN
   * 35ec088ef24e841beae78c33488975d2d8d0a40d UNKNOWN
   * 334458afaa98b601eec12c490e71caa8274be055 UNKNOWN
   * 559816dcea4999dd46b09ee1091ddc0e1a5a7a54 UNKNOWN
   * 6cd76afe4990f56a5166e1592374aa8f86fe883f UNKNOWN
   * ac996f5c703560ecbe6cad7394cc8ad54d6f0029 UNKNOWN
   * 67018bacf5bc2daa8a03a1aafa880efc1db86808 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/160347006) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7500) 
   * 79c116a6a1f5fe314f801e81f0265dea8b9ac1a7 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#issuecomment-603776093
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6621",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155064201",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155877268",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6755",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6839",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156597180",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6846",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156864478",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6873",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156994047",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157330632",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6900",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "FAILURE",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157451694",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6916",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * dee2b337e5e72d8f7b1f5098b74f2958d000fb3c UNKNOWN
   * 80b7f76f24b5fb6704a4b2292543f8764ec19053 UNKNOWN
   * d5d714a4d954b82862972864805a151d04c3a513 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/157451694) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6916) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r408061523
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
 ##########
 @@ -206,6 +214,25 @@ void retriggerSubpartitionRequest(int subpartitionIndex) throws IOException {
 		return Optional.of(new BufferAndAvailability(next, moreAvailable, getSenderBacklog()));
 	}
 
+	@Override
+	public List<Buffer> requestInflightBuffers(long checkpointId) throws IOException {
+		synchronized (receivedBuffers) {
+			checkState(checkpointId > lastRequestedCheckpointId, "Need to request the next checkpointId");
+
+			final List<Buffer> inflightBuffers = new ArrayList<>(receivedBuffers.size());
+			for (Buffer buffer : receivedBuffers) {
+				if (!buffer.isBuffer() && parseCheckpointBarrierOrNull(buffer) != null) {
 
 Review comment:
   👍 for 1.
   For 2., this is done implicitly (I know not ideal), through `CheckpointedInputGate#requestInflightBuffers`, which will only delegate to this method if it indeed has some data.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r402588442
 
 

 ##########
 File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
 ##########
 @@ -845,21 +845,19 @@ public ExecutorService getAsyncOperationsThreadPool() {
 
 	private void notifyCheckpointComplete(long checkpointId) {
 		try {
-			boolean success = actionExecutor.call(() -> {
 
 Review comment:
   `actionExecutor` is only meaningful for legacy sources and acquires checkpoint lock. We cannot remove it for `performCheckpoint` as it could be called from barrier handler via `triggerCheckpointOnBarrier`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#issuecomment-603776093
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6621",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155064201",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155877268",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6755",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6839",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156597180",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6846",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156864478",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6873",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156994047",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157330632",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6900",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157451694",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6916",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157494634",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6933",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157589655",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6944",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6991",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157754467",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158102285",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7007",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7023",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158153241",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "FAILURE",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158188400",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7040",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * dee2b337e5e72d8f7b1f5098b74f2958d000fb3c UNKNOWN
   * 80b7f76f24b5fb6704a4b2292543f8764ec19053 UNKNOWN
   * 49d5d3e1e8e1bf962716241b79db1f2e28e506b4 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/158188400) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7040) 
   * a8335f0def293f04fd74bfc47c1b31fc98a46a23 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] rkhachatryan commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r398980439
 
 

 ##########
 File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/StreamTaskNetworkInput.java
 ##########
 @@ -197,6 +205,29 @@ public int getInputIndex() {
 		return checkpointedInputGate.getAvailableFuture();
 	}
 
+	@Override
+	public CompletableFuture<?> prepareSnapshot(long checkpointId) throws IOException {
+		// Note that if considering recovery in future, we should guarantee that the spilled buffers in one channel
+		// should be close together because one record might span multiple buffers.
+		for (int channelIndex = 0; channelIndex < recordDeserializers.length; channelIndex++) {
+			final InputChannel channel = checkpointedInputGate.getChannel(channelIndex);
+
+			recordDeserializers[channelIndex].getUnconsumedBuffer().ifPresent(buffer ->
+				channelStateWriter.addInputData(
+					checkpointId,
+					channel.getChannelInfo(),
+					ChannelStateWriter.SEQUENCE_NUMBER_UNKNOWN,
+					buffer));
+
+			channelStateWriter.addInputData(
+				checkpointId,
+				channel.getChannelInfo(),
+				ChannelStateWriter.SEQUENCE_NUMBER_UNKNOWN,
+				checkpointedInputGate.getInflightBuffers(checkpointId, channelIndex).toArray(new Buffer[0]));
+		}
+		return checkpointedInputGate.getAllBarriersReceivedFuture(checkpointId);
+	}
+
 	@Override
 	public void close() throws IOException {
 
 Review comment:
   Probably, we should add to `close` 
   `CheckpointedInputGate.close` -> `CheckpointBarrierHandler.close` -> `future.complete`
   (and similar places)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#issuecomment-603776093
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6621",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155064201",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155877268",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6755",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6839",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156597180",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6846",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156864478",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6873",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156994047",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157330632",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6900",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157451694",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6916",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157494634",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6933",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157589655",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6944",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6991",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157754467",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158102285",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7007",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7023",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158153241",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158188400",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7040",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7048",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158276096",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158831429",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7117",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7121",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158855200",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159112519",
       "triggerID" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7172",
       "triggerID" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159143719",
       "triggerID" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7175",
       "triggerID" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "triggerType" : "PUSH"
     }, {
       "hash" : "35ec088ef24e841beae78c33488975d2d8d0a40d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "35ec088ef24e841beae78c33488975d2d8d0a40d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7194",
       "triggerID" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159244661",
       "triggerID" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "triggerType" : "PUSH"
     }, {
       "hash" : "334458afaa98b601eec12c490e71caa8274be055",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "334458afaa98b601eec12c490e71caa8274be055",
       "triggerType" : "PUSH"
     }, {
       "hash" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7212",
       "triggerID" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "triggerType" : "PUSH"
     }, {
       "hash" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159269141",
       "triggerID" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7226",
       "triggerID" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159307415",
       "triggerID" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7297",
       "triggerID" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159652918",
       "triggerID" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "559816dcea4999dd46b09ee1091ddc0e1a5a7a54",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "559816dcea4999dd46b09ee1091ddc0e1a5a7a54",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6cd76afe4990f56a5166e1592374aa8f86fe883f",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "6cd76afe4990f56a5166e1592374aa8f86fe883f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7302",
       "triggerID" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159678447",
       "triggerID" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159695914",
       "triggerID" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7305",
       "triggerID" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ac996f5c703560ecbe6cad7394cc8ad54d6f0029",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "ac996f5c703560ecbe6cad7394cc8ad54d6f0029",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7347",
       "triggerID" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159875195",
       "triggerID" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "75c8130873e9b91e21e1e833d3d05f1ad9b5d2b8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7354",
       "triggerID" : "75c8130873e9b91e21e1e833d3d05f1ad9b5d2b8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7369",
       "triggerID" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "triggerType" : "PUSH"
     }, {
       "hash" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159960514",
       "triggerID" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7373",
       "triggerID" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159990549",
       "triggerID" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "triggerType" : "PUSH"
     }, {
       "hash" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7443",
       "triggerID" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160172375",
       "triggerID" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "536d9fb04a7a8142c04c94344dd0b3c0f2c10999",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160215439",
       "triggerID" : "536d9fb04a7a8142c04c94344dd0b3c0f2c10999",
       "triggerType" : "PUSH"
     }, {
       "hash" : "536d9fb04a7a8142c04c94344dd0b3c0f2c10999",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7469",
       "triggerID" : "536d9fb04a7a8142c04c94344dd0b3c0f2c10999",
       "triggerType" : "PUSH"
     }, {
       "hash" : "67018bacf5bc2daa8a03a1aafa880efc1db86808",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7500",
       "triggerID" : "67018bacf5bc2daa8a03a1aafa880efc1db86808",
       "triggerType" : "PUSH"
     }, {
       "hash" : "67018bacf5bc2daa8a03a1aafa880efc1db86808",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160347006",
       "triggerID" : "67018bacf5bc2daa8a03a1aafa880efc1db86808",
       "triggerType" : "PUSH"
     }, {
       "hash" : "79c116a6a1f5fe314f801e81f0265dea8b9ac1a7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7522",
       "triggerID" : "79c116a6a1f5fe314f801e81f0265dea8b9ac1a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "79c116a6a1f5fe314f801e81f0265dea8b9ac1a7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160377553",
       "triggerID" : "79c116a6a1f5fe314f801e81f0265dea8b9ac1a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "27ce4bfad8e99989dd64f8c636c934727da8a062",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "27ce4bfad8e99989dd64f8c636c934727da8a062",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ce0dfc7324679ebf2da84278eac8f5f59d748319",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7539",
       "triggerID" : "ce0dfc7324679ebf2da84278eac8f5f59d748319",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ce0dfc7324679ebf2da84278eac8f5f59d748319",
       "status" : "FAILURE",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160418181",
       "triggerID" : "ce0dfc7324679ebf2da84278eac8f5f59d748319",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * dee2b337e5e72d8f7b1f5098b74f2958d000fb3c UNKNOWN
   * 80b7f76f24b5fb6704a4b2292543f8764ec19053 UNKNOWN
   * 35ec088ef24e841beae78c33488975d2d8d0a40d UNKNOWN
   * 334458afaa98b601eec12c490e71caa8274be055 UNKNOWN
   * 559816dcea4999dd46b09ee1091ddc0e1a5a7a54 UNKNOWN
   * 6cd76afe4990f56a5166e1592374aa8f86fe883f UNKNOWN
   * ac996f5c703560ecbe6cad7394cc8ad54d6f0029 UNKNOWN
   * 27ce4bfad8e99989dd64f8c636c934727da8a062 UNKNOWN
   * ce0dfc7324679ebf2da84278eac8f5f59d748319 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/160418181) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7539) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] rkhachatryan commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r398943916
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
 ##########
 @@ -206,6 +210,20 @@ void retriggerSubpartitionRequest(int subpartitionIndex) throws IOException {
 		return Optional.of(new BufferAndAvailability(next, moreAvailable, getSenderBacklog()));
 	}
 
+	@Override
+	public List<Buffer> getInflightBuffers(long checkpointId) throws IOException {
+		final ArrayList<Buffer> inflightBuffers = new ArrayList<>(receivedBuffers.size());
 
 Review comment:
   Is it a race condition here?
   If `receivedBuffers` is currently updated by another thread (even in `synchronized`) we can read inconsistent state inside `size`, get it negative and exception in `ArrayList` constructor.
   I see think we could use `unsynchronizedGetNumberOfQueuedBuffers()`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] rkhachatryan commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r399515415
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/SingleInputGate.java
 ##########
 @@ -170,9 +173,14 @@
 
 	private final CompletableFuture<Void> closeFuture;
 
+	@Nullable
+	protected BufferReceivedListener bufferReceivedListener;
 
 Review comment:
   Regarding 
   > I'd refrain from using volatile on the hot path
   
   I share this concern but
   > we could cache volatile value if we guarantee that it's never changed once set
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zhijiangW commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
zhijiangW commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r400817529
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/UnionInputGate.java
 ##########
 @@ -77,37 +77,34 @@
 	 */
 	private final LinkedHashSet<InputGate> inputGatesWithData = new LinkedHashSet<>();
 
-	/** The total number of input channels across all unioned input gates. */
-	private final int totalNumberOfInputChannels;
+	/** Input channels across all unioned input gates. */
+	private final InputChannel[] inputChannels;
 
 	/**
 	 * A mapping from input gate to (logical) channel index offset. Valid channel indexes go from 0
 	 * (inclusive) to the total number of input channels (exclusive).
 	 */
-	private final Map<InputGate, Integer> inputGateToIndexOffsetMap;
+	private final int[] inputGateChannelIndexOffsets;
 
 	public UnionInputGate(InputGate... inputGates) {
 		this.inputGates = checkNotNull(inputGates);
 		checkArgument(inputGates.length > 1, "Union input gate should union at least two input gates.");
 
-		this.inputGateToIndexOffsetMap = Maps.newHashMapWithExpectedSize(inputGates.length);
 		this.inputGatesWithRemainingData = Sets.newHashSetWithExpectedSize(inputGates.length);
 
+		final int maxGateIndex = Arrays.stream(inputGates).mapToInt(InputGate::getGateIndex).max().orElse(0);
+		inputGateChannelIndexOffsets = new int[maxGateIndex + 1];
 		int currentNumberOfInputChannels = 0;
+		for (final InputGate inputGate : inputGates) {
+			currentNumberOfInputChannels += inputGate.getNumberOfInputChannels();
+			inputGateChannelIndexOffsets[inputGate.getGateIndex()] = currentNumberOfInputChannels;
+		}
+		inputChannels = Arrays.stream(inputGates)
+			.flatMap(gate -> IntStream.range(0, gate.getNumberOfInputChannels()).mapToObj(gate::getChannel))
+			.toArray(InputChannel[]::new);
 
 		synchronized (inputGatesWithData) {
 			for (InputGate inputGate : inputGates) {
-				if (inputGate instanceof UnionInputGate) {
 
 Review comment:
   It is better to retain this check to solve my above comments https://github.com/apache/flink/pull/11507/commits/63f5dcb77fce09d76e04f28fa50fc80d3ecfcc6d#r400814235. 
   
   Although it would still throw `UnsupportedOperationException` after `getGateIndex`, the root cause message should be `Cannot union a union of input gates`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zhijiangW commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
zhijiangW commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r400814235
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/UnionInputGate.java
 ##########
 @@ -77,37 +77,34 @@
 	 */
 	private final LinkedHashSet<InputGate> inputGatesWithData = new LinkedHashSet<>();
 
-	/** The total number of input channels across all unioned input gates. */
-	private final int totalNumberOfInputChannels;
+	/** Input channels across all unioned input gates. */
+	private final InputChannel[] inputChannels;
 
 	/**
 	 * A mapping from input gate to (logical) channel index offset. Valid channel indexes go from 0
 	 * (inclusive) to the total number of input channels (exclusive).
 	 */
-	private final Map<InputGate, Integer> inputGateToIndexOffsetMap;
+	private final int[] inputGateChannelIndexOffsets;
 
 	public UnionInputGate(InputGate... inputGates) {
 		this.inputGates = checkNotNull(inputGates);
 		checkArgument(inputGates.length > 1, "Union input gate should union at least two input gates.");
 
-		this.inputGateToIndexOffsetMap = Maps.newHashMapWithExpectedSize(inputGates.length);
 		this.inputGatesWithRemainingData = Sets.newHashSetWithExpectedSize(inputGates.length);
 
+		final int maxGateIndex = Arrays.stream(inputGates).mapToInt(InputGate::getGateIndex).max().orElse(0);
 
 Review comment:
   I am wondering whether the `inputGates` argument might refer to `UnionInputGate` in practice, otherwise it should be definitely defined `SingleInputGate`. For the case of union gate in arguments, `getGateIndex` would throw exception as implemented default in `InputGate`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#issuecomment-603776093
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6621",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155064201",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155877268",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6755",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6839",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156597180",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6846",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156864478",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6873",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156994047",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157330632",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6900",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157451694",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6916",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157494634",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6933",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157589655",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6944",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6991",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157754467",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158102285",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7007",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7023",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158153241",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158188400",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7040",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7048",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158276096",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158831429",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7117",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7121",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158855200",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159112519",
       "triggerID" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7172",
       "triggerID" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159143719",
       "triggerID" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7175",
       "triggerID" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "triggerType" : "PUSH"
     }, {
       "hash" : "35ec088ef24e841beae78c33488975d2d8d0a40d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "35ec088ef24e841beae78c33488975d2d8d0a40d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7194",
       "triggerID" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159244661",
       "triggerID" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "triggerType" : "PUSH"
     }, {
       "hash" : "334458afaa98b601eec12c490e71caa8274be055",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "334458afaa98b601eec12c490e71caa8274be055",
       "triggerType" : "PUSH"
     }, {
       "hash" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7212",
       "triggerID" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "triggerType" : "PUSH"
     }, {
       "hash" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159269141",
       "triggerID" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7226",
       "triggerID" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159307415",
       "triggerID" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7297",
       "triggerID" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159652918",
       "triggerID" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "559816dcea4999dd46b09ee1091ddc0e1a5a7a54",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "559816dcea4999dd46b09ee1091ddc0e1a5a7a54",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6cd76afe4990f56a5166e1592374aa8f86fe883f",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "6cd76afe4990f56a5166e1592374aa8f86fe883f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7302",
       "triggerID" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159678447",
       "triggerID" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159695914",
       "triggerID" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7305",
       "triggerID" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ac996f5c703560ecbe6cad7394cc8ad54d6f0029",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "ac996f5c703560ecbe6cad7394cc8ad54d6f0029",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7347",
       "triggerID" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "status" : "FAILURE",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159875195",
       "triggerID" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "75c8130873e9b91e21e1e833d3d05f1ad9b5d2b8",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7354",
       "triggerID" : "75c8130873e9b91e21e1e833d3d05f1ad9b5d2b8",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * dee2b337e5e72d8f7b1f5098b74f2958d000fb3c UNKNOWN
   * 80b7f76f24b5fb6704a4b2292543f8764ec19053 UNKNOWN
   * 35ec088ef24e841beae78c33488975d2d8d0a40d UNKNOWN
   * 334458afaa98b601eec12c490e71caa8274be055 UNKNOWN
   * 559816dcea4999dd46b09ee1091ddc0e1a5a7a54 UNKNOWN
   * 6cd76afe4990f56a5166e1592374aa8f86fe883f UNKNOWN
   * ac996f5c703560ecbe6cad7394cc8ad54d6f0029 UNKNOWN
   * 2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/159875195) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7347) 
   * 75c8130873e9b91e21e1e833d3d05f1ad9b5d2b8 Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7354) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r406472565
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
 ##########
 @@ -206,6 +214,23 @@ void retriggerSubpartitionRequest(int subpartitionIndex) throws IOException {
 		return Optional.of(new BufferAndAvailability(next, moreAvailable, getSenderBacklog()));
 	}
 
+	@Override
+	public List<Buffer> getInflightBuffers(long checkpointId) throws IOException {
+		synchronized (receivedBuffers) {
+			final List<Buffer> inflightBuffers = new ArrayList<>(receivedBuffers.size());
+			for (Buffer buffer : receivedBuffers) {
+				if (!buffer.isBuffer() && parseCheckpointBarrierOrNull(buffer) != null) {
+					break;
+				}
+				inflightBuffers.add(buffer.retainBuffer());
+			}
+
+			triggeredCheckpointId = checkpointId;
 
 Review comment:
   Added the `checkState` and I agree that the naming is not ideal.
   
   I renamed `getInflightBuffers` to `requestInflightBuffers` (as suggested), and used `lastRequestedCheckpointId` instead of `triggeredCheckpointId` to highlight its usage.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] rkhachatryan commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r398965050
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartition.java
 ##########
 @@ -83,24 +87,45 @@
 	/** The total number of bytes (both data and event buffers). */
 	private long totalNumberOfBytes;
 
+	/** The collection of buffers which are spanned over by checkpoint barrier and needs to be persisted for snapshot. */
+	private final List<Buffer> inflightBuffers = new ArrayList<>();
 
 Review comment:
   To me, this is more of a snapshot: we fill it **once** we receive a barrier and then we don't update it until the next barrier (even if we **do** receive buffers).
   This is in contrast to input side, were we actually collect data currently in-flight.
   So I'd name it `snapshot` or `buffersSnapshot`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r406327420
 
 

 ##########
 File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/CheckpointBarrierUnaligner.java
 ##########
 @@ -0,0 +1,427 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.streaming.runtime.io;
+
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.runtime.checkpoint.CheckpointException;
+import org.apache.flink.runtime.checkpoint.CheckpointFailureReason;
+import org.apache.flink.runtime.checkpoint.channel.ChannelStateWriter;
+import org.apache.flink.runtime.checkpoint.channel.InputChannelInfo;
+import org.apache.flink.runtime.concurrent.FutureUtils;
+import org.apache.flink.runtime.io.network.api.CancelCheckpointMarker;
+import org.apache.flink.runtime.io.network.api.CheckpointBarrier;
+import org.apache.flink.runtime.io.network.buffer.Buffer;
+import org.apache.flink.runtime.io.network.buffer.BufferReceivedListener;
+import org.apache.flink.runtime.jobgraph.tasks.AbstractInvokable;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import javax.annotation.concurrent.NotThreadSafe;
+import javax.annotation.concurrent.ThreadSafe;
+
+import java.io.Closeable;
+import java.io.IOException;
+import java.util.Arrays;
+import java.util.Optional;
+import java.util.concurrent.CompletableFuture;
+import java.util.function.Function;
+import java.util.stream.IntStream;
+
+import static org.apache.flink.util.Preconditions.checkNotNull;
+import static org.apache.flink.util.Preconditions.checkState;
+
+/**
+ * {@link CheckpointBarrierUnaligner} is used for triggering checkpoint while reading the first barrier
+ * and keeping track of the number of received barriers and consumed barriers.
+ */
+@Internal
+@NotThreadSafe
+public class CheckpointBarrierUnaligner extends CheckpointBarrierHandler {
+
+	private static final Logger LOG = LoggerFactory.getLogger(CheckpointBarrierUnaligner.class);
+
+	private final String taskName;
+
+	/**
+	 * Tag the state of which input channel has read the barrier. If one channel has read the barrier by task,
+	 * the respective in-flight input buffers should be empty when triggering unaligned checkpoint.
+	 */
+	private final boolean[] barrierConsumedChannels;
+
+	private int numBarrierConsumed;
+
+	/**
+	 * Contains the offsets of the channel indices for each gate when flattening the channels of all gates.
+	 *
+	 * <p>For example, consider 3 gates with 4 channels, {@code gateChannelOffsets = [0, 4, 8]}.
+	 */
+	private final int[] gateChannelOffsets;
+
+	private final InputChannelInfo[] channelInfos;
+
+	/**
+	 * The checkpoint id to guarantee that we would trigger only one checkpoint when reading the same barrier from
+	 * different channels.
+	 *
+	 * <p>Note: this checkpoint is valid in respect to <b>consumed</b> barriers in contrast to
+	 * {@link ThreadSafeUnaligner#currentReceivedCheckpointId}.
+	 */
+	private long currentConsumedCheckpointId = -1L;
+
+	/** Encapsulates state that is shared between netty threads and task thread. */
+	private final ThreadSafeUnaligner threadSafeUnaligner;
+
+	CheckpointBarrierUnaligner(
+			int[] numberOfInputChannelsPerGate,
+			ChannelStateWriter channelStateWriter,
+			String taskName,
+			AbstractInvokable toNotifyOnCheckpoint) {
+		super(toNotifyOnCheckpoint);
+
+		this.taskName = taskName;
+
+		final int numGates = numberOfInputChannelsPerGate.length;
+
+		gateChannelOffsets = new int[numGates];
+		for (int index = 1; index < numGates; index++) {
+			gateChannelOffsets[index] = gateChannelOffsets[index - 1] + numberOfInputChannelsPerGate[index - 1];
+		}
+
+		final int totalNumChannels = gateChannelOffsets[numGates - 1] + numberOfInputChannelsPerGate[numGates - 1];
+		barrierConsumedChannels = new boolean[totalNumChannels];
+		Arrays.fill(barrierConsumedChannels, true);
+
+		channelInfos = IntStream.range(0, numGates)
+			.mapToObj(gateIndex -> IntStream.range(0, numberOfInputChannelsPerGate[gateIndex])
+				.mapToObj(channelIndex -> new InputChannelInfo(gateIndex, channelIndex)))
+			.flatMap(Function.identity())
+			.toArray(InputChannelInfo[]::new);
+
+		threadSafeUnaligner = new ThreadSafeUnaligner(totalNumChannels,	checkNotNull(channelStateWriter), this);
+	}
+
+	@Override
+	public void releaseBlocksAndResetBarriers() {
+		// make sure no additional data is persisted
+		Arrays.fill(barrierConsumedChannels, true);
+		// the next barrier that comes must assume it is the first
+		numBarrierConsumed = 0;
+		threadSafeUnaligner.releaseReceivedBarriers();
+	}
+
+	/**
+	 * For unaligned checkpoint, it never blocks processing from the task aspect.
+	 *
+	 * <p>For PoC, we do not consider the possibility that the unaligned checkpoint would
+	 * not perform due to the max configured unaligned checkpoint size.
+	 */
+	@Override
+	public boolean isBlocked(int channelIndex) {
+		return false;
+	}
+
+	/**
+	 * We still need to trigger checkpoint while reading the first barrier from one channel, because this might happen
+	 * earlier than the previous async trigger via mailbox by netty thread. And the {@link AbstractInvokable} has the
+	 * deduplication logic to guarantee trigger checkpoint only once finally.
+	 *
+	 * <p>Note this is also suitable for the trigger case of local input channel.
+	 */
+	@Override
+	public boolean processBarrier(
+			CheckpointBarrier receivedBarrier,
+			int channelIndex,
+			long bufferedBytes) {
+		long barrierId = receivedBarrier.getId();
+		if (currentConsumedCheckpointId < barrierId) {
+			currentConsumedCheckpointId = barrierId;
+			numBarrierConsumed = 0;
+			Arrays.fill(barrierConsumedChannels, false);
+		}
+		if (currentConsumedCheckpointId == barrierId) {
+			barrierConsumedChannels[channelIndex] = true;
+			numBarrierConsumed++;
+		}
+		// processBarrier is called from task thread and can actually happen before notifyBarrierReceived on empty
+		// buffer queues
+		// to avoid replicating any logic, we simply call notifyBarrierReceived here as well
+		threadSafeUnaligner.notifyBarrierReceived(receivedBarrier, channelInfos[channelIndex]);
+		return false;
+	}
+
+	@Override
+	public boolean processCancellationBarrier(CancelCheckpointMarker cancelBarrier) throws Exception {
+		final long barrierId = cancelBarrier.getCheckpointId();
+
+		if (numBarrierConsumed > 0) {
+			// this is only true if some alignment is in progress and nothing was canceled
+
+			if (barrierId == currentConsumedCheckpointId) {
+				// cancel this alignment
+				if (LOG.isDebugEnabled()) {
+					LOG.debug("{}: Checkpoint {} canceled, aborting alignment.", taskName, barrierId);
+				}
+
+				releaseBlocksAndResetBarriers();
+				notifyAbortOnCancellationBarrier(barrierId);
+			}
+			else if (barrierId > currentConsumedCheckpointId) {
+				// we canceled the next which also cancels the current
+				LOG.warn("{}: Received cancellation barrier for checkpoint {} before completing current checkpoint {}. " +
+						"Skipping current checkpoint.",
+					taskName,
+					barrierId,
+					currentConsumedCheckpointId);
+
+				// this stops the current alignment
+				releaseBlocksAndResetBarriers();
 
 Review comment:
   I added the checkpoint id as a parameter to make sure they talk about the same thing.
   
   The current method name is `resetReceivedBarriers`. I think it's now quite precise but feel free to add if it's still confusing.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zhijiangW commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
zhijiangW commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r400276566
 
 

 ##########
 File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/CheckpointBarrierUnaligner.java
 ##########
 @@ -0,0 +1,338 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.streaming.runtime.io;
+
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.runtime.checkpoint.CheckpointException;
+import org.apache.flink.runtime.checkpoint.CheckpointFailureReason;
+import org.apache.flink.runtime.checkpoint.channel.ChannelStateWriter;
+import org.apache.flink.runtime.checkpoint.channel.InputChannelInfo;
+import org.apache.flink.runtime.io.network.api.CancelCheckpointMarker;
+import org.apache.flink.runtime.io.network.api.CheckpointBarrier;
+import org.apache.flink.runtime.io.network.buffer.Buffer;
+import org.apache.flink.runtime.jobgraph.tasks.AbstractInvokable;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.IOException;
+import java.util.Arrays;
+import java.util.concurrent.CompletableFuture;
+
+import static org.apache.flink.util.Preconditions.checkNotNull;
+
+/**
+ * {@link CheckpointBarrierUnaligner} is used for triggering checkpoint while reading the first barrier
+ * and keeping track of the number of received barriers and consumed barriers.
+ */
+@Internal
+public class CheckpointBarrierUnaligner extends CheckpointBarrierHandler {
+
+	private static final Logger LOG = LoggerFactory.getLogger(CheckpointBarrierUnaligner.class);
+	public static final CompletableFuture<Void> DONE = CompletableFuture.completedFuture(null);
+
+	private final String taskName;
+
+	/**
+	 * Tag the state of which input channel has read the barrier. If one channel has read the barrier by task,
+	 * the respective in-flight input buffers should be empty when triggering unaligned checkpoint.
+	 */
+	private final boolean[] barrierConsumedChannels;
+
+	/**
+	 * Tag the state of which input channel has received the barrier. Until the barrier of a specific channel is
+	 * received, all new buffers need to be persisted after unaligned checkpointing has been started.
+	 */
+	private final boolean[] barrierReceivedChannels;
+
+	/**
+	 * Contains the offsets of the channel indices for each gate when flattening the channels of all gates.
+	 *
+	 * <p>For example, consider 3 gates with 4 channels, {@code gateChannelOffsets = [0, 4, 8]}.
+	 */
+	private final int[] gateChannelOffsets;
+
+	/**
+	 * The number of input channels which has read the barrier by task.
+	 */
+	private int numBarriersReceived;
+
+	/**
+	 * The checkpoint id to guarantee that we would trigger only one checkpoint when reading the same barrier from
+	 * different channels.
+	 */
+	private long currentCheckpointId = -1L;
+
+	/** The number of opened channels. */
+	private int numOpenChannels;
+
+	/** A future indicating that all barriers of the a given checkpoint have been read. */
+	private CompletableFuture<Void> allBarriersReceivedFuture = DONE;
+
+	private final ChannelStateWriter channelStateWriter;
+
+	CheckpointBarrierUnaligner(
+			int[] numberOfInputChannelsPerGate,
+			ChannelStateWriter channelStateWriter,
+			String taskName,
+			AbstractInvokable toNotifyOnCheckpoint) {
+		super(toNotifyOnCheckpoint);
+
+		this.taskName = taskName;
+		this.channelStateWriter = checkNotNull(channelStateWriter);
+
+		final int numGates = numberOfInputChannelsPerGate.length;
+
+		gateChannelOffsets = new int[numGates];
+		for (int index = 1; index < numGates; index++) {
+			gateChannelOffsets[index] = gateChannelOffsets[index - 1] + numberOfInputChannelsPerGate[index - 1];
+		}
+
+		final int totalNumChannels = gateChannelOffsets[numGates - 1] + numberOfInputChannelsPerGate[numGates - 1];
+		barrierConsumedChannels = new boolean[totalNumChannels];
+		Arrays.fill(barrierConsumedChannels, true);
+		barrierReceivedChannels = new boolean[totalNumChannels];
+		Arrays.fill(barrierReceivedChannels, true);
+		numOpenChannels = totalNumChannels;
+	}
+
+	@Override
+	public void releaseBlocksAndResetBarriers() {
+		// make sure no additional data is persisted
+		Arrays.fill(barrierConsumedChannels, true);
+		Arrays.fill(barrierReceivedChannels, true);
+	}
+
+	/**
+	 * For unaligned checkpoint, it never blocks processing from the task aspect.
+	 *
+	 * <p>For PoC, we do not consider the possibility that the unaligned checkpoint would
+	 * not perform due to the max configured unaligned checkpoint size.
+	 */
+	@Override
+	public boolean isBlocked(int channelIndex) {
+		return false;
+	}
+
+	/**
+	 * We still need to trigger checkpoint while reading the first barrier from one channel, because this might happen
+	 * earlier than the previous async trigger via mailbox by netty thread. And the {@link AbstractInvokable} has the
+	 * deduplication logic to guarantee trigger checkpoint only once finally.
+	 *
+	 * <p>Note this is also suitable for the trigger case of local input channel.
+	 */
+	@Override
+	public boolean processBarrier(
+			CheckpointBarrier receivedBarrier,
+			int channelIndex,
+			long bufferedBytes) throws Exception {
+		long barrierId = receivedBarrier.getId();
+		if (currentCheckpointId < barrierId) {
+			handleNewCheckpoint(barrierId);
+			notifyCheckpointAsync(receivedBarrier, bufferedBytes, 0);
+		}
+		barrierConsumedChannels[channelIndex] = true;
 
 Review comment:
   This should be done before `notifyCheckpointAsync`, because during performing checkpoint, it would access this state while get in-flight buffers for respective channel.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#issuecomment-603776093
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6621",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155064201",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155877268",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6755",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6839",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156597180",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6846",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156864478",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6873",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156994047",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157330632",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6900",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157451694",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6916",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157494634",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6933",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157589655",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6944",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6991",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157754467",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158102285",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7007",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7023",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158153241",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158188400",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7040",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7048",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158276096",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158831429",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7117",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7121",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158855200",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159112519",
       "triggerID" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7172",
       "triggerID" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159143719",
       "triggerID" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7175",
       "triggerID" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "triggerType" : "PUSH"
     }, {
       "hash" : "35ec088ef24e841beae78c33488975d2d8d0a40d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "35ec088ef24e841beae78c33488975d2d8d0a40d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7194",
       "triggerID" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159244661",
       "triggerID" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "triggerType" : "PUSH"
     }, {
       "hash" : "334458afaa98b601eec12c490e71caa8274be055",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "334458afaa98b601eec12c490e71caa8274be055",
       "triggerType" : "PUSH"
     }, {
       "hash" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7212",
       "triggerID" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "triggerType" : "PUSH"
     }, {
       "hash" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159269141",
       "triggerID" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7226",
       "triggerID" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159307415",
       "triggerID" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7297",
       "triggerID" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159652918",
       "triggerID" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "559816dcea4999dd46b09ee1091ddc0e1a5a7a54",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "559816dcea4999dd46b09ee1091ddc0e1a5a7a54",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6cd76afe4990f56a5166e1592374aa8f86fe883f",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "6cd76afe4990f56a5166e1592374aa8f86fe883f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7302",
       "triggerID" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159678447",
       "triggerID" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159695914",
       "triggerID" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7305",
       "triggerID" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ac996f5c703560ecbe6cad7394cc8ad54d6f0029",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "ac996f5c703560ecbe6cad7394cc8ad54d6f0029",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7347",
       "triggerID" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159875195",
       "triggerID" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "75c8130873e9b91e21e1e833d3d05f1ad9b5d2b8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7354",
       "triggerID" : "75c8130873e9b91e21e1e833d3d05f1ad9b5d2b8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7369",
       "triggerID" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "triggerType" : "PUSH"
     }, {
       "hash" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159960514",
       "triggerID" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7373",
       "triggerID" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159990549",
       "triggerID" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "triggerType" : "PUSH"
     }, {
       "hash" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7443",
       "triggerID" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160172375",
       "triggerID" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "536d9fb04a7a8142c04c94344dd0b3c0f2c10999",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160215439",
       "triggerID" : "536d9fb04a7a8142c04c94344dd0b3c0f2c10999",
       "triggerType" : "PUSH"
     }, {
       "hash" : "536d9fb04a7a8142c04c94344dd0b3c0f2c10999",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7469",
       "triggerID" : "536d9fb04a7a8142c04c94344dd0b3c0f2c10999",
       "triggerType" : "PUSH"
     }, {
       "hash" : "67018bacf5bc2daa8a03a1aafa880efc1db86808",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7500",
       "triggerID" : "67018bacf5bc2daa8a03a1aafa880efc1db86808",
       "triggerType" : "PUSH"
     }, {
       "hash" : "67018bacf5bc2daa8a03a1aafa880efc1db86808",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160347006",
       "triggerID" : "67018bacf5bc2daa8a03a1aafa880efc1db86808",
       "triggerType" : "PUSH"
     }, {
       "hash" : "79c116a6a1f5fe314f801e81f0265dea8b9ac1a7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7522",
       "triggerID" : "79c116a6a1f5fe314f801e81f0265dea8b9ac1a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "79c116a6a1f5fe314f801e81f0265dea8b9ac1a7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160377553",
       "triggerID" : "79c116a6a1f5fe314f801e81f0265dea8b9ac1a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "27ce4bfad8e99989dd64f8c636c934727da8a062",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "27ce4bfad8e99989dd64f8c636c934727da8a062",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ce0dfc7324679ebf2da84278eac8f5f59d748319",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7539",
       "triggerID" : "ce0dfc7324679ebf2da84278eac8f5f59d748319",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ce0dfc7324679ebf2da84278eac8f5f59d748319",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160418181",
       "triggerID" : "ce0dfc7324679ebf2da84278eac8f5f59d748319",
       "triggerType" : "PUSH"
     }, {
       "hash" : "05c934bf483d4fb673496783ef8ff85b40b86708",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "05c934bf483d4fb673496783ef8ff85b40b86708",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4bbe67a13a75f4491898fbb1cd2315237dbca30e",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160443829",
       "triggerID" : "4bbe67a13a75f4491898fbb1cd2315237dbca30e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4bbe67a13a75f4491898fbb1cd2315237dbca30e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7543",
       "triggerID" : "4bbe67a13a75f4491898fbb1cd2315237dbca30e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "cb5258f13c64ed033db7b8476122721ac418d798",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160496434",
       "triggerID" : "cb5258f13c64ed033db7b8476122721ac418d798",
       "triggerType" : "PUSH"
     }, {
       "hash" : "cb5258f13c64ed033db7b8476122721ac418d798",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7560",
       "triggerID" : "cb5258f13c64ed033db7b8476122721ac418d798",
       "triggerType" : "PUSH"
     }, {
       "hash" : "fdc673b8583650ce40a6f13b8a44d9773e14c370",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7597",
       "triggerID" : "fdc673b8583650ce40a6f13b8a44d9773e14c370",
       "triggerType" : "PUSH"
     }, {
       "hash" : "fdc673b8583650ce40a6f13b8a44d9773e14c370",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160543449",
       "triggerID" : "fdc673b8583650ce40a6f13b8a44d9773e14c370",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1123cc69ed817c9935bae5ffbba5e48f5bbe0f25",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7611",
       "triggerID" : "1123cc69ed817c9935bae5ffbba5e48f5bbe0f25",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1123cc69ed817c9935bae5ffbba5e48f5bbe0f25",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160619473",
       "triggerID" : "1123cc69ed817c9935bae5ffbba5e48f5bbe0f25",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * dee2b337e5e72d8f7b1f5098b74f2958d000fb3c UNKNOWN
   * 80b7f76f24b5fb6704a4b2292543f8764ec19053 UNKNOWN
   * 35ec088ef24e841beae78c33488975d2d8d0a40d UNKNOWN
   * 334458afaa98b601eec12c490e71caa8274be055 UNKNOWN
   * 559816dcea4999dd46b09ee1091ddc0e1a5a7a54 UNKNOWN
   * 6cd76afe4990f56a5166e1592374aa8f86fe883f UNKNOWN
   * ac996f5c703560ecbe6cad7394cc8ad54d6f0029 UNKNOWN
   * 27ce4bfad8e99989dd64f8c636c934727da8a062 UNKNOWN
   * 05c934bf483d4fb673496783ef8ff85b40b86708 UNKNOWN
   * 1123cc69ed817c9935bae5ffbba5e48f5bbe0f25 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/160619473) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7611) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zhijiangW commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
zhijiangW commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r400304625
 
 

 ##########
 File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
 ##########
 @@ -1144,6 +1186,9 @@ public void run() {
 
 				checkpointMetrics.setAsyncDurationMillis(asyncDurationMillis);
 
+				bufferPersistingFuture.get();
+
+				LOG.debug("{}: Finished checkpoint {}.", owner.getName(), checkpointMetaData.getCheckpointId());
 
 Review comment:
   I guess this log is not necessary. Otherwise the whole log stacks would be following:
   
   `Finished synchronous checkpoints.......`
   `Finished checkpoint......`
   `finished synchronous part of checkpoint.....`
   
   It might confuse users.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zhijiangW commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
zhijiangW commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r400637920
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PriorityEventListener.java
 ##########
 @@ -0,0 +1,54 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.io.network.partition;
+
+import org.apache.flink.runtime.event.AbstractEvent;
+import org.apache.flink.runtime.io.network.buffer.BufferConsumer;
+
+import java.io.IOException;
+
+/**
+ * Listens to priority events (e.g., checkpoint barriers) of subpartitions. The listener can completely process the
+ * event without the buffer queue or let the subpartition enqueue the event in the front or back of the buffer queue.
+ */
+public interface PriorityEventListener {
+	/**
+	 * Allows the listener to react to a priority event independent of the outgoing buffer queue.
+	 *
+	 * @return the action to be performed by the caller.
+	 */
+	EnqueueAction priorityEvent(AbstractEvent event, BufferConsumer eventBufferConsumer) throws IOException;
 
 Review comment:
   I guess this return value actually not be used in practice now. Do we need to introduce it?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] rkhachatryan commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r407996739
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
 ##########
 @@ -523,15 +557,18 @@ public void onBuffer(Buffer buffer, int sequenceNumber, int backlog) throws IOEx
 					return;
 				}
 
-				if (expectedSequenceNumber != sequenceNumber) {
 
 Review comment:
   Why was this `if` moved outside of the `synchronized`?
   Also, increment of `expectedSequenceNumber` below outside of the `synchronized` looks suspicious. But this is an old change.
   Am I missing something?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r406324281
 
 

 ##########
 File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/CheckpointBarrierUnaligner.java
 ##########
 @@ -0,0 +1,420 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.streaming.runtime.io;
+
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.runtime.checkpoint.CheckpointException;
+import org.apache.flink.runtime.checkpoint.CheckpointFailureReason;
+import org.apache.flink.runtime.checkpoint.channel.ChannelStateWriter;
+import org.apache.flink.runtime.checkpoint.channel.InputChannelInfo;
+import org.apache.flink.runtime.concurrent.FutureUtils;
+import org.apache.flink.runtime.io.network.api.CancelCheckpointMarker;
+import org.apache.flink.runtime.io.network.api.CheckpointBarrier;
+import org.apache.flink.runtime.io.network.buffer.Buffer;
+import org.apache.flink.runtime.io.network.buffer.BufferReceivedListener;
+import org.apache.flink.runtime.jobgraph.tasks.AbstractInvokable;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.Closeable;
+import java.io.IOException;
+import java.util.Arrays;
+import java.util.Optional;
+import java.util.concurrent.CompletableFuture;
+import java.util.function.Function;
+import java.util.stream.IntStream;
+
+import static org.apache.flink.util.Preconditions.checkNotNull;
+
+/**
+ * {@link CheckpointBarrierUnaligner} is used for triggering checkpoint while reading the first barrier
+ * and keeping track of the number of received barriers and consumed barriers.
+ */
+@Internal
+public class CheckpointBarrierUnaligner extends CheckpointBarrierHandler {
+
+	private static final Logger LOG = LoggerFactory.getLogger(CheckpointBarrierUnaligner.class);
+
+	private final String taskName;
+
+	/**
+	 * Tag the state of which input channel has read the barrier. If one channel has read the barrier by task,
+	 * the respective in-flight input buffers should be empty when triggering unaligned checkpoint.
+	 */
+	private final boolean[] barrierConsumedChannels;
+
+	private int numBarrierConsumed;
+
+	/**
+	 * Contains the offsets of the channel indices for each gate when flattening the channels of all gates.
+	 *
+	 * <p>For example, consider 3 gates with 4 channels, {@code gateChannelOffsets = [0, 4, 8]}.
+	 */
+	private final int[] gateChannelOffsets;
+
+	private final InputChannelInfo[] channelInfos;
+
+	/**
+	 * The checkpoint id to guarantee that we would trigger only one checkpoint when reading the same barrier from
+	 * different channels.
+	 *
+	 * <p>Note: this checkpoint is valid in respect to <b>consumed</b> barriers in contrast to
+	 * {@link ThreadSafeUnaligner#currentCheckpointId}.
+	 */
+	private long currentCheckpointId = -1L;
+
+	/** Encapsulates state that is shared between netty threads and task thread. */
+	private final ThreadSafeUnaligner threadSafeUnaligner;
+
+	CheckpointBarrierUnaligner(
+			int[] numberOfInputChannelsPerGate,
+			ChannelStateWriter channelStateWriter,
+			String taskName,
+			AbstractInvokable toNotifyOnCheckpoint) {
+		super(toNotifyOnCheckpoint);
+
+		this.taskName = taskName;
+
+		final int numGates = numberOfInputChannelsPerGate.length;
+
+		gateChannelOffsets = new int[numGates];
+		for (int index = 1; index < numGates; index++) {
+			gateChannelOffsets[index] = gateChannelOffsets[index - 1] + numberOfInputChannelsPerGate[index - 1];
+		}
+
+		final int totalNumChannels = gateChannelOffsets[numGates - 1] + numberOfInputChannelsPerGate[numGates - 1];
+		barrierConsumedChannels = new boolean[totalNumChannels];
+		Arrays.fill(barrierConsumedChannels, true);
+
+		channelInfos = IntStream.range(0, numGates)
+			.mapToObj(gateIndex -> IntStream.range(0, numberOfInputChannelsPerGate[gateIndex])
+				.mapToObj(channelIndex -> new InputChannelInfo(gateIndex, channelIndex)))
+			.flatMap(Function.identity())
+			.toArray(InputChannelInfo[]::new);
+
+		threadSafeUnaligner = new ThreadSafeUnaligner(totalNumChannels,	checkNotNull(channelStateWriter), this);
+	}
+
+	@Override
+	public void releaseBlocksAndResetBarriers() {
+		// make sure no additional data is persisted
+		Arrays.fill(barrierConsumedChannels, true);
+		// the next barrier that comes must assume it is the first
+		numBarrierConsumed = 0;
+		threadSafeUnaligner.releaseBlocksAndResetBarriers();
+	}
+
+	/**
+	 * For unaligned checkpoint, it never blocks processing from the task aspect.
+	 *
+	 * <p>For PoC, we do not consider the possibility that the unaligned checkpoint would
+	 * not perform due to the max configured unaligned checkpoint size.
+	 */
+	@Override
+	public boolean isBlocked(int channelIndex) {
+		return false;
+	}
+
+	/**
+	 * We still need to trigger checkpoint while reading the first barrier from one channel, because this might happen
+	 * earlier than the previous async trigger via mailbox by netty thread. And the {@link AbstractInvokable} has the
+	 * deduplication logic to guarantee trigger checkpoint only once finally.
+	 *
+	 * <p>Note this is also suitable for the trigger case of local input channel.
+	 */
+	@Override
+	public boolean processBarrier(
+			CheckpointBarrier receivedBarrier,
+			int channelIndex,
+			long bufferedBytes) throws IOException {
+		long barrierId = receivedBarrier.getId();
+		if (currentCheckpointId < barrierId) {
+			currentCheckpointId = barrierId;
+			numBarrierConsumed = 0;
+			Arrays.fill(barrierConsumedChannels, false);
+		}
+		if (currentCheckpointId == barrierId) {
+			barrierConsumedChannels[channelIndex] = true;
+			numBarrierConsumed++;
+		}
+		// processBarrier is called from task thread and can actually happen before notifyBarrierReceived on empty
+		// buffer queues
+		// to avoid replicating any logic, we simply call notifyBarrierReceived here as well
+		threadSafeUnaligner.notifyBarrierReceived(receivedBarrier, channelInfos[channelIndex]);
+		return false;
+	}
+
+	@Override
+	public boolean processCancellationBarrier(CancelCheckpointMarker cancelBarrier) throws Exception {
+		final long barrierId = cancelBarrier.getCheckpointId();
+
+		if (numBarrierConsumed > 0) {
+			// this is only true if some alignment is in progress and nothing was canceled
+
+			if (barrierId == currentCheckpointId) {
+				// cancel this alignment
+				if (LOG.isDebugEnabled()) {
+					LOG.debug("{}: Checkpoint {} canceled, aborting alignment.", taskName, barrierId);
+				}
+
+				releaseBlocksAndResetBarriers();
+				notifyAbortOnCancellationBarrier(barrierId);
+			}
+			else if (barrierId > currentCheckpointId) {
+				// we canceled the next which also cancels the current
+				LOG.warn("{}: Received cancellation barrier for checkpoint {} before completing current checkpoint {}. " +
+						"Skipping current checkpoint.",
+					taskName,
+					barrierId,
+					currentCheckpointId);
+
+				// this stops the current alignment
+				releaseBlocksAndResetBarriers();
+
+				// the next checkpoint starts as canceled
+				currentCheckpointId = barrierId;
+				threadSafeUnaligner.setCurrentCheckpointId(currentCheckpointId);
+				notifyAbortOnCancellationBarrier(barrierId);
+			}
+
+			// else: ignore trailing (cancellation) barrier from an earlier checkpoint (obsolete now)
+
+		}
+		else if (barrierId > currentCheckpointId) {
+			// first barrier of a new checkpoint is directly a cancellation
+
+			// by setting the currentCheckpointId to this checkpoint while keeping the numBarriers
+			// at zero means that no checkpoint barrier can start a new alignment
+			currentCheckpointId = barrierId;
+			threadSafeUnaligner.setCurrentCheckpointId(currentCheckpointId);
+
+			if (LOG.isDebugEnabled()) {
+				LOG.debug("{}: Checkpoint {} canceled, skipping alignment.", taskName, barrierId);
+			}
+
+			notifyAbortOnCancellationBarrier(barrierId);
+		}
+
+		// else: trailing barrier from either
+		//   - a previous (subsumed) checkpoint
+		//   - the current checkpoint if it was already canceled
+		return false;
+	}
+
+	@Override
+	public boolean processEndOfPartition() throws Exception {
+		threadSafeUnaligner.processEndOfPartition();
+
+		if (numBarrierConsumed > 0) {
+			// let the task know we skip a checkpoint
+			notifyAbort(
+				currentCheckpointId,
+				new CheckpointException(CheckpointFailureReason.CHECKPOINT_DECLINED_INPUT_END_OF_STREAM));
+			// no chance to complete this checkpoint
+			releaseBlocksAndResetBarriers();
+			return true;
+		}
+		return false;
+	}
+
+	@Override
+	public long getLatestCheckpointId() {
+		return currentCheckpointId;
+	}
+
+	@Override
+	public long getAlignmentDurationNanos() {
+		return 0;
+	}
+
+	@Override
+	public String toString() {
+		return String.format("%s: last checkpoint: %d", taskName, currentCheckpointId);
+	}
+
+	@Override
+	public void checkpointSizeLimitExceeded(long maxBufferedBytes) {
+	}
+
+	@Override
+	public void close() throws IOException {
+		super.close();
+		threadSafeUnaligner.close();
+	}
+
+	@Override
+	protected boolean isBarrierConsumed(long checkpointId, int channelIndex) {
+		if (checkpointId < currentCheckpointId) {
+			return true;
+		}
+		if (checkpointId > currentCheckpointId) {
+			return false;
+		}
+		return barrierConsumedChannels[channelIndex];
+	}
+
+	public CompletableFuture<Void> getAllBarriersReceivedFuture(long checkpointId) {
+		return threadSafeUnaligner.getAllBarriersReceivedFuture(checkpointId);
+	}
+
+	@Override
+	public Optional<BufferReceivedListener> getBufferReceivedListener() {
+		return Optional.of(threadSafeUnaligner);
+	}
+
+	private int getFlattenedChannelIndex(InputChannelInfo channelInfo) {
+		return gateChannelOffsets[channelInfo.getGateIdx()] + channelInfo.getInputChannelIdx();
+	}
+
+	private static class ThreadSafeUnaligner implements BufferReceivedListener, Closeable {
+
+		/**
+		 * Tag the state of which input channel has received the barrier. Until the barrier of a specific channel is
+		 * received, all new buffers need to be persisted after unaligned checkpointing has been started.
+		 */
+		private final boolean[] barrierReceivedChannels;
+
+		/**
+		 * The number of input channels which has read the barrier by task.
+		 */
+		private int numBarriersReceived;
+
+		/** A future indicating that all barriers of the a given checkpoint have been read. */
+		private CompletableFuture<Void> allBarriersReceivedFuture = FutureUtils.completedVoidFuture();
+
+		/**
+		 * The checkpoint id to guarantee that we would trigger only one checkpoint when reading the same barrier from
+		 * different channels.
+		 *
+		 * <p>Note: this checkpoint is valid in respect to <b>received</b> barriers in contrast to
+		 * {@link CheckpointBarrierUnaligner#currentCheckpointId}.
+		 */
+		private long currentCheckpointId = -1L;
+
+		/** The number of opened channels. */
+		private int numOpenChannels;
+
+		private final ChannelStateWriter channelStateWriter;
+
+		private final CheckpointBarrierUnaligner handler;
+
+		public ThreadSafeUnaligner(
+				int totalNumChannels,
+				ChannelStateWriter channelStateWriter,
+				CheckpointBarrierUnaligner handler) {
+			barrierReceivedChannels = new boolean[totalNumChannels];
+			this.channelStateWriter = channelStateWriter;
+			this.handler = handler;
+			Arrays.fill(barrierReceivedChannels, true);
+			numOpenChannels = totalNumChannels;
+		}
+
+		@Override
+		public synchronized void notifyBarrierReceived(CheckpointBarrier barrier, InputChannelInfo channelInfo) {
+			long barrierId = barrier.getId();
+
+			if (currentCheckpointId < barrierId) {
+				handleNewCheckpoint(barrierId);
+				handler.runInTaskThread(() -> handler.notifyCheckpoint(barrier, 0, 0), "notifyCheckpoint");
+			}
+
+			int channelIndex = handler.getFlattenedChannelIndex(channelInfo);
+			if (barrierId == currentCheckpointId && !barrierReceivedChannels[channelIndex]) {
+				if (LOG.isDebugEnabled()) {
+					LOG.debug("{}: Received barrier from channel {} @ {}.", handler.taskName, channelIndex, barrierId);
+				}
+
+				barrierReceivedChannels[channelIndex] = true;
+
+				if (++numBarriersReceived == numOpenChannels) {
+					allBarriersReceivedFuture.complete(null);
+				}
+			}
+		}
+
+		@Override
+		public synchronized void notifyBufferReceived(Buffer buffer, InputChannelInfo channelInfo) {
+			if (!barrierReceivedChannels[handler.getFlattenedChannelIndex(channelInfo)]) {
+				channelStateWriter.addInputData(
+					currentCheckpointId,
+					channelInfo,
+					ChannelStateWriter.SEQUENCE_NUMBER_UNKNOWN,
+					buffer);
+			} else {
+				buffer.recycleBuffer();
+			}
+		}
+
+		@Override
+		public void close() throws IOException {
+			allBarriersReceivedFuture.completeExceptionally(new IllegalStateException("Closed CheckpointBarrierUnaligner"));
+		}
+
+		private synchronized void handleNewCheckpoint(long barrierId) {
+			if (!allBarriersReceivedFuture.isDone()) {
+				// we did not complete the current checkpoint, another started before
+				LOG.warn("{}: Received checkpoint barrier for checkpoint {} before completing current checkpoint {}. " +
+						"Skipping current checkpoint.",
+					handler.taskName,
+					barrierId,
+					currentCheckpointId);
+
+				// let the task know we are not completing this
+				long currentCheckpointId = this.currentCheckpointId;
+				handler.runInTaskThread(() ->
+					handler.notifyAbort(currentCheckpointId,
+						new CheckpointException(
+							"Barrier id: " + barrierId,
+							CheckpointFailureReason.CHECKPOINT_DECLINED_SUBSUMED)),
+					"notifyAbort");
+			}
+
+			currentCheckpointId = barrierId;
+			Arrays.fill(barrierReceivedChannels, false);
+			numBarriersReceived = 0;
+			allBarriersReceivedFuture = new CompletableFuture<>();
+			channelStateWriter.start(barrierId);
+		}
+
+		public synchronized void releaseBlocksAndResetBarriers() {
+			Arrays.fill(barrierReceivedChannels, true);
+			// the next barrier that comes must assume it is the first
+			numBarriersReceived = 0;
+		}
+
+		public synchronized CompletableFuture<Void> getAllBarriersReceivedFuture(long checkpointId) {
+			if (checkpointId < currentCheckpointId) {
+				return FutureUtils.completedVoidFuture();
+			}
+			if (checkpointId > currentCheckpointId) {
+				throw new IllegalStateException("Checkpoint " + checkpointId + " has not been started at all");
+			}
+			return this.allBarriersReceivedFuture;
+		}
+
+		public synchronized void processEndOfPartition() {
+			numOpenChannels--;
+		}
+
+		public void setCurrentCheckpointId(long currentCheckpointId) {
+			this.currentCheckpointId = currentCheckpointId;
+		}
 
 Review comment:
   You are right and I even encountered it in a test run. I modified it to `this.currentReceivedCheckpointId = Math.max(currentReceivedCheckpointId, this.currentReceivedCheckpointId);`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] pnowojski commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
pnowojski commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r406774796
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartition.java
 ##########
 @@ -114,13 +119,25 @@ public boolean add(BufferConsumer bufferConsumer) {
 		return add(bufferConsumer, false);
 	}
 
+	@Override
+	public boolean add(BufferConsumer bufferConsumer, boolean isPriorityEvent) {
 
 Review comment:
   `isPriorityEvent == true` seems like it's not tested in any way. While there should be a test at least for checking that's enqueued at the head AND that data notification was issued.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r407253818
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
 ##########
 @@ -542,6 +573,16 @@ public void onBuffer(Buffer buffer, int sequenceNumber, int backlog) throws IOEx
 			if (backlog >= 0) {
 				onSenderBacklog(backlog);
 			}
+
+			if (checkpointBarrier != null) {
+				receivedCheckpointId = checkpointBarrier.getId();
+			}
+			if (checkpointBarrier != null && inputGate.bufferReceivedListener != null) {
+				inputGate.bufferReceivedListener.notifyBarrierReceived(checkpointBarrier, channelInfo);
+			}
+			if (notifyReceivedBuffer != null && inputGate.bufferReceivedListener != null) {
 
 Review comment:
   I extracted `hasListener = inputGate.bufferReceivedListener != null` variable and tried to add it a) as a guard around the treatment of `notifyBuffer/Barrier` and b) in checkState. Got a warning that it is always `true` for `notifyBuffer/Barrier != null`. So left it out for now. Feel free to nag once more and I'll add it anyways.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] pnowojski commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
pnowojski commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r399235074
 
 

 ##########
 File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/CheckpointBarrierUnaligner.java
 ##########
 @@ -0,0 +1,242 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.streaming.runtime.io;
+
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.runtime.checkpoint.channel.ChannelStateWriter;
+import org.apache.flink.runtime.checkpoint.channel.InputChannelInfo;
+import org.apache.flink.runtime.io.network.api.CancelCheckpointMarker;
+import org.apache.flink.runtime.io.network.api.CheckpointBarrier;
+import org.apache.flink.runtime.io.network.buffer.Buffer;
+import org.apache.flink.runtime.jobgraph.tasks.AbstractInvokable;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import javax.annotation.Nullable;
+
+import java.util.Arrays;
+import java.util.concurrent.CompletableFuture;
+
+import static org.apache.flink.util.Preconditions.checkNotNull;
+
+/**
+ * {@link CheckpointBarrierUnaligner} is used for triggering checkpoint while reading the first barrier
+ * and keeping track of the number of received barriers and consumed barriers.
+ */
+@Internal
+public class CheckpointBarrierUnaligner extends CheckpointBarrierHandler {
 
 Review comment:
   -1 for `CheckpointBarrierOvertakeHandler` from my side. I don't think using "marketing" names as class names is bad, after all that's the terminology that all of us will be using and it will make finding & understanding classes easier. `UnalignedCheckpointBarrierHandler` is also a good name.
   
   However:
   > it (CheckpointBarrierUnaligner) is kind of a pun on CheckpointBarrierAligner (also no Handler), which I liked
   
   has it's own charm. And yes, it's consistent with the existing ones.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#issuecomment-603776093
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6621",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155064201",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155877268",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6755",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6839",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156597180",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6846",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "FAILURE",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156864478",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9a496a27a92e242519764b935012e44adade76a1 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/156864478) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6846) 
   * dee2b337e5e72d8f7b1f5098b74f2958d000fb3c UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r402258136
 
 

 ##########
 File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/CheckpointBarrierUnaligner.java
 ##########
 @@ -0,0 +1,242 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.streaming.runtime.io;
+
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.runtime.checkpoint.channel.ChannelStateWriter;
+import org.apache.flink.runtime.checkpoint.channel.InputChannelInfo;
+import org.apache.flink.runtime.io.network.api.CancelCheckpointMarker;
+import org.apache.flink.runtime.io.network.api.CheckpointBarrier;
+import org.apache.flink.runtime.io.network.buffer.Buffer;
+import org.apache.flink.runtime.jobgraph.tasks.AbstractInvokable;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import javax.annotation.Nullable;
+
+import java.util.Arrays;
+import java.util.concurrent.CompletableFuture;
+
+import static org.apache.flink.util.Preconditions.checkNotNull;
+
+/**
+ * {@link CheckpointBarrierUnaligner} is used for triggering checkpoint while reading the first barrier
+ * and keeping track of the number of received barriers and consumed barriers.
+ */
+@Internal
+public class CheckpointBarrierUnaligner extends CheckpointBarrierHandler {
+
+	private static final Logger LOG = LoggerFactory.getLogger(CheckpointBarrierUnaligner.class);
+
+	private final String taskName;
+
+	/**
+	 * Tag the state of which input channel has read the barrier. If one channel has read the barrier by task,
+	 * the respective in-flight input buffers should be empty when triggering unaligned checkpoint.
+	 */
+	private final boolean[] barrierConsumedChannels;
+
+	/**
+	 * Tag the state of which input channel has received the barrier. Until the barrier of a specific channel is
+	 * received, all new buffers need to be persisted after unaligned checkpointing has been started.
+	 */
+	private final boolean[] barrierReceivedChannels;
+
+	/**
+	 * Contains the offsets of the channel indices for each gate when flattening the channels of all gates.
+	 *
+	 * <p>For example, consider 3 gates with 4 channels, {@code gateChannelOffsets = [0, 4, 8]}.
+	 */
+	private final int[] gateChannelOffsets;
+
+	/**
+	 * The number of input channels which has read the barrier by task.
+	 */
+	private int numBarriersReceived;
+
+	/**
+	 * The checkpoint id to guarantee that we would trigger only one checkpoint when reading the same barrier from
+	 * different channels.
+	 */
+	private long currentCheckpointId = -1L;
+
+	private final ChannelStateWriter channelStateWriter;
+
+	private CompletableFuture<?> allBarriersReceivedFuture;
+
+	CheckpointBarrierUnaligner(
+			int[] numberOfInputChannelsPerGate,
+			ChannelStateWriter channelStateWriter,
+			String taskName,
+			@Nullable AbstractInvokable toNotifyOnCheckpoint) {
+		super(toNotifyOnCheckpoint);
+
+		this.taskName = taskName;
+		this.channelStateWriter = checkNotNull(channelStateWriter);
+
+		final int numGates = numberOfInputChannelsPerGate.length;
+
+		gateChannelOffsets = new int[numGates];
+		for (int index = 1; index < numGates; index++) {
+			gateChannelOffsets[index] = gateChannelOffsets[index - 1] + numberOfInputChannelsPerGate[index - 1];
+		}
+
+		final int totalNumChannels = gateChannelOffsets[numGates - 1] + numberOfInputChannelsPerGate[numGates - 1];
+		barrierConsumedChannels = new boolean[totalNumChannels];
+		Arrays.fill(barrierConsumedChannels, true);
+		barrierReceivedChannels = new boolean[totalNumChannels];
+		Arrays.fill(barrierReceivedChannels, true);
+	}
+
+	@Override
+	public void releaseBlocksAndResetBarriers() {
+	}
+
+	/**
+	 * For unaligned checkpoint, it never blocks processing from the task aspect.
+	 *
+	 * <p>For PoC, we do not consider the possibility that the unaligned checkpoint would
+	 * not perform due to the max configured unaligned checkpoint size.
+	 */
+	@Override
+	public boolean isBlocked(int channelIndex) {
+		return false;
+	}
+
+	/**
+	 * We still need to trigger checkpoint while reading the first barrier from one channel, because this might happen
+	 * earlier than the previous async trigger via mailbox by netty thread. And the {@link AbstractInvokable} has the
+	 * deduplication logic to guarantee trigger checkpoint only once finally.
+	 *
+	 * <p>Note this is also suitable for the trigger case of local input channel.
+	 */
+	@Override
+	public synchronized boolean processBarrier(
+			CheckpointBarrier receivedBarrier,
+			int channelIndex,
+			long bufferedBytes) {
+		long barrierId = receivedBarrier.getId();
+		if (checkNewCheckpoint(barrierId)) {
+			notifyCheckpointAsync(receivedBarrier, bufferedBytes, 0);
+		}
+		barrierConsumedChannels[channelIndex] = true;
+		return false;
+	}
+
+	@Override
+	public boolean processCancellationBarrier(CancelCheckpointMarker cancelBarrier) {
+		return false;
+	}
+
+	@Override
+	public boolean processEndOfPartition() {
+		return false;
+	}
+
+	@Override
+	public long getLatestCheckpointId() {
+		return currentCheckpointId;
+	}
+
+	@Override
+	public long getAlignmentDurationNanos() {
+		return 0;
+	}
+
+	@Override
+	public String toString() {
+		return String.format("%s: last checkpoint: %d", taskName, currentCheckpointId);
+	}
+
+	@Override
+	public void checkpointSizeLimitExceeded(long maxBufferedBytes) {
+	}
+
+	@Override
+	protected boolean isBarrierConsumed(long checkpointId, int channelIndex) {
+		if (checkpointId < currentCheckpointId) {
+			return true;
+		}
+		if (checkpointId > currentCheckpointId) {
+			return false;
+		}
+		return barrierConsumedChannels[channelIndex];
+	}
+
+	public CompletableFuture<?> getAllBarriersReceivedFuture(long checkpointId) {
 
 Review comment:
   After our offline discussions, I moved larger potion of the Unaligner into a `ThreadSafeUnaligner`, to avoid these kind of issues on all variables that are touched on both netty and task thread.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#issuecomment-603776093
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6621",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155064201",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155877268",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6755",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6839",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156597180",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6846",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156864478",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6873",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156994047",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157330632",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6900",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157451694",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6916",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157494634",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6933",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157589655",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6944",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6991",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157754467",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158102285",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7007",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7023",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158153241",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158188400",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7040",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7048",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158276096",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158831429",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7117",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7121",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158855200",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159112519",
       "triggerID" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7172",
       "triggerID" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159143719",
       "triggerID" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7175",
       "triggerID" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "triggerType" : "PUSH"
     }, {
       "hash" : "35ec088ef24e841beae78c33488975d2d8d0a40d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "35ec088ef24e841beae78c33488975d2d8d0a40d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7194",
       "triggerID" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159244661",
       "triggerID" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "triggerType" : "PUSH"
     }, {
       "hash" : "334458afaa98b601eec12c490e71caa8274be055",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "334458afaa98b601eec12c490e71caa8274be055",
       "triggerType" : "PUSH"
     }, {
       "hash" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7212",
       "triggerID" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "triggerType" : "PUSH"
     }, {
       "hash" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159269141",
       "triggerID" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7226",
       "triggerID" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159307415",
       "triggerID" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7297",
       "triggerID" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159652918",
       "triggerID" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "559816dcea4999dd46b09ee1091ddc0e1a5a7a54",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "559816dcea4999dd46b09ee1091ddc0e1a5a7a54",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6cd76afe4990f56a5166e1592374aa8f86fe883f",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "6cd76afe4990f56a5166e1592374aa8f86fe883f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7302",
       "triggerID" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159678447",
       "triggerID" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159695914",
       "triggerID" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7305",
       "triggerID" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ac996f5c703560ecbe6cad7394cc8ad54d6f0029",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "ac996f5c703560ecbe6cad7394cc8ad54d6f0029",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7347",
       "triggerID" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159875195",
       "triggerID" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "75c8130873e9b91e21e1e833d3d05f1ad9b5d2b8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7354",
       "triggerID" : "75c8130873e9b91e21e1e833d3d05f1ad9b5d2b8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7369",
       "triggerID" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "triggerType" : "PUSH"
     }, {
       "hash" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159960514",
       "triggerID" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7373",
       "triggerID" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159990549",
       "triggerID" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "triggerType" : "PUSH"
     }, {
       "hash" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7443",
       "triggerID" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160172375",
       "triggerID" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "536d9fb04a7a8142c04c94344dd0b3c0f2c10999",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160215439",
       "triggerID" : "536d9fb04a7a8142c04c94344dd0b3c0f2c10999",
       "triggerType" : "PUSH"
     }, {
       "hash" : "536d9fb04a7a8142c04c94344dd0b3c0f2c10999",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7469",
       "triggerID" : "536d9fb04a7a8142c04c94344dd0b3c0f2c10999",
       "triggerType" : "PUSH"
     }, {
       "hash" : "67018bacf5bc2daa8a03a1aafa880efc1db86808",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7500",
       "triggerID" : "67018bacf5bc2daa8a03a1aafa880efc1db86808",
       "triggerType" : "PUSH"
     }, {
       "hash" : "67018bacf5bc2daa8a03a1aafa880efc1db86808",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160347006",
       "triggerID" : "67018bacf5bc2daa8a03a1aafa880efc1db86808",
       "triggerType" : "PUSH"
     }, {
       "hash" : "79c116a6a1f5fe314f801e81f0265dea8b9ac1a7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7522",
       "triggerID" : "79c116a6a1f5fe314f801e81f0265dea8b9ac1a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "79c116a6a1f5fe314f801e81f0265dea8b9ac1a7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160377553",
       "triggerID" : "79c116a6a1f5fe314f801e81f0265dea8b9ac1a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "27ce4bfad8e99989dd64f8c636c934727da8a062",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "27ce4bfad8e99989dd64f8c636c934727da8a062",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ce0dfc7324679ebf2da84278eac8f5f59d748319",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7539",
       "triggerID" : "ce0dfc7324679ebf2da84278eac8f5f59d748319",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ce0dfc7324679ebf2da84278eac8f5f59d748319",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160418181",
       "triggerID" : "ce0dfc7324679ebf2da84278eac8f5f59d748319",
       "triggerType" : "PUSH"
     }, {
       "hash" : "05c934bf483d4fb673496783ef8ff85b40b86708",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "05c934bf483d4fb673496783ef8ff85b40b86708",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4bbe67a13a75f4491898fbb1cd2315237dbca30e",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160443829",
       "triggerID" : "4bbe67a13a75f4491898fbb1cd2315237dbca30e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4bbe67a13a75f4491898fbb1cd2315237dbca30e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7543",
       "triggerID" : "4bbe67a13a75f4491898fbb1cd2315237dbca30e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "cb5258f13c64ed033db7b8476122721ac418d798",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160496434",
       "triggerID" : "cb5258f13c64ed033db7b8476122721ac418d798",
       "triggerType" : "PUSH"
     }, {
       "hash" : "cb5258f13c64ed033db7b8476122721ac418d798",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7560",
       "triggerID" : "cb5258f13c64ed033db7b8476122721ac418d798",
       "triggerType" : "PUSH"
     }, {
       "hash" : "fdc673b8583650ce40a6f13b8a44d9773e14c370",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7597",
       "triggerID" : "fdc673b8583650ce40a6f13b8a44d9773e14c370",
       "triggerType" : "PUSH"
     }, {
       "hash" : "fdc673b8583650ce40a6f13b8a44d9773e14c370",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160543449",
       "triggerID" : "fdc673b8583650ce40a6f13b8a44d9773e14c370",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1123cc69ed817c9935bae5ffbba5e48f5bbe0f25",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7611",
       "triggerID" : "1123cc69ed817c9935bae5ffbba5e48f5bbe0f25",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1123cc69ed817c9935bae5ffbba5e48f5bbe0f25",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160619473",
       "triggerID" : "1123cc69ed817c9935bae5ffbba5e48f5bbe0f25",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dd5b4999b59b53950c2fb3784fc50ed97617f5aa",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "dd5b4999b59b53950c2fb3784fc50ed97617f5aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9e118a737919fb9c784d171ae06567030a5a9ecd",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160633665",
       "triggerID" : "9e118a737919fb9c784d171ae06567030a5a9ecd",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9e118a737919fb9c784d171ae06567030a5a9ecd",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7612",
       "triggerID" : "9e118a737919fb9c784d171ae06567030a5a9ecd",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * dee2b337e5e72d8f7b1f5098b74f2958d000fb3c UNKNOWN
   * 80b7f76f24b5fb6704a4b2292543f8764ec19053 UNKNOWN
   * 35ec088ef24e841beae78c33488975d2d8d0a40d UNKNOWN
   * 334458afaa98b601eec12c490e71caa8274be055 UNKNOWN
   * 559816dcea4999dd46b09ee1091ddc0e1a5a7a54 UNKNOWN
   * 6cd76afe4990f56a5166e1592374aa8f86fe883f UNKNOWN
   * ac996f5c703560ecbe6cad7394cc8ad54d6f0029 UNKNOWN
   * 27ce4bfad8e99989dd64f8c636c934727da8a062 UNKNOWN
   * 05c934bf483d4fb673496783ef8ff85b40b86708 UNKNOWN
   * dd5b4999b59b53950c2fb3784fc50ed97617f5aa UNKNOWN
   * 9e118a737919fb9c784d171ae06567030a5a9ecd Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/160633665) Azure: [CANCELED](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7612) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#issuecomment-603776093
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6621",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155064201",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155877268",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6755",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6839",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156597180",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6846",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156864478",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6873",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156994047",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157330632",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6900",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157451694",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6916",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157494634",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6933",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "FAILURE",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157589655",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6944",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6991",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157754467",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * dee2b337e5e72d8f7b1f5098b74f2958d000fb3c UNKNOWN
   * 80b7f76f24b5fb6704a4b2292543f8764ec19053 UNKNOWN
   * 707cb2dc5af184ebd495d7381d8e4e944436b936 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/157589655) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6944) 
   * e148bdc935791d691e3d09c6576c3e3fa04e2ac8 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/157754467) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6991) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] rkhachatryan commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r408013290
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
 ##########
 @@ -206,6 +214,25 @@ void retriggerSubpartitionRequest(int subpartitionIndex) throws IOException {
 		return Optional.of(new BufferAndAvailability(next, moreAvailable, getSenderBacklog()));
 	}
 
+	@Override
+	public List<Buffer> requestInflightBuffers(long checkpointId) throws IOException {
+		synchronized (receivedBuffers) {
+			checkState(checkpointId > lastRequestedCheckpointId, "Need to request the next checkpointId");
+
+			final List<Buffer> inflightBuffers = new ArrayList<>(receivedBuffers.size());
+			for (Buffer buffer : receivedBuffers) {
+				if (!buffer.isBuffer() && parseCheckpointBarrierOrNull(buffer) != null) {
+					break;
+				}
+				inflightBuffers.add(buffer.retainBuffer());
 
 Review comment:
   We shouldn't persist anything except buffers (`isBuffer == true`).
   With the check above we break if it's checkpoint barrier, but it can also be e.g. `CancelCheckpointMarker`.
   I couldn't find any checks for this in other places.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r402620783
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/InputGate.java
 ##########
 @@ -107,6 +107,20 @@
 		return availabilityHelper.getAvailableFuture();
 	}
 
+	/**
+	 * Returns the index of this gate in respect to the consuming operator instance.
+	 */
+	public int getGateIndex() {
+		throw new UnsupportedOperationException();
+	}
+
+	/**
+	 * Returns the channel of this gate.
+	 */
+	public InputChannel getChannel(int channelIndex) {
 
 Review comment:
   Made it abstract.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r405057369
 
 

 ##########
 File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/CheckpointBarrierUnaligner.java
 ##########
 @@ -0,0 +1,417 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.streaming.runtime.io;
+
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.runtime.checkpoint.CheckpointException;
+import org.apache.flink.runtime.checkpoint.CheckpointFailureReason;
+import org.apache.flink.runtime.checkpoint.channel.ChannelStateWriter;
+import org.apache.flink.runtime.checkpoint.channel.InputChannelInfo;
+import org.apache.flink.runtime.concurrent.FutureUtils;
+import org.apache.flink.runtime.io.network.api.CancelCheckpointMarker;
+import org.apache.flink.runtime.io.network.api.CheckpointBarrier;
+import org.apache.flink.runtime.io.network.buffer.Buffer;
+import org.apache.flink.runtime.io.network.buffer.BufferReceivedListener;
+import org.apache.flink.runtime.jobgraph.tasks.AbstractInvokable;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.Closeable;
+import java.io.IOException;
+import java.util.Arrays;
+import java.util.Optional;
+import java.util.concurrent.CompletableFuture;
+import java.util.function.Function;
+import java.util.stream.IntStream;
+
+import static org.apache.flink.util.Preconditions.checkNotNull;
+
+/**
+ * {@link CheckpointBarrierUnaligner} is used for triggering checkpoint while reading the first barrier
+ * and keeping track of the number of received barriers and consumed barriers.
+ */
+@Internal
+public class CheckpointBarrierUnaligner extends CheckpointBarrierHandler {
+
+	private static final Logger LOG = LoggerFactory.getLogger(CheckpointBarrierUnaligner.class);
+
+	private final String taskName;
+
+	/**
+	 * Tag the state of which input channel has read the barrier. If one channel has read the barrier by task,
+	 * the respective in-flight input buffers should be empty when triggering unaligned checkpoint.
+	 */
+	private final boolean[] barrierConsumedChannels;
+
+	private int numBarrierConsumed;
+
+	/**
+	 * Contains the offsets of the channel indices for each gate when flattening the channels of all gates.
+	 *
+	 * <p>For example, consider 3 gates with 4 channels, {@code gateChannelOffsets = [0, 4, 8]}.
+	 */
+	private final int[] gateChannelOffsets;
+
+	private final InputChannelInfo[] channelInfos;
+
+	/**
+	 * The checkpoint id to guarantee that we would trigger only one checkpoint when reading the same barrier from
+	 * different channels.
+	 *
+	 * <p>Note: this checkpoint is valid in respect to <b>consumed</b> barriers in contrast to
+	 * {@link ThreadSafeUnaligner#currentCheckpointId}.
+	 */
+	private long currentCheckpointId = -1L;
+
+	/** Encapsulates state that is shared between netty threads and task thread. */
+	private final ThreadSafeUnaligner threadSafeUnaligner;
+
+	CheckpointBarrierUnaligner(
+			int[] numberOfInputChannelsPerGate,
+			ChannelStateWriter channelStateWriter,
+			String taskName,
+			AbstractInvokable toNotifyOnCheckpoint) {
+		super(toNotifyOnCheckpoint);
+
+		this.taskName = taskName;
+
+		final int numGates = numberOfInputChannelsPerGate.length;
+
+		gateChannelOffsets = new int[numGates];
+		for (int index = 1; index < numGates; index++) {
+			gateChannelOffsets[index] = gateChannelOffsets[index - 1] + numberOfInputChannelsPerGate[index - 1];
+		}
+
+		final int totalNumChannels = gateChannelOffsets[numGates - 1] + numberOfInputChannelsPerGate[numGates - 1];
+		barrierConsumedChannels = new boolean[totalNumChannels];
+		Arrays.fill(barrierConsumedChannels, true);
+
+		channelInfos = IntStream.range(0, numGates)
+			.mapToObj(gateIndex -> IntStream.range(0, numberOfInputChannelsPerGate[gateIndex])
+				.mapToObj(channelIndex -> new InputChannelInfo(gateIndex, channelIndex)))
+			.flatMap(Function.identity())
+			.toArray(InputChannelInfo[]::new);
+
+		threadSafeUnaligner = new ThreadSafeUnaligner(totalNumChannels,	checkNotNull(channelStateWriter), this);
+	}
+
+	@Override
+	public void releaseBlocksAndResetBarriers() {
+		// make sure no additional data is persisted
+		Arrays.fill(barrierConsumedChannels, true);
+		// the next barrier that comes must assume it is the first
+		numBarrierConsumed = 0;
+		threadSafeUnaligner.releaseBlocksAndResetBarriers();
+	}
+
+	/**
+	 * For unaligned checkpoint, it never blocks processing from the task aspect.
+	 *
+	 * <p>For PoC, we do not consider the possibility that the unaligned checkpoint would
+	 * not perform due to the max configured unaligned checkpoint size.
+	 */
+	@Override
+	public boolean isBlocked(int channelIndex) {
+		return false;
+	}
+
+	/**
+	 * We still need to trigger checkpoint while reading the first barrier from one channel, because this might happen
+	 * earlier than the previous async trigger via mailbox by netty thread. And the {@link AbstractInvokable} has the
+	 * deduplication logic to guarantee trigger checkpoint only once finally.
+	 *
+	 * <p>Note this is also suitable for the trigger case of local input channel.
+	 */
+	@Override
+	public boolean processBarrier(
+			CheckpointBarrier receivedBarrier,
+			int channelIndex,
+			long bufferedBytes) throws IOException {
+		long barrierId = receivedBarrier.getId();
+		if (currentCheckpointId < barrierId) {
+			currentCheckpointId = barrierId;
+			numBarrierConsumed = 0;
+			Arrays.fill(barrierConsumedChannels, false);
+		}
+		if (currentCheckpointId == barrierId) {
+			barrierConsumedChannels[channelIndex] = true;
+			numBarrierConsumed++;
+		}
+		// processBarrier is called from task thread and can actually happen before notifyBarrierReceived on empty
+		// buffer queues
+		// to avoid replicating any logic, we simply call notifyBarrierReceived here as well
+		threadSafeUnaligner.notifyBarrierReceived(receivedBarrier, channelInfos[channelIndex]);
+		return false;
+	}
+
+	@Override
+	public boolean processCancellationBarrier(CancelCheckpointMarker cancelBarrier) throws Exception {
+		final long barrierId = cancelBarrier.getCheckpointId();
+
+		if (numBarrierConsumed > 0) {
+			// this is only true if some alignment is in progress and nothing was canceled
+
+			if (barrierId == currentCheckpointId) {
+				// cancel this alignment
+				if (LOG.isDebugEnabled()) {
+					LOG.debug("{}: Checkpoint {} canceled, aborting alignment.", taskName, barrierId);
+				}
+
+				releaseBlocksAndResetBarriers();
+				notifyAbortOnCancellationBarrier(barrierId);
+			}
+			else if (barrierId > currentCheckpointId) {
+				// we canceled the next which also cancels the current
+				LOG.warn("{}: Received cancellation barrier for checkpoint {} before completing current checkpoint {}. " +
+						"Skipping current checkpoint.",
+					taskName,
+					barrierId,
+					currentCheckpointId);
+
+				// this stops the current alignment
+				releaseBlocksAndResetBarriers();
+
+				// the next checkpoint starts as canceled
+				currentCheckpointId = barrierId;
+				threadSafeUnaligner.setCurrentCheckpointId(currentCheckpointId);
+				notifyAbortOnCancellationBarrier(barrierId);
+			}
+
+			// else: ignore trailing (cancellation) barrier from an earlier checkpoint (obsolete now)
+
+		}
+		else if (barrierId > currentCheckpointId) {
+			// first barrier of a new checkpoint is directly a cancellation
+
+			// by setting the currentCheckpointId to this checkpoint while keeping the numBarriers
+			// at zero means that no checkpoint barrier can start a new alignment
+			currentCheckpointId = barrierId;
+			threadSafeUnaligner.setCurrentCheckpointId(currentCheckpointId);
+
+			if (LOG.isDebugEnabled()) {
+				LOG.debug("{}: Checkpoint {} canceled, skipping alignment.", taskName, barrierId);
+			}
+
+			notifyAbortOnCancellationBarrier(barrierId);
+		}
+
+		// else: trailing barrier from either
+		//   - a previous (subsumed) checkpoint
+		//   - the current checkpoint if it was already canceled
+		return false;
+	}
+
+	@Override
+	public boolean processEndOfPartition() throws Exception {
+		threadSafeUnaligner.processEndOfPartition();
+
+		if (numBarrierConsumed > 0) {
+			// let the task know we skip a checkpoint
+			notifyAbort(
+				currentCheckpointId,
+				new CheckpointException(CheckpointFailureReason.CHECKPOINT_DECLINED_INPUT_END_OF_STREAM));
+			// no chance to complete this checkpoint
+			releaseBlocksAndResetBarriers();
+			return true;
+		}
+		return false;
+	}
+
+	@Override
+	public long getLatestCheckpointId() {
+		return currentCheckpointId;
+	}
+
+	@Override
+	public long getAlignmentDurationNanos() {
+		return 0;
+	}
+
+	@Override
+	public String toString() {
+		return String.format("%s: last checkpoint: %d", taskName, currentCheckpointId);
+	}
+
+	@Override
+	public void checkpointSizeLimitExceeded(long maxBufferedBytes) {
+	}
+
+	@Override
+	public void close() throws IOException {
+		super.close();
+		threadSafeUnaligner.close();
+	}
+
+	@Override
+	protected boolean isBarrierConsumed(long checkpointId, int channelIndex) {
+		if (checkpointId < currentCheckpointId) {
+			return true;
+		}
+		if (checkpointId > currentCheckpointId) {
+			return false;
+		}
+		return barrierConsumedChannels[channelIndex];
+	}
+
+	public CompletableFuture<Void> getAllBarriersReceivedFuture(long checkpointId) {
+		return threadSafeUnaligner.getAllBarriersReceivedFuture(checkpointId);
+	}
+
+	@Override
+	public Optional<BufferReceivedListener> getBufferReceivedListener() {
+		return Optional.of(threadSafeUnaligner);
+	}
+
+	private int getFlattenedChannelIndex(InputChannelInfo channelInfo) {
+		return gateChannelOffsets[channelInfo.getGateIdx()] + channelInfo.getInputChannelIdx();
+	}
+
+	private static class ThreadSafeUnaligner implements BufferReceivedListener, Closeable {
+
+		/**
+		 * Tag the state of which input channel has received the barrier. Until the barrier of a specific channel is
+		 * received, all new buffers need to be persisted after unaligned checkpointing has been started.
+		 */
+		private final boolean[] barrierReceivedChannels;
+
+		/**
+		 * The number of input channels which has read the barrier by task.
+		 */
+		private int numBarriersReceived;
+
+		/** A future indicating that all barriers of the a given checkpoint have been read. */
+		private CompletableFuture<Void> allBarriersReceivedFuture = FutureUtils.completedVoidFuture();
+
+		/**
+		 * The checkpoint id to guarantee that we would trigger only one checkpoint when reading the same barrier from
+		 * different channels.
+		 *
+		 * <p>Note: this checkpoint is valid in respect to <b>received</b> barriers in contrast to
+		 * {@link CheckpointBarrierUnaligner#currentCheckpointId}.
+		 */
+		private long currentCheckpointId = -1L;
+
+		/** The number of opened channels. */
+		private int numOpenChannels;
+
+		private final ChannelStateWriter channelStateWriter;
+
+		private final CheckpointBarrierUnaligner handler;
+
+		public ThreadSafeUnaligner(
+				int totalNumChannels,
+				ChannelStateWriter channelStateWriter,
+				CheckpointBarrierUnaligner handler) {
+			barrierReceivedChannels = new boolean[totalNumChannels];
+			this.channelStateWriter = channelStateWriter;
+			this.handler = handler;
+			Arrays.fill(barrierReceivedChannels, true);
+			numOpenChannels = totalNumChannels;
+		}
+
+		@Override
+		public synchronized void notifyBarrierReceived(CheckpointBarrier barrier, InputChannelInfo channelInfo) throws IOException {
+			long barrierId = barrier.getId();
+
+			if (currentCheckpointId < barrierId) {
+				handleNewCheckpoint(barrierId);
+				handler.runInTaskThread(() -> handler.notifyCheckpoint(barrier, 0, 0), "notifyCheckpoint");
+			}
+
+			int channelIndex = handler.getFlattenedChannelIndex(channelInfo);
+			if (barrierId == currentCheckpointId && !barrierReceivedChannels[channelIndex]) {
+				if (LOG.isDebugEnabled()) {
+					LOG.debug("{}: Received barrier from channel {} @ {}.", handler.taskName, channelIndex, barrierId);
+				}
+
+				barrierReceivedChannels[channelIndex] = true;
+
+				if (++numBarriersReceived == numOpenChannels) {
+					allBarriersReceivedFuture.complete(null);
+				}
+			}
+		}
+
+		@Override
+		public synchronized void notifyBufferReceived(Buffer buffer, InputChannelInfo channelInfo) {
+			if (!barrierReceivedChannels[handler.getFlattenedChannelIndex(channelInfo)]) {
+				channelStateWriter.addInputData(
+					currentCheckpointId,
+					channelInfo,
+					ChannelStateWriter.SEQUENCE_NUMBER_UNKNOWN,
+					buffer.retainBuffer());
+			}
+		}
+
+		@Override
+		public void close() throws IOException {
+			allBarriersReceivedFuture.completeExceptionally(new IllegalStateException("Closed CheckpointBarrierUnaligner"));
+		}
+
+		private synchronized void handleNewCheckpoint(long barrierId) throws IOException {
+			if (!allBarriersReceivedFuture.isDone()) {
 
 Review comment:
   Good idea. I just fear that it may lead to the checkpoint being aborted with the provided exception instead of the `CHECKPOINT_DECLINED_SUBSUMED` failure message from `notifyAbort`. Could you please double-check?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#issuecomment-603776093
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6621",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155064201",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155877268",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6755",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6839",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156597180",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6846",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156864478",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6873",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156994047",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157330632",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6900",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157451694",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6916",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157494634",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6933",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157589655",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6944",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6991",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157754467",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158102285",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7007",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7023",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158153241",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158188400",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7040",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7048",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158276096",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158831429",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7117",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7121",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158855200",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159112519",
       "triggerID" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7172",
       "triggerID" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159143719",
       "triggerID" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7175",
       "triggerID" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "triggerType" : "PUSH"
     }, {
       "hash" : "35ec088ef24e841beae78c33488975d2d8d0a40d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "35ec088ef24e841beae78c33488975d2d8d0a40d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7194",
       "triggerID" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159244661",
       "triggerID" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "triggerType" : "PUSH"
     }, {
       "hash" : "334458afaa98b601eec12c490e71caa8274be055",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "334458afaa98b601eec12c490e71caa8274be055",
       "triggerType" : "PUSH"
     }, {
       "hash" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7212",
       "triggerID" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "triggerType" : "PUSH"
     }, {
       "hash" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159269141",
       "triggerID" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7226",
       "triggerID" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159307415",
       "triggerID" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7297",
       "triggerID" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159652918",
       "triggerID" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "559816dcea4999dd46b09ee1091ddc0e1a5a7a54",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "559816dcea4999dd46b09ee1091ddc0e1a5a7a54",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6cd76afe4990f56a5166e1592374aa8f86fe883f",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "6cd76afe4990f56a5166e1592374aa8f86fe883f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7302",
       "triggerID" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159678447",
       "triggerID" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159695914",
       "triggerID" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7305",
       "triggerID" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ac996f5c703560ecbe6cad7394cc8ad54d6f0029",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "ac996f5c703560ecbe6cad7394cc8ad54d6f0029",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7347",
       "triggerID" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159875195",
       "triggerID" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "75c8130873e9b91e21e1e833d3d05f1ad9b5d2b8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7354",
       "triggerID" : "75c8130873e9b91e21e1e833d3d05f1ad9b5d2b8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7369",
       "triggerID" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "triggerType" : "PUSH"
     }, {
       "hash" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159960514",
       "triggerID" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7373",
       "triggerID" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159990549",
       "triggerID" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "triggerType" : "PUSH"
     }, {
       "hash" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7443",
       "triggerID" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160172375",
       "triggerID" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "536d9fb04a7a8142c04c94344dd0b3c0f2c10999",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160215439",
       "triggerID" : "536d9fb04a7a8142c04c94344dd0b3c0f2c10999",
       "triggerType" : "PUSH"
     }, {
       "hash" : "536d9fb04a7a8142c04c94344dd0b3c0f2c10999",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7469",
       "triggerID" : "536d9fb04a7a8142c04c94344dd0b3c0f2c10999",
       "triggerType" : "PUSH"
     }, {
       "hash" : "67018bacf5bc2daa8a03a1aafa880efc1db86808",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7500",
       "triggerID" : "67018bacf5bc2daa8a03a1aafa880efc1db86808",
       "triggerType" : "PUSH"
     }, {
       "hash" : "67018bacf5bc2daa8a03a1aafa880efc1db86808",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160347006",
       "triggerID" : "67018bacf5bc2daa8a03a1aafa880efc1db86808",
       "triggerType" : "PUSH"
     }, {
       "hash" : "79c116a6a1f5fe314f801e81f0265dea8b9ac1a7",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7522",
       "triggerID" : "79c116a6a1f5fe314f801e81f0265dea8b9ac1a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "79c116a6a1f5fe314f801e81f0265dea8b9ac1a7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160377553",
       "triggerID" : "79c116a6a1f5fe314f801e81f0265dea8b9ac1a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "27ce4bfad8e99989dd64f8c636c934727da8a062",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "27ce4bfad8e99989dd64f8c636c934727da8a062",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ce0dfc7324679ebf2da84278eac8f5f59d748319",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7539",
       "triggerID" : "ce0dfc7324679ebf2da84278eac8f5f59d748319",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ce0dfc7324679ebf2da84278eac8f5f59d748319",
       "status" : "FAILURE",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160418181",
       "triggerID" : "ce0dfc7324679ebf2da84278eac8f5f59d748319",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * dee2b337e5e72d8f7b1f5098b74f2958d000fb3c UNKNOWN
   * 80b7f76f24b5fb6704a4b2292543f8764ec19053 UNKNOWN
   * 35ec088ef24e841beae78c33488975d2d8d0a40d UNKNOWN
   * 334458afaa98b601eec12c490e71caa8274be055 UNKNOWN
   * 559816dcea4999dd46b09ee1091ddc0e1a5a7a54 UNKNOWN
   * 6cd76afe4990f56a5166e1592374aa8f86fe883f UNKNOWN
   * ac996f5c703560ecbe6cad7394cc8ad54d6f0029 UNKNOWN
   * 27ce4bfad8e99989dd64f8c636c934727da8a062 UNKNOWN
   * ce0dfc7324679ebf2da84278eac8f5f59d748319 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/160418181) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7539) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#issuecomment-603776093
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6621",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155064201",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155877268",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6755",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6839",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156597180",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6846",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156864478",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6873",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156994047",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157330632",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6900",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157451694",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6916",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157494634",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6933",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157589655",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6944",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6991",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157754467",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158102285",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7007",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7023",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158153241",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158188400",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7040",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7048",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158276096",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158831429",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7117",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7121",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158855200",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159112519",
       "triggerID" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7172",
       "triggerID" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159143719",
       "triggerID" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7175",
       "triggerID" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "triggerType" : "PUSH"
     }, {
       "hash" : "35ec088ef24e841beae78c33488975d2d8d0a40d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "35ec088ef24e841beae78c33488975d2d8d0a40d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7194",
       "triggerID" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159244661",
       "triggerID" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "triggerType" : "PUSH"
     }, {
       "hash" : "334458afaa98b601eec12c490e71caa8274be055",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "334458afaa98b601eec12c490e71caa8274be055",
       "triggerType" : "PUSH"
     }, {
       "hash" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7212",
       "triggerID" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "triggerType" : "PUSH"
     }, {
       "hash" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159269141",
       "triggerID" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7226",
       "triggerID" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159307415",
       "triggerID" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7297",
       "triggerID" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159652918",
       "triggerID" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "559816dcea4999dd46b09ee1091ddc0e1a5a7a54",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "559816dcea4999dd46b09ee1091ddc0e1a5a7a54",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6cd76afe4990f56a5166e1592374aa8f86fe883f",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "6cd76afe4990f56a5166e1592374aa8f86fe883f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7302",
       "triggerID" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159678447",
       "triggerID" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159695914",
       "triggerID" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7305",
       "triggerID" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ac996f5c703560ecbe6cad7394cc8ad54d6f0029",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "ac996f5c703560ecbe6cad7394cc8ad54d6f0029",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7347",
       "triggerID" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159875195",
       "triggerID" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "75c8130873e9b91e21e1e833d3d05f1ad9b5d2b8",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7354",
       "triggerID" : "75c8130873e9b91e21e1e833d3d05f1ad9b5d2b8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7369",
       "triggerID" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "triggerType" : "PUSH"
     }, {
       "hash" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159960514",
       "triggerID" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * dee2b337e5e72d8f7b1f5098b74f2958d000fb3c UNKNOWN
   * 80b7f76f24b5fb6704a4b2292543f8764ec19053 UNKNOWN
   * 35ec088ef24e841beae78c33488975d2d8d0a40d UNKNOWN
   * 334458afaa98b601eec12c490e71caa8274be055 UNKNOWN
   * 559816dcea4999dd46b09ee1091ddc0e1a5a7a54 UNKNOWN
   * 6cd76afe4990f56a5166e1592374aa8f86fe883f UNKNOWN
   * ac996f5c703560ecbe6cad7394cc8ad54d6f0029 UNKNOWN
   * 75c8130873e9b91e21e1e833d3d05f1ad9b5d2b8 Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7354) 
   * 54a27acd416fbed48aa7876fda85036b90c641ab Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/159960514) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7369) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#issuecomment-603776093
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6621",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155064201",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155877268",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6755",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6839",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156597180",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6846",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156864478",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6873",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156994047",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157330632",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6900",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157451694",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6916",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157494634",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6933",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157589655",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6944",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6991",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157754467",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158102285",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7007",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7023",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158153241",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158188400",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7040",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7048",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158276096",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158831429",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7117",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7121",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "FAILURE",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158855200",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * dee2b337e5e72d8f7b1f5098b74f2958d000fb3c UNKNOWN
   * 80b7f76f24b5fb6704a4b2292543f8764ec19053 UNKNOWN
   * a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/158855200) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7121) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r398379957
 
 

 ##########
 File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/CheckpointBarrierUnaligner.java
 ##########
 @@ -0,0 +1,242 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.streaming.runtime.io;
+
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.runtime.checkpoint.channel.ChannelStateWriter;
+import org.apache.flink.runtime.checkpoint.channel.InputChannelInfo;
+import org.apache.flink.runtime.io.network.api.CancelCheckpointMarker;
+import org.apache.flink.runtime.io.network.api.CheckpointBarrier;
+import org.apache.flink.runtime.io.network.buffer.Buffer;
+import org.apache.flink.runtime.jobgraph.tasks.AbstractInvokable;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import javax.annotation.Nullable;
+
+import java.util.Arrays;
+import java.util.concurrent.CompletableFuture;
+
+import static org.apache.flink.util.Preconditions.checkNotNull;
+
+/**
+ * {@link CheckpointBarrierUnaligner} is used for triggering checkpoint while reading the first barrier
+ * and keeping track of the number of received barriers and consumed barriers.
+ */
+@Internal
+public class CheckpointBarrierUnaligner extends CheckpointBarrierHandler {
 
 Review comment:
   I'm fine with the proposal. I took the name from @zhijiangW's original POC and for me it's kind of a pun on `CheckpointBarrierAligner` (also no Handler), which I liked.
   
   In general, when it comes to naming, unaligned checkpoints is mostly marketing imho, as we still have an alignment phase at some point. It would be more precise to call it `CheckpointBarrierOvertakeHandler` or something along these lines.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#issuecomment-603776093
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6621",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155064201",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155877268",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6755",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6839",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156597180",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6846",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156864478",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6873",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156994047",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157330632",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6900",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157451694",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6916",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157494634",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6933",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157589655",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6944",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6991",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157754467",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158102285",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7007",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7023",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158153241",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158188400",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7040",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7048",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158276096",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158831429",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7117",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7121",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158855200",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159112519",
       "triggerID" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7172",
       "triggerID" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159143719",
       "triggerID" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7175",
       "triggerID" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "triggerType" : "PUSH"
     }, {
       "hash" : "35ec088ef24e841beae78c33488975d2d8d0a40d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "35ec088ef24e841beae78c33488975d2d8d0a40d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7194",
       "triggerID" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159244661",
       "triggerID" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "triggerType" : "PUSH"
     }, {
       "hash" : "334458afaa98b601eec12c490e71caa8274be055",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "334458afaa98b601eec12c490e71caa8274be055",
       "triggerType" : "PUSH"
     }, {
       "hash" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7212",
       "triggerID" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "triggerType" : "PUSH"
     }, {
       "hash" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159269141",
       "triggerID" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7226",
       "triggerID" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159307415",
       "triggerID" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7297",
       "triggerID" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159652918",
       "triggerID" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "559816dcea4999dd46b09ee1091ddc0e1a5a7a54",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "559816dcea4999dd46b09ee1091ddc0e1a5a7a54",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6cd76afe4990f56a5166e1592374aa8f86fe883f",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "6cd76afe4990f56a5166e1592374aa8f86fe883f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7302",
       "triggerID" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159678447",
       "triggerID" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159695914",
       "triggerID" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7305",
       "triggerID" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ac996f5c703560ecbe6cad7394cc8ad54d6f0029",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "ac996f5c703560ecbe6cad7394cc8ad54d6f0029",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7347",
       "triggerID" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159875195",
       "triggerID" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "75c8130873e9b91e21e1e833d3d05f1ad9b5d2b8",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7354",
       "triggerID" : "75c8130873e9b91e21e1e833d3d05f1ad9b5d2b8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * dee2b337e5e72d8f7b1f5098b74f2958d000fb3c UNKNOWN
   * 80b7f76f24b5fb6704a4b2292543f8764ec19053 UNKNOWN
   * 35ec088ef24e841beae78c33488975d2d8d0a40d UNKNOWN
   * 334458afaa98b601eec12c490e71caa8274be055 UNKNOWN
   * 559816dcea4999dd46b09ee1091ddc0e1a5a7a54 UNKNOWN
   * 6cd76afe4990f56a5166e1592374aa8f86fe883f UNKNOWN
   * ac996f5c703560ecbe6cad7394cc8ad54d6f0029 UNKNOWN
   * 75c8130873e9b91e21e1e833d3d05f1ad9b5d2b8 Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7354) 
   * 54a27acd416fbed48aa7876fda85036b90c641ab UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] rkhachatryan commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r408011248
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
 ##########
 @@ -206,6 +214,25 @@ void retriggerSubpartitionRequest(int subpartitionIndex) throws IOException {
 		return Optional.of(new BufferAndAvailability(next, moreAvailable, getSenderBacklog()));
 	}
 
+	@Override
+	public List<Buffer> requestInflightBuffers(long checkpointId) throws IOException {
+		synchronized (receivedBuffers) {
+			checkState(checkpointId > lastRequestedCheckpointId, "Need to request the next checkpointId");
+
+			final List<Buffer> inflightBuffers = new ArrayList<>(receivedBuffers.size());
+			for (Buffer buffer : receivedBuffers) {
+				if (!buffer.isBuffer() && parseCheckpointBarrierOrNull(buffer) != null) {
+					break;
 
 Review comment:
   Can/should we check the id of parsed checkpoint? Should it be `checkpointId + 1`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zhijiangW commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
zhijiangW commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r399085282
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
 ##########
 @@ -514,20 +532,29 @@ public void onBuffer(Buffer buffer, int sequenceNumber, int backlog) throws IOEx
 
 		try {
 
-			final boolean wasEmpty;
-			synchronized (receivedBuffers) {
-				// Similar to notifyBufferAvailable(), make sure that we never add a buffer
-				// after releaseAllResources() released all buffers from receivedBuffers
-				// (see above for details).
-				if (isReleased.get()) {
-					return;
-				}
+			// Similar to notifyBufferAvailable(), make sure that we never add a buffer
+			// after releaseAllResources() released all buffers from receivedBuffers
+			// (see above for details).
+			if (isReleased.get()) {
+				return;
+			}
 
-				if (expectedSequenceNumber != sequenceNumber) {
-					onError(new BufferReorderingException(expectedSequenceNumber, sequenceNumber));
-					return;
+			if (expectedSequenceNumber != sequenceNumber) {
+				onError(new BufferReorderingException(expectedSequenceNumber, sequenceNumber));
+				return;
+			}
+
+			if (inputGate.bufferReceivedListener != null) {
+				CheckpointBarrier checkpointBarrier = parseCheckpointBarrier(buffer);
+				if (checkpointBarrier == null) {
+					inputGate.bufferReceivedListener.notifyBufferReceived(buffer, channelInfo);
+				} else {
+					inputGate.bufferReceivedListener.notifyBarrierReceived(checkpointBarrier, channelInfo);
 				}
+			}
 
+			final boolean wasEmpty;
+			synchronized (receivedBuffers) {
 
 Review comment:
   After double checking, this change is caused by this PR change from commit "[hotfix][network] Minimizing code under lock in RemoteInputChannel."
   
   And I only reviewed the commit of  "[FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint" to see this comment before, then I did not realize it was caused by other commits.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zhijiangW commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
zhijiangW commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r400829024
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/InputGate.java
 ##########
 @@ -107,6 +107,20 @@
 		return availabilityHelper.getAvailableFuture();
 	}
 
+	/**
+	 * Returns the index of this gate in respect to the consuming operator instance.
+	 */
+	public int getGateIndex() {
+		throw new UnsupportedOperationException();
 
 Review comment:
   I guess we can remove it from `InputGate` and only implement it inside `SingleInputGate` because all the usages currently are referring to the `SingleInputGate`, e.g. in `UnionInputGate` arguments and `InputChannel` component.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r402533939
 
 

 ##########
 File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/CheckpointBarrierUnaligner.java
 ##########
 @@ -0,0 +1,338 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.streaming.runtime.io;
+
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.runtime.checkpoint.CheckpointException;
+import org.apache.flink.runtime.checkpoint.CheckpointFailureReason;
+import org.apache.flink.runtime.checkpoint.channel.ChannelStateWriter;
+import org.apache.flink.runtime.checkpoint.channel.InputChannelInfo;
+import org.apache.flink.runtime.io.network.api.CancelCheckpointMarker;
+import org.apache.flink.runtime.io.network.api.CheckpointBarrier;
+import org.apache.flink.runtime.io.network.buffer.Buffer;
+import org.apache.flink.runtime.jobgraph.tasks.AbstractInvokable;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.IOException;
+import java.util.Arrays;
+import java.util.concurrent.CompletableFuture;
+
+import static org.apache.flink.util.Preconditions.checkNotNull;
+
+/**
+ * {@link CheckpointBarrierUnaligner} is used for triggering checkpoint while reading the first barrier
+ * and keeping track of the number of received barriers and consumed barriers.
+ */
+@Internal
+public class CheckpointBarrierUnaligner extends CheckpointBarrierHandler {
+
+	private static final Logger LOG = LoggerFactory.getLogger(CheckpointBarrierUnaligner.class);
+	public static final CompletableFuture<Void> DONE = CompletableFuture.completedFuture(null);
+
+	private final String taskName;
+
+	/**
+	 * Tag the state of which input channel has read the barrier. If one channel has read the barrier by task,
+	 * the respective in-flight input buffers should be empty when triggering unaligned checkpoint.
+	 */
+	private final boolean[] barrierConsumedChannels;
+
+	/**
+	 * Tag the state of which input channel has received the barrier. Until the barrier of a specific channel is
+	 * received, all new buffers need to be persisted after unaligned checkpointing has been started.
+	 */
+	private final boolean[] barrierReceivedChannels;
+
+	/**
+	 * Contains the offsets of the channel indices for each gate when flattening the channels of all gates.
+	 *
+	 * <p>For example, consider 3 gates with 4 channels, {@code gateChannelOffsets = [0, 4, 8]}.
+	 */
+	private final int[] gateChannelOffsets;
+
+	/**
+	 * The number of input channels which has read the barrier by task.
+	 */
+	private int numBarriersReceived;
+
+	/**
+	 * The checkpoint id to guarantee that we would trigger only one checkpoint when reading the same barrier from
+	 * different channels.
+	 */
+	private long currentCheckpointId = -1L;
+
+	/** The number of opened channels. */
+	private int numOpenChannels;
+
+	/** A future indicating that all barriers of the a given checkpoint have been read. */
+	private CompletableFuture<Void> allBarriersReceivedFuture = DONE;
+
+	private final ChannelStateWriter channelStateWriter;
+
+	CheckpointBarrierUnaligner(
+			int[] numberOfInputChannelsPerGate,
+			ChannelStateWriter channelStateWriter,
+			String taskName,
+			AbstractInvokable toNotifyOnCheckpoint) {
+		super(toNotifyOnCheckpoint);
+
+		this.taskName = taskName;
+		this.channelStateWriter = checkNotNull(channelStateWriter);
+
+		final int numGates = numberOfInputChannelsPerGate.length;
+
+		gateChannelOffsets = new int[numGates];
+		for (int index = 1; index < numGates; index++) {
+			gateChannelOffsets[index] = gateChannelOffsets[index - 1] + numberOfInputChannelsPerGate[index - 1];
+		}
+
+		final int totalNumChannels = gateChannelOffsets[numGates - 1] + numberOfInputChannelsPerGate[numGates - 1];
+		barrierConsumedChannels = new boolean[totalNumChannels];
+		Arrays.fill(barrierConsumedChannels, true);
+		barrierReceivedChannels = new boolean[totalNumChannels];
+		Arrays.fill(barrierReceivedChannels, true);
+		numOpenChannels = totalNumChannels;
+	}
+
+	@Override
+	public void releaseBlocksAndResetBarriers() {
+		// make sure no additional data is persisted
+		Arrays.fill(barrierConsumedChannels, true);
 
 Review comment:
   Here, you are probably right for `barrierConsumedChannels`. I have done it to guard against `CheckpointInputGate#getInflightBuffers`, but that should happen in the same thread as `releaseBlocksAndResetBarriers`. 
   
   For `barrierReceivedChannels`, same argument as above: we are persisting data as long as it's not received. So if we are aborting, we are faking the receive. 
   
   It still feels that `Arrays.fill(barrierConsumedChannels, true);` does no harm and is more consistent.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#issuecomment-603776093
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6621",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155064201",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155877268",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6755",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6839",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156597180",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6846",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156864478",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6873",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156994047",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157330632",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6900",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157451694",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6916",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157494634",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6933",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157589655",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6944",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6991",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157754467",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158102285",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7007",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7023",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158153241",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158188400",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7040",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7048",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158276096",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "FAILURE",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158831429",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7117",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7121",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158855200",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * dee2b337e5e72d8f7b1f5098b74f2958d000fb3c UNKNOWN
   * 80b7f76f24b5fb6704a4b2292543f8764ec19053 UNKNOWN
   * a3eed025c7faad5d680ab09e83d8af2819f0048b Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/158831429) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7117) 
   * a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/158855200) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7121) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zhijiangW commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
zhijiangW commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r400831304
 
 

 ##########
 File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/CheckpointConfig.java
 ##########
 @@ -378,6 +381,48 @@ public void setPreferCheckpointForRecovery(boolean preferCheckpointForRecovery)
 		this.preferCheckpointForRecovery = preferCheckpointForRecovery;
 	}
 
+	/**
+	 * Enables unaligned checkpoints, which greatly reduce checkpointing times under backpressure.
 
 Review comment:
   nit: reduce -> reduces

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r402574161
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/serialization/SpillingAdaptiveSpanningRecordDeserializer.java
 ##########
 @@ -557,6 +579,28 @@ private void addNextChunkFromMemorySegment(MemorySegment segment, int offset, in
 			}
 		}
 
+		@Nullable
+		MemorySegment copyToTargetSegment() {
+			// for the case of only partial length, no data
+			final int position = lengthBuffer.position();
+			if (position > 0) {
+				MemorySegment segment = MemorySegmentFactory.allocateUnpooledSegment(lengthBuffer.remaining());
+				segment.put(0, lengthBuffer, lengthBuffer.remaining());
+				lengthBuffer.position(position);
+				return segment;
+			}
+
+			// for the case of full length, partial data in buffer
+			if (recordLength != -1) {
+				// In the PoC we skip the case of large record which size exceeds THRESHOLD_FOR_SPILLING,
 
 Review comment:
   What is the solution here? Have one big memory segment/buffer to store everything? Return all the record in smaller buffers?
   I fear that everything more elaborate would be hard to implement with the current ChannelStateWriter interface.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#issuecomment-603776093
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6621",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155064201",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155877268",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6755",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6839",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156597180",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6846",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156864478",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6873",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156994047",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157330632",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6900",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157451694",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6916",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157494634",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6933",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157589655",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6944",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6991",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157754467",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158102285",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7007",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7023",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158153241",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158188400",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7040",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7048",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158276096",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158831429",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7117",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7121",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158855200",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159112519",
       "triggerID" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7172",
       "triggerID" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159143719",
       "triggerID" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7175",
       "triggerID" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "triggerType" : "PUSH"
     }, {
       "hash" : "35ec088ef24e841beae78c33488975d2d8d0a40d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "35ec088ef24e841beae78c33488975d2d8d0a40d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7194",
       "triggerID" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159244661",
       "triggerID" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "triggerType" : "PUSH"
     }, {
       "hash" : "334458afaa98b601eec12c490e71caa8274be055",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "334458afaa98b601eec12c490e71caa8274be055",
       "triggerType" : "PUSH"
     }, {
       "hash" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7212",
       "triggerID" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "triggerType" : "PUSH"
     }, {
       "hash" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159269141",
       "triggerID" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7226",
       "triggerID" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159307415",
       "triggerID" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7297",
       "triggerID" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159652918",
       "triggerID" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "559816dcea4999dd46b09ee1091ddc0e1a5a7a54",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "559816dcea4999dd46b09ee1091ddc0e1a5a7a54",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6cd76afe4990f56a5166e1592374aa8f86fe883f",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "6cd76afe4990f56a5166e1592374aa8f86fe883f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7302",
       "triggerID" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159678447",
       "triggerID" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159695914",
       "triggerID" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7305",
       "triggerID" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ac996f5c703560ecbe6cad7394cc8ad54d6f0029",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "ac996f5c703560ecbe6cad7394cc8ad54d6f0029",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7347",
       "triggerID" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159875195",
       "triggerID" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "75c8130873e9b91e21e1e833d3d05f1ad9b5d2b8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7354",
       "triggerID" : "75c8130873e9b91e21e1e833d3d05f1ad9b5d2b8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7369",
       "triggerID" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "triggerType" : "PUSH"
     }, {
       "hash" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159960514",
       "triggerID" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7373",
       "triggerID" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159990549",
       "triggerID" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "triggerType" : "PUSH"
     }, {
       "hash" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7443",
       "triggerID" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160172375",
       "triggerID" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "536d9fb04a7a8142c04c94344dd0b3c0f2c10999",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160215439",
       "triggerID" : "536d9fb04a7a8142c04c94344dd0b3c0f2c10999",
       "triggerType" : "PUSH"
     }, {
       "hash" : "536d9fb04a7a8142c04c94344dd0b3c0f2c10999",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7469",
       "triggerID" : "536d9fb04a7a8142c04c94344dd0b3c0f2c10999",
       "triggerType" : "PUSH"
     }, {
       "hash" : "67018bacf5bc2daa8a03a1aafa880efc1db86808",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7500",
       "triggerID" : "67018bacf5bc2daa8a03a1aafa880efc1db86808",
       "triggerType" : "PUSH"
     }, {
       "hash" : "67018bacf5bc2daa8a03a1aafa880efc1db86808",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160347006",
       "triggerID" : "67018bacf5bc2daa8a03a1aafa880efc1db86808",
       "triggerType" : "PUSH"
     }, {
       "hash" : "79c116a6a1f5fe314f801e81f0265dea8b9ac1a7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7522",
       "triggerID" : "79c116a6a1f5fe314f801e81f0265dea8b9ac1a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "79c116a6a1f5fe314f801e81f0265dea8b9ac1a7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160377553",
       "triggerID" : "79c116a6a1f5fe314f801e81f0265dea8b9ac1a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "27ce4bfad8e99989dd64f8c636c934727da8a062",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "27ce4bfad8e99989dd64f8c636c934727da8a062",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ce0dfc7324679ebf2da84278eac8f5f59d748319",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7539",
       "triggerID" : "ce0dfc7324679ebf2da84278eac8f5f59d748319",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ce0dfc7324679ebf2da84278eac8f5f59d748319",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160418181",
       "triggerID" : "ce0dfc7324679ebf2da84278eac8f5f59d748319",
       "triggerType" : "PUSH"
     }, {
       "hash" : "05c934bf483d4fb673496783ef8ff85b40b86708",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "05c934bf483d4fb673496783ef8ff85b40b86708",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4bbe67a13a75f4491898fbb1cd2315237dbca30e",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160443829",
       "triggerID" : "4bbe67a13a75f4491898fbb1cd2315237dbca30e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4bbe67a13a75f4491898fbb1cd2315237dbca30e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7543",
       "triggerID" : "4bbe67a13a75f4491898fbb1cd2315237dbca30e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "cb5258f13c64ed033db7b8476122721ac418d798",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160496434",
       "triggerID" : "cb5258f13c64ed033db7b8476122721ac418d798",
       "triggerType" : "PUSH"
     }, {
       "hash" : "cb5258f13c64ed033db7b8476122721ac418d798",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7560",
       "triggerID" : "cb5258f13c64ed033db7b8476122721ac418d798",
       "triggerType" : "PUSH"
     }, {
       "hash" : "fdc673b8583650ce40a6f13b8a44d9773e14c370",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7597",
       "triggerID" : "fdc673b8583650ce40a6f13b8a44d9773e14c370",
       "triggerType" : "PUSH"
     }, {
       "hash" : "fdc673b8583650ce40a6f13b8a44d9773e14c370",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160543449",
       "triggerID" : "fdc673b8583650ce40a6f13b8a44d9773e14c370",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1123cc69ed817c9935bae5ffbba5e48f5bbe0f25",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7611",
       "triggerID" : "1123cc69ed817c9935bae5ffbba5e48f5bbe0f25",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1123cc69ed817c9935bae5ffbba5e48f5bbe0f25",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160619473",
       "triggerID" : "1123cc69ed817c9935bae5ffbba5e48f5bbe0f25",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dd5b4999b59b53950c2fb3784fc50ed97617f5aa",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "dd5b4999b59b53950c2fb3784fc50ed97617f5aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9e118a737919fb9c784d171ae06567030a5a9ecd",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160633665",
       "triggerID" : "9e118a737919fb9c784d171ae06567030a5a9ecd",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9e118a737919fb9c784d171ae06567030a5a9ecd",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7612",
       "triggerID" : "9e118a737919fb9c784d171ae06567030a5a9ecd",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * dee2b337e5e72d8f7b1f5098b74f2958d000fb3c UNKNOWN
   * 80b7f76f24b5fb6704a4b2292543f8764ec19053 UNKNOWN
   * 35ec088ef24e841beae78c33488975d2d8d0a40d UNKNOWN
   * 334458afaa98b601eec12c490e71caa8274be055 UNKNOWN
   * 559816dcea4999dd46b09ee1091ddc0e1a5a7a54 UNKNOWN
   * 6cd76afe4990f56a5166e1592374aa8f86fe883f UNKNOWN
   * ac996f5c703560ecbe6cad7394cc8ad54d6f0029 UNKNOWN
   * 27ce4bfad8e99989dd64f8c636c934727da8a062 UNKNOWN
   * 05c934bf483d4fb673496783ef8ff85b40b86708 UNKNOWN
   * dd5b4999b59b53950c2fb3784fc50ed97617f5aa UNKNOWN
   * 9e118a737919fb9c784d171ae06567030a5a9ecd Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/160633665) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7612) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r402526998
 
 

 ##########
 File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/CheckpointBarrierUnaligner.java
 ##########
 @@ -0,0 +1,338 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.streaming.runtime.io;
+
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.runtime.checkpoint.CheckpointException;
+import org.apache.flink.runtime.checkpoint.CheckpointFailureReason;
+import org.apache.flink.runtime.checkpoint.channel.ChannelStateWriter;
+import org.apache.flink.runtime.checkpoint.channel.InputChannelInfo;
+import org.apache.flink.runtime.io.network.api.CancelCheckpointMarker;
+import org.apache.flink.runtime.io.network.api.CheckpointBarrier;
+import org.apache.flink.runtime.io.network.buffer.Buffer;
+import org.apache.flink.runtime.jobgraph.tasks.AbstractInvokable;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.IOException;
+import java.util.Arrays;
+import java.util.concurrent.CompletableFuture;
+
+import static org.apache.flink.util.Preconditions.checkNotNull;
+
+/**
+ * {@link CheckpointBarrierUnaligner} is used for triggering checkpoint while reading the first barrier
+ * and keeping track of the number of received barriers and consumed barriers.
+ */
+@Internal
+public class CheckpointBarrierUnaligner extends CheckpointBarrierHandler {
+
+	private static final Logger LOG = LoggerFactory.getLogger(CheckpointBarrierUnaligner.class);
+	public static final CompletableFuture<Void> DONE = CompletableFuture.completedFuture(null);
+
+	private final String taskName;
+
+	/**
+	 * Tag the state of which input channel has read the barrier. If one channel has read the barrier by task,
+	 * the respective in-flight input buffers should be empty when triggering unaligned checkpoint.
+	 */
+	private final boolean[] barrierConsumedChannels;
+
+	/**
+	 * Tag the state of which input channel has received the barrier. Until the barrier of a specific channel is
+	 * received, all new buffers need to be persisted after unaligned checkpointing has been started.
+	 */
+	private final boolean[] barrierReceivedChannels;
+
+	/**
+	 * Contains the offsets of the channel indices for each gate when flattening the channels of all gates.
+	 *
+	 * <p>For example, consider 3 gates with 4 channels, {@code gateChannelOffsets = [0, 4, 8]}.
+	 */
+	private final int[] gateChannelOffsets;
+
+	/**
+	 * The number of input channels which has read the barrier by task.
+	 */
+	private int numBarriersReceived;
+
+	/**
+	 * The checkpoint id to guarantee that we would trigger only one checkpoint when reading the same barrier from
+	 * different channels.
+	 */
+	private long currentCheckpointId = -1L;
+
+	/** The number of opened channels. */
+	private int numOpenChannels;
+
+	/** A future indicating that all barriers of the a given checkpoint have been read. */
+	private CompletableFuture<Void> allBarriersReceivedFuture = DONE;
+
+	private final ChannelStateWriter channelStateWriter;
+
+	CheckpointBarrierUnaligner(
+			int[] numberOfInputChannelsPerGate,
+			ChannelStateWriter channelStateWriter,
+			String taskName,
+			AbstractInvokable toNotifyOnCheckpoint) {
+		super(toNotifyOnCheckpoint);
+
+		this.taskName = taskName;
+		this.channelStateWriter = checkNotNull(channelStateWriter);
+
+		final int numGates = numberOfInputChannelsPerGate.length;
+
+		gateChannelOffsets = new int[numGates];
+		for (int index = 1; index < numGates; index++) {
+			gateChannelOffsets[index] = gateChannelOffsets[index - 1] + numberOfInputChannelsPerGate[index - 1];
+		}
+
+		final int totalNumChannels = gateChannelOffsets[numGates - 1] + numberOfInputChannelsPerGate[numGates - 1];
+		barrierConsumedChannels = new boolean[totalNumChannels];
+		Arrays.fill(barrierConsumedChannels, true);
+		barrierReceivedChannels = new boolean[totalNumChannels];
+		Arrays.fill(barrierReceivedChannels, true);
 
 Review comment:
   Same as above: Since current checkpoint id is -1. `true` is closer to the semantics as we don't ever expect a(nother) barrier with that value to be received.
   In the case of `barrierReceivedChannels`, data is only written to the `ChannelStateWriter`, when it is false. Of course, we are now guarded with `triggerCheckpointId` in `RemoteInputChannel` against that case, but if we ever go to message handover, then this will be relevant again.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zhijiangW commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
zhijiangW commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r403724706
 
 

 ##########
 File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
 ##########
 @@ -845,21 +845,19 @@ public ExecutorService getAsyncOperationsThreadPool() {
 
 	private void notifyCheckpointComplete(long checkpointId) {
 		try {
-			boolean success = actionExecutor.call(() -> {
 
 Review comment:
   Maybe I misunderstood the scope for `actionExecutor`? I thought it is only used for executing operations for non-task/mailbox thread for unification. And I checked all the usages for `performCheckpoint`, and it seems all from task thread execution. If it is called from barrier handler via `triggerCheckpointOnBarrier`, it should be still from task thread? If so we will not need to delegate it to `actionExecutor`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r402908363
 
 

 ##########
 File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
 ##########
 @@ -1096,14 +1134,18 @@ void handleAsyncException(String message, Throwable exception) {
 		private final AtomicReference<CheckpointingOperation.AsyncCheckpointState> asyncCheckpointState = new AtomicReference<>(
 			CheckpointingOperation.AsyncCheckpointState.RUNNING);
 
+		private final Future<?> bufferPersistingFuture;
 
 Review comment:
   To add, I consider using `StateObject` in `ChannelStateWriter` to be an implementation detail.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] rkhachatryan commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r399519903
 
 

 ##########
 File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/StreamTaskNetworkInput.java
 ##########
 @@ -197,6 +205,29 @@ public int getInputIndex() {
 		return checkpointedInputGate.getAvailableFuture();
 	}
 
+	@Override
+	public CompletableFuture<?> prepareSnapshot(long checkpointId) throws IOException {
+		// Note that if considering recovery in future, we should guarantee that the spilled buffers in one channel
+		// should be close together because one record might span multiple buffers.
+		for (int channelIndex = 0; channelIndex < recordDeserializers.length; channelIndex++) {
+			final InputChannel channel = checkpointedInputGate.getChannel(channelIndex);
+
+			recordDeserializers[channelIndex].getUnconsumedBuffer().ifPresent(buffer ->
+				channelStateWriter.addInputData(
+					checkpointId,
+					channel.getChannelInfo(),
+					ChannelStateWriter.SEQUENCE_NUMBER_UNKNOWN,
+					buffer));
+
+			channelStateWriter.addInputData(
+				checkpointId,
+				channel.getChannelInfo(),
+				ChannelStateWriter.SEQUENCE_NUMBER_UNKNOWN,
+				checkpointedInputGate.getInflightBuffers(checkpointId, channelIndex).toArray(new Buffer[0]));
+		}
+		return checkpointedInputGate.getAllBarriersReceivedFuture(checkpointId);
+	}
+
 	@Override
 	public void close() throws IOException {
 
 Review comment:
   You're right. What about `completeExceptionally`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#issuecomment-603776093
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6621",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155064201",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155877268",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6755",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6839",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "FAILURE",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156597180",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 2a84fd2fe1659cab80b711384febf50669561257 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/156597180) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6839) 
   * 9a496a27a92e242519764b935012e44adade76a1 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zhijiangW commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
zhijiangW commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r400638771
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartition.java
 ##########
 @@ -83,24 +86,45 @@
 	/** The total number of bytes (both data and event buffers). */
 	private long totalNumberOfBytes;
 
+	/** The collection of buffers which are spanned over by checkpoint barrier and needs to be persisted for snapshot. */
+	private final List<Buffer> inflightBufferSnapshot = new ArrayList<>();
+
 	// ------------------------------------------------------------------------
 
 	PipelinedSubpartition(int index, ResultPartition parent) {
 		super(index, parent);
 	}
 
 	@Override
-	public boolean add(BufferConsumer bufferConsumer) {
-		return add(bufferConsumer, false);
+	public boolean add(BufferConsumer bufferConsumer) throws IOException {
+		return add(bufferConsumer, false, false);
 	}
 
 	@Override
 	public void finish() throws IOException {
-		add(EventSerializer.toBufferConsumer(EndOfPartitionEvent.INSTANCE), true);
+		add(EventSerializer.toBufferConsumer(EndOfPartitionEvent.INSTANCE), true, false);
 		LOG.debug("{}: Finished {}.", parent.getOwningTaskName(), this);
 	}
 
-	private boolean add(BufferConsumer bufferConsumer, boolean finish) {
+	@Override
+	public EnqueueAction priorityEvent(AbstractEvent event, BufferConsumer eventBufferConsumer) throws IOException {
+		if (readView != null) {
+			switch (readView.priorityEvent(event, eventBufferConsumer)) {
+				case ENQUEUE_AS_FIRST_BUFFER:
+					add(eventBufferConsumer.copy(), false, true);
+					break;
+				case ENQUEUE_AS_LAST_BUFFER:
+					add(eventBufferConsumer.copy(), false, false);
+					break;
+			}
+		} else {
+			buffers.add(eventBufferConsumer.copy());
 
 Review comment:
   If the current view is null, maybe it is also worth inserting the barrier into head, because the view might be established soon after inserting. Or are there any considerations for making the difference based on the view status?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r407253251
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartition.java
 ##########
 @@ -114,13 +119,25 @@ public boolean add(BufferConsumer bufferConsumer) {
 		return add(bufferConsumer, false);
 	}
 
+	@Override
+	public boolean add(BufferConsumer bufferConsumer, boolean isPriorityEvent) {
 
 Review comment:
   Added tests for subpartition in this commit.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] pnowojski commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
pnowojski commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r405587339
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/UnionInputGate.java
 ##########
 @@ -77,37 +77,34 @@
 	 */
 	private final LinkedHashSet<InputGate> inputGatesWithData = new LinkedHashSet<>();
 
-	/** The total number of input channels across all unioned input gates. */
-	private final int totalNumberOfInputChannels;
+	/** Input channels across all unioned input gates. */
+	private final InputChannel[] inputChannels;
 
 	/**
 	 * A mapping from input gate to (logical) channel index offset. Valid channel indexes go from 0
 	 * (inclusive) to the total number of input channels (exclusive).
 	 */
-	private final Map<InputGate, Integer> inputGateToIndexOffsetMap;
+	private final int[] inputGateChannelIndexOffsets;
 
 	public UnionInputGate(InputGate... inputGates) {
 		this.inputGates = checkNotNull(inputGates);
 		checkArgument(inputGates.length > 1, "Union input gate should union at least two input gates.");
 
-		this.inputGateToIndexOffsetMap = Maps.newHashMapWithExpectedSize(inputGates.length);
 		this.inputGatesWithRemainingData = Sets.newHashSetWithExpectedSize(inputGates.length);
 
+		final int maxGateIndex = Arrays.stream(inputGates).mapToInt(InputGate::getGateIndex).max().orElse(0);
 
 Review comment:
   From the `UnionInputGate` java doc:
   >  * <strong>It is NOT possible to recursively union union input gates.</strong>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#issuecomment-603776093
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6621",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155064201",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155877268",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6755",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6839",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156597180",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6846",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156864478",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6873",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156994047",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157330632",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6900",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157451694",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6916",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157494634",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6933",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157589655",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6944",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6991",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157754467",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158102285",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7007",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7023",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158153241",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158188400",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7040",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7048",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158276096",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158831429",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7117",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7121",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158855200",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "status" : "FAILURE",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159112519",
       "triggerID" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7172",
       "triggerID" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * dee2b337e5e72d8f7b1f5098b74f2958d000fb3c UNKNOWN
   * 80b7f76f24b5fb6704a4b2292543f8764ec19053 UNKNOWN
   * f1c7ddec67cf96365c63ff93d1ed4353b478eba4 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/159112519) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7172) 
   * 2c9926f618130a7d268ac2784fbb5e956e488088 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r408162902
 
 

 ##########
 File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/CheckpointedInputGate.java
 ##########
 @@ -171,6 +176,18 @@ else if (bufferOrEvent.getEvent().getClass() == CancelCheckpointMarker.class) {
 		}
 	}
 
+	public List<Buffer> requestInflightBuffers(long checkpointId, int channelIndex) throws IOException {
+		if (((CheckpointBarrierUnaligner) barrierHandler).hasInflightData(checkpointId, channelIndex)) {
+			return inputGate.getChannel(channelIndex).requestInflightBuffers(checkpointId);
 
 Review comment:
   When a barrier is received in the input channel, it triggers the notify, but is also added at the tail of the queue in its in-order position.
   `hasInflightData` is only updated to `false` in `Unaligner#processBarrier` when task thread pulls the barrier from its in-order position. That means, that `hasInflightData` can only be false iff `X` has been consumed in the meantime.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#issuecomment-603776093
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6621",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155064201",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155877268",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6755",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6839",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156597180",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6846",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156864478",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6873",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156994047",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157330632",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6900",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157451694",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6916",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "FAILURE",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157494634",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6933",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * dee2b337e5e72d8f7b1f5098b74f2958d000fb3c UNKNOWN
   * 80b7f76f24b5fb6704a4b2292543f8764ec19053 UNKNOWN
   * 734812c326634e1fd0da63465dcfbffa53cff792 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/157494634) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6933) 
   * 707cb2dc5af184ebd495d7381d8e4e944436b936 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#issuecomment-603776093
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6621",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155064201",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155877268",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6755",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6839",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156597180",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6846",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156864478",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6873",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156994047",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157330632",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6900",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157451694",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6916",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157494634",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6933",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157589655",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6944",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6991",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157754467",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158102285",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7007",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7023",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158153241",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158188400",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7040",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7048",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158276096",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158831429",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7117",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7121",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158855200",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159112519",
       "triggerID" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7172",
       "triggerID" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159143719",
       "triggerID" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7175",
       "triggerID" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "triggerType" : "PUSH"
     }, {
       "hash" : "35ec088ef24e841beae78c33488975d2d8d0a40d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "35ec088ef24e841beae78c33488975d2d8d0a40d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7194",
       "triggerID" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159244661",
       "triggerID" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "triggerType" : "PUSH"
     }, {
       "hash" : "334458afaa98b601eec12c490e71caa8274be055",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "334458afaa98b601eec12c490e71caa8274be055",
       "triggerType" : "PUSH"
     }, {
       "hash" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7212",
       "triggerID" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "triggerType" : "PUSH"
     }, {
       "hash" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159269141",
       "triggerID" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7226",
       "triggerID" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159307415",
       "triggerID" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7297",
       "triggerID" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159652918",
       "triggerID" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "559816dcea4999dd46b09ee1091ddc0e1a5a7a54",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "559816dcea4999dd46b09ee1091ddc0e1a5a7a54",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6cd76afe4990f56a5166e1592374aa8f86fe883f",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "6cd76afe4990f56a5166e1592374aa8f86fe883f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7302",
       "triggerID" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159678447",
       "triggerID" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159695914",
       "triggerID" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7305",
       "triggerID" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ac996f5c703560ecbe6cad7394cc8ad54d6f0029",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "ac996f5c703560ecbe6cad7394cc8ad54d6f0029",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7347",
       "triggerID" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159875195",
       "triggerID" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "75c8130873e9b91e21e1e833d3d05f1ad9b5d2b8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7354",
       "triggerID" : "75c8130873e9b91e21e1e833d3d05f1ad9b5d2b8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7369",
       "triggerID" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "triggerType" : "PUSH"
     }, {
       "hash" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159960514",
       "triggerID" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7373",
       "triggerID" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159990549",
       "triggerID" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "triggerType" : "PUSH"
     }, {
       "hash" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7443",
       "triggerID" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160172375",
       "triggerID" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "536d9fb04a7a8142c04c94344dd0b3c0f2c10999",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160215439",
       "triggerID" : "536d9fb04a7a8142c04c94344dd0b3c0f2c10999",
       "triggerType" : "PUSH"
     }, {
       "hash" : "536d9fb04a7a8142c04c94344dd0b3c0f2c10999",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7469",
       "triggerID" : "536d9fb04a7a8142c04c94344dd0b3c0f2c10999",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * dee2b337e5e72d8f7b1f5098b74f2958d000fb3c UNKNOWN
   * 80b7f76f24b5fb6704a4b2292543f8764ec19053 UNKNOWN
   * 35ec088ef24e841beae78c33488975d2d8d0a40d UNKNOWN
   * 334458afaa98b601eec12c490e71caa8274be055 UNKNOWN
   * 559816dcea4999dd46b09ee1091ddc0e1a5a7a54 UNKNOWN
   * 6cd76afe4990f56a5166e1592374aa8f86fe883f UNKNOWN
   * ac996f5c703560ecbe6cad7394cc8ad54d6f0029 UNKNOWN
   * 11d69a1fed933cd4894f84e429d91e9b965d121b Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/160172375) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7443) 
   * 536d9fb04a7a8142c04c94344dd0b3c0f2c10999 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/160215439) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7469) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zhijiangW commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
zhijiangW commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r400781265
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/InputChannel.java
 ##########
 @@ -108,12 +102,17 @@ protected InputChannel(
 	// Properties
 	// ------------------------------------------------------------------------
 
-	int getChannelIndex() {
-		return channelIndex;
+	/**
+	 * Returns the index of this channel within its {@link InputGate}.
 
 Review comment:
   nit: `{@link SingleInputGate}` probably seems more accurate. For `{@link InputGate}` we actually also have `UnionInputGate` instance.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zhijiangW commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
zhijiangW commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r400257995
 
 

 ##########
 File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/CheckpointBarrierUnaligner.java
 ##########
 @@ -0,0 +1,338 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.streaming.runtime.io;
+
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.runtime.checkpoint.CheckpointException;
+import org.apache.flink.runtime.checkpoint.CheckpointFailureReason;
+import org.apache.flink.runtime.checkpoint.channel.ChannelStateWriter;
+import org.apache.flink.runtime.checkpoint.channel.InputChannelInfo;
+import org.apache.flink.runtime.io.network.api.CancelCheckpointMarker;
+import org.apache.flink.runtime.io.network.api.CheckpointBarrier;
+import org.apache.flink.runtime.io.network.buffer.Buffer;
+import org.apache.flink.runtime.jobgraph.tasks.AbstractInvokable;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.IOException;
+import java.util.Arrays;
+import java.util.concurrent.CompletableFuture;
+
+import static org.apache.flink.util.Preconditions.checkNotNull;
+
+/**
+ * {@link CheckpointBarrierUnaligner} is used for triggering checkpoint while reading the first barrier
+ * and keeping track of the number of received barriers and consumed barriers.
+ */
+@Internal
+public class CheckpointBarrierUnaligner extends CheckpointBarrierHandler {
+
+	private static final Logger LOG = LoggerFactory.getLogger(CheckpointBarrierUnaligner.class);
+	public static final CompletableFuture<Void> DONE = CompletableFuture.completedFuture(null);
+
+	private final String taskName;
+
+	/**
+	 * Tag the state of which input channel has read the barrier. If one channel has read the barrier by task,
+	 * the respective in-flight input buffers should be empty when triggering unaligned checkpoint.
+	 */
+	private final boolean[] barrierConsumedChannels;
+
+	/**
+	 * Tag the state of which input channel has received the barrier. Until the barrier of a specific channel is
+	 * received, all new buffers need to be persisted after unaligned checkpointing has been started.
+	 */
+	private final boolean[] barrierReceivedChannels;
+
+	/**
+	 * Contains the offsets of the channel indices for each gate when flattening the channels of all gates.
+	 *
+	 * <p>For example, consider 3 gates with 4 channels, {@code gateChannelOffsets = [0, 4, 8]}.
+	 */
+	private final int[] gateChannelOffsets;
+
+	/**
+	 * The number of input channels which has read the barrier by task.
+	 */
+	private int numBarriersReceived;
+
+	/**
+	 * The checkpoint id to guarantee that we would trigger only one checkpoint when reading the same barrier from
+	 * different channels.
+	 */
+	private long currentCheckpointId = -1L;
+
+	/** The number of opened channels. */
+	private int numOpenChannels;
+
+	/** A future indicating that all barriers of the a given checkpoint have been read. */
+	private CompletableFuture<Void> allBarriersReceivedFuture = DONE;
+
+	private final ChannelStateWriter channelStateWriter;
+
+	CheckpointBarrierUnaligner(
+			int[] numberOfInputChannelsPerGate,
+			ChannelStateWriter channelStateWriter,
+			String taskName,
+			AbstractInvokable toNotifyOnCheckpoint) {
+		super(toNotifyOnCheckpoint);
+
+		this.taskName = taskName;
+		this.channelStateWriter = checkNotNull(channelStateWriter);
+
+		final int numGates = numberOfInputChannelsPerGate.length;
+
+		gateChannelOffsets = new int[numGates];
+		for (int index = 1; index < numGates; index++) {
+			gateChannelOffsets[index] = gateChannelOffsets[index - 1] + numberOfInputChannelsPerGate[index - 1];
+		}
+
+		final int totalNumChannels = gateChannelOffsets[numGates - 1] + numberOfInputChannelsPerGate[numGates - 1];
+		barrierConsumedChannels = new boolean[totalNumChannels];
+		Arrays.fill(barrierConsumedChannels, true);
+		barrierReceivedChannels = new boolean[totalNumChannels];
+		Arrays.fill(barrierReceivedChannels, true);
+		numOpenChannels = totalNumChannels;
+	}
+
+	@Override
+	public void releaseBlocksAndResetBarriers() {
+		// make sure no additional data is persisted
+		Arrays.fill(barrierConsumedChannels, true);
 
 Review comment:
   should be reset false for both `barrierConsumedChannels` and `barrierReceivedChannels` by variable semantics.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zhijiangW commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
zhijiangW commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r399074486
 
 

 ##########
 File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/InputProcessorUtil.java
 ##########
 @@ -93,6 +97,12 @@ public static CheckpointedInputGate createCheckpointedInputGate(
 			toNotifyOnCheckpoint);
 		registerCheckpointMetrics(taskIOMetricGroup, barrierHandler);
 
+		if (config.isUnalignedCheckpointsEnabled()) {
 
 Review comment:
   Maybe extract a common method `registerBufferReceivedListener(StreamConfig config, BufferReceivedListener listener, InputGate ...inputGates)` for duplicating two places.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] rkhachatryan commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r398951005
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/SingleInputGate.java
 ##########
 @@ -245,6 +257,11 @@ void requestPartitions() throws IOException, InterruptedException {
 		}
 	}
 
+	@Override
+	public void registerBufferReceivedListener(BufferReceivedListener bufferReceivedListener) {
+		this.bufferReceivedListener = checkNotNull(bufferReceivedListener);
 
 Review comment:
   I'd disallow to overwrite the current listener.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#issuecomment-603776093
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6621",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155064201",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "FAILURE",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155877268",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6755",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c45c6a352fc2f7760dcf942a75728d4d1f1777a7 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/155877268) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6755) 
   * 2a84fd2fe1659cab80b711384febf50669561257 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r402521814
 
 

 ##########
 File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/CheckpointBarrierUnaligner.java
 ##########
 @@ -0,0 +1,245 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.streaming.runtime.io;
+
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.runtime.checkpoint.channel.ChannelStateWriter;
+import org.apache.flink.runtime.checkpoint.channel.InputChannelInfo;
+import org.apache.flink.runtime.io.network.api.CancelCheckpointMarker;
+import org.apache.flink.runtime.io.network.api.CheckpointBarrier;
+import org.apache.flink.runtime.io.network.buffer.Buffer;
+import org.apache.flink.runtime.jobgraph.tasks.AbstractInvokable;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.util.Arrays;
+import java.util.concurrent.CompletableFuture;
+import java.util.concurrent.atomic.AtomicBoolean;
+
+import static org.apache.flink.util.Preconditions.checkNotNull;
+
+/**
+ * {@link CheckpointBarrierUnaligner} is used for triggering checkpoint while reading the first barrier
+ * and keeping track of the number of received barriers and consumed barriers.
+ */
+@Internal
+public class CheckpointBarrierUnaligner extends CheckpointBarrierHandler {
+
+	private static final Logger LOG = LoggerFactory.getLogger(CheckpointBarrierUnaligner.class);
+
+	private final String taskName;
+
+	/**
+	 * Tag the state of which input channel has read the barrier. If one channel has read the barrier by task,
+	 * the respective in-flight input buffers should be empty when triggering unaligned checkpoint.
+	 */
+	private final AtomicBoolean[] barrierConsumedChannels;
+
+	/**
+	 * Tag the state of which input channel has received the barrier. Until the barrier of a specific channel is
+	 * received, all new buffers need to be persisted after unaligned checkpointing has been started.
+	 */
+	private final boolean[] barrierReceivedChannels;
+
+	/**
+	 * Contains the offsets of the channel indices for each gate when flattening the channels of all gates.
+	 *
+	 * <p>For example, consider 3 gates with 4 channels, {@code gateChannelOffsets = [0, 4, 8]}.
+	 */
+	private final int[] gateChannelOffsets;
+
+	/**
+	 * The number of input channels which has read the barrier by task.
+	 */
+	private int numBarriersReceived;
+
+	/**
+	 * The checkpoint id to guarantee that we would trigger only one checkpoint when reading the same barrier from
+	 * different channels.
+	 */
+	private long currentCheckpointId = -1L;
+
+	private volatile long currentVolatileCheckpointId = -1L;
+
+	private final ChannelStateWriter channelStateWriter;
+
+	private CompletableFuture<Void> allBarriersReceivedFuture;
+
+	CheckpointBarrierUnaligner(
+			int[] numberOfInputChannelsPerGate,
+			ChannelStateWriter channelStateWriter,
+			String taskName,
+			AbstractInvokable toNotifyOnCheckpoint) {
+		super(toNotifyOnCheckpoint);
+
+		this.taskName = taskName;
+		this.channelStateWriter = checkNotNull(channelStateWriter);
+
+		final int numGates = numberOfInputChannelsPerGate.length;
+
+		gateChannelOffsets = new int[numGates];
+		for (int index = 1; index < numGates; index++) {
+			gateChannelOffsets[index] = gateChannelOffsets[index - 1] + numberOfInputChannelsPerGate[index - 1];
+		}
+
+		final int totalNumChannels = gateChannelOffsets[numGates - 1] + numberOfInputChannelsPerGate[numGates - 1];
+		barrierConsumedChannels = new AtomicBoolean[totalNumChannels];
+		for (int index = 0; index < barrierConsumedChannels.length; index++) {
+			barrierConsumedChannels[index] = new AtomicBoolean(true);
+		}
+		barrierReceivedChannels = new boolean[totalNumChannels];
+		Arrays.fill(barrierReceivedChannels, true);
+	}
+
+	@Override
+	public void releaseBlocksAndResetBarriers() {
+	}
+
+	/**
+	 * For unaligned checkpoint, it never blocks processing from the task aspect.
+	 *
+	 * <p>For PoC, we do not consider the possibility that the unaligned checkpoint would
+	 * not perform due to the max configured unaligned checkpoint size.
+	 */
+	@Override
+	public boolean isBlocked(int channelIndex) {
+		return false;
+	}
+
+	/**
+	 * We still need to trigger checkpoint while reading the first barrier from one channel, because this might happen
+	 * earlier than the previous async trigger via mailbox by netty thread. And the {@link AbstractInvokable} has the
+	 * deduplication logic to guarantee trigger checkpoint only once finally.
+	 *
+	 * <p>Note this is also suitable for the trigger case of local input channel.
+	 */
+	@Override
+	public synchronized boolean processBarrier(
+			CheckpointBarrier receivedBarrier,
+			int channelIndex,
+			long bufferedBytes) {
+		long barrierId = receivedBarrier.getId();
+		if (currentCheckpointId < barrierId) {
+			handleNewCheckpoint(barrierId);
+			notifyCheckpointAsync(receivedBarrier, bufferedBytes, 0);
+		}
+		barrierConsumedChannels[channelIndex].set(true);
+		return false;
+	}
+
+	@Override
+	public boolean processCancellationBarrier(CancelCheckpointMarker cancelBarrier) {
+		return false;
+	}
+
+	@Override
+	public boolean processEndOfPartition() {
+		return false;
+	}
+
+	@Override
+	public long getLatestCheckpointId() {
+		return currentCheckpointId;
+	}
+
+	@Override
+	public long getAlignmentDurationNanos() {
+		return 0;
+	}
+
+	@Override
+	public String toString() {
+		return String.format("%s: last checkpoint: %d", taskName, currentCheckpointId);
+	}
+
+	@Override
+	public void checkpointSizeLimitExceeded(long maxBufferedBytes) {
+	}
+
+	@Override
+	protected boolean isBarrierConsumed(long checkpointId, int channelIndex) {
+		if (checkpointId < currentVolatileCheckpointId) {
+			return true;
+		}
+		if (checkpointId > currentVolatileCheckpointId) {
 
 Review comment:
   You are right about the version that you reviewed. 
   Now with the later refactoring, this case is possible however. Checkpoint is triggered over netty thread, but no barrier has been consumed in task thread (such that `return false` is sound).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r404299271
 
 

 ##########
 File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
 ##########
 @@ -845,21 +845,19 @@ public ExecutorService getAsyncOperationsThreadPool() {
 
 	private void notifyCheckpointComplete(long checkpointId) {
 		try {
-			boolean success = actionExecutor.call(() -> {
 
 Review comment:
   `actionExecutor` was added during checkpoint lock deprecation to unify `SourceStreamTask` and `StreamTask`. 
   Basically, under `StreamTask` it's a no-op operation going through `StreamTaskActionExecutor.IMMEDIATE`, while `SourceStreamTask` is using `StreamTaskActionExecutor#SynchronizedStreamTaskActionExecutor`, which acquires checkpoint lock for all operations.
   I agree that the naming and the tight integration into the `MailboxExecutor` makes it hard to understand at first. Luckily, we can get rid of it, once FLIP-27 is fully implemented and we can get rid of legacy source thread (so in about 3 years? ;)).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] pnowojski commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
pnowojski commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r399252660
 
 

 ##########
 File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/InputProcessorUtil.java
 ##########
 @@ -54,6 +54,10 @@ public static CheckpointedInputGate createCheckpointedInputGate(
 			config, inputGate.getNumberOfInputChannels(), taskName, toNotifyOnCheckpoint);
 		registerCheckpointMetrics(taskIOMetricGroup, barrierHandler);
 
+		if (config.isUnalignedCheckpointsEnabled()) {
+			inputGate.registerBufferReceivedListener(barrierHandler);
+		}
 
 Review comment:
   nit: We could always register the listener, but aligned handler could be just ignoring the calls. It would make more OO design. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#issuecomment-603776093
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6621",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155064201",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155877268",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6755",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6839",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156597180",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6846",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156864478",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6873",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156994047",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157330632",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6900",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157451694",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6916",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157494634",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6933",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "FAILURE",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157589655",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6944",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * dee2b337e5e72d8f7b1f5098b74f2958d000fb3c UNKNOWN
   * 80b7f76f24b5fb6704a4b2292543f8764ec19053 UNKNOWN
   * 707cb2dc5af184ebd495d7381d8e4e944436b936 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/157589655) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6944) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zhijiangW commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
zhijiangW commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r400257578
 
 

 ##########
 File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/CheckpointBarrierUnaligner.java
 ##########
 @@ -0,0 +1,338 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.streaming.runtime.io;
+
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.runtime.checkpoint.CheckpointException;
+import org.apache.flink.runtime.checkpoint.CheckpointFailureReason;
+import org.apache.flink.runtime.checkpoint.channel.ChannelStateWriter;
+import org.apache.flink.runtime.checkpoint.channel.InputChannelInfo;
+import org.apache.flink.runtime.io.network.api.CancelCheckpointMarker;
+import org.apache.flink.runtime.io.network.api.CheckpointBarrier;
+import org.apache.flink.runtime.io.network.buffer.Buffer;
+import org.apache.flink.runtime.jobgraph.tasks.AbstractInvokable;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.IOException;
+import java.util.Arrays;
+import java.util.concurrent.CompletableFuture;
+
+import static org.apache.flink.util.Preconditions.checkNotNull;
+
+/**
+ * {@link CheckpointBarrierUnaligner} is used for triggering checkpoint while reading the first barrier
+ * and keeping track of the number of received barriers and consumed barriers.
+ */
+@Internal
+public class CheckpointBarrierUnaligner extends CheckpointBarrierHandler {
+
+	private static final Logger LOG = LoggerFactory.getLogger(CheckpointBarrierUnaligner.class);
+	public static final CompletableFuture<Void> DONE = CompletableFuture.completedFuture(null);
+
+	private final String taskName;
+
+	/**
+	 * Tag the state of which input channel has read the barrier. If one channel has read the barrier by task,
+	 * the respective in-flight input buffers should be empty when triggering unaligned checkpoint.
+	 */
+	private final boolean[] barrierConsumedChannels;
+
+	/**
+	 * Tag the state of which input channel has received the barrier. Until the barrier of a specific channel is
+	 * received, all new buffers need to be persisted after unaligned checkpointing has been started.
+	 */
+	private final boolean[] barrierReceivedChannels;
+
+	/**
+	 * Contains the offsets of the channel indices for each gate when flattening the channels of all gates.
+	 *
+	 * <p>For example, consider 3 gates with 4 channels, {@code gateChannelOffsets = [0, 4, 8]}.
+	 */
+	private final int[] gateChannelOffsets;
+
+	/**
+	 * The number of input channels which has read the barrier by task.
+	 */
+	private int numBarriersReceived;
+
+	/**
+	 * The checkpoint id to guarantee that we would trigger only one checkpoint when reading the same barrier from
+	 * different channels.
+	 */
+	private long currentCheckpointId = -1L;
+
+	/** The number of opened channels. */
+	private int numOpenChannels;
+
+	/** A future indicating that all barriers of the a given checkpoint have been read. */
+	private CompletableFuture<Void> allBarriersReceivedFuture = DONE;
+
+	private final ChannelStateWriter channelStateWriter;
+
+	CheckpointBarrierUnaligner(
+			int[] numberOfInputChannelsPerGate,
+			ChannelStateWriter channelStateWriter,
+			String taskName,
+			AbstractInvokable toNotifyOnCheckpoint) {
+		super(toNotifyOnCheckpoint);
+
+		this.taskName = taskName;
+		this.channelStateWriter = checkNotNull(channelStateWriter);
+
+		final int numGates = numberOfInputChannelsPerGate.length;
+
+		gateChannelOffsets = new int[numGates];
+		for (int index = 1; index < numGates; index++) {
+			gateChannelOffsets[index] = gateChannelOffsets[index - 1] + numberOfInputChannelsPerGate[index - 1];
+		}
+
+		final int totalNumChannels = gateChannelOffsets[numGates - 1] + numberOfInputChannelsPerGate[numGates - 1];
+		barrierConsumedChannels = new boolean[totalNumChannels];
+		Arrays.fill(barrierConsumedChannels, true);
+		barrierReceivedChannels = new boolean[totalNumChannels];
+		Arrays.fill(barrierReceivedChannels, true);
 
 Review comment:
   Also default false for `barrierReceivedChannels`, because we have not received any barriers from channel after startup.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] rkhachatryan commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r404917344
 
 

 ##########
 File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/CheckpointBarrierUnaligner.java
 ##########
 @@ -0,0 +1,417 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.streaming.runtime.io;
+
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.runtime.checkpoint.CheckpointException;
+import org.apache.flink.runtime.checkpoint.CheckpointFailureReason;
+import org.apache.flink.runtime.checkpoint.channel.ChannelStateWriter;
+import org.apache.flink.runtime.checkpoint.channel.InputChannelInfo;
+import org.apache.flink.runtime.concurrent.FutureUtils;
+import org.apache.flink.runtime.io.network.api.CancelCheckpointMarker;
+import org.apache.flink.runtime.io.network.api.CheckpointBarrier;
+import org.apache.flink.runtime.io.network.buffer.Buffer;
+import org.apache.flink.runtime.io.network.buffer.BufferReceivedListener;
+import org.apache.flink.runtime.jobgraph.tasks.AbstractInvokable;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.Closeable;
+import java.io.IOException;
+import java.util.Arrays;
+import java.util.Optional;
+import java.util.concurrent.CompletableFuture;
+import java.util.function.Function;
+import java.util.stream.IntStream;
+
+import static org.apache.flink.util.Preconditions.checkNotNull;
+
+/**
+ * {@link CheckpointBarrierUnaligner} is used for triggering checkpoint while reading the first barrier
+ * and keeping track of the number of received barriers and consumed barriers.
+ */
+@Internal
+public class CheckpointBarrierUnaligner extends CheckpointBarrierHandler {
+
+	private static final Logger LOG = LoggerFactory.getLogger(CheckpointBarrierUnaligner.class);
+
+	private final String taskName;
+
+	/**
+	 * Tag the state of which input channel has read the barrier. If one channel has read the barrier by task,
+	 * the respective in-flight input buffers should be empty when triggering unaligned checkpoint.
+	 */
+	private final boolean[] barrierConsumedChannels;
+
+	private int numBarrierConsumed;
+
+	/**
+	 * Contains the offsets of the channel indices for each gate when flattening the channels of all gates.
+	 *
+	 * <p>For example, consider 3 gates with 4 channels, {@code gateChannelOffsets = [0, 4, 8]}.
+	 */
+	private final int[] gateChannelOffsets;
+
+	private final InputChannelInfo[] channelInfos;
+
+	/**
+	 * The checkpoint id to guarantee that we would trigger only one checkpoint when reading the same barrier from
+	 * different channels.
+	 *
+	 * <p>Note: this checkpoint is valid in respect to <b>consumed</b> barriers in contrast to
+	 * {@link ThreadSafeUnaligner#currentCheckpointId}.
+	 */
+	private long currentCheckpointId = -1L;
+
+	/** Encapsulates state that is shared between netty threads and task thread. */
+	private final ThreadSafeUnaligner threadSafeUnaligner;
+
+	CheckpointBarrierUnaligner(
+			int[] numberOfInputChannelsPerGate,
+			ChannelStateWriter channelStateWriter,
+			String taskName,
+			AbstractInvokable toNotifyOnCheckpoint) {
+		super(toNotifyOnCheckpoint);
+
+		this.taskName = taskName;
+
+		final int numGates = numberOfInputChannelsPerGate.length;
+
+		gateChannelOffsets = new int[numGates];
+		for (int index = 1; index < numGates; index++) {
+			gateChannelOffsets[index] = gateChannelOffsets[index - 1] + numberOfInputChannelsPerGate[index - 1];
+		}
+
+		final int totalNumChannels = gateChannelOffsets[numGates - 1] + numberOfInputChannelsPerGate[numGates - 1];
+		barrierConsumedChannels = new boolean[totalNumChannels];
+		Arrays.fill(barrierConsumedChannels, true);
+
+		channelInfos = IntStream.range(0, numGates)
+			.mapToObj(gateIndex -> IntStream.range(0, numberOfInputChannelsPerGate[gateIndex])
+				.mapToObj(channelIndex -> new InputChannelInfo(gateIndex, channelIndex)))
+			.flatMap(Function.identity())
+			.toArray(InputChannelInfo[]::new);
+
+		threadSafeUnaligner = new ThreadSafeUnaligner(totalNumChannels,	checkNotNull(channelStateWriter), this);
+	}
+
+	@Override
+	public void releaseBlocksAndResetBarriers() {
+		// make sure no additional data is persisted
+		Arrays.fill(barrierConsumedChannels, true);
+		// the next barrier that comes must assume it is the first
+		numBarrierConsumed = 0;
+		threadSafeUnaligner.releaseBlocksAndResetBarriers();
+	}
+
+	/**
+	 * For unaligned checkpoint, it never blocks processing from the task aspect.
+	 *
+	 * <p>For PoC, we do not consider the possibility that the unaligned checkpoint would
+	 * not perform due to the max configured unaligned checkpoint size.
+	 */
+	@Override
+	public boolean isBlocked(int channelIndex) {
+		return false;
+	}
+
+	/**
+	 * We still need to trigger checkpoint while reading the first barrier from one channel, because this might happen
+	 * earlier than the previous async trigger via mailbox by netty thread. And the {@link AbstractInvokable} has the
+	 * deduplication logic to guarantee trigger checkpoint only once finally.
+	 *
+	 * <p>Note this is also suitable for the trigger case of local input channel.
+	 */
+	@Override
+	public boolean processBarrier(
+			CheckpointBarrier receivedBarrier,
+			int channelIndex,
+			long bufferedBytes) throws IOException {
+		long barrierId = receivedBarrier.getId();
+		if (currentCheckpointId < barrierId) {
+			currentCheckpointId = barrierId;
+			numBarrierConsumed = 0;
+			Arrays.fill(barrierConsumedChannels, false);
+		}
+		if (currentCheckpointId == barrierId) {
+			barrierConsumedChannels[channelIndex] = true;
+			numBarrierConsumed++;
+		}
+		// processBarrier is called from task thread and can actually happen before notifyBarrierReceived on empty
+		// buffer queues
+		// to avoid replicating any logic, we simply call notifyBarrierReceived here as well
+		threadSafeUnaligner.notifyBarrierReceived(receivedBarrier, channelInfos[channelIndex]);
+		return false;
+	}
+
+	@Override
+	public boolean processCancellationBarrier(CancelCheckpointMarker cancelBarrier) throws Exception {
+		final long barrierId = cancelBarrier.getCheckpointId();
+
+		if (numBarrierConsumed > 0) {
+			// this is only true if some alignment is in progress and nothing was canceled
+
+			if (barrierId == currentCheckpointId) {
+				// cancel this alignment
+				if (LOG.isDebugEnabled()) {
+					LOG.debug("{}: Checkpoint {} canceled, aborting alignment.", taskName, barrierId);
+				}
+
+				releaseBlocksAndResetBarriers();
+				notifyAbortOnCancellationBarrier(barrierId);
+			}
+			else if (barrierId > currentCheckpointId) {
+				// we canceled the next which also cancels the current
+				LOG.warn("{}: Received cancellation barrier for checkpoint {} before completing current checkpoint {}. " +
+						"Skipping current checkpoint.",
+					taskName,
+					barrierId,
+					currentCheckpointId);
+
+				// this stops the current alignment
+				releaseBlocksAndResetBarriers();
+
+				// the next checkpoint starts as canceled
+				currentCheckpointId = barrierId;
+				threadSafeUnaligner.setCurrentCheckpointId(currentCheckpointId);
+				notifyAbortOnCancellationBarrier(barrierId);
+			}
+
+			// else: ignore trailing (cancellation) barrier from an earlier checkpoint (obsolete now)
+
+		}
+		else if (barrierId > currentCheckpointId) {
+			// first barrier of a new checkpoint is directly a cancellation
+
+			// by setting the currentCheckpointId to this checkpoint while keeping the numBarriers
+			// at zero means that no checkpoint barrier can start a new alignment
+			currentCheckpointId = barrierId;
+			threadSafeUnaligner.setCurrentCheckpointId(currentCheckpointId);
+
+			if (LOG.isDebugEnabled()) {
+				LOG.debug("{}: Checkpoint {} canceled, skipping alignment.", taskName, barrierId);
+			}
+
+			notifyAbortOnCancellationBarrier(barrierId);
+		}
+
+		// else: trailing barrier from either
+		//   - a previous (subsumed) checkpoint
+		//   - the current checkpoint if it was already canceled
+		return false;
+	}
+
+	@Override
+	public boolean processEndOfPartition() throws Exception {
+		threadSafeUnaligner.processEndOfPartition();
+
+		if (numBarrierConsumed > 0) {
+			// let the task know we skip a checkpoint
+			notifyAbort(
+				currentCheckpointId,
+				new CheckpointException(CheckpointFailureReason.CHECKPOINT_DECLINED_INPUT_END_OF_STREAM));
+			// no chance to complete this checkpoint
+			releaseBlocksAndResetBarriers();
+			return true;
+		}
+		return false;
+	}
+
+	@Override
+	public long getLatestCheckpointId() {
+		return currentCheckpointId;
+	}
+
+	@Override
+	public long getAlignmentDurationNanos() {
+		return 0;
+	}
+
+	@Override
+	public String toString() {
+		return String.format("%s: last checkpoint: %d", taskName, currentCheckpointId);
+	}
+
+	@Override
+	public void checkpointSizeLimitExceeded(long maxBufferedBytes) {
+	}
+
+	@Override
+	public void close() throws IOException {
+		super.close();
+		threadSafeUnaligner.close();
+	}
+
+	@Override
+	protected boolean isBarrierConsumed(long checkpointId, int channelIndex) {
+		if (checkpointId < currentCheckpointId) {
+			return true;
+		}
+		if (checkpointId > currentCheckpointId) {
+			return false;
+		}
+		return barrierConsumedChannels[channelIndex];
+	}
+
+	public CompletableFuture<Void> getAllBarriersReceivedFuture(long checkpointId) {
+		return threadSafeUnaligner.getAllBarriersReceivedFuture(checkpointId);
+	}
+
+	@Override
+	public Optional<BufferReceivedListener> getBufferReceivedListener() {
+		return Optional.of(threadSafeUnaligner);
+	}
+
+	private int getFlattenedChannelIndex(InputChannelInfo channelInfo) {
+		return gateChannelOffsets[channelInfo.getGateIdx()] + channelInfo.getInputChannelIdx();
+	}
+
+	private static class ThreadSafeUnaligner implements BufferReceivedListener, Closeable {
+
+		/**
+		 * Tag the state of which input channel has received the barrier. Until the barrier of a specific channel is
+		 * received, all new buffers need to be persisted after unaligned checkpointing has been started.
+		 */
+		private final boolean[] barrierReceivedChannels;
+
+		/**
+		 * The number of input channels which has read the barrier by task.
+		 */
+		private int numBarriersReceived;
+
+		/** A future indicating that all barriers of the a given checkpoint have been read. */
+		private CompletableFuture<Void> allBarriersReceivedFuture = FutureUtils.completedVoidFuture();
+
+		/**
+		 * The checkpoint id to guarantee that we would trigger only one checkpoint when reading the same barrier from
+		 * different channels.
+		 *
+		 * <p>Note: this checkpoint is valid in respect to <b>received</b> barriers in contrast to
+		 * {@link CheckpointBarrierUnaligner#currentCheckpointId}.
+		 */
+		private long currentCheckpointId = -1L;
+
+		/** The number of opened channels. */
+		private int numOpenChannels;
+
+		private final ChannelStateWriter channelStateWriter;
+
+		private final CheckpointBarrierUnaligner handler;
 
 Review comment:
   This cyclic reference is redundant and confusing IMO.
   Instead, we could have fields `taskName`, `AbstractInvokable` and flattenedChannelIndex info in some form.
   (not a very important thing, feel free to ignore and resolve)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#issuecomment-603776093
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6621",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155064201",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155877268",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6755",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6839",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156597180",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6846",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156864478",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6873",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156994047",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157330632",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6900",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157451694",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6916",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157494634",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6933",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157589655",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6944",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6991",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157754467",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158102285",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7007",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7023",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158153241",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158188400",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7040",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7048",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158276096",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158831429",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7117",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7121",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158855200",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159112519",
       "triggerID" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7172",
       "triggerID" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159143719",
       "triggerID" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7175",
       "triggerID" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "triggerType" : "PUSH"
     }, {
       "hash" : "35ec088ef24e841beae78c33488975d2d8d0a40d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "35ec088ef24e841beae78c33488975d2d8d0a40d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7194",
       "triggerID" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159244661",
       "triggerID" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "triggerType" : "PUSH"
     }, {
       "hash" : "334458afaa98b601eec12c490e71caa8274be055",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "334458afaa98b601eec12c490e71caa8274be055",
       "triggerType" : "PUSH"
     }, {
       "hash" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7212",
       "triggerID" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "triggerType" : "PUSH"
     }, {
       "hash" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159269141",
       "triggerID" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7226",
       "triggerID" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159307415",
       "triggerID" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7297",
       "triggerID" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159652918",
       "triggerID" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "559816dcea4999dd46b09ee1091ddc0e1a5a7a54",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "559816dcea4999dd46b09ee1091ddc0e1a5a7a54",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6cd76afe4990f56a5166e1592374aa8f86fe883f",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "6cd76afe4990f56a5166e1592374aa8f86fe883f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7302",
       "triggerID" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159678447",
       "triggerID" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159695914",
       "triggerID" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7305",
       "triggerID" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ac996f5c703560ecbe6cad7394cc8ad54d6f0029",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "ac996f5c703560ecbe6cad7394cc8ad54d6f0029",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7347",
       "triggerID" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159875195",
       "triggerID" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "75c8130873e9b91e21e1e833d3d05f1ad9b5d2b8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7354",
       "triggerID" : "75c8130873e9b91e21e1e833d3d05f1ad9b5d2b8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7369",
       "triggerID" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "triggerType" : "PUSH"
     }, {
       "hash" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159960514",
       "triggerID" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7373",
       "triggerID" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159990549",
       "triggerID" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "triggerType" : "PUSH"
     }, {
       "hash" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7443",
       "triggerID" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160172375",
       "triggerID" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * dee2b337e5e72d8f7b1f5098b74f2958d000fb3c UNKNOWN
   * 80b7f76f24b5fb6704a4b2292543f8764ec19053 UNKNOWN
   * 35ec088ef24e841beae78c33488975d2d8d0a40d UNKNOWN
   * 334458afaa98b601eec12c490e71caa8274be055 UNKNOWN
   * 559816dcea4999dd46b09ee1091ddc0e1a5a7a54 UNKNOWN
   * 6cd76afe4990f56a5166e1592374aa8f86fe883f UNKNOWN
   * ac996f5c703560ecbe6cad7394cc8ad54d6f0029 UNKNOWN
   * 11d69a1fed933cd4894f84e429d91e9b965d121b Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/160172375) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7443) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#issuecomment-603776093
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6621",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155064201",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155877268",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6755",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6839",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156597180",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6846",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156864478",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6873",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156994047",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157330632",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6900",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157451694",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6916",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157494634",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6933",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157589655",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6944",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6991",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157754467",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158102285",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7007",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7023",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158153241",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158188400",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7040",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7048",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158276096",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158831429",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7117",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7121",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158855200",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159112519",
       "triggerID" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7172",
       "triggerID" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159143719",
       "triggerID" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7175",
       "triggerID" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "triggerType" : "PUSH"
     }, {
       "hash" : "35ec088ef24e841beae78c33488975d2d8d0a40d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "35ec088ef24e841beae78c33488975d2d8d0a40d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7194",
       "triggerID" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159244661",
       "triggerID" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "triggerType" : "PUSH"
     }, {
       "hash" : "334458afaa98b601eec12c490e71caa8274be055",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "334458afaa98b601eec12c490e71caa8274be055",
       "triggerType" : "PUSH"
     }, {
       "hash" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7212",
       "triggerID" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "triggerType" : "PUSH"
     }, {
       "hash" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159269141",
       "triggerID" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7226",
       "triggerID" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159307415",
       "triggerID" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7297",
       "triggerID" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159652918",
       "triggerID" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "559816dcea4999dd46b09ee1091ddc0e1a5a7a54",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "559816dcea4999dd46b09ee1091ddc0e1a5a7a54",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6cd76afe4990f56a5166e1592374aa8f86fe883f",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "6cd76afe4990f56a5166e1592374aa8f86fe883f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7302",
       "triggerID" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159678447",
       "triggerID" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159695914",
       "triggerID" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7305",
       "triggerID" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ac996f5c703560ecbe6cad7394cc8ad54d6f0029",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "ac996f5c703560ecbe6cad7394cc8ad54d6f0029",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7347",
       "triggerID" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159875195",
       "triggerID" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "75c8130873e9b91e21e1e833d3d05f1ad9b5d2b8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7354",
       "triggerID" : "75c8130873e9b91e21e1e833d3d05f1ad9b5d2b8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7369",
       "triggerID" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "triggerType" : "PUSH"
     }, {
       "hash" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159960514",
       "triggerID" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7373",
       "triggerID" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159990549",
       "triggerID" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * dee2b337e5e72d8f7b1f5098b74f2958d000fb3c UNKNOWN
   * 80b7f76f24b5fb6704a4b2292543f8764ec19053 UNKNOWN
   * 35ec088ef24e841beae78c33488975d2d8d0a40d UNKNOWN
   * 334458afaa98b601eec12c490e71caa8274be055 UNKNOWN
   * 559816dcea4999dd46b09ee1091ddc0e1a5a7a54 UNKNOWN
   * 6cd76afe4990f56a5166e1592374aa8f86fe883f UNKNOWN
   * ac996f5c703560ecbe6cad7394cc8ad54d6f0029 UNKNOWN
   * 3242e942c07ec35f2532af7cd737af8bc1ce7749 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/159990549) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7373) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r406475213
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
 ##########
 @@ -542,6 +573,16 @@ public void onBuffer(Buffer buffer, int sequenceNumber, int backlog) throws IOEx
 			if (backlog >= 0) {
 				onSenderBacklog(backlog);
 			}
+
+			if (checkpointBarrier != null) {
+				receivedCheckpointId = checkpointBarrier.getId();
+			}
+			if (checkpointBarrier != null && inputGate.bufferReceivedListener != null) {
+				inputGate.bufferReceivedListener.notifyBarrierReceived(checkpointBarrier, channelInfo);
+			}
+			if (notifyReceivedBuffer != null && inputGate.bufferReceivedListener != null) {
 
 Review comment:
   That's a tricky one. `receivedCheckpointId < lastRequestedCheckpointId` can only be true if the checkpoint has been triggered through `Unaligner`, which in turn guarantees that `bufferReceivedListener != null`. 
   
   Aside from your suggestions, we could also add this assumption to the place, where we create `notifyReceivedBuffer` to make it more explicit. (So don't retain if `bufferReceivedListener == null`). Then we would just trust branch prediction to effectively get rid of the check. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zhijiangW commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
zhijiangW commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r400294892
 
 

 ##########
 File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
 ##########
 @@ -858,7 +866,12 @@ private boolean performCheckpoint(
 				// make sure it can skip outgoing buffers if unaligned
 				operatorChain.broadcastEvent(message, configuration.isUnalignedCheckpointsEnabled());
 
-				// Step (3): Take the state snapshot. This should be largely asynchronous, to not
+				// Step (3): Prepare to spill the inflighting buffers for input and output
 
 Review comment:
   nit: inflighting -> inflight

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] rkhachatryan commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r404988787
 
 

 ##########
 File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/CheckpointBarrierUnaligner.java
 ##########
 @@ -0,0 +1,420 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.streaming.runtime.io;
+
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.runtime.checkpoint.CheckpointException;
+import org.apache.flink.runtime.checkpoint.CheckpointFailureReason;
+import org.apache.flink.runtime.checkpoint.channel.ChannelStateWriter;
+import org.apache.flink.runtime.checkpoint.channel.InputChannelInfo;
+import org.apache.flink.runtime.concurrent.FutureUtils;
+import org.apache.flink.runtime.io.network.api.CancelCheckpointMarker;
+import org.apache.flink.runtime.io.network.api.CheckpointBarrier;
+import org.apache.flink.runtime.io.network.buffer.Buffer;
+import org.apache.flink.runtime.io.network.buffer.BufferReceivedListener;
+import org.apache.flink.runtime.jobgraph.tasks.AbstractInvokable;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.Closeable;
+import java.io.IOException;
+import java.util.Arrays;
+import java.util.Optional;
+import java.util.concurrent.CompletableFuture;
+import java.util.function.Function;
+import java.util.stream.IntStream;
+
+import static org.apache.flink.util.Preconditions.checkNotNull;
+
+/**
+ * {@link CheckpointBarrierUnaligner} is used for triggering checkpoint while reading the first barrier
+ * and keeping track of the number of received barriers and consumed barriers.
+ */
+@Internal
+public class CheckpointBarrierUnaligner extends CheckpointBarrierHandler {
+
+	private static final Logger LOG = LoggerFactory.getLogger(CheckpointBarrierUnaligner.class);
+
+	private final String taskName;
+
+	/**
+	 * Tag the state of which input channel has read the barrier. If one channel has read the barrier by task,
+	 * the respective in-flight input buffers should be empty when triggering unaligned checkpoint.
+	 */
+	private final boolean[] barrierConsumedChannels;
+
+	private int numBarrierConsumed;
+
+	/**
+	 * Contains the offsets of the channel indices for each gate when flattening the channels of all gates.
+	 *
+	 * <p>For example, consider 3 gates with 4 channels, {@code gateChannelOffsets = [0, 4, 8]}.
+	 */
+	private final int[] gateChannelOffsets;
+
+	private final InputChannelInfo[] channelInfos;
+
+	/**
+	 * The checkpoint id to guarantee that we would trigger only one checkpoint when reading the same barrier from
+	 * different channels.
+	 *
+	 * <p>Note: this checkpoint is valid in respect to <b>consumed</b> barriers in contrast to
+	 * {@link ThreadSafeUnaligner#currentCheckpointId}.
+	 */
+	private long currentCheckpointId = -1L;
+
+	/** Encapsulates state that is shared between netty threads and task thread. */
+	private final ThreadSafeUnaligner threadSafeUnaligner;
+
+	CheckpointBarrierUnaligner(
+			int[] numberOfInputChannelsPerGate,
+			ChannelStateWriter channelStateWriter,
+			String taskName,
+			AbstractInvokable toNotifyOnCheckpoint) {
+		super(toNotifyOnCheckpoint);
+
+		this.taskName = taskName;
+
+		final int numGates = numberOfInputChannelsPerGate.length;
+
+		gateChannelOffsets = new int[numGates];
+		for (int index = 1; index < numGates; index++) {
+			gateChannelOffsets[index] = gateChannelOffsets[index - 1] + numberOfInputChannelsPerGate[index - 1];
+		}
+
+		final int totalNumChannels = gateChannelOffsets[numGates - 1] + numberOfInputChannelsPerGate[numGates - 1];
+		barrierConsumedChannels = new boolean[totalNumChannels];
+		Arrays.fill(barrierConsumedChannels, true);
+
+		channelInfos = IntStream.range(0, numGates)
+			.mapToObj(gateIndex -> IntStream.range(0, numberOfInputChannelsPerGate[gateIndex])
+				.mapToObj(channelIndex -> new InputChannelInfo(gateIndex, channelIndex)))
+			.flatMap(Function.identity())
+			.toArray(InputChannelInfo[]::new);
+
+		threadSafeUnaligner = new ThreadSafeUnaligner(totalNumChannels,	checkNotNull(channelStateWriter), this);
+	}
+
+	@Override
+	public void releaseBlocksAndResetBarriers() {
+		// make sure no additional data is persisted
+		Arrays.fill(barrierConsumedChannels, true);
+		// the next barrier that comes must assume it is the first
+		numBarrierConsumed = 0;
+		threadSafeUnaligner.releaseBlocksAndResetBarriers();
+	}
+
+	/**
+	 * For unaligned checkpoint, it never blocks processing from the task aspect.
+	 *
+	 * <p>For PoC, we do not consider the possibility that the unaligned checkpoint would
+	 * not perform due to the max configured unaligned checkpoint size.
+	 */
+	@Override
+	public boolean isBlocked(int channelIndex) {
+		return false;
+	}
+
+	/**
+	 * We still need to trigger checkpoint while reading the first barrier from one channel, because this might happen
+	 * earlier than the previous async trigger via mailbox by netty thread. And the {@link AbstractInvokable} has the
+	 * deduplication logic to guarantee trigger checkpoint only once finally.
+	 *
+	 * <p>Note this is also suitable for the trigger case of local input channel.
+	 */
+	@Override
+	public boolean processBarrier(
+			CheckpointBarrier receivedBarrier,
+			int channelIndex,
+			long bufferedBytes) throws IOException {
+		long barrierId = receivedBarrier.getId();
+		if (currentCheckpointId < barrierId) {
+			currentCheckpointId = barrierId;
+			numBarrierConsumed = 0;
+			Arrays.fill(barrierConsumedChannels, false);
+		}
+		if (currentCheckpointId == barrierId) {
+			barrierConsumedChannels[channelIndex] = true;
+			numBarrierConsumed++;
+		}
+		// processBarrier is called from task thread and can actually happen before notifyBarrierReceived on empty
+		// buffer queues
+		// to avoid replicating any logic, we simply call notifyBarrierReceived here as well
+		threadSafeUnaligner.notifyBarrierReceived(receivedBarrier, channelInfos[channelIndex]);
+		return false;
+	}
+
+	@Override
+	public boolean processCancellationBarrier(CancelCheckpointMarker cancelBarrier) throws Exception {
+		final long barrierId = cancelBarrier.getCheckpointId();
+
+		if (numBarrierConsumed > 0) {
+			// this is only true if some alignment is in progress and nothing was canceled
+
+			if (barrierId == currentCheckpointId) {
+				// cancel this alignment
+				if (LOG.isDebugEnabled()) {
+					LOG.debug("{}: Checkpoint {} canceled, aborting alignment.", taskName, barrierId);
+				}
+
+				releaseBlocksAndResetBarriers();
+				notifyAbortOnCancellationBarrier(barrierId);
+			}
+			else if (barrierId > currentCheckpointId) {
+				// we canceled the next which also cancels the current
+				LOG.warn("{}: Received cancellation barrier for checkpoint {} before completing current checkpoint {}. " +
+						"Skipping current checkpoint.",
+					taskName,
+					barrierId,
+					currentCheckpointId);
+
+				// this stops the current alignment
+				releaseBlocksAndResetBarriers();
+
+				// the next checkpoint starts as canceled
+				currentCheckpointId = barrierId;
+				threadSafeUnaligner.setCurrentCheckpointId(currentCheckpointId);
+				notifyAbortOnCancellationBarrier(barrierId);
+			}
+
+			// else: ignore trailing (cancellation) barrier from an earlier checkpoint (obsolete now)
+
+		}
+		else if (barrierId > currentCheckpointId) {
+			// first barrier of a new checkpoint is directly a cancellation
+
+			// by setting the currentCheckpointId to this checkpoint while keeping the numBarriers
+			// at zero means that no checkpoint barrier can start a new alignment
+			currentCheckpointId = barrierId;
+			threadSafeUnaligner.setCurrentCheckpointId(currentCheckpointId);
+
+			if (LOG.isDebugEnabled()) {
+				LOG.debug("{}: Checkpoint {} canceled, skipping alignment.", taskName, barrierId);
+			}
+
+			notifyAbortOnCancellationBarrier(barrierId);
+		}
+
+		// else: trailing barrier from either
+		//   - a previous (subsumed) checkpoint
+		//   - the current checkpoint if it was already canceled
+		return false;
+	}
+
+	@Override
+	public boolean processEndOfPartition() throws Exception {
+		threadSafeUnaligner.processEndOfPartition();
+
+		if (numBarrierConsumed > 0) {
+			// let the task know we skip a checkpoint
+			notifyAbort(
+				currentCheckpointId,
+				new CheckpointException(CheckpointFailureReason.CHECKPOINT_DECLINED_INPUT_END_OF_STREAM));
+			// no chance to complete this checkpoint
+			releaseBlocksAndResetBarriers();
+			return true;
+		}
+		return false;
+	}
+
+	@Override
+	public long getLatestCheckpointId() {
+		return currentCheckpointId;
+	}
+
+	@Override
+	public long getAlignmentDurationNanos() {
+		return 0;
+	}
+
+	@Override
+	public String toString() {
+		return String.format("%s: last checkpoint: %d", taskName, currentCheckpointId);
+	}
+
+	@Override
+	public void checkpointSizeLimitExceeded(long maxBufferedBytes) {
+	}
+
+	@Override
+	public void close() throws IOException {
+		super.close();
+		threadSafeUnaligner.close();
+	}
+
+	@Override
+	protected boolean isBarrierConsumed(long checkpointId, int channelIndex) {
+		if (checkpointId < currentCheckpointId) {
+			return true;
+		}
+		if (checkpointId > currentCheckpointId) {
+			return false;
+		}
+		return barrierConsumedChannels[channelIndex];
+	}
+
+	public CompletableFuture<Void> getAllBarriersReceivedFuture(long checkpointId) {
+		return threadSafeUnaligner.getAllBarriersReceivedFuture(checkpointId);
+	}
+
+	@Override
+	public Optional<BufferReceivedListener> getBufferReceivedListener() {
+		return Optional.of(threadSafeUnaligner);
+	}
+
+	private int getFlattenedChannelIndex(InputChannelInfo channelInfo) {
+		return gateChannelOffsets[channelInfo.getGateIdx()] + channelInfo.getInputChannelIdx();
+	}
+
+	private static class ThreadSafeUnaligner implements BufferReceivedListener, Closeable {
+
+		/**
+		 * Tag the state of which input channel has received the barrier. Until the barrier of a specific channel is
+		 * received, all new buffers need to be persisted after unaligned checkpointing has been started.
+		 */
+		private final boolean[] barrierReceivedChannels;
+
+		/**
+		 * The number of input channels which has read the barrier by task.
+		 */
+		private int numBarriersReceived;
+
+		/** A future indicating that all barriers of the a given checkpoint have been read. */
+		private CompletableFuture<Void> allBarriersReceivedFuture = FutureUtils.completedVoidFuture();
+
+		/**
+		 * The checkpoint id to guarantee that we would trigger only one checkpoint when reading the same barrier from
+		 * different channels.
+		 *
+		 * <p>Note: this checkpoint is valid in respect to <b>received</b> barriers in contrast to
+		 * {@link CheckpointBarrierUnaligner#currentCheckpointId}.
+		 */
+		private long currentCheckpointId = -1L;
+
+		/** The number of opened channels. */
+		private int numOpenChannels;
+
+		private final ChannelStateWriter channelStateWriter;
+
+		private final CheckpointBarrierUnaligner handler;
+
+		public ThreadSafeUnaligner(
+				int totalNumChannels,
+				ChannelStateWriter channelStateWriter,
+				CheckpointBarrierUnaligner handler) {
+			barrierReceivedChannels = new boolean[totalNumChannels];
+			this.channelStateWriter = channelStateWriter;
+			this.handler = handler;
+			Arrays.fill(barrierReceivedChannels, true);
+			numOpenChannels = totalNumChannels;
+		}
+
+		@Override
+		public synchronized void notifyBarrierReceived(CheckpointBarrier barrier, InputChannelInfo channelInfo) {
+			long barrierId = barrier.getId();
+
+			if (currentCheckpointId < barrierId) {
+				handleNewCheckpoint(barrierId);
+				handler.runInTaskThread(() -> handler.notifyCheckpoint(barrier, 0, 0), "notifyCheckpoint");
+			}
+
+			int channelIndex = handler.getFlattenedChannelIndex(channelInfo);
+			if (barrierId == currentCheckpointId && !barrierReceivedChannels[channelIndex]) {
+				if (LOG.isDebugEnabled()) {
+					LOG.debug("{}: Received barrier from channel {} @ {}.", handler.taskName, channelIndex, barrierId);
+				}
+
+				barrierReceivedChannels[channelIndex] = true;
+
+				if (++numBarriersReceived == numOpenChannels) {
+					allBarriersReceivedFuture.complete(null);
+				}
+			}
+		}
+
+		@Override
+		public synchronized void notifyBufferReceived(Buffer buffer, InputChannelInfo channelInfo) {
+			if (!barrierReceivedChannels[handler.getFlattenedChannelIndex(channelInfo)]) {
+				channelStateWriter.addInputData(
+					currentCheckpointId,
+					channelInfo,
+					ChannelStateWriter.SEQUENCE_NUMBER_UNKNOWN,
+					buffer);
+			} else {
+				buffer.recycleBuffer();
+			}
+		}
+
+		@Override
+		public void close() throws IOException {
+			allBarriersReceivedFuture.completeExceptionally(new IllegalStateException("Closed CheckpointBarrierUnaligner"));
+		}
+
+		private synchronized void handleNewCheckpoint(long barrierId) {
+			if (!allBarriersReceivedFuture.isDone()) {
+				// we did not complete the current checkpoint, another started before
+				LOG.warn("{}: Received checkpoint barrier for checkpoint {} before completing current checkpoint {}. " +
+						"Skipping current checkpoint.",
+					handler.taskName,
+					barrierId,
+					currentCheckpointId);
+
+				// let the task know we are not completing this
+				long currentCheckpointId = this.currentCheckpointId;
+				handler.runInTaskThread(() ->
+					handler.notifyAbort(currentCheckpointId,
+						new CheckpointException(
+							"Barrier id: " + barrierId,
+							CheckpointFailureReason.CHECKPOINT_DECLINED_SUBSUMED)),
+					"notifyAbort");
+			}
+
+			currentCheckpointId = barrierId;
+			Arrays.fill(barrierReceivedChannels, false);
+			numBarriersReceived = 0;
+			allBarriersReceivedFuture = new CompletableFuture<>();
+			channelStateWriter.start(barrierId);
+		}
+
+		public synchronized void releaseBlocksAndResetBarriers() {
+			Arrays.fill(barrierReceivedChannels, true);
+			// the next barrier that comes must assume it is the first
+			numBarriersReceived = 0;
+		}
+
+		public synchronized CompletableFuture<Void> getAllBarriersReceivedFuture(long checkpointId) {
+			if (checkpointId < currentCheckpointId) {
+				return FutureUtils.completedVoidFuture();
+			}
+			if (checkpointId > currentCheckpointId) {
+				throw new IllegalStateException("Checkpoint " + checkpointId + " has not been started at all");
+			}
+			return this.allBarriersReceivedFuture;
+		}
+
+		public synchronized void processEndOfPartition() {
+			numOpenChannels--;
+		}
+
+		public void setCurrentCheckpointId(long currentCheckpointId) {
+			this.currentCheckpointId = currentCheckpointId;
+		}
 
 Review comment:
   1. Should this method be `syncrhonized`?
   2. Should it check that `currentCheckpointId` passed is greater than `this.currentCheckpointId`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#issuecomment-603776093
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6621",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155064201",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155877268",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6755",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6839",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156597180",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6846",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156864478",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6873",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156994047",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157330632",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6900",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157451694",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6916",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157494634",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6933",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157589655",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6944",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6991",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157754467",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158102285",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7007",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7023",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158153241",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158188400",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7040",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7048",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158276096",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158831429",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7117",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7121",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158855200",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159112519",
       "triggerID" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7172",
       "triggerID" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159143719",
       "triggerID" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7175",
       "triggerID" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "triggerType" : "PUSH"
     }, {
       "hash" : "35ec088ef24e841beae78c33488975d2d8d0a40d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "35ec088ef24e841beae78c33488975d2d8d0a40d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7194",
       "triggerID" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "status" : "CANCELED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159244661",
       "triggerID" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "triggerType" : "PUSH"
     }, {
       "hash" : "334458afaa98b601eec12c490e71caa8274be055",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "334458afaa98b601eec12c490e71caa8274be055",
       "triggerType" : "PUSH"
     }, {
       "hash" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7212",
       "triggerID" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "triggerType" : "PUSH"
     }, {
       "hash" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159269141",
       "triggerID" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * dee2b337e5e72d8f7b1f5098b74f2958d000fb3c UNKNOWN
   * 80b7f76f24b5fb6704a4b2292543f8764ec19053 UNKNOWN
   * 35ec088ef24e841beae78c33488975d2d8d0a40d UNKNOWN
   * ee3ad987187409939aa7c211778ed88dd64f6479 Travis: [CANCELED](https://travis-ci.com/github/flink-ci/flink/builds/159244661) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7194) 
   * 334458afaa98b601eec12c490e71caa8274be055 UNKNOWN
   * 17d1689c8376c55a8c5e41f78908d047b14f5631 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/159269141) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7212) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zhijiangW commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
zhijiangW commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r399038839
 
 

 ##########
 File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/StreamTaskNetworkInput.java
 ##########
 @@ -197,6 +205,29 @@ public int getInputIndex() {
 		return checkpointedInputGate.getAvailableFuture();
 	}
 
+	@Override
+	public CompletableFuture<?> prepareSnapshot(long checkpointId) throws IOException {
+		// Note that if considering recovery in future, we should guarantee that the spilled buffers in one channel
+		// should be close together because one record might span multiple buffers.
+		for (int channelIndex = 0; channelIndex < recordDeserializers.length; channelIndex++) {
+			final InputChannel channel = checkpointedInputGate.getChannel(channelIndex);
+
+			recordDeserializers[channelIndex].getUnconsumedBuffer().ifPresent(buffer ->
 
 Review comment:
   The partial buffer in `RecordDeserializer` should be treated same as the inflight buffers in `RemoteInputChannel` queue. When the given checkpoint is triggered, this partial buffer is also overtaken actually. If there are multiple checkpoints concurrent, this partial buffer might belong to multiple checkpoint states, then that brings the concern of duplicated persistence like incremental checkpoint.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#issuecomment-603776093
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6621",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155064201",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155877268",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6755",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6839",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156597180",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6846",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156864478",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6873",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156994047",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157330632",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6900",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157451694",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6916",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157494634",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6933",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157589655",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6944",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6991",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157754467",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158102285",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7007",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7023",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158153241",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158188400",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7040",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7048",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158276096",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158831429",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7117",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7121",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158855200",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159112519",
       "triggerID" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7172",
       "triggerID" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159143719",
       "triggerID" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7175",
       "triggerID" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "triggerType" : "PUSH"
     }, {
       "hash" : "35ec088ef24e841beae78c33488975d2d8d0a40d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "35ec088ef24e841beae78c33488975d2d8d0a40d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7194",
       "triggerID" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159244661",
       "triggerID" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "triggerType" : "PUSH"
     }, {
       "hash" : "334458afaa98b601eec12c490e71caa8274be055",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "334458afaa98b601eec12c490e71caa8274be055",
       "triggerType" : "PUSH"
     }, {
       "hash" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7212",
       "triggerID" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "triggerType" : "PUSH"
     }, {
       "hash" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159269141",
       "triggerID" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7226",
       "triggerID" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159307415",
       "triggerID" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7297",
       "triggerID" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159652918",
       "triggerID" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "559816dcea4999dd46b09ee1091ddc0e1a5a7a54",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "559816dcea4999dd46b09ee1091ddc0e1a5a7a54",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6cd76afe4990f56a5166e1592374aa8f86fe883f",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "6cd76afe4990f56a5166e1592374aa8f86fe883f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7302",
       "triggerID" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159678447",
       "triggerID" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159695914",
       "triggerID" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7305",
       "triggerID" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ac996f5c703560ecbe6cad7394cc8ad54d6f0029",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "ac996f5c703560ecbe6cad7394cc8ad54d6f0029",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7347",
       "triggerID" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159875195",
       "triggerID" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "75c8130873e9b91e21e1e833d3d05f1ad9b5d2b8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7354",
       "triggerID" : "75c8130873e9b91e21e1e833d3d05f1ad9b5d2b8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7369",
       "triggerID" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "triggerType" : "PUSH"
     }, {
       "hash" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "status" : "FAILURE",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159960514",
       "triggerID" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7373",
       "triggerID" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159990549",
       "triggerID" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * dee2b337e5e72d8f7b1f5098b74f2958d000fb3c UNKNOWN
   * 80b7f76f24b5fb6704a4b2292543f8764ec19053 UNKNOWN
   * 35ec088ef24e841beae78c33488975d2d8d0a40d UNKNOWN
   * 334458afaa98b601eec12c490e71caa8274be055 UNKNOWN
   * 559816dcea4999dd46b09ee1091ddc0e1a5a7a54 UNKNOWN
   * 6cd76afe4990f56a5166e1592374aa8f86fe883f UNKNOWN
   * ac996f5c703560ecbe6cad7394cc8ad54d6f0029 UNKNOWN
   * 54a27acd416fbed48aa7876fda85036b90c641ab Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/159960514) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7369) 
   * 3242e942c07ec35f2532af7cd737af8bc1ce7749 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/159990549) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7373) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#issuecomment-603776093
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6621",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155064201",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155877268",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6755",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6839",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156597180",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6846",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156864478",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6873",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156994047",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157330632",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6900",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157451694",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6916",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157494634",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6933",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157589655",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6944",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6991",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157754467",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158102285",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7007",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7023",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158153241",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158188400",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7040",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7048",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158276096",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158831429",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7117",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7121",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158855200",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159112519",
       "triggerID" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7172",
       "triggerID" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159143719",
       "triggerID" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7175",
       "triggerID" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "triggerType" : "PUSH"
     }, {
       "hash" : "35ec088ef24e841beae78c33488975d2d8d0a40d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "35ec088ef24e841beae78c33488975d2d8d0a40d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7194",
       "triggerID" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159244661",
       "triggerID" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "triggerType" : "PUSH"
     }, {
       "hash" : "334458afaa98b601eec12c490e71caa8274be055",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "334458afaa98b601eec12c490e71caa8274be055",
       "triggerType" : "PUSH"
     }, {
       "hash" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7212",
       "triggerID" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "triggerType" : "PUSH"
     }, {
       "hash" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159269141",
       "triggerID" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7226",
       "triggerID" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159307415",
       "triggerID" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7297",
       "triggerID" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159652918",
       "triggerID" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "559816dcea4999dd46b09ee1091ddc0e1a5a7a54",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "559816dcea4999dd46b09ee1091ddc0e1a5a7a54",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6cd76afe4990f56a5166e1592374aa8f86fe883f",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "6cd76afe4990f56a5166e1592374aa8f86fe883f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7302",
       "triggerID" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159678447",
       "triggerID" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159695914",
       "triggerID" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7305",
       "triggerID" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ac996f5c703560ecbe6cad7394cc8ad54d6f0029",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "ac996f5c703560ecbe6cad7394cc8ad54d6f0029",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7347",
       "triggerID" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159875195",
       "triggerID" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "75c8130873e9b91e21e1e833d3d05f1ad9b5d2b8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7354",
       "triggerID" : "75c8130873e9b91e21e1e833d3d05f1ad9b5d2b8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7369",
       "triggerID" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "triggerType" : "PUSH"
     }, {
       "hash" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159960514",
       "triggerID" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7373",
       "triggerID" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159990549",
       "triggerID" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "triggerType" : "PUSH"
     }, {
       "hash" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7443",
       "triggerID" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160172375",
       "triggerID" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "536d9fb04a7a8142c04c94344dd0b3c0f2c10999",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160215439",
       "triggerID" : "536d9fb04a7a8142c04c94344dd0b3c0f2c10999",
       "triggerType" : "PUSH"
     }, {
       "hash" : "536d9fb04a7a8142c04c94344dd0b3c0f2c10999",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7469",
       "triggerID" : "536d9fb04a7a8142c04c94344dd0b3c0f2c10999",
       "triggerType" : "PUSH"
     }, {
       "hash" : "67018bacf5bc2daa8a03a1aafa880efc1db86808",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7500",
       "triggerID" : "67018bacf5bc2daa8a03a1aafa880efc1db86808",
       "triggerType" : "PUSH"
     }, {
       "hash" : "67018bacf5bc2daa8a03a1aafa880efc1db86808",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160347006",
       "triggerID" : "67018bacf5bc2daa8a03a1aafa880efc1db86808",
       "triggerType" : "PUSH"
     }, {
       "hash" : "79c116a6a1f5fe314f801e81f0265dea8b9ac1a7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7522",
       "triggerID" : "79c116a6a1f5fe314f801e81f0265dea8b9ac1a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "79c116a6a1f5fe314f801e81f0265dea8b9ac1a7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160377553",
       "triggerID" : "79c116a6a1f5fe314f801e81f0265dea8b9ac1a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "27ce4bfad8e99989dd64f8c636c934727da8a062",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "27ce4bfad8e99989dd64f8c636c934727da8a062",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ce0dfc7324679ebf2da84278eac8f5f59d748319",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7539",
       "triggerID" : "ce0dfc7324679ebf2da84278eac8f5f59d748319",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ce0dfc7324679ebf2da84278eac8f5f59d748319",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160418181",
       "triggerID" : "ce0dfc7324679ebf2da84278eac8f5f59d748319",
       "triggerType" : "PUSH"
     }, {
       "hash" : "05c934bf483d4fb673496783ef8ff85b40b86708",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "05c934bf483d4fb673496783ef8ff85b40b86708",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4bbe67a13a75f4491898fbb1cd2315237dbca30e",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160443829",
       "triggerID" : "4bbe67a13a75f4491898fbb1cd2315237dbca30e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4bbe67a13a75f4491898fbb1cd2315237dbca30e",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7543",
       "triggerID" : "4bbe67a13a75f4491898fbb1cd2315237dbca30e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * dee2b337e5e72d8f7b1f5098b74f2958d000fb3c UNKNOWN
   * 80b7f76f24b5fb6704a4b2292543f8764ec19053 UNKNOWN
   * 35ec088ef24e841beae78c33488975d2d8d0a40d UNKNOWN
   * 334458afaa98b601eec12c490e71caa8274be055 UNKNOWN
   * 559816dcea4999dd46b09ee1091ddc0e1a5a7a54 UNKNOWN
   * 6cd76afe4990f56a5166e1592374aa8f86fe883f UNKNOWN
   * ac996f5c703560ecbe6cad7394cc8ad54d6f0029 UNKNOWN
   * 27ce4bfad8e99989dd64f8c636c934727da8a062 UNKNOWN
   * 05c934bf483d4fb673496783ef8ff85b40b86708 UNKNOWN
   * 4bbe67a13a75f4491898fbb1cd2315237dbca30e Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/160443829) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7543) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] pnowojski commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
pnowojski commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r405585586
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/NettyShuffleEnvironment.java
 ##########
 @@ -184,17 +184,18 @@ public ShuffleIOOwnerContext createShuffleIOOwnerContext(
 	}
 
 	@Override
-	public Collection<ResultPartition> createResultPartitionWriters(
 
 Review comment:
   But current code implicitly assumes the partition indexes when calling `Collection#toArray` in `Task` class:
   ```
   // produced intermediate result partitions
   final ResultPartitionWriter[] resultPartitionWriters = shuffleEnvironment.createResultPartitionWriters(
   	taskShuffleContext,
   	resultPartitionDeploymentDescriptors).toArray(new ResultPartitionWriter[] {});
   ```
   so I think it indeed should be a `List`, not a `Collection`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] pnowojski commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
pnowojski commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r405582156
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartition.java
 ##########
 @@ -83,24 +86,45 @@
 	/** The total number of bytes (both data and event buffers). */
 	private long totalNumberOfBytes;
 
+	/** The collection of buffers which are spanned over by checkpoint barrier and needs to be persisted for snapshot. */
+	private final List<Buffer> inflightBufferSnapshot = new ArrayList<>();
+
 	// ------------------------------------------------------------------------
 
 	PipelinedSubpartition(int index, ResultPartition parent) {
 		super(index, parent);
 	}
 
 	@Override
-	public boolean add(BufferConsumer bufferConsumer) {
-		return add(bufferConsumer, false);
+	public boolean add(BufferConsumer bufferConsumer) throws IOException {
+		return add(bufferConsumer, false, false);
 	}
 
 	@Override
 	public void finish() throws IOException {
-		add(EventSerializer.toBufferConsumer(EndOfPartitionEvent.INSTANCE), true);
+		add(EventSerializer.toBufferConsumer(EndOfPartitionEvent.INSTANCE), true, false);
 		LOG.debug("{}: Finished {}.", parent.getOwningTaskName(), this);
 	}
 
-	private boolean add(BufferConsumer bufferConsumer, boolean finish) {
+	@Override
+	public EnqueueAction priorityEvent(AbstractEvent event, BufferConsumer eventBufferConsumer) throws IOException {
+		if (readView != null) {
+			switch (readView.priorityEvent(event, eventBufferConsumer)) {
 
 Review comment:
   I think for the `PipelinedSubpartition` and `BoundedBlockingSubpartition` we do not need to return those values.  We could just define `void addPriorityEvent(...)` method in the `ResultSubpartition` method instead of inheriting from `PriorityEventListener`. The same applies for `PipelinedSubpartitionView`, as those classes are not being used as listeners, they are just forwarding the call. This extra abundant inheritance makes the code a little bit less readable and messes up with IDE support of usages.  
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] pnowojski commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
pnowojski commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r399245855
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/channel/ChannelStateWriter.java
 ##########
 @@ -94,10 +94,16 @@ public void start(long checkpointId) {
 
 		@Override
 		public void addInputData(long checkpointId, InputChannelInfo info, int startSeqNum, Buffer... data) {
+			for (final Buffer buffer : data) {
 
 Review comment:
   nit: some unit test?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zhijiangW commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
zhijiangW commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r400820857
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/UnionInputGate.java
 ##########
 @@ -77,37 +77,34 @@
 	 */
 	private final LinkedHashSet<InputGate> inputGatesWithData = new LinkedHashSet<>();
 
-	/** The total number of input channels across all unioned input gates. */
-	private final int totalNumberOfInputChannels;
+	/** Input channels across all unioned input gates. */
+	private final InputChannel[] inputChannels;
 
 	/**
 	 * A mapping from input gate to (logical) channel index offset. Valid channel indexes go from 0
 	 * (inclusive) to the total number of input channels (exclusive).
 	 */
-	private final Map<InputGate, Integer> inputGateToIndexOffsetMap;
+	private final int[] inputGateChannelIndexOffsets;
 
 	public UnionInputGate(InputGate... inputGates) {
 		this.inputGates = checkNotNull(inputGates);
 		checkArgument(inputGates.length > 1, "Union input gate should union at least two input gates.");
 
-		this.inputGateToIndexOffsetMap = Maps.newHashMapWithExpectedSize(inputGates.length);
 		this.inputGatesWithRemainingData = Sets.newHashSetWithExpectedSize(inputGates.length);
 
+		final int maxGateIndex = Arrays.stream(inputGates).mapToInt(InputGate::getGateIndex).max().orElse(0);
+		inputGateChannelIndexOffsets = new int[maxGateIndex + 1];
 
 Review comment:
   why need length `maxGateIndex + 1`? `maxGateIndex` is enough?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] AHeise commented on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
AHeise commented on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#issuecomment-606431452
 
 
   @travis run azure

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#issuecomment-603776093
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6621",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155064201",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155877268",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6755",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6839",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156597180",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6846",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156864478",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6873",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156994047",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157330632",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6900",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157451694",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6916",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157494634",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6933",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157589655",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6944",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6991",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157754467",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158102285",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7007",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7023",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158153241",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158188400",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7040",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7048",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158276096",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158831429",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7117",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7121",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158855200",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159112519",
       "triggerID" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7172",
       "triggerID" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159143719",
       "triggerID" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7175",
       "triggerID" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "triggerType" : "PUSH"
     }, {
       "hash" : "35ec088ef24e841beae78c33488975d2d8d0a40d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "35ec088ef24e841beae78c33488975d2d8d0a40d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7194",
       "triggerID" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159244661",
       "triggerID" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "triggerType" : "PUSH"
     }, {
       "hash" : "334458afaa98b601eec12c490e71caa8274be055",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "334458afaa98b601eec12c490e71caa8274be055",
       "triggerType" : "PUSH"
     }, {
       "hash" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7212",
       "triggerID" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "triggerType" : "PUSH"
     }, {
       "hash" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159269141",
       "triggerID" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7226",
       "triggerID" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159307415",
       "triggerID" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7297",
       "triggerID" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159652918",
       "triggerID" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "559816dcea4999dd46b09ee1091ddc0e1a5a7a54",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "559816dcea4999dd46b09ee1091ddc0e1a5a7a54",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6cd76afe4990f56a5166e1592374aa8f86fe883f",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "6cd76afe4990f56a5166e1592374aa8f86fe883f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7302",
       "triggerID" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159678447",
       "triggerID" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159695914",
       "triggerID" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7305",
       "triggerID" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ac996f5c703560ecbe6cad7394cc8ad54d6f0029",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "ac996f5c703560ecbe6cad7394cc8ad54d6f0029",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7347",
       "triggerID" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159875195",
       "triggerID" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "75c8130873e9b91e21e1e833d3d05f1ad9b5d2b8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7354",
       "triggerID" : "75c8130873e9b91e21e1e833d3d05f1ad9b5d2b8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7369",
       "triggerID" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "triggerType" : "PUSH"
     }, {
       "hash" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159960514",
       "triggerID" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7373",
       "triggerID" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159990549",
       "triggerID" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "triggerType" : "PUSH"
     }, {
       "hash" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7443",
       "triggerID" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160172375",
       "triggerID" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "536d9fb04a7a8142c04c94344dd0b3c0f2c10999",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160215439",
       "triggerID" : "536d9fb04a7a8142c04c94344dd0b3c0f2c10999",
       "triggerType" : "PUSH"
     }, {
       "hash" : "536d9fb04a7a8142c04c94344dd0b3c0f2c10999",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7469",
       "triggerID" : "536d9fb04a7a8142c04c94344dd0b3c0f2c10999",
       "triggerType" : "PUSH"
     }, {
       "hash" : "67018bacf5bc2daa8a03a1aafa880efc1db86808",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7500",
       "triggerID" : "67018bacf5bc2daa8a03a1aafa880efc1db86808",
       "triggerType" : "PUSH"
     }, {
       "hash" : "67018bacf5bc2daa8a03a1aafa880efc1db86808",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160347006",
       "triggerID" : "67018bacf5bc2daa8a03a1aafa880efc1db86808",
       "triggerType" : "PUSH"
     }, {
       "hash" : "79c116a6a1f5fe314f801e81f0265dea8b9ac1a7",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7522",
       "triggerID" : "79c116a6a1f5fe314f801e81f0265dea8b9ac1a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "79c116a6a1f5fe314f801e81f0265dea8b9ac1a7",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160377553",
       "triggerID" : "79c116a6a1f5fe314f801e81f0265dea8b9ac1a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "27ce4bfad8e99989dd64f8c636c934727da8a062",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "27ce4bfad8e99989dd64f8c636c934727da8a062",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * dee2b337e5e72d8f7b1f5098b74f2958d000fb3c UNKNOWN
   * 80b7f76f24b5fb6704a4b2292543f8764ec19053 UNKNOWN
   * 35ec088ef24e841beae78c33488975d2d8d0a40d UNKNOWN
   * 334458afaa98b601eec12c490e71caa8274be055 UNKNOWN
   * 559816dcea4999dd46b09ee1091ddc0e1a5a7a54 UNKNOWN
   * 6cd76afe4990f56a5166e1592374aa8f86fe883f UNKNOWN
   * ac996f5c703560ecbe6cad7394cc8ad54d6f0029 UNKNOWN
   * 79c116a6a1f5fe314f801e81f0265dea8b9ac1a7 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/160377553) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7522) 
   * 27ce4bfad8e99989dd64f8c636c934727da8a062 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zhijiangW commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
zhijiangW commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r400766640
 
 

 ##########
 File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
 ##########
 @@ -845,21 +845,19 @@ public ExecutorService getAsyncOperationsThreadPool() {
 
 	private void notifyCheckpointComplete(long checkpointId) {
 		try {
-			boolean success = actionExecutor.call(() -> {
 
 Review comment:
   I guess we can also get ride of `actionExecutor` from `#performCheckpoint` method which is actually executed by mailbox thread.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zhijiangW commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
zhijiangW commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r400298984
 
 

 ##########
 File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
 ##########
 @@ -1185,6 +1230,12 @@ private void reportCompletedSnapshotStates(
 				"Found cached state but no corresponding primary state is reported to the job " +
 					"manager. This indicates a problem.");
 
+			LOG.debug("{} - finished asynchronous part of checkpoint {}. Asynchronous duration: {} ms",
 
 Review comment:
   Not necessary changes

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] pnowojski commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
pnowojski commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r399367431
 
 

 ##########
 File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/CheckpointBarrierUnaligner.java
 ##########
 @@ -0,0 +1,242 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.streaming.runtime.io;
+
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.runtime.checkpoint.channel.ChannelStateWriter;
+import org.apache.flink.runtime.checkpoint.channel.InputChannelInfo;
+import org.apache.flink.runtime.io.network.api.CancelCheckpointMarker;
+import org.apache.flink.runtime.io.network.api.CheckpointBarrier;
+import org.apache.flink.runtime.io.network.buffer.Buffer;
+import org.apache.flink.runtime.jobgraph.tasks.AbstractInvokable;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import javax.annotation.Nullable;
+
+import java.util.Arrays;
+import java.util.concurrent.CompletableFuture;
+
+import static org.apache.flink.util.Preconditions.checkNotNull;
+
+/**
+ * {@link CheckpointBarrierUnaligner} is used for triggering checkpoint while reading the first barrier
+ * and keeping track of the number of received barriers and consumed barriers.
+ */
+@Internal
+public class CheckpointBarrierUnaligner extends CheckpointBarrierHandler {
+
+	private static final Logger LOG = LoggerFactory.getLogger(CheckpointBarrierUnaligner.class);
+
+	private final String taskName;
+
+	/**
+	 * Tag the state of which input channel has read the barrier. If one channel has read the barrier by task,
+	 * the respective in-flight input buffers should be empty when triggering unaligned checkpoint.
+	 */
+	private final boolean[] barrierConsumedChannels;
+
+	/**
+	 * Tag the state of which input channel has received the barrier. Until the barrier of a specific channel is
+	 * received, all new buffers need to be persisted after unaligned checkpointing has been started.
+	 */
+	private final boolean[] barrierReceivedChannels;
+
+	/**
+	 * Contains the offsets of the channel indices for each gate when flattening the channels of all gates.
+	 *
+	 * <p>For example, consider 3 gates with 4 channels, {@code gateChannelOffsets = [0, 4, 8]}.
+	 */
+	private final int[] gateChannelOffsets;
+
+	/**
+	 * The number of input channels which has read the barrier by task.
+	 */
+	private int numBarriersReceived;
+
+	/**
+	 * The checkpoint id to guarantee that we would trigger only one checkpoint when reading the same barrier from
+	 * different channels.
+	 */
+	private long currentCheckpointId = -1L;
+
+	private final ChannelStateWriter channelStateWriter;
+
+	private CompletableFuture<?> allBarriersReceivedFuture;
+
+	CheckpointBarrierUnaligner(
+			int[] numberOfInputChannelsPerGate,
+			ChannelStateWriter channelStateWriter,
+			String taskName,
+			@Nullable AbstractInvokable toNotifyOnCheckpoint) {
+		super(toNotifyOnCheckpoint);
+
+		this.taskName = taskName;
+		this.channelStateWriter = checkNotNull(channelStateWriter);
+
+		final int numGates = numberOfInputChannelsPerGate.length;
+
+		gateChannelOffsets = new int[numGates];
+		for (int index = 1; index < numGates; index++) {
+			gateChannelOffsets[index] = gateChannelOffsets[index - 1] + numberOfInputChannelsPerGate[index - 1];
+		}
+
+		final int totalNumChannels = gateChannelOffsets[numGates - 1] + numberOfInputChannelsPerGate[numGates - 1];
+		barrierConsumedChannels = new boolean[totalNumChannels];
+		Arrays.fill(barrierConsumedChannels, true);
+		barrierReceivedChannels = new boolean[totalNumChannels];
+		Arrays.fill(barrierReceivedChannels, true);
+	}
+
+	@Override
+	public void releaseBlocksAndResetBarriers() {
+	}
+
+	/**
+	 * For unaligned checkpoint, it never blocks processing from the task aspect.
+	 *
+	 * <p>For PoC, we do not consider the possibility that the unaligned checkpoint would
+	 * not perform due to the max configured unaligned checkpoint size.
+	 */
+	@Override
+	public boolean isBlocked(int channelIndex) {
+		return false;
+	}
+
+	/**
+	 * We still need to trigger checkpoint while reading the first barrier from one channel, because this might happen
+	 * earlier than the previous async trigger via mailbox by netty thread. And the {@link AbstractInvokable} has the
+	 * deduplication logic to guarantee trigger checkpoint only once finally.
+	 *
+	 * <p>Note this is also suitable for the trigger case of local input channel.
+	 */
+	@Override
+	public synchronized boolean processBarrier(
+			CheckpointBarrier receivedBarrier,
+			int channelIndex,
+			long bufferedBytes) {
+		long barrierId = receivedBarrier.getId();
+		if (checkNewCheckpoint(barrierId)) {
+			notifyCheckpointAsync(receivedBarrier, bufferedBytes, 0);
+		}
+		barrierConsumedChannels[channelIndex] = true;
+		return false;
+	}
+
+	@Override
+	public boolean processCancellationBarrier(CancelCheckpointMarker cancelBarrier) {
+		return false;
+	}
+
+	@Override
+	public boolean processEndOfPartition() {
+		return false;
+	}
+
+	@Override
+	public long getLatestCheckpointId() {
+		return currentCheckpointId;
+	}
+
+	@Override
+	public long getAlignmentDurationNanos() {
+		return 0;
+	}
+
+	@Override
+	public String toString() {
+		return String.format("%s: last checkpoint: %d", taskName, currentCheckpointId);
+	}
+
+	@Override
+	public void checkpointSizeLimitExceeded(long maxBufferedBytes) {
+	}
+
+	@Override
+	protected boolean isBarrierConsumed(long checkpointId, int channelIndex) {
+		if (checkpointId < currentCheckpointId) {
+			return true;
+		}
+		if (checkpointId > currentCheckpointId) {
+			return false;
+		}
+		return barrierConsumedChannels[channelIndex];
+	}
+
+	public CompletableFuture<?> getAllBarriersReceivedFuture(long checkpointId) {
 
 Review comment:
   I don't like the solution with `volatile` it makes reasoning about this class so much more complicated... Making the future `volatile` is even worse pattern, as future itself is already a volatile variable.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] rkhachatryan commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r404911834
 
 

 ##########
 File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/CheckpointBarrierUnaligner.java
 ##########
 @@ -0,0 +1,417 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.streaming.runtime.io;
+
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.runtime.checkpoint.CheckpointException;
+import org.apache.flink.runtime.checkpoint.CheckpointFailureReason;
+import org.apache.flink.runtime.checkpoint.channel.ChannelStateWriter;
+import org.apache.flink.runtime.checkpoint.channel.InputChannelInfo;
+import org.apache.flink.runtime.concurrent.FutureUtils;
+import org.apache.flink.runtime.io.network.api.CancelCheckpointMarker;
+import org.apache.flink.runtime.io.network.api.CheckpointBarrier;
+import org.apache.flink.runtime.io.network.buffer.Buffer;
+import org.apache.flink.runtime.io.network.buffer.BufferReceivedListener;
+import org.apache.flink.runtime.jobgraph.tasks.AbstractInvokable;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.Closeable;
+import java.io.IOException;
+import java.util.Arrays;
+import java.util.Optional;
+import java.util.concurrent.CompletableFuture;
+import java.util.function.Function;
+import java.util.stream.IntStream;
+
+import static org.apache.flink.util.Preconditions.checkNotNull;
+
+/**
+ * {@link CheckpointBarrierUnaligner} is used for triggering checkpoint while reading the first barrier
+ * and keeping track of the number of received barriers and consumed barriers.
+ */
+@Internal
+public class CheckpointBarrierUnaligner extends CheckpointBarrierHandler {
+
+	private static final Logger LOG = LoggerFactory.getLogger(CheckpointBarrierUnaligner.class);
+
+	private final String taskName;
+
+	/**
+	 * Tag the state of which input channel has read the barrier. If one channel has read the barrier by task,
+	 * the respective in-flight input buffers should be empty when triggering unaligned checkpoint.
+	 */
+	private final boolean[] barrierConsumedChannels;
+
+	private int numBarrierConsumed;
+
+	/**
+	 * Contains the offsets of the channel indices for each gate when flattening the channels of all gates.
+	 *
+	 * <p>For example, consider 3 gates with 4 channels, {@code gateChannelOffsets = [0, 4, 8]}.
+	 */
+	private final int[] gateChannelOffsets;
+
+	private final InputChannelInfo[] channelInfos;
+
+	/**
+	 * The checkpoint id to guarantee that we would trigger only one checkpoint when reading the same barrier from
+	 * different channels.
+	 *
+	 * <p>Note: this checkpoint is valid in respect to <b>consumed</b> barriers in contrast to
+	 * {@link ThreadSafeUnaligner#currentCheckpointId}.
+	 */
+	private long currentCheckpointId = -1L;
+
+	/** Encapsulates state that is shared between netty threads and task thread. */
+	private final ThreadSafeUnaligner threadSafeUnaligner;
+
+	CheckpointBarrierUnaligner(
+			int[] numberOfInputChannelsPerGate,
+			ChannelStateWriter channelStateWriter,
+			String taskName,
+			AbstractInvokable toNotifyOnCheckpoint) {
+		super(toNotifyOnCheckpoint);
+
+		this.taskName = taskName;
+
+		final int numGates = numberOfInputChannelsPerGate.length;
+
+		gateChannelOffsets = new int[numGates];
+		for (int index = 1; index < numGates; index++) {
+			gateChannelOffsets[index] = gateChannelOffsets[index - 1] + numberOfInputChannelsPerGate[index - 1];
+		}
+
+		final int totalNumChannels = gateChannelOffsets[numGates - 1] + numberOfInputChannelsPerGate[numGates - 1];
+		barrierConsumedChannels = new boolean[totalNumChannels];
+		Arrays.fill(barrierConsumedChannels, true);
+
+		channelInfos = IntStream.range(0, numGates)
+			.mapToObj(gateIndex -> IntStream.range(0, numberOfInputChannelsPerGate[gateIndex])
+				.mapToObj(channelIndex -> new InputChannelInfo(gateIndex, channelIndex)))
+			.flatMap(Function.identity())
+			.toArray(InputChannelInfo[]::new);
+
+		threadSafeUnaligner = new ThreadSafeUnaligner(totalNumChannels,	checkNotNull(channelStateWriter), this);
+	}
+
+	@Override
+	public void releaseBlocksAndResetBarriers() {
+		// make sure no additional data is persisted
+		Arrays.fill(barrierConsumedChannels, true);
+		// the next barrier that comes must assume it is the first
+		numBarrierConsumed = 0;
+		threadSafeUnaligner.releaseBlocksAndResetBarriers();
+	}
+
+	/**
+	 * For unaligned checkpoint, it never blocks processing from the task aspect.
+	 *
+	 * <p>For PoC, we do not consider the possibility that the unaligned checkpoint would
+	 * not perform due to the max configured unaligned checkpoint size.
+	 */
+	@Override
+	public boolean isBlocked(int channelIndex) {
+		return false;
+	}
+
+	/**
+	 * We still need to trigger checkpoint while reading the first barrier from one channel, because this might happen
+	 * earlier than the previous async trigger via mailbox by netty thread. And the {@link AbstractInvokable} has the
+	 * deduplication logic to guarantee trigger checkpoint only once finally.
+	 *
+	 * <p>Note this is also suitable for the trigger case of local input channel.
+	 */
+	@Override
+	public boolean processBarrier(
+			CheckpointBarrier receivedBarrier,
+			int channelIndex,
+			long bufferedBytes) throws IOException {
+		long barrierId = receivedBarrier.getId();
+		if (currentCheckpointId < barrierId) {
+			currentCheckpointId = barrierId;
+			numBarrierConsumed = 0;
+			Arrays.fill(barrierConsumedChannels, false);
+		}
+		if (currentCheckpointId == barrierId) {
+			barrierConsumedChannels[channelIndex] = true;
+			numBarrierConsumed++;
+		}
+		// processBarrier is called from task thread and can actually happen before notifyBarrierReceived on empty
+		// buffer queues
+		// to avoid replicating any logic, we simply call notifyBarrierReceived here as well
+		threadSafeUnaligner.notifyBarrierReceived(receivedBarrier, channelInfos[channelIndex]);
+		return false;
+	}
+
+	@Override
+	public boolean processCancellationBarrier(CancelCheckpointMarker cancelBarrier) throws Exception {
+		final long barrierId = cancelBarrier.getCheckpointId();
+
+		if (numBarrierConsumed > 0) {
+			// this is only true if some alignment is in progress and nothing was canceled
+
+			if (barrierId == currentCheckpointId) {
+				// cancel this alignment
+				if (LOG.isDebugEnabled()) {
+					LOG.debug("{}: Checkpoint {} canceled, aborting alignment.", taskName, barrierId);
+				}
+
+				releaseBlocksAndResetBarriers();
+				notifyAbortOnCancellationBarrier(barrierId);
+			}
+			else if (barrierId > currentCheckpointId) {
+				// we canceled the next which also cancels the current
+				LOG.warn("{}: Received cancellation barrier for checkpoint {} before completing current checkpoint {}. " +
+						"Skipping current checkpoint.",
+					taskName,
+					barrierId,
+					currentCheckpointId);
+
+				// this stops the current alignment
+				releaseBlocksAndResetBarriers();
+
+				// the next checkpoint starts as canceled
+				currentCheckpointId = barrierId;
+				threadSafeUnaligner.setCurrentCheckpointId(currentCheckpointId);
+				notifyAbortOnCancellationBarrier(barrierId);
+			}
+
+			// else: ignore trailing (cancellation) barrier from an earlier checkpoint (obsolete now)
+
+		}
+		else if (barrierId > currentCheckpointId) {
+			// first barrier of a new checkpoint is directly a cancellation
+
+			// by setting the currentCheckpointId to this checkpoint while keeping the numBarriers
+			// at zero means that no checkpoint barrier can start a new alignment
+			currentCheckpointId = barrierId;
+			threadSafeUnaligner.setCurrentCheckpointId(currentCheckpointId);
+
+			if (LOG.isDebugEnabled()) {
+				LOG.debug("{}: Checkpoint {} canceled, skipping alignment.", taskName, barrierId);
+			}
+
+			notifyAbortOnCancellationBarrier(barrierId);
+		}
+
+		// else: trailing barrier from either
+		//   - a previous (subsumed) checkpoint
+		//   - the current checkpoint if it was already canceled
+		return false;
+	}
+
+	@Override
+	public boolean processEndOfPartition() throws Exception {
+		threadSafeUnaligner.processEndOfPartition();
+
+		if (numBarrierConsumed > 0) {
+			// let the task know we skip a checkpoint
+			notifyAbort(
+				currentCheckpointId,
+				new CheckpointException(CheckpointFailureReason.CHECKPOINT_DECLINED_INPUT_END_OF_STREAM));
+			// no chance to complete this checkpoint
+			releaseBlocksAndResetBarriers();
+			return true;
+		}
+		return false;
+	}
+
+	@Override
+	public long getLatestCheckpointId() {
+		return currentCheckpointId;
+	}
+
+	@Override
+	public long getAlignmentDurationNanos() {
+		return 0;
+	}
+
+	@Override
+	public String toString() {
+		return String.format("%s: last checkpoint: %d", taskName, currentCheckpointId);
+	}
+
+	@Override
+	public void checkpointSizeLimitExceeded(long maxBufferedBytes) {
+	}
+
+	@Override
+	public void close() throws IOException {
+		super.close();
+		threadSafeUnaligner.close();
+	}
+
+	@Override
+	protected boolean isBarrierConsumed(long checkpointId, int channelIndex) {
+		if (checkpointId < currentCheckpointId) {
+			return true;
+		}
+		if (checkpointId > currentCheckpointId) {
+			return false;
+		}
+		return barrierConsumedChannels[channelIndex];
+	}
+
+	public CompletableFuture<Void> getAllBarriersReceivedFuture(long checkpointId) {
+		return threadSafeUnaligner.getAllBarriersReceivedFuture(checkpointId);
+	}
+
+	@Override
+	public Optional<BufferReceivedListener> getBufferReceivedListener() {
+		return Optional.of(threadSafeUnaligner);
+	}
+
+	private int getFlattenedChannelIndex(InputChannelInfo channelInfo) {
+		return gateChannelOffsets[channelInfo.getGateIdx()] + channelInfo.getInputChannelIdx();
+	}
+
+	private static class ThreadSafeUnaligner implements BufferReceivedListener, Closeable {
 
 Review comment:
   This static class has similar members with its enclosing class which is confusing to me.
   Should we extract it to a separate file?
   
   Also, mark it `@ThreadSafe` and `@NotThreadUnsafe CheckpointBarrierUnaligner` 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r402909258
 
 

 ##########
 File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/CheckpointBarrierUnaligner.java
 ##########
 @@ -0,0 +1,242 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.streaming.runtime.io;
+
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.runtime.checkpoint.channel.ChannelStateWriter;
+import org.apache.flink.runtime.checkpoint.channel.InputChannelInfo;
+import org.apache.flink.runtime.io.network.api.CancelCheckpointMarker;
+import org.apache.flink.runtime.io.network.api.CheckpointBarrier;
+import org.apache.flink.runtime.io.network.buffer.Buffer;
+import org.apache.flink.runtime.jobgraph.tasks.AbstractInvokable;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import javax.annotation.Nullable;
+
+import java.util.Arrays;
+import java.util.concurrent.CompletableFuture;
+
+import static org.apache.flink.util.Preconditions.checkNotNull;
+
+/**
+ * {@link CheckpointBarrierUnaligner} is used for triggering checkpoint while reading the first barrier
+ * and keeping track of the number of received barriers and consumed barriers.
+ */
+@Internal
+public class CheckpointBarrierUnaligner extends CheckpointBarrierHandler {
+
+	private static final Logger LOG = LoggerFactory.getLogger(CheckpointBarrierUnaligner.class);
+
+	private final String taskName;
+
+	/**
+	 * Tag the state of which input channel has read the barrier. If one channel has read the barrier by task,
+	 * the respective in-flight input buffers should be empty when triggering unaligned checkpoint.
+	 */
+	private final boolean[] barrierConsumedChannels;
+
+	/**
+	 * Tag the state of which input channel has received the barrier. Until the barrier of a specific channel is
+	 * received, all new buffers need to be persisted after unaligned checkpointing has been started.
+	 */
+	private final boolean[] barrierReceivedChannels;
+
+	/**
+	 * Contains the offsets of the channel indices for each gate when flattening the channels of all gates.
+	 *
+	 * <p>For example, consider 3 gates with 4 channels, {@code gateChannelOffsets = [0, 4, 8]}.
+	 */
+	private final int[] gateChannelOffsets;
+
+	/**
+	 * The number of input channels which has read the barrier by task.
+	 */
+	private int numBarriersReceived;
+
+	/**
+	 * The checkpoint id to guarantee that we would trigger only one checkpoint when reading the same barrier from
+	 * different channels.
+	 */
+	private long currentCheckpointId = -1L;
+
+	private final ChannelStateWriter channelStateWriter;
+
+	private CompletableFuture<?> allBarriersReceivedFuture;
+
+	CheckpointBarrierUnaligner(
+			int[] numberOfInputChannelsPerGate,
+			ChannelStateWriter channelStateWriter,
+			String taskName,
+			@Nullable AbstractInvokable toNotifyOnCheckpoint) {
+		super(toNotifyOnCheckpoint);
+
+		this.taskName = taskName;
+		this.channelStateWriter = checkNotNull(channelStateWriter);
+
+		final int numGates = numberOfInputChannelsPerGate.length;
+
+		gateChannelOffsets = new int[numGates];
+		for (int index = 1; index < numGates; index++) {
+			gateChannelOffsets[index] = gateChannelOffsets[index - 1] + numberOfInputChannelsPerGate[index - 1];
+		}
+
+		final int totalNumChannels = gateChannelOffsets[numGates - 1] + numberOfInputChannelsPerGate[numGates - 1];
+		barrierConsumedChannels = new boolean[totalNumChannels];
+		Arrays.fill(barrierConsumedChannels, true);
+		barrierReceivedChannels = new boolean[totalNumChannels];
+		Arrays.fill(barrierReceivedChannels, true);
+	}
+
+	@Override
+	public void releaseBlocksAndResetBarriers() {
+	}
+
+	/**
+	 * For unaligned checkpoint, it never blocks processing from the task aspect.
+	 *
+	 * <p>For PoC, we do not consider the possibility that the unaligned checkpoint would
+	 * not perform due to the max configured unaligned checkpoint size.
+	 */
+	@Override
+	public boolean isBlocked(int channelIndex) {
+		return false;
+	}
+
+	/**
+	 * We still need to trigger checkpoint while reading the first barrier from one channel, because this might happen
+	 * earlier than the previous async trigger via mailbox by netty thread. And the {@link AbstractInvokable} has the
+	 * deduplication logic to guarantee trigger checkpoint only once finally.
+	 *
+	 * <p>Note this is also suitable for the trigger case of local input channel.
+	 */
+	@Override
+	public synchronized boolean processBarrier(
+			CheckpointBarrier receivedBarrier,
+			int channelIndex,
+			long bufferedBytes) {
+		long barrierId = receivedBarrier.getId();
+		if (checkNewCheckpoint(barrierId)) {
+			notifyCheckpointAsync(receivedBarrier, bufferedBytes, 0);
+		}
+		barrierConsumedChannels[channelIndex] = true;
+		return false;
+	}
+
+	@Override
+	public boolean processCancellationBarrier(CancelCheckpointMarker cancelBarrier) {
+		return false;
+	}
+
+	@Override
+	public boolean processEndOfPartition() {
+		return false;
+	}
+
+	@Override
+	public long getLatestCheckpointId() {
+		return currentCheckpointId;
+	}
+
+	@Override
+	public long getAlignmentDurationNanos() {
+		return 0;
+	}
+
+	@Override
+	public String toString() {
+		return String.format("%s: last checkpoint: %d", taskName, currentCheckpointId);
+	}
+
+	@Override
+	public void checkpointSizeLimitExceeded(long maxBufferedBytes) {
+	}
+
+	@Override
+	protected boolean isBarrierConsumed(long checkpointId, int channelIndex) {
+		if (checkpointId < currentCheckpointId) {
+			return true;
+		}
+		if (checkpointId > currentCheckpointId) {
+			return false;
+		}
+		return barrierConsumedChannels[channelIndex];
+	}
+
+	public CompletableFuture<?> getAllBarriersReceivedFuture(long checkpointId) {
 
 Review comment:
   Please double-check the threading model and look for potential concurrency issues.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] pnowojski commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
pnowojski commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r399260140
 
 

 ##########
 File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/CheckpointBarrierUnaligner.java
 ##########
 @@ -0,0 +1,242 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.streaming.runtime.io;
+
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.runtime.checkpoint.channel.ChannelStateWriter;
+import org.apache.flink.runtime.checkpoint.channel.InputChannelInfo;
+import org.apache.flink.runtime.io.network.api.CancelCheckpointMarker;
+import org.apache.flink.runtime.io.network.api.CheckpointBarrier;
+import org.apache.flink.runtime.io.network.buffer.Buffer;
+import org.apache.flink.runtime.jobgraph.tasks.AbstractInvokable;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import javax.annotation.Nullable;
+
+import java.util.Arrays;
+import java.util.concurrent.CompletableFuture;
+
+import static org.apache.flink.util.Preconditions.checkNotNull;
+
+/**
+ * {@link CheckpointBarrierUnaligner} is used for triggering checkpoint while reading the first barrier
+ * and keeping track of the number of received barriers and consumed barriers.
+ */
+@Internal
+public class CheckpointBarrierUnaligner extends CheckpointBarrierHandler {
+
+	private static final Logger LOG = LoggerFactory.getLogger(CheckpointBarrierUnaligner.class);
+
+	private final String taskName;
+
+	/**
+	 * Tag the state of which input channel has read the barrier. If one channel has read the barrier by task,
+	 * the respective in-flight input buffers should be empty when triggering unaligned checkpoint.
+	 */
+	private final boolean[] barrierConsumedChannels;
+
+	/**
+	 * Tag the state of which input channel has received the barrier. Until the barrier of a specific channel is
+	 * received, all new buffers need to be persisted after unaligned checkpointing has been started.
+	 */
+	private final boolean[] barrierReceivedChannels;
+
+	/**
+	 * Contains the offsets of the channel indices for each gate when flattening the channels of all gates.
+	 *
+	 * <p>For example, consider 3 gates with 4 channels, {@code gateChannelOffsets = [0, 4, 8]}.
+	 */
+	private final int[] gateChannelOffsets;
+
+	/**
+	 * The number of input channels which has read the barrier by task.
+	 */
+	private int numBarriersReceived;
+
+	/**
+	 * The checkpoint id to guarantee that we would trigger only one checkpoint when reading the same barrier from
+	 * different channels.
+	 */
+	private long currentCheckpointId = -1L;
+
+	private final ChannelStateWriter channelStateWriter;
+
+	private CompletableFuture<?> allBarriersReceivedFuture;
+
+	CheckpointBarrierUnaligner(
+			int[] numberOfInputChannelsPerGate,
+			ChannelStateWriter channelStateWriter,
+			String taskName,
+			@Nullable AbstractInvokable toNotifyOnCheckpoint) {
+		super(toNotifyOnCheckpoint);
+
+		this.taskName = taskName;
+		this.channelStateWriter = checkNotNull(channelStateWriter);
+
+		final int numGates = numberOfInputChannelsPerGate.length;
+
+		gateChannelOffsets = new int[numGates];
+		for (int index = 1; index < numGates; index++) {
+			gateChannelOffsets[index] = gateChannelOffsets[index - 1] + numberOfInputChannelsPerGate[index - 1];
+		}
+
+		final int totalNumChannels = gateChannelOffsets[numGates - 1] + numberOfInputChannelsPerGate[numGates - 1];
+		barrierConsumedChannels = new boolean[totalNumChannels];
+		Arrays.fill(barrierConsumedChannels, true);
+		barrierReceivedChannels = new boolean[totalNumChannels];
+		Arrays.fill(barrierReceivedChannels, true);
+	}
+
+	@Override
+	public void releaseBlocksAndResetBarriers() {
+	}
+
+	/**
+	 * For unaligned checkpoint, it never blocks processing from the task aspect.
+	 *
+	 * <p>For PoC, we do not consider the possibility that the unaligned checkpoint would
+	 * not perform due to the max configured unaligned checkpoint size.
+	 */
+	@Override
+	public boolean isBlocked(int channelIndex) {
+		return false;
+	}
+
+	/**
+	 * We still need to trigger checkpoint while reading the first barrier from one channel, because this might happen
+	 * earlier than the previous async trigger via mailbox by netty thread. And the {@link AbstractInvokable} has the
+	 * deduplication logic to guarantee trigger checkpoint only once finally.
+	 *
+	 * <p>Note this is also suitable for the trigger case of local input channel.
+	 */
+	@Override
+	public synchronized boolean processBarrier(
+			CheckpointBarrier receivedBarrier,
+			int channelIndex,
+			long bufferedBytes) {
+		long barrierId = receivedBarrier.getId();
+		if (checkNewCheckpoint(barrierId)) {
+			notifyCheckpointAsync(receivedBarrier, bufferedBytes, 0);
+		}
+		barrierConsumedChannels[channelIndex] = true;
+		return false;
+	}
+
+	@Override
+	public boolean processCancellationBarrier(CancelCheckpointMarker cancelBarrier) {
+		return false;
+	}
+
+	@Override
+	public boolean processEndOfPartition() {
+		return false;
+	}
+
+	@Override
+	public long getLatestCheckpointId() {
+		return currentCheckpointId;
+	}
+
+	@Override
+	public long getAlignmentDurationNanos() {
+		return 0;
+	}
+
+	@Override
+	public String toString() {
+		return String.format("%s: last checkpoint: %d", taskName, currentCheckpointId);
+	}
+
+	@Override
+	public void checkpointSizeLimitExceeded(long maxBufferedBytes) {
+	}
+
+	@Override
+	protected boolean isBarrierConsumed(long checkpointId, int channelIndex) {
+		if (checkpointId < currentCheckpointId) {
+			return true;
+		}
+		if (checkpointId > currentCheckpointId) {
+			return false;
+		}
+		return barrierConsumedChannels[channelIndex];
+	}
+
+	public CompletableFuture<?> getAllBarriersReceivedFuture(long checkpointId) {
 
 Review comment:
   +1 for this. I think there are both visibility issues (maybe masked by touching other volatile/synchronized variables) and race condition (probably not visible now because of not very frequent checkpointing).
   
   We could either add more synchronisation here, but I would prefer to avoid that. 
   
   Could we move out `allBarriersReceivedFuture` from the network thread scope, to the task/mailbox thread scope? And use mailbox actions enqueued from the network thread to update those variables? Like currently we are already firing `notifyCheckpointAsync` when we are creating new `allBarriersReceivedFuture` just after `checkNewCheckpoint()`. We could move the `allBarriersReceivedFuture.complete(null);` logic (or it's equivalent) into the mailbox as well.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zhijiangW commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
zhijiangW commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r400831304
 
 

 ##########
 File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/CheckpointConfig.java
 ##########
 @@ -378,6 +381,48 @@ public void setPreferCheckpointForRecovery(boolean preferCheckpointForRecovery)
 		this.preferCheckpointForRecovery = preferCheckpointForRecovery;
 	}
 
+	/**
+	 * Enables unaligned checkpoints, which greatly reduce checkpointing times under backpressure.
 
 Review comment:
   nit: reduce -> reduces

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r404299271
 
 

 ##########
 File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
 ##########
 @@ -845,21 +845,19 @@ public ExecutorService getAsyncOperationsThreadPool() {
 
 	private void notifyCheckpointComplete(long checkpointId) {
 		try {
-			boolean success = actionExecutor.call(() -> {
 
 Review comment:
   `actionExecutor` was added during checkpoint lock deprecation to unify `SourceStreamTask` and `StreamTask`. 
   Basically, under `StreamTask` it's a no-op operation going through `StreamTaskActionExecutor.IMMEDIATE`, while `SourceStreamTask` is using `StreamTaskActionExecutor#SynchronizedStreamTaskActionExecutor`, which acquires checkpoint lock for all operations.
   None of these implementations use mailbox for any task. However, the `Mailbox` internally uses the `StreamTaskActionExecutor`.
   I agree that the naming and the tight integration into the `MailboxExecutor` makes it hard to understand at first. Luckily, we can get rid of it, once FLIP-27 is fully implemented and we can get rid of legacy source thread (so in about 3 years? ;)).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#issuecomment-603776093
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6621",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155064201",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155877268",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6755",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6839",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156597180",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6846",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156864478",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6873",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156994047",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157330632",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6900",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157451694",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6916",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157494634",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6933",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157589655",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6944",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6991",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157754467",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158102285",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7007",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7023",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158153241",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158188400",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7040",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7048",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158276096",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158831429",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7117",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7121",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158855200",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159112519",
       "triggerID" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7172",
       "triggerID" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159143719",
       "triggerID" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7175",
       "triggerID" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "triggerType" : "PUSH"
     }, {
       "hash" : "35ec088ef24e841beae78c33488975d2d8d0a40d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "35ec088ef24e841beae78c33488975d2d8d0a40d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7194",
       "triggerID" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159244661",
       "triggerID" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "triggerType" : "PUSH"
     }, {
       "hash" : "334458afaa98b601eec12c490e71caa8274be055",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "334458afaa98b601eec12c490e71caa8274be055",
       "triggerType" : "PUSH"
     }, {
       "hash" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7212",
       "triggerID" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "triggerType" : "PUSH"
     }, {
       "hash" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159269141",
       "triggerID" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7226",
       "triggerID" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159307415",
       "triggerID" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7297",
       "triggerID" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159652918",
       "triggerID" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "559816dcea4999dd46b09ee1091ddc0e1a5a7a54",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "559816dcea4999dd46b09ee1091ddc0e1a5a7a54",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6cd76afe4990f56a5166e1592374aa8f86fe883f",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "6cd76afe4990f56a5166e1592374aa8f86fe883f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7302",
       "triggerID" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159678447",
       "triggerID" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "status" : "CANCELED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159695914",
       "triggerID" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7305",
       "triggerID" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ac996f5c703560ecbe6cad7394cc8ad54d6f0029",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "ac996f5c703560ecbe6cad7394cc8ad54d6f0029",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * dee2b337e5e72d8f7b1f5098b74f2958d000fb3c UNKNOWN
   * 80b7f76f24b5fb6704a4b2292543f8764ec19053 UNKNOWN
   * 35ec088ef24e841beae78c33488975d2d8d0a40d UNKNOWN
   * 334458afaa98b601eec12c490e71caa8274be055 UNKNOWN
   * 559816dcea4999dd46b09ee1091ddc0e1a5a7a54 UNKNOWN
   * 6cd76afe4990f56a5166e1592374aa8f86fe883f UNKNOWN
   * a7dd8d3321593ab8211487c0ad27eb299e876a8a Travis: [CANCELED](https://travis-ci.com/github/flink-ci/flink/builds/159695914) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7305) 
   * ac996f5c703560ecbe6cad7394cc8ad54d6f0029 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#issuecomment-603776093
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6621",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155064201",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155877268",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6755",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6839",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156597180",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6846",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156864478",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6873",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156994047",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157330632",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6900",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157451694",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6916",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157494634",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6933",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157589655",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6944",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6991",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157754467",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "FAILURE",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158102285",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7007",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * dee2b337e5e72d8f7b1f5098b74f2958d000fb3c UNKNOWN
   * 80b7f76f24b5fb6704a4b2292543f8764ec19053 UNKNOWN
   * 77476642d8fe2f648f2079fc9e4b43c9506c2024 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/158102285) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7007) 
   * 9b2544fc4e77e2fb607cb801f24d6fa970387517 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] rkhachatryan commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r408039235
 
 

 ##########
 File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/CheckpointBarrierUnaligner.java
 ##########
 @@ -0,0 +1,431 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.streaming.runtime.io;
+
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.runtime.checkpoint.CheckpointException;
+import org.apache.flink.runtime.checkpoint.CheckpointFailureReason;
+import org.apache.flink.runtime.checkpoint.channel.ChannelStateWriter;
+import org.apache.flink.runtime.checkpoint.channel.InputChannelInfo;
+import org.apache.flink.runtime.concurrent.FutureUtils;
+import org.apache.flink.runtime.io.network.api.CancelCheckpointMarker;
+import org.apache.flink.runtime.io.network.api.CheckpointBarrier;
+import org.apache.flink.runtime.io.network.buffer.Buffer;
+import org.apache.flink.runtime.io.network.buffer.BufferReceivedListener;
+import org.apache.flink.runtime.jobgraph.tasks.AbstractInvokable;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import javax.annotation.concurrent.NotThreadSafe;
+import javax.annotation.concurrent.ThreadSafe;
+
+import java.io.Closeable;
+import java.io.IOException;
+import java.util.Arrays;
+import java.util.Optional;
+import java.util.concurrent.CompletableFuture;
+import java.util.function.Function;
+import java.util.stream.IntStream;
+
+import static org.apache.flink.util.Preconditions.checkNotNull;
+
+/**
+ * {@link CheckpointBarrierUnaligner} is used for triggering checkpoint while reading the first barrier
+ * and keeping track of the number of received barriers and consumed barriers.
+ */
+@Internal
+@NotThreadSafe
+public class CheckpointBarrierUnaligner extends CheckpointBarrierHandler {
+
+	private static final Logger LOG = LoggerFactory.getLogger(CheckpointBarrierUnaligner.class);
+
+	private final String taskName;
+
+	/**
+	 * Tag the state of which input channel has pending in-flight buffers; that is, already received buffers that
+	 * predate the checkpoint barrier of the current checkpoint.
+	 */
+	private final boolean[] hasInflightBuffers;
+
+	private int numBarrierConsumed;
+
+	/**
+	 * Contains the offsets of the channel indices for each gate when flattening the channels of all gates.
+	 *
+	 * <p>For example, consider 3 gates with 4 channels, {@code gateChannelOffsets = [0, 4, 8]}.
+	 */
+	private final int[] gateChannelOffsets;
+
+	private final InputChannelInfo[] channelInfos;
+
+	/**
+	 * The checkpoint id to guarantee that we would trigger only one checkpoint when reading the same barrier from
+	 * different channels.
+	 *
+	 * <p>Note: this checkpoint is valid in respect to <b>consumed</b> barriers in contrast to
+	 * {@link ThreadSafeUnaligner#currentReceivedCheckpointId}.
+	 */
+	private long currentConsumedCheckpointId = -1L;
+
+	/** Encapsulates state that is shared between netty threads and task thread. */
+	private final ThreadSafeUnaligner threadSafeUnaligner;
+
+	CheckpointBarrierUnaligner(
+			int[] numberOfInputChannelsPerGate,
+			ChannelStateWriter channelStateWriter,
+			String taskName,
+			AbstractInvokable toNotifyOnCheckpoint) {
+		super(toNotifyOnCheckpoint);
+
+		this.taskName = taskName;
+
+		final int numGates = numberOfInputChannelsPerGate.length;
+
+		gateChannelOffsets = new int[numGates];
+		for (int index = 1; index < numGates; index++) {
+			gateChannelOffsets[index] = gateChannelOffsets[index - 1] + numberOfInputChannelsPerGate[index - 1];
+		}
+
+		final int totalNumChannels = gateChannelOffsets[numGates - 1] + numberOfInputChannelsPerGate[numGates - 1];
+		hasInflightBuffers = new boolean[totalNumChannels];
+
+		channelInfos = IntStream.range(0, numGates)
+			.mapToObj(gateIndex -> IntStream.range(0, numberOfInputChannelsPerGate[gateIndex])
+				.mapToObj(channelIndex -> new InputChannelInfo(gateIndex, channelIndex)))
+			.flatMap(Function.identity())
+			.toArray(InputChannelInfo[]::new);
+
+		threadSafeUnaligner = new ThreadSafeUnaligner(totalNumChannels,	checkNotNull(channelStateWriter), this);
+	}
+
+	@Override
+	public void releaseBlocksAndResetBarriers() {
+		// make sure no additional data is persisted
+		Arrays.fill(hasInflightBuffers, false);
+		threadSafeUnaligner.resetReceivedBarriers(currentConsumedCheckpointId);
+		// the next barrier that comes must assume it is the first
+		numBarrierConsumed = 0;
+	}
+
+	/**
+	 * For unaligned checkpoint, it never blocks processing from the task aspect.
+	 *
+	 * <p>For PoC, we do not consider the possibility that the unaligned checkpoint would
+	 * not perform due to the max configured unaligned checkpoint size.
+	 */
+	@Override
+	public boolean isBlocked(int channelIndex) {
+		return false;
+	}
+
+	/**
+	 * We still need to trigger checkpoint while reading the first barrier from one channel, because this might happen
+	 * earlier than the previous async trigger via mailbox by netty thread. And the {@link AbstractInvokable} has the
+	 * deduplication logic to guarantee trigger checkpoint only once finally.
+	 *
+	 * <p>Note this is also suitable for the trigger case of local input channel.
+	 */
+	@Override
+	public boolean processBarrier(
+			CheckpointBarrier receivedBarrier,
+			int channelIndex,
+			long bufferedBytes) {
+		long barrierId = receivedBarrier.getId();
+		if (currentConsumedCheckpointId < barrierId) {
+			currentConsumedCheckpointId = barrierId;
+			numBarrierConsumed = 0;
+			Arrays.fill(hasInflightBuffers, true);
+		}
+		if (currentConsumedCheckpointId == barrierId) {
+			hasInflightBuffers[channelIndex] = false;
+			numBarrierConsumed++;
+		}
+		// processBarrier is called from task thread and can actually happen before notifyBarrierReceived on empty
+		// buffer queues
+		// to avoid replicating any logic, we simply call notifyBarrierReceived here as well
+		threadSafeUnaligner.notifyBarrierReceived(receivedBarrier, channelInfos[channelIndex]);
+		return false;
+	}
+
+	@Override
+	public boolean processCancellationBarrier(CancelCheckpointMarker cancelBarrier) throws Exception {
+		final long barrierId = cancelBarrier.getCheckpointId();
+
+		if (numBarrierConsumed > 0) {
+			// this is only true if some alignment is in progress and nothing was canceled
+
+			if (barrierId == currentConsumedCheckpointId) {
+				// cancel this alignment
+				if (LOG.isDebugEnabled()) {
+					LOG.debug("{}: Checkpoint {} canceled, aborting alignment.", taskName, barrierId);
+				}
+
+				releaseBlocksAndResetBarriers();
+				notifyAbortOnCancellationBarrier(barrierId);
+			}
+			else if (barrierId > currentConsumedCheckpointId) {
+				// we canceled the next which also cancels the current
+				LOG.warn("{}: Received cancellation barrier for checkpoint {} before completing current checkpoint {}. " +
+						"Skipping current checkpoint.",
+					taskName,
+					barrierId,
+					currentConsumedCheckpointId);
+
+				// this stops the current alignment
+				releaseBlocksAndResetBarriers();
+
+				// the next checkpoint starts as canceled
+				currentConsumedCheckpointId = barrierId;
+				threadSafeUnaligner.setCurrentReceivedCheckpointId(currentConsumedCheckpointId);
+				notifyAbortOnCancellationBarrier(barrierId);
+			}
+
+			// else: ignore trailing (cancellation) barrier from an earlier checkpoint (obsolete now)
+
+		}
+		else if (barrierId > currentConsumedCheckpointId) {
+			// first barrier of a new checkpoint is directly a cancellation
+
+			// by setting the currentCheckpointId to this checkpoint while keeping the numBarriers
+			// at zero means that no checkpoint barrier can start a new alignment
+			currentConsumedCheckpointId = barrierId;
+			threadSafeUnaligner.setCurrentReceivedCheckpointId(currentConsumedCheckpointId);
+
+			if (LOG.isDebugEnabled()) {
+				LOG.debug("{}: Checkpoint {} canceled, skipping alignment.", taskName, barrierId);
+			}
+
+			notifyAbortOnCancellationBarrier(barrierId);
+		}
+
+		// else: trailing barrier from either
+		//   - a previous (subsumed) checkpoint
+		//   - the current checkpoint if it was already canceled
+		return false;
+	}
+
+	@Override
+	public boolean processEndOfPartition() throws Exception {
+		threadSafeUnaligner.onChannelClosed();
+
+		if (numBarrierConsumed > 0) {
+			// let the task know we skip a checkpoint
+			notifyAbort(
+				currentConsumedCheckpointId,
+				new CheckpointException(CheckpointFailureReason.CHECKPOINT_DECLINED_INPUT_END_OF_STREAM));
+			// no chance to complete this checkpoint
+			releaseBlocksAndResetBarriers();
+			return true;
+		}
+		return false;
+	}
+
+	@Override
+	public long getLatestCheckpointId() {
+		return currentConsumedCheckpointId;
+	}
+
+	@Override
+	public long getAlignmentDurationNanos() {
+		return 0;
+	}
+
+	@Override
+	public String toString() {
+		return String.format("%s: last checkpoint: %d", taskName, currentConsumedCheckpointId);
+	}
+
+	@Override
+	public void checkpointSizeLimitExceeded(long maxBufferedBytes) {
+	}
+
+	@Override
+	public void close() throws IOException {
+		super.close();
+		threadSafeUnaligner.close();
+	}
+
+	/**
+	 * Returns true if there is in-flight data in the buffers for the given channel and checkpoint. More specifically,
+	 * this method returns true iff the unaligner still expects the respective barrier to be <i>consumed</i> on the
+	 * that channel.
+	 */
+	public boolean hasInflightData(long checkpointId, int channelIndex) {
+		if (checkpointId < currentConsumedCheckpointId) {
+			return false;
+		}
+		if (checkpointId > currentConsumedCheckpointId) {
+			return true;
+		}
+		return hasInflightBuffers[channelIndex];
+	}
+
+	public CompletableFuture<Void> getAllBarriersReceivedFuture(long checkpointId) {
+		return threadSafeUnaligner.getAllBarriersReceivedFuture(checkpointId);
+	}
+
+	@Override
+	public Optional<BufferReceivedListener> getBufferReceivedListener() {
+		return Optional.of(threadSafeUnaligner);
+	}
+
+	private int getFlattenedChannelIndex(InputChannelInfo channelInfo) {
+		return gateChannelOffsets[channelInfo.getGateIdx()] + channelInfo.getInputChannelIdx();
+	}
+
+	@ThreadSafe
+	private static class ThreadSafeUnaligner implements BufferReceivedListener, Closeable {
+
+		/**
+		 * Tag the state of which input channel has not received the barrier, such that newly arriving buffers need
+		 * to be written in the unaligned checkpoint.
+		 */
+		private final boolean[] storeNewBuffers;
+
+		/**
+		 * The number of input channels which has read the barrier by task.
+		 */
+		private int numBarriersReceived;
+
+		/** A future indicating that all barriers of the a given checkpoint have been read. */
+		private CompletableFuture<Void> allBarriersReceivedFuture = FutureUtils.completedVoidFuture();
+
+		/**
+		 * The checkpoint id to guarantee that we would trigger only one checkpoint when reading the same barrier from
+		 * different channels.
+		 *
+		 * <p>Note: this checkpoint is valid in respect to <b>received</b> barriers in contrast to
+		 * {@link CheckpointBarrierUnaligner#currentConsumedCheckpointId}.
+		 */
+		private long currentReceivedCheckpointId = -1L;
+
+		/** The number of opened channels. */
+		private int numOpenChannels;
+
+		private final ChannelStateWriter channelStateWriter;
+
+		private final CheckpointBarrierUnaligner handler;
+
+		public ThreadSafeUnaligner(
+				int totalNumChannels,
+				ChannelStateWriter channelStateWriter,
+				CheckpointBarrierUnaligner handler) {
+			storeNewBuffers = new boolean[totalNumChannels];
+			this.channelStateWriter = channelStateWriter;
+			this.handler = handler;
+			numOpenChannels = totalNumChannels;
+		}
+
+		@Override
+		public synchronized void notifyBarrierReceived(CheckpointBarrier barrier, InputChannelInfo channelInfo) {
+			long barrierId = barrier.getId();
+
+			if (currentReceivedCheckpointId < barrierId) {
+				handleNewCheckpoint(barrier);
+				handler.runInTaskThread(() -> handler.notifyCheckpoint(barrier, 0, 0), "notifyCheckpoint");
+			}
+
+			int channelIndex = handler.getFlattenedChannelIndex(channelInfo);
+			if (barrierId == currentReceivedCheckpointId && storeNewBuffers[channelIndex]) {
+				if (LOG.isDebugEnabled()) {
+					LOG.debug("{}: Received barrier from channel {} @ {}.", handler.taskName, channelIndex, barrierId);
+				}
+
+				storeNewBuffers[channelIndex] = false;
+
+				if (++numBarriersReceived == numOpenChannels) {
+					allBarriersReceivedFuture.complete(null);
+				}
+			}
+		}
+
+		@Override
+		public synchronized void notifyBufferReceived(Buffer buffer, InputChannelInfo channelInfo) {
+			if (storeNewBuffers[handler.getFlattenedChannelIndex(channelInfo)]) {
+				channelStateWriter.addInputData(
+					currentReceivedCheckpointId,
+					channelInfo,
+					ChannelStateWriter.SEQUENCE_NUMBER_UNKNOWN,
+					buffer);
+			} else {
+				buffer.recycleBuffer();
+			}
+		}
+
+		@Override
+		public void close() throws IOException {
+			allBarriersReceivedFuture.cancel(false);
+		}
+
+		private synchronized void handleNewCheckpoint(CheckpointBarrier barrier) {
+			long barrierId = barrier.getId();
+			if (!allBarriersReceivedFuture.isDone()) {
+				// we did not complete the current checkpoint, another started before
+				LOG.warn("{}: Received checkpoint barrier for checkpoint {} before completing current checkpoint {}. " +
+						"Skipping current checkpoint.",
+					handler.taskName,
+					barrierId,
+					currentReceivedCheckpointId);
+
+				// let the task know we are not completing this
+				long currentCheckpointId = currentReceivedCheckpointId;
+				handler.runInTaskThread(() ->
+					handler.notifyAbort(currentCheckpointId,
+						new CheckpointException(
+							"Barrier id: " + barrierId,
+							CheckpointFailureReason.CHECKPOINT_DECLINED_SUBSUMED)),
+					"notifyAbort");
+			}
+
+			currentReceivedCheckpointId = barrierId;
+			Arrays.fill(storeNewBuffers, true);
+			numBarriersReceived = 0;
+			allBarriersReceivedFuture = new CompletableFuture<>();
+			channelStateWriter.start(barrierId, barrier.getCheckpointOptions());
 
 Review comment:
   As I understood, `channelStateWriter.finishInput` is called when this `allBarriersReceivedFuture` is completed. 
   But in a quite entangled manner: `StreamTask.prepareInputSnapshot -> InputProcessor -> InputGate -> Unaligner -> ThreadSafeUnaligner (this`).
   Why don't we set this callback right here?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] rkhachatryan commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r407984986
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
 ##########
 @@ -523,15 +557,18 @@ public void onBuffer(Buffer buffer, int sequenceNumber, int backlog) throws IOEx
 					return;
 				}
 
-				if (expectedSequenceNumber != sequenceNumber) {
-					onError(new BufferReorderingException(expectedSequenceNumber, sequenceNumber));
-					return;
-				}
-
 				wasEmpty = receivedBuffers.isEmpty();
 				receivedBuffers.add(buffer);
-				recycleBuffer = false;
+
+				if (hasListener) {
+					if (buffer.isBuffer() && receivedCheckpointId < lastRequestedCheckpointId) {
+						notifyReceivedBuffer = buffer.retainBuffer();
+					} else {
+						notifyReceivedBarrier = parseCheckpointBarrierOrNull(buffer);
 
 Review comment:
   Could this parsing be done outside of the `synchronized` block? (I assume it is relatively slow).
   
   This would also simplify code as we wouldn't need to declare `notifyReceivedBarrier` in advance.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r404302316
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/InputGate.java
 ##########
 @@ -107,6 +107,20 @@
 		return availabilityHelper.getAvailableFuture();
 	}
 
+	/**
+	 * Returns the index of this gate in respect to the consuming operator instance.
+	 */
+	public int getGateIndex() {
+		throw new UnsupportedOperationException();
 
 Review comment:
   It was a bit harder to do because of `InputGateWithMetrics` which also needs to have the `getIndex` as it is usually passed to `UnionInputGate`. So I added an extra commit that introduces `IndexedInputGate`. Only this `InputGate` has an `getIndex` and union gate can only be composed by these gates (turning the runtime into a compile time check).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#issuecomment-603776093
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6621",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155064201",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155877268",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6755",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6839",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156597180",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6846",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156864478",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6873",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156994047",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157330632",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6900",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157451694",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6916",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157494634",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6933",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157589655",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6944",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6991",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157754467",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158102285",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7007",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7023",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158153241",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * dee2b337e5e72d8f7b1f5098b74f2958d000fb3c UNKNOWN
   * 80b7f76f24b5fb6704a4b2292543f8764ec19053 UNKNOWN
   * 9b2544fc4e77e2fb607cb801f24d6fa970387517 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/158153241) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7023) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] rkhachatryan commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r398953446
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/SingleInputGate.java
 ##########
 @@ -170,9 +173,14 @@
 
 	private final CompletableFuture<Void> closeFuture;
 
+	@Nullable
+	protected BufferReceivedListener bufferReceivedListener;
 
 Review comment:
   I see this field is set by the task thread, but it is read by the network thread (right?).
   I'm pretty sure in most of the cases there is a fence, but we can't guarantee it.
   Should we make it `final` or `volatile`?
   
   (we could cache `volatile` value if we guarantee that it's never changed once set).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r402257164
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/SingleInputGate.java
 ##########
 @@ -170,9 +173,14 @@
 
 	private final CompletableFuture<Void> closeFuture;
 
+	@Nullable
+	protected BufferReceivedListener bufferReceivedListener;
 
 Review comment:
   Yes added a guard to avoid it being reset.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] rkhachatryan commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r399516250
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartition.java
 ##########
 @@ -83,24 +87,45 @@
 	/** The total number of bytes (both data and event buffers). */
 	private long totalNumberOfBytes;
 
+	/** The collection of buffers which are spanned over by checkpoint barrier and needs to be persisted for snapshot. */
+	private final List<Buffer> inflightBuffers = new ArrayList<>();
 
 Review comment:
   Even better :)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#issuecomment-603776093
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6621",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155064201",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155877268",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6755",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6839",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156597180",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6846",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156864478",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6873",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156994047",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157330632",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6900",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157451694",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6916",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157494634",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6933",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157589655",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6944",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6991",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157754467",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158102285",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7007",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7023",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158153241",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158188400",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7040",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7048",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158276096",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158831429",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7117",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7121",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158855200",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159112519",
       "triggerID" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7172",
       "triggerID" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159143719",
       "triggerID" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7175",
       "triggerID" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "triggerType" : "PUSH"
     }, {
       "hash" : "35ec088ef24e841beae78c33488975d2d8d0a40d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "35ec088ef24e841beae78c33488975d2d8d0a40d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7194",
       "triggerID" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159244661",
       "triggerID" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "triggerType" : "PUSH"
     }, {
       "hash" : "334458afaa98b601eec12c490e71caa8274be055",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "334458afaa98b601eec12c490e71caa8274be055",
       "triggerType" : "PUSH"
     }, {
       "hash" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7212",
       "triggerID" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "triggerType" : "PUSH"
     }, {
       "hash" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159269141",
       "triggerID" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7226",
       "triggerID" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159307415",
       "triggerID" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7297",
       "triggerID" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159652918",
       "triggerID" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "559816dcea4999dd46b09ee1091ddc0e1a5a7a54",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "559816dcea4999dd46b09ee1091ddc0e1a5a7a54",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6cd76afe4990f56a5166e1592374aa8f86fe883f",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "6cd76afe4990f56a5166e1592374aa8f86fe883f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7302",
       "triggerID" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159678447",
       "triggerID" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159695914",
       "triggerID" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7305",
       "triggerID" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ac996f5c703560ecbe6cad7394cc8ad54d6f0029",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "ac996f5c703560ecbe6cad7394cc8ad54d6f0029",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7347",
       "triggerID" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159875195",
       "triggerID" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "75c8130873e9b91e21e1e833d3d05f1ad9b5d2b8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7354",
       "triggerID" : "75c8130873e9b91e21e1e833d3d05f1ad9b5d2b8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7369",
       "triggerID" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "triggerType" : "PUSH"
     }, {
       "hash" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159960514",
       "triggerID" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7373",
       "triggerID" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159990549",
       "triggerID" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "triggerType" : "PUSH"
     }, {
       "hash" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7443",
       "triggerID" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160172375",
       "triggerID" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "536d9fb04a7a8142c04c94344dd0b3c0f2c10999",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "536d9fb04a7a8142c04c94344dd0b3c0f2c10999",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * dee2b337e5e72d8f7b1f5098b74f2958d000fb3c UNKNOWN
   * 80b7f76f24b5fb6704a4b2292543f8764ec19053 UNKNOWN
   * 35ec088ef24e841beae78c33488975d2d8d0a40d UNKNOWN
   * 334458afaa98b601eec12c490e71caa8274be055 UNKNOWN
   * 559816dcea4999dd46b09ee1091ddc0e1a5a7a54 UNKNOWN
   * 6cd76afe4990f56a5166e1592374aa8f86fe883f UNKNOWN
   * ac996f5c703560ecbe6cad7394cc8ad54d6f0029 UNKNOWN
   * 11d69a1fed933cd4894f84e429d91e9b965d121b Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/160172375) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7443) 
   * 536d9fb04a7a8142c04c94344dd0b3c0f2c10999 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#issuecomment-603776093
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6621",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155064201",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155877268",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6755",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6839",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156597180",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6846",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156864478",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6873",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156994047",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157330632",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6900",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157451694",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6916",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157494634",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6933",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157589655",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6944",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6991",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157754467",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * dee2b337e5e72d8f7b1f5098b74f2958d000fb3c UNKNOWN
   * 80b7f76f24b5fb6704a4b2292543f8764ec19053 UNKNOWN
   * e148bdc935791d691e3d09c6576c3e3fa04e2ac8 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/157754467) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6991) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#issuecomment-603776093
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6621",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155064201",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155877268",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6755",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6839",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156597180",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6846",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156864478",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6873",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156994047",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157330632",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6900",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157451694",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6916",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157494634",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6933",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157589655",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6944",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6991",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157754467",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158102285",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7007",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7023",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158153241",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158188400",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7040",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7048",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158276096",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158831429",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7117",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7121",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158855200",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159112519",
       "triggerID" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7172",
       "triggerID" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159143719",
       "triggerID" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7175",
       "triggerID" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "triggerType" : "PUSH"
     }, {
       "hash" : "35ec088ef24e841beae78c33488975d2d8d0a40d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "35ec088ef24e841beae78c33488975d2d8d0a40d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7194",
       "triggerID" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159244661",
       "triggerID" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "triggerType" : "PUSH"
     }, {
       "hash" : "334458afaa98b601eec12c490e71caa8274be055",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "334458afaa98b601eec12c490e71caa8274be055",
       "triggerType" : "PUSH"
     }, {
       "hash" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7212",
       "triggerID" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "triggerType" : "PUSH"
     }, {
       "hash" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159269141",
       "triggerID" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7226",
       "triggerID" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159307415",
       "triggerID" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7297",
       "triggerID" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159652918",
       "triggerID" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "559816dcea4999dd46b09ee1091ddc0e1a5a7a54",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "559816dcea4999dd46b09ee1091ddc0e1a5a7a54",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6cd76afe4990f56a5166e1592374aa8f86fe883f",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "6cd76afe4990f56a5166e1592374aa8f86fe883f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7302",
       "triggerID" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159678447",
       "triggerID" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159695914",
       "triggerID" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7305",
       "triggerID" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ac996f5c703560ecbe6cad7394cc8ad54d6f0029",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "ac996f5c703560ecbe6cad7394cc8ad54d6f0029",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7347",
       "triggerID" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159875195",
       "triggerID" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "75c8130873e9b91e21e1e833d3d05f1ad9b5d2b8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7354",
       "triggerID" : "75c8130873e9b91e21e1e833d3d05f1ad9b5d2b8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7369",
       "triggerID" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "triggerType" : "PUSH"
     }, {
       "hash" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159960514",
       "triggerID" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7373",
       "triggerID" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159990549",
       "triggerID" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "triggerType" : "PUSH"
     }, {
       "hash" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7443",
       "triggerID" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160172375",
       "triggerID" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "536d9fb04a7a8142c04c94344dd0b3c0f2c10999",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160215439",
       "triggerID" : "536d9fb04a7a8142c04c94344dd0b3c0f2c10999",
       "triggerType" : "PUSH"
     }, {
       "hash" : "536d9fb04a7a8142c04c94344dd0b3c0f2c10999",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7469",
       "triggerID" : "536d9fb04a7a8142c04c94344dd0b3c0f2c10999",
       "triggerType" : "PUSH"
     }, {
       "hash" : "67018bacf5bc2daa8a03a1aafa880efc1db86808",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7500",
       "triggerID" : "67018bacf5bc2daa8a03a1aafa880efc1db86808",
       "triggerType" : "PUSH"
     }, {
       "hash" : "67018bacf5bc2daa8a03a1aafa880efc1db86808",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160347006",
       "triggerID" : "67018bacf5bc2daa8a03a1aafa880efc1db86808",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * dee2b337e5e72d8f7b1f5098b74f2958d000fb3c UNKNOWN
   * 80b7f76f24b5fb6704a4b2292543f8764ec19053 UNKNOWN
   * 35ec088ef24e841beae78c33488975d2d8d0a40d UNKNOWN
   * 334458afaa98b601eec12c490e71caa8274be055 UNKNOWN
   * 559816dcea4999dd46b09ee1091ddc0e1a5a7a54 UNKNOWN
   * 6cd76afe4990f56a5166e1592374aa8f86fe883f UNKNOWN
   * ac996f5c703560ecbe6cad7394cc8ad54d6f0029 UNKNOWN
   * 67018bacf5bc2daa8a03a1aafa880efc1db86808 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/160347006) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7500) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zhijiangW commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
zhijiangW commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r400292238
 
 

 ##########
 File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/StreamTwoInputProcessor.java
 ##########
 @@ -109,13 +111,13 @@ public StreamTwoInputProcessor(
 			checkpointedInputGates[0],
 			inputSerializer1,
 			ioManager,
-			new StatusWatermarkValve(checkpointedInputGates[0].getNumberOfInputChannels(), output1),
+			channelStateWriter, new StatusWatermarkValve(checkpointedInputGates[0].getNumberOfInputChannels(), output1),
 			0);
 		this.input2 = new StreamTaskNetworkInput<>(
 			checkpointedInputGates[1],
 			inputSerializer2,
 			ioManager,
-			new StatusWatermarkValve(checkpointedInputGates[1].getNumberOfInputChannels(), output2),
+			channelStateWriter, new StatusWatermarkValve(checkpointedInputGates[1].getNumberOfInputChannels(), output2),
 
 Review comment:
   ditto: formatting

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r402618446
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/UnionInputGate.java
 ##########
 @@ -77,37 +77,34 @@
 	 */
 	private final LinkedHashSet<InputGate> inputGatesWithData = new LinkedHashSet<>();
 
-	/** The total number of input channels across all unioned input gates. */
-	private final int totalNumberOfInputChannels;
+	/** Input channels across all unioned input gates. */
+	private final InputChannel[] inputChannels;
 
 	/**
 	 * A mapping from input gate to (logical) channel index offset. Valid channel indexes go from 0
 	 * (inclusive) to the total number of input channels (exclusive).
 	 */
-	private final Map<InputGate, Integer> inputGateToIndexOffsetMap;
+	private final int[] inputGateChannelIndexOffsets;
 
 	public UnionInputGate(InputGate... inputGates) {
 		this.inputGates = checkNotNull(inputGates);
 		checkArgument(inputGates.length > 1, "Union input gate should union at least two input gates.");
 
-		this.inputGateToIndexOffsetMap = Maps.newHashMapWithExpectedSize(inputGates.length);
 		this.inputGatesWithRemainingData = Sets.newHashSetWithExpectedSize(inputGates.length);
 
+		final int maxGateIndex = Arrays.stream(inputGates).mapToInt(InputGate::getGateIndex).max().orElse(0);
 
 Review comment:
   Added a check that no union of UnionInputGate are possible - it happened to late as you have observed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#issuecomment-603776093
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6621",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155064201",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155877268",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6755",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6839",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156597180",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6846",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156864478",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6873",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156994047",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157330632",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6900",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157451694",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6916",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157494634",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6933",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157589655",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6944",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6991",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157754467",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158102285",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7007",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7023",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158153241",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158188400",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7040",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7048",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158276096",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158831429",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7117",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7121",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158855200",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159112519",
       "triggerID" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7172",
       "triggerID" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159143719",
       "triggerID" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7175",
       "triggerID" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "triggerType" : "PUSH"
     }, {
       "hash" : "35ec088ef24e841beae78c33488975d2d8d0a40d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "35ec088ef24e841beae78c33488975d2d8d0a40d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7194",
       "triggerID" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159244661",
       "triggerID" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "triggerType" : "PUSH"
     }, {
       "hash" : "334458afaa98b601eec12c490e71caa8274be055",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "334458afaa98b601eec12c490e71caa8274be055",
       "triggerType" : "PUSH"
     }, {
       "hash" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7212",
       "triggerID" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "triggerType" : "PUSH"
     }, {
       "hash" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159269141",
       "triggerID" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7226",
       "triggerID" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159307415",
       "triggerID" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7297",
       "triggerID" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159652918",
       "triggerID" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "559816dcea4999dd46b09ee1091ddc0e1a5a7a54",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "559816dcea4999dd46b09ee1091ddc0e1a5a7a54",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6cd76afe4990f56a5166e1592374aa8f86fe883f",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "6cd76afe4990f56a5166e1592374aa8f86fe883f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7302",
       "triggerID" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159678447",
       "triggerID" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159695914",
       "triggerID" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7305",
       "triggerID" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ac996f5c703560ecbe6cad7394cc8ad54d6f0029",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "ac996f5c703560ecbe6cad7394cc8ad54d6f0029",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7347",
       "triggerID" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159875195",
       "triggerID" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "75c8130873e9b91e21e1e833d3d05f1ad9b5d2b8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7354",
       "triggerID" : "75c8130873e9b91e21e1e833d3d05f1ad9b5d2b8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7369",
       "triggerID" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "triggerType" : "PUSH"
     }, {
       "hash" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159960514",
       "triggerID" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7373",
       "triggerID" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159990549",
       "triggerID" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "triggerType" : "PUSH"
     }, {
       "hash" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7443",
       "triggerID" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160172375",
       "triggerID" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "536d9fb04a7a8142c04c94344dd0b3c0f2c10999",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160215439",
       "triggerID" : "536d9fb04a7a8142c04c94344dd0b3c0f2c10999",
       "triggerType" : "PUSH"
     }, {
       "hash" : "536d9fb04a7a8142c04c94344dd0b3c0f2c10999",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7469",
       "triggerID" : "536d9fb04a7a8142c04c94344dd0b3c0f2c10999",
       "triggerType" : "PUSH"
     }, {
       "hash" : "67018bacf5bc2daa8a03a1aafa880efc1db86808",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7500",
       "triggerID" : "67018bacf5bc2daa8a03a1aafa880efc1db86808",
       "triggerType" : "PUSH"
     }, {
       "hash" : "67018bacf5bc2daa8a03a1aafa880efc1db86808",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160347006",
       "triggerID" : "67018bacf5bc2daa8a03a1aafa880efc1db86808",
       "triggerType" : "PUSH"
     }, {
       "hash" : "79c116a6a1f5fe314f801e81f0265dea8b9ac1a7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7522",
       "triggerID" : "79c116a6a1f5fe314f801e81f0265dea8b9ac1a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "79c116a6a1f5fe314f801e81f0265dea8b9ac1a7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160377553",
       "triggerID" : "79c116a6a1f5fe314f801e81f0265dea8b9ac1a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "27ce4bfad8e99989dd64f8c636c934727da8a062",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "27ce4bfad8e99989dd64f8c636c934727da8a062",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ce0dfc7324679ebf2da84278eac8f5f59d748319",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7539",
       "triggerID" : "ce0dfc7324679ebf2da84278eac8f5f59d748319",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ce0dfc7324679ebf2da84278eac8f5f59d748319",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160418181",
       "triggerID" : "ce0dfc7324679ebf2da84278eac8f5f59d748319",
       "triggerType" : "PUSH"
     }, {
       "hash" : "05c934bf483d4fb673496783ef8ff85b40b86708",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "05c934bf483d4fb673496783ef8ff85b40b86708",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4bbe67a13a75f4491898fbb1cd2315237dbca30e",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160443829",
       "triggerID" : "4bbe67a13a75f4491898fbb1cd2315237dbca30e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4bbe67a13a75f4491898fbb1cd2315237dbca30e",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7543",
       "triggerID" : "4bbe67a13a75f4491898fbb1cd2315237dbca30e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * dee2b337e5e72d8f7b1f5098b74f2958d000fb3c UNKNOWN
   * 80b7f76f24b5fb6704a4b2292543f8764ec19053 UNKNOWN
   * 35ec088ef24e841beae78c33488975d2d8d0a40d UNKNOWN
   * 334458afaa98b601eec12c490e71caa8274be055 UNKNOWN
   * 559816dcea4999dd46b09ee1091ddc0e1a5a7a54 UNKNOWN
   * 6cd76afe4990f56a5166e1592374aa8f86fe883f UNKNOWN
   * ac996f5c703560ecbe6cad7394cc8ad54d6f0029 UNKNOWN
   * 27ce4bfad8e99989dd64f8c636c934727da8a062 UNKNOWN
   * 05c934bf483d4fb673496783ef8ff85b40b86708 UNKNOWN
   * 4bbe67a13a75f4491898fbb1cd2315237dbca30e Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/160443829) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7543) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] rkhachatryan commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r399530922
 
 

 ##########
 File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/StreamTaskNetworkInput.java
 ##########
 @@ -197,6 +205,29 @@ public int getInputIndex() {
 		return checkpointedInputGate.getAvailableFuture();
 	}
 
+	@Override
+	public CompletableFuture<?> prepareSnapshot(long checkpointId) throws IOException {
+		// Note that if considering recovery in future, we should guarantee that the spilled buffers in one channel
+		// should be close together because one record might span multiple buffers.
+		for (int channelIndex = 0; channelIndex < recordDeserializers.length; channelIndex++) {
+			final InputChannel channel = checkpointedInputGate.getChannel(channelIndex);
+
+			recordDeserializers[channelIndex].getUnconsumedBuffer().ifPresent(buffer ->
 
 Review comment:
   Got it, thanks for the explanations.
   
   Does it make sense to add a comment? (and maybe mark somehow so we don't forget it when removing the limit of in-flight checkpoints)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] rkhachatryan commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r399512927
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
 ##########
 @@ -206,6 +210,20 @@ void retriggerSubpartitionRequest(int subpartitionIndex) throws IOException {
 		return Optional.of(new BufferAndAvailability(next, moreAvailable, getSenderBacklog()));
 	}
 
+	@Override
+	public List<Buffer> getInflightBuffers(long checkpointId) throws IOException {
+		final ArrayList<Buffer> inflightBuffers = new ArrayList<>(receivedBuffers.size());
 
 Review comment:
   This collection (`receivedBuffers`) is not thread-safe, so its contract makes no sense in a multi-threaded environment.
   
   Yes, it's only a hint. But if it's negative, we'll get an exception.
   
   `syncrhonized` has a cost, which I think will be higher here than potential re-allocation in `ArrayList`.
   
   So I'd just remove it or guard against negative values.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zhijiangW commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
zhijiangW commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r400636648
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/writer/ResultPartitionWriter.java
 ##########
 @@ -67,6 +68,13 @@
 	 */
 	boolean addBufferConsumer(BufferConsumer bufferConsumer, int subpartitionIndex) throws IOException;
 
+	default void addPriorityEvent(
+			AbstractEvent event,
+			int subpartitionIndex,
+			BufferConsumer eventBufferConsumer) throws IOException {
+		getSubpartition(subpartitionIndex).priorityEvent(event, eventBufferConsumer);
 
 Review comment:
   We create another path for handling priority event, which might be inconsistent with previous handling. 
   In normal `ResultPartition#addBufferConsumer`, we would also check the `checkInProduceState` before adding into subpartition. Now we bypass this process which might bring trouble for code maintenance.
   
   Are there any blockers for reuse the previous code path?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#issuecomment-603776093
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6621",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155064201",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155877268",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6755",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6839",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156597180",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6846",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156864478",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6873",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156994047",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157330632",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6900",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157451694",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6916",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157494634",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6933",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157589655",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6944",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6991",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157754467",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158102285",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7007",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7023",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158153241",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158188400",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7040",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7048",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "FAILURE",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158276096",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * dee2b337e5e72d8f7b1f5098b74f2958d000fb3c UNKNOWN
   * 80b7f76f24b5fb6704a4b2292543f8764ec19053 UNKNOWN
   * a8335f0def293f04fd74bfc47c1b31fc98a46a23 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/158276096) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7048) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] rkhachatryan commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r407990091
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
 ##########
 @@ -523,15 +557,18 @@ public void onBuffer(Buffer buffer, int sequenceNumber, int backlog) throws IOEx
 					return;
 				}
 
-				if (expectedSequenceNumber != sequenceNumber) {
-					onError(new BufferReorderingException(expectedSequenceNumber, sequenceNumber));
-					return;
-				}
-
 				wasEmpty = receivedBuffers.isEmpty();
 				receivedBuffers.add(buffer);
-				recycleBuffer = false;
+
+				if (hasListener) {
+					if (buffer.isBuffer() && receivedCheckpointId < lastRequestedCheckpointId) {
+						notifyReceivedBuffer = buffer.retainBuffer();
+					} else {
 
 Review comment:
   I'd prefer to see all writes to `notifyReceivedBuffer` in one place (so it can be made `final` and easier to track).
   For example (assuming we parse barrier later):
   ```
   final Buffer notifyReceivedBuffer;
   synchronized {
   ...
       notifyReceivedBuffer = hasListener && buffer.isBuffer() && receivedCheckpointId < lastRequestedCheckpointId
                                  ? buffer.retainBuffer()
                                  : null;
   }
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r402533939
 
 

 ##########
 File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/CheckpointBarrierUnaligner.java
 ##########
 @@ -0,0 +1,338 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.streaming.runtime.io;
+
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.runtime.checkpoint.CheckpointException;
+import org.apache.flink.runtime.checkpoint.CheckpointFailureReason;
+import org.apache.flink.runtime.checkpoint.channel.ChannelStateWriter;
+import org.apache.flink.runtime.checkpoint.channel.InputChannelInfo;
+import org.apache.flink.runtime.io.network.api.CancelCheckpointMarker;
+import org.apache.flink.runtime.io.network.api.CheckpointBarrier;
+import org.apache.flink.runtime.io.network.buffer.Buffer;
+import org.apache.flink.runtime.jobgraph.tasks.AbstractInvokable;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.IOException;
+import java.util.Arrays;
+import java.util.concurrent.CompletableFuture;
+
+import static org.apache.flink.util.Preconditions.checkNotNull;
+
+/**
+ * {@link CheckpointBarrierUnaligner} is used for triggering checkpoint while reading the first barrier
+ * and keeping track of the number of received barriers and consumed barriers.
+ */
+@Internal
+public class CheckpointBarrierUnaligner extends CheckpointBarrierHandler {
+
+	private static final Logger LOG = LoggerFactory.getLogger(CheckpointBarrierUnaligner.class);
+	public static final CompletableFuture<Void> DONE = CompletableFuture.completedFuture(null);
+
+	private final String taskName;
+
+	/**
+	 * Tag the state of which input channel has read the barrier. If one channel has read the barrier by task,
+	 * the respective in-flight input buffers should be empty when triggering unaligned checkpoint.
+	 */
+	private final boolean[] barrierConsumedChannels;
+
+	/**
+	 * Tag the state of which input channel has received the barrier. Until the barrier of a specific channel is
+	 * received, all new buffers need to be persisted after unaligned checkpointing has been started.
+	 */
+	private final boolean[] barrierReceivedChannels;
+
+	/**
+	 * Contains the offsets of the channel indices for each gate when flattening the channels of all gates.
+	 *
+	 * <p>For example, consider 3 gates with 4 channels, {@code gateChannelOffsets = [0, 4, 8]}.
+	 */
+	private final int[] gateChannelOffsets;
+
+	/**
+	 * The number of input channels which has read the barrier by task.
+	 */
+	private int numBarriersReceived;
+
+	/**
+	 * The checkpoint id to guarantee that we would trigger only one checkpoint when reading the same barrier from
+	 * different channels.
+	 */
+	private long currentCheckpointId = -1L;
+
+	/** The number of opened channels. */
+	private int numOpenChannels;
+
+	/** A future indicating that all barriers of the a given checkpoint have been read. */
+	private CompletableFuture<Void> allBarriersReceivedFuture = DONE;
+
+	private final ChannelStateWriter channelStateWriter;
+
+	CheckpointBarrierUnaligner(
+			int[] numberOfInputChannelsPerGate,
+			ChannelStateWriter channelStateWriter,
+			String taskName,
+			AbstractInvokable toNotifyOnCheckpoint) {
+		super(toNotifyOnCheckpoint);
+
+		this.taskName = taskName;
+		this.channelStateWriter = checkNotNull(channelStateWriter);
+
+		final int numGates = numberOfInputChannelsPerGate.length;
+
+		gateChannelOffsets = new int[numGates];
+		for (int index = 1; index < numGates; index++) {
+			gateChannelOffsets[index] = gateChannelOffsets[index - 1] + numberOfInputChannelsPerGate[index - 1];
+		}
+
+		final int totalNumChannels = gateChannelOffsets[numGates - 1] + numberOfInputChannelsPerGate[numGates - 1];
+		barrierConsumedChannels = new boolean[totalNumChannels];
+		Arrays.fill(barrierConsumedChannels, true);
+		barrierReceivedChannels = new boolean[totalNumChannels];
+		Arrays.fill(barrierReceivedChannels, true);
+		numOpenChannels = totalNumChannels;
+	}
+
+	@Override
+	public void releaseBlocksAndResetBarriers() {
+		// make sure no additional data is persisted
+		Arrays.fill(barrierConsumedChannels, true);
 
 Review comment:
   Here, you are probably right for `barrierConsumedChannels`. I have done it to guard against `CheckpointInputGate#getInflightBuffers`, but that should happen in the same thread as `releaseBlocksAndResetBarriers`.
   
   For `barrierReceivedChannels`, same argument as above: we are persisting data as long as it's not received. So if we are aborting, we are faking the receival. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#issuecomment-603776093
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6621",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "FAILURE",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155064201",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 46c39891af3d5ae037620c384f15d01b77419b1b Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/155064201) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6621) 
   * c45c6a352fc2f7760dcf942a75728d4d1f1777a7 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#issuecomment-603776093
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6621",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155064201",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "FAILURE",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155877268",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6755",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6839",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156597180",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c45c6a352fc2f7760dcf942a75728d4d1f1777a7 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/155877268) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6755) 
   * 2a84fd2fe1659cab80b711384febf50669561257 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/156597180) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6839) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r402576918
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/writer/ResultPartitionWriter.java
 ##########
 @@ -67,6 +68,13 @@
 	 */
 	boolean addBufferConsumer(BufferConsumer bufferConsumer, int subpartitionIndex) throws IOException;
 
+	default void addPriorityEvent(
+			AbstractEvent event,
+			int subpartitionIndex,
+			BufferConsumer eventBufferConsumer) throws IOException {
+		getSubpartition(subpartitionIndex).priorityEvent(event, eventBufferConsumer);
 
 Review comment:
   The previous way did not work with `LocalInputChannel`, where I added `PriorityEventListener`. I figured it could be used everywhere to unify both input channel types. If you have concerns about the current way, I can of course revert to POC code.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] pnowojski commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
pnowojski commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r405510659
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/serialization/SpillingAdaptiveSpanningRecordDeserializer.java
 ##########
 @@ -557,6 +579,28 @@ private void addNextChunkFromMemorySegment(MemorySegment segment, int offset, in
 			}
 		}
 
+		@Nullable
+		MemorySegment copyToTargetSegment() {
+			// for the case of only partial length, no data
+			final int position = lengthBuffer.position();
+			if (position > 0) {
+				MemorySegment segment = MemorySegmentFactory.allocateUnpooledSegment(lengthBuffer.remaining());
+				segment.put(0, lengthBuffer, lengthBuffer.remaining());
+				lengthBuffer.position(position);
+				return segment;
+			}
+
+			// for the case of full length, partial data in buffer
+			if (recordLength != -1) {
+				// In the PoC we skip the case of large record which size exceeds THRESHOLD_FOR_SPILLING,
 
 Review comment:
   I created a separate ticket for that. For now we are throwing UnsupportedOperationException
   https://issues.apache.org/jira/browse/FLINK-17051

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#issuecomment-603776093
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6621",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155064201",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155877268",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6755",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6839",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156597180",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6846",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156864478",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6873",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156994047",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157330632",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6900",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157451694",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6916",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157494634",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6933",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157589655",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6944",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6991",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157754467",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158102285",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7007",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7023",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158153241",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158188400",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7040",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7048",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158276096",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158831429",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7117",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7121",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158855200",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159112519",
       "triggerID" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7172",
       "triggerID" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159143719",
       "triggerID" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7175",
       "triggerID" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "triggerType" : "PUSH"
     }, {
       "hash" : "35ec088ef24e841beae78c33488975d2d8d0a40d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "35ec088ef24e841beae78c33488975d2d8d0a40d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7194",
       "triggerID" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159244661",
       "triggerID" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "triggerType" : "PUSH"
     }, {
       "hash" : "334458afaa98b601eec12c490e71caa8274be055",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "334458afaa98b601eec12c490e71caa8274be055",
       "triggerType" : "PUSH"
     }, {
       "hash" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7212",
       "triggerID" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "triggerType" : "PUSH"
     }, {
       "hash" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159269141",
       "triggerID" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7226",
       "triggerID" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159307415",
       "triggerID" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7297",
       "triggerID" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159652918",
       "triggerID" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "559816dcea4999dd46b09ee1091ddc0e1a5a7a54",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "559816dcea4999dd46b09ee1091ddc0e1a5a7a54",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6cd76afe4990f56a5166e1592374aa8f86fe883f",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "6cd76afe4990f56a5166e1592374aa8f86fe883f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7302",
       "triggerID" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159678447",
       "triggerID" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159695914",
       "triggerID" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7305",
       "triggerID" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ac996f5c703560ecbe6cad7394cc8ad54d6f0029",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "ac996f5c703560ecbe6cad7394cc8ad54d6f0029",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7347",
       "triggerID" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159875195",
       "triggerID" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "75c8130873e9b91e21e1e833d3d05f1ad9b5d2b8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7354",
       "triggerID" : "75c8130873e9b91e21e1e833d3d05f1ad9b5d2b8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7369",
       "triggerID" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "triggerType" : "PUSH"
     }, {
       "hash" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159960514",
       "triggerID" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7373",
       "triggerID" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159990549",
       "triggerID" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "triggerType" : "PUSH"
     }, {
       "hash" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7443",
       "triggerID" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160172375",
       "triggerID" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "536d9fb04a7a8142c04c94344dd0b3c0f2c10999",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160215439",
       "triggerID" : "536d9fb04a7a8142c04c94344dd0b3c0f2c10999",
       "triggerType" : "PUSH"
     }, {
       "hash" : "536d9fb04a7a8142c04c94344dd0b3c0f2c10999",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7469",
       "triggerID" : "536d9fb04a7a8142c04c94344dd0b3c0f2c10999",
       "triggerType" : "PUSH"
     }, {
       "hash" : "67018bacf5bc2daa8a03a1aafa880efc1db86808",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7500",
       "triggerID" : "67018bacf5bc2daa8a03a1aafa880efc1db86808",
       "triggerType" : "PUSH"
     }, {
       "hash" : "67018bacf5bc2daa8a03a1aafa880efc1db86808",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160347006",
       "triggerID" : "67018bacf5bc2daa8a03a1aafa880efc1db86808",
       "triggerType" : "PUSH"
     }, {
       "hash" : "79c116a6a1f5fe314f801e81f0265dea8b9ac1a7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7522",
       "triggerID" : "79c116a6a1f5fe314f801e81f0265dea8b9ac1a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "79c116a6a1f5fe314f801e81f0265dea8b9ac1a7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160377553",
       "triggerID" : "79c116a6a1f5fe314f801e81f0265dea8b9ac1a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "27ce4bfad8e99989dd64f8c636c934727da8a062",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "27ce4bfad8e99989dd64f8c636c934727da8a062",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ce0dfc7324679ebf2da84278eac8f5f59d748319",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7539",
       "triggerID" : "ce0dfc7324679ebf2da84278eac8f5f59d748319",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ce0dfc7324679ebf2da84278eac8f5f59d748319",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160418181",
       "triggerID" : "ce0dfc7324679ebf2da84278eac8f5f59d748319",
       "triggerType" : "PUSH"
     }, {
       "hash" : "05c934bf483d4fb673496783ef8ff85b40b86708",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "05c934bf483d4fb673496783ef8ff85b40b86708",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4bbe67a13a75f4491898fbb1cd2315237dbca30e",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160443829",
       "triggerID" : "4bbe67a13a75f4491898fbb1cd2315237dbca30e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4bbe67a13a75f4491898fbb1cd2315237dbca30e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7543",
       "triggerID" : "4bbe67a13a75f4491898fbb1cd2315237dbca30e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "cb5258f13c64ed033db7b8476122721ac418d798",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160496434",
       "triggerID" : "cb5258f13c64ed033db7b8476122721ac418d798",
       "triggerType" : "PUSH"
     }, {
       "hash" : "cb5258f13c64ed033db7b8476122721ac418d798",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7560",
       "triggerID" : "cb5258f13c64ed033db7b8476122721ac418d798",
       "triggerType" : "PUSH"
     }, {
       "hash" : "fdc673b8583650ce40a6f13b8a44d9773e14c370",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7597",
       "triggerID" : "fdc673b8583650ce40a6f13b8a44d9773e14c370",
       "triggerType" : "PUSH"
     }, {
       "hash" : "fdc673b8583650ce40a6f13b8a44d9773e14c370",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160543449",
       "triggerID" : "fdc673b8583650ce40a6f13b8a44d9773e14c370",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1123cc69ed817c9935bae5ffbba5e48f5bbe0f25",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7611",
       "triggerID" : "1123cc69ed817c9935bae5ffbba5e48f5bbe0f25",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1123cc69ed817c9935bae5ffbba5e48f5bbe0f25",
       "status" : "FAILURE",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160619473",
       "triggerID" : "1123cc69ed817c9935bae5ffbba5e48f5bbe0f25",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dd5b4999b59b53950c2fb3784fc50ed97617f5aa",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "dd5b4999b59b53950c2fb3784fc50ed97617f5aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9e118a737919fb9c784d171ae06567030a5a9ecd",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "9e118a737919fb9c784d171ae06567030a5a9ecd",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * dee2b337e5e72d8f7b1f5098b74f2958d000fb3c UNKNOWN
   * 80b7f76f24b5fb6704a4b2292543f8764ec19053 UNKNOWN
   * 35ec088ef24e841beae78c33488975d2d8d0a40d UNKNOWN
   * 334458afaa98b601eec12c490e71caa8274be055 UNKNOWN
   * 559816dcea4999dd46b09ee1091ddc0e1a5a7a54 UNKNOWN
   * 6cd76afe4990f56a5166e1592374aa8f86fe883f UNKNOWN
   * ac996f5c703560ecbe6cad7394cc8ad54d6f0029 UNKNOWN
   * 27ce4bfad8e99989dd64f8c636c934727da8a062 UNKNOWN
   * 05c934bf483d4fb673496783ef8ff85b40b86708 UNKNOWN
   * 1123cc69ed817c9935bae5ffbba5e48f5bbe0f25 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/160619473) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7611) 
   * dd5b4999b59b53950c2fb3784fc50ed97617f5aa UNKNOWN
   * 9e118a737919fb9c784d171ae06567030a5a9ecd UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#issuecomment-603776093
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6621",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155064201",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155877268",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6755",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6839",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156597180",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6846",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156864478",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6873",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156994047",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157330632",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6900",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157451694",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6916",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157494634",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6933",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157589655",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6944",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6991",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157754467",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158102285",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7007",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7023",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158153241",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158188400",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7040",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7048",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158276096",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158831429",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7117",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7121",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158855200",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159112519",
       "triggerID" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7172",
       "triggerID" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159143719",
       "triggerID" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7175",
       "triggerID" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "triggerType" : "PUSH"
     }, {
       "hash" : "35ec088ef24e841beae78c33488975d2d8d0a40d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "35ec088ef24e841beae78c33488975d2d8d0a40d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7194",
       "triggerID" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159244661",
       "triggerID" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "triggerType" : "PUSH"
     }, {
       "hash" : "334458afaa98b601eec12c490e71caa8274be055",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "334458afaa98b601eec12c490e71caa8274be055",
       "triggerType" : "PUSH"
     }, {
       "hash" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7212",
       "triggerID" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "triggerType" : "PUSH"
     }, {
       "hash" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159269141",
       "triggerID" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7226",
       "triggerID" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159307415",
       "triggerID" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7297",
       "triggerID" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159652918",
       "triggerID" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "559816dcea4999dd46b09ee1091ddc0e1a5a7a54",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "559816dcea4999dd46b09ee1091ddc0e1a5a7a54",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6cd76afe4990f56a5166e1592374aa8f86fe883f",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "6cd76afe4990f56a5166e1592374aa8f86fe883f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7302",
       "triggerID" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159678447",
       "triggerID" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159695914",
       "triggerID" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7305",
       "triggerID" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ac996f5c703560ecbe6cad7394cc8ad54d6f0029",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "ac996f5c703560ecbe6cad7394cc8ad54d6f0029",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7347",
       "triggerID" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159875195",
       "triggerID" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "75c8130873e9b91e21e1e833d3d05f1ad9b5d2b8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7354",
       "triggerID" : "75c8130873e9b91e21e1e833d3d05f1ad9b5d2b8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7369",
       "triggerID" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "triggerType" : "PUSH"
     }, {
       "hash" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159960514",
       "triggerID" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7373",
       "triggerID" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159990549",
       "triggerID" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "triggerType" : "PUSH"
     }, {
       "hash" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7443",
       "triggerID" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160172375",
       "triggerID" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "536d9fb04a7a8142c04c94344dd0b3c0f2c10999",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160215439",
       "triggerID" : "536d9fb04a7a8142c04c94344dd0b3c0f2c10999",
       "triggerType" : "PUSH"
     }, {
       "hash" : "536d9fb04a7a8142c04c94344dd0b3c0f2c10999",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7469",
       "triggerID" : "536d9fb04a7a8142c04c94344dd0b3c0f2c10999",
       "triggerType" : "PUSH"
     }, {
       "hash" : "67018bacf5bc2daa8a03a1aafa880efc1db86808",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7500",
       "triggerID" : "67018bacf5bc2daa8a03a1aafa880efc1db86808",
       "triggerType" : "PUSH"
     }, {
       "hash" : "67018bacf5bc2daa8a03a1aafa880efc1db86808",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160347006",
       "triggerID" : "67018bacf5bc2daa8a03a1aafa880efc1db86808",
       "triggerType" : "PUSH"
     }, {
       "hash" : "79c116a6a1f5fe314f801e81f0265dea8b9ac1a7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7522",
       "triggerID" : "79c116a6a1f5fe314f801e81f0265dea8b9ac1a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "79c116a6a1f5fe314f801e81f0265dea8b9ac1a7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160377553",
       "triggerID" : "79c116a6a1f5fe314f801e81f0265dea8b9ac1a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "27ce4bfad8e99989dd64f8c636c934727da8a062",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "27ce4bfad8e99989dd64f8c636c934727da8a062",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ce0dfc7324679ebf2da84278eac8f5f59d748319",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7539",
       "triggerID" : "ce0dfc7324679ebf2da84278eac8f5f59d748319",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ce0dfc7324679ebf2da84278eac8f5f59d748319",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160418181",
       "triggerID" : "ce0dfc7324679ebf2da84278eac8f5f59d748319",
       "triggerType" : "PUSH"
     }, {
       "hash" : "05c934bf483d4fb673496783ef8ff85b40b86708",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "05c934bf483d4fb673496783ef8ff85b40b86708",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4bbe67a13a75f4491898fbb1cd2315237dbca30e",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160443829",
       "triggerID" : "4bbe67a13a75f4491898fbb1cd2315237dbca30e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4bbe67a13a75f4491898fbb1cd2315237dbca30e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7543",
       "triggerID" : "4bbe67a13a75f4491898fbb1cd2315237dbca30e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "cb5258f13c64ed033db7b8476122721ac418d798",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160496434",
       "triggerID" : "cb5258f13c64ed033db7b8476122721ac418d798",
       "triggerType" : "PUSH"
     }, {
       "hash" : "cb5258f13c64ed033db7b8476122721ac418d798",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7560",
       "triggerID" : "cb5258f13c64ed033db7b8476122721ac418d798",
       "triggerType" : "PUSH"
     }, {
       "hash" : "fdc673b8583650ce40a6f13b8a44d9773e14c370",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "fdc673b8583650ce40a6f13b8a44d9773e14c370",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * dee2b337e5e72d8f7b1f5098b74f2958d000fb3c UNKNOWN
   * 80b7f76f24b5fb6704a4b2292543f8764ec19053 UNKNOWN
   * 35ec088ef24e841beae78c33488975d2d8d0a40d UNKNOWN
   * 334458afaa98b601eec12c490e71caa8274be055 UNKNOWN
   * 559816dcea4999dd46b09ee1091ddc0e1a5a7a54 UNKNOWN
   * 6cd76afe4990f56a5166e1592374aa8f86fe883f UNKNOWN
   * ac996f5c703560ecbe6cad7394cc8ad54d6f0029 UNKNOWN
   * 27ce4bfad8e99989dd64f8c636c934727da8a062 UNKNOWN
   * 05c934bf483d4fb673496783ef8ff85b40b86708 UNKNOWN
   * cb5258f13c64ed033db7b8476122721ac418d798 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/160496434) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7560) 
   * fdc673b8583650ce40a6f13b8a44d9773e14c370 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#issuecomment-603776093
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6621",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155064201",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155877268",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6755",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6839",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156597180",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6846",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156864478",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6873",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156994047",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157330632",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6900",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157451694",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6916",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157494634",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6933",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157589655",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6944",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6991",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157754467",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158102285",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7007",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7023",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158153241",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158188400",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7040",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7048",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "FAILURE",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158276096",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * dee2b337e5e72d8f7b1f5098b74f2958d000fb3c UNKNOWN
   * 80b7f76f24b5fb6704a4b2292543f8764ec19053 UNKNOWN
   * a8335f0def293f04fd74bfc47c1b31fc98a46a23 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/158276096) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7048) 
   * a3eed025c7faad5d680ab09e83d8af2819f0048b UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#issuecomment-603776093
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6621",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155064201",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155877268",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6755",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6839",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156597180",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6846",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156864478",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6873",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156994047",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157330632",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6900",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157451694",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6916",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157494634",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6933",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157589655",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6944",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6991",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157754467",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158102285",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7007",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7023",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158153241",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158188400",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7040",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7048",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158276096",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158831429",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7117",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7121",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158855200",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159112519",
       "triggerID" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7172",
       "triggerID" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "status" : "CANCELED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159143719",
       "triggerID" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7175",
       "triggerID" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "triggerType" : "PUSH"
     }, {
       "hash" : "35ec088ef24e841beae78c33488975d2d8d0a40d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "35ec088ef24e841beae78c33488975d2d8d0a40d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7194",
       "triggerID" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159244661",
       "triggerID" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * dee2b337e5e72d8f7b1f5098b74f2958d000fb3c UNKNOWN
   * 80b7f76f24b5fb6704a4b2292543f8764ec19053 UNKNOWN
   * 2c9926f618130a7d268ac2784fbb5e956e488088 Travis: [CANCELED](https://travis-ci.com/github/flink-ci/flink/builds/159143719) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7175) 
   * 35ec088ef24e841beae78c33488975d2d8d0a40d UNKNOWN
   * ee3ad987187409939aa7c211778ed88dd64f6479 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/159244661) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7194) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] rkhachatryan commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r406039709
 
 

 ##########
 File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/CheckpointBarrierUnaligner.java
 ##########
 @@ -0,0 +1,427 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.streaming.runtime.io;
+
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.runtime.checkpoint.CheckpointException;
+import org.apache.flink.runtime.checkpoint.CheckpointFailureReason;
+import org.apache.flink.runtime.checkpoint.channel.ChannelStateWriter;
+import org.apache.flink.runtime.checkpoint.channel.InputChannelInfo;
+import org.apache.flink.runtime.concurrent.FutureUtils;
+import org.apache.flink.runtime.io.network.api.CancelCheckpointMarker;
+import org.apache.flink.runtime.io.network.api.CheckpointBarrier;
+import org.apache.flink.runtime.io.network.buffer.Buffer;
+import org.apache.flink.runtime.io.network.buffer.BufferReceivedListener;
+import org.apache.flink.runtime.jobgraph.tasks.AbstractInvokable;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import javax.annotation.concurrent.NotThreadSafe;
+import javax.annotation.concurrent.ThreadSafe;
+
+import java.io.Closeable;
+import java.io.IOException;
+import java.util.Arrays;
+import java.util.Optional;
+import java.util.concurrent.CompletableFuture;
+import java.util.function.Function;
+import java.util.stream.IntStream;
+
+import static org.apache.flink.util.Preconditions.checkNotNull;
+import static org.apache.flink.util.Preconditions.checkState;
+
+/**
+ * {@link CheckpointBarrierUnaligner} is used for triggering checkpoint while reading the first barrier
+ * and keeping track of the number of received barriers and consumed barriers.
+ */
+@Internal
+@NotThreadSafe
+public class CheckpointBarrierUnaligner extends CheckpointBarrierHandler {
+
+	private static final Logger LOG = LoggerFactory.getLogger(CheckpointBarrierUnaligner.class);
+
+	private final String taskName;
+
+	/**
+	 * Tag the state of which input channel has read the barrier. If one channel has read the barrier by task,
+	 * the respective in-flight input buffers should be empty when triggering unaligned checkpoint.
+	 */
+	private final boolean[] barrierConsumedChannels;
+
+	private int numBarrierConsumed;
+
+	/**
+	 * Contains the offsets of the channel indices for each gate when flattening the channels of all gates.
+	 *
+	 * <p>For example, consider 3 gates with 4 channels, {@code gateChannelOffsets = [0, 4, 8]}.
+	 */
+	private final int[] gateChannelOffsets;
+
+	private final InputChannelInfo[] channelInfos;
+
+	/**
+	 * The checkpoint id to guarantee that we would trigger only one checkpoint when reading the same barrier from
+	 * different channels.
+	 *
+	 * <p>Note: this checkpoint is valid in respect to <b>consumed</b> barriers in contrast to
+	 * {@link ThreadSafeUnaligner#currentReceivedCheckpointId}.
+	 */
+	private long currentConsumedCheckpointId = -1L;
+
+	/** Encapsulates state that is shared between netty threads and task thread. */
+	private final ThreadSafeUnaligner threadSafeUnaligner;
+
+	CheckpointBarrierUnaligner(
+			int[] numberOfInputChannelsPerGate,
+			ChannelStateWriter channelStateWriter,
+			String taskName,
+			AbstractInvokable toNotifyOnCheckpoint) {
+		super(toNotifyOnCheckpoint);
+
+		this.taskName = taskName;
+
+		final int numGates = numberOfInputChannelsPerGate.length;
+
+		gateChannelOffsets = new int[numGates];
+		for (int index = 1; index < numGates; index++) {
+			gateChannelOffsets[index] = gateChannelOffsets[index - 1] + numberOfInputChannelsPerGate[index - 1];
+		}
+
+		final int totalNumChannels = gateChannelOffsets[numGates - 1] + numberOfInputChannelsPerGate[numGates - 1];
+		barrierConsumedChannels = new boolean[totalNumChannels];
+		Arrays.fill(barrierConsumedChannels, true);
+
+		channelInfos = IntStream.range(0, numGates)
+			.mapToObj(gateIndex -> IntStream.range(0, numberOfInputChannelsPerGate[gateIndex])
+				.mapToObj(channelIndex -> new InputChannelInfo(gateIndex, channelIndex)))
+			.flatMap(Function.identity())
+			.toArray(InputChannelInfo[]::new);
+
+		threadSafeUnaligner = new ThreadSafeUnaligner(totalNumChannels,	checkNotNull(channelStateWriter), this);
+	}
+
+	@Override
+	public void releaseBlocksAndResetBarriers() {
+		// make sure no additional data is persisted
+		Arrays.fill(barrierConsumedChannels, true);
+		// the next barrier that comes must assume it is the first
+		numBarrierConsumed = 0;
+		threadSafeUnaligner.releaseReceivedBarriers();
+	}
+
+	/**
+	 * For unaligned checkpoint, it never blocks processing from the task aspect.
+	 *
+	 * <p>For PoC, we do not consider the possibility that the unaligned checkpoint would
+	 * not perform due to the max configured unaligned checkpoint size.
+	 */
+	@Override
+	public boolean isBlocked(int channelIndex) {
+		return false;
+	}
+
+	/**
+	 * We still need to trigger checkpoint while reading the first barrier from one channel, because this might happen
+	 * earlier than the previous async trigger via mailbox by netty thread. And the {@link AbstractInvokable} has the
+	 * deduplication logic to guarantee trigger checkpoint only once finally.
+	 *
+	 * <p>Note this is also suitable for the trigger case of local input channel.
+	 */
+	@Override
+	public boolean processBarrier(
+			CheckpointBarrier receivedBarrier,
+			int channelIndex,
+			long bufferedBytes) {
+		long barrierId = receivedBarrier.getId();
+		if (currentConsumedCheckpointId < barrierId) {
+			currentConsumedCheckpointId = barrierId;
+			numBarrierConsumed = 0;
+			Arrays.fill(barrierConsumedChannels, false);
+		}
+		if (currentConsumedCheckpointId == barrierId) {
+			barrierConsumedChannels[channelIndex] = true;
+			numBarrierConsumed++;
+		}
+		// processBarrier is called from task thread and can actually happen before notifyBarrierReceived on empty
+		// buffer queues
+		// to avoid replicating any logic, we simply call notifyBarrierReceived here as well
+		threadSafeUnaligner.notifyBarrierReceived(receivedBarrier, channelInfos[channelIndex]);
+		return false;
+	}
+
+	@Override
+	public boolean processCancellationBarrier(CancelCheckpointMarker cancelBarrier) throws Exception {
+		final long barrierId = cancelBarrier.getCheckpointId();
+
+		if (numBarrierConsumed > 0) {
+			// this is only true if some alignment is in progress and nothing was canceled
+
+			if (barrierId == currentConsumedCheckpointId) {
+				// cancel this alignment
+				if (LOG.isDebugEnabled()) {
+					LOG.debug("{}: Checkpoint {} canceled, aborting alignment.", taskName, barrierId);
+				}
+
+				releaseBlocksAndResetBarriers();
+				notifyAbortOnCancellationBarrier(barrierId);
+			}
+			else if (barrierId > currentConsumedCheckpointId) {
+				// we canceled the next which also cancels the current
+				LOG.warn("{}: Received cancellation barrier for checkpoint {} before completing current checkpoint {}. " +
+						"Skipping current checkpoint.",
+					taskName,
+					barrierId,
+					currentConsumedCheckpointId);
+
+				// this stops the current alignment
+				releaseBlocksAndResetBarriers();
 
 Review comment:
   In `this.releaseBlocksAndResetBarriers` we call
   `threadSafeUnaligner.releaseReceivedBarriers();`
   
   But in `threadSafeUnaligner` condition `barrierId > currentConsumedCheckpointId` may not hold.
   Should we add a check in `threadSafeUnaligner.releaseReceivedBarriers` similar to `setCurrentReceivedCheckpointId`?
   
   nit: repeating method name for a nested class (discussed above)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] pnowojski commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
pnowojski commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r405596704
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartition.java
 ##########
 @@ -83,24 +86,45 @@
 	/** The total number of bytes (both data and event buffers). */
 	private long totalNumberOfBytes;
 
+	/** The collection of buffers which are spanned over by checkpoint barrier and needs to be persisted for snapshot. */
+	private final List<Buffer> inflightBufferSnapshot = new ArrayList<>();
+
 	// ------------------------------------------------------------------------
 
 	PipelinedSubpartition(int index, ResultPartition parent) {
 		super(index, parent);
 	}
 
 	@Override
-	public boolean add(BufferConsumer bufferConsumer) {
-		return add(bufferConsumer, false);
+	public boolean add(BufferConsumer bufferConsumer) throws IOException {
+		return add(bufferConsumer, false, false);
 	}
 
 	@Override
 	public void finish() throws IOException {
-		add(EventSerializer.toBufferConsumer(EndOfPartitionEvent.INSTANCE), true);
+		add(EventSerializer.toBufferConsumer(EndOfPartitionEvent.INSTANCE), true, false);
 		LOG.debug("{}: Finished {}.", parent.getOwningTaskName(), this);
 	}
 
-	private boolean add(BufferConsumer bufferConsumer, boolean finish) {
+	@Override
+	public EnqueueAction priorityEvent(AbstractEvent event, BufferConsumer eventBufferConsumer) throws IOException {
+		if (readView != null) {
+			switch (readView.priorityEvent(event, eventBufferConsumer)) {
 
 Review comment:
   One more thing. @AHeise shouldn't we merge `BufferAvailabilityListener` and `PriorityEventListener` interfaces? They are doing basically the same thing. One is notifying about "hot" data, another about normal data and they should be used together always (especially after dropping `PriorityEventListener` inheritance from `ResultSubpartition` and `PipelinedSubpartitionView`).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zhijiangW commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
zhijiangW commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r403725829
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/serialization/SpillingAdaptiveSpanningRecordDeserializer.java
 ##########
 @@ -557,6 +579,28 @@ private void addNextChunkFromMemorySegment(MemorySegment segment, int offset, in
 			}
 		}
 
+		@Nullable
+		MemorySegment copyToTargetSegment() {
+			// for the case of only partial length, no data
+			final int position = lengthBuffer.position();
+			if (position > 0) {
+				MemorySegment segment = MemorySegmentFactory.allocateUnpooledSegment(lengthBuffer.remaining());
+				segment.put(0, lengthBuffer, lengthBuffer.remaining());
+				lengthBuffer.position(position);
+				return segment;
+			}
+
+			// for the case of full length, partial data in buffer
+			if (recordLength != -1) {
+				// In the PoC we skip the case of large record which size exceeds THRESHOLD_FOR_SPILLING,
 
 Review comment:
   I am not thinking through the solution yet. In my previous PoC, I also found it is difficult to handle since it is also not easy to read the partial data from spilled files ATM, so I left it as TODO to not pay much efforts.
   
   I think we might not support this large record case in MVP, but we should not mute it. Otherwise once we encounter this case in production, the completed checkpoint can not be restored correctly because of missing partial records. Maybe we can discard the unaligned checkpoint for large record case or throw exceptions to warn users for tuning the proper checkpoint setting?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#issuecomment-603776093
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6621",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155064201",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155877268",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6755",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6839",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156597180",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6846",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156864478",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6873",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156994047",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157330632",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6900",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157451694",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6916",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157494634",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6933",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157589655",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6944",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6991",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157754467",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158102285",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7007",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7023",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158153241",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158188400",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7040",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7048",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158276096",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158831429",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7117",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7121",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158855200",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "status" : "FAILURE",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159112519",
       "triggerID" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7172",
       "triggerID" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159143719",
       "triggerID" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7175",
       "triggerID" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * dee2b337e5e72d8f7b1f5098b74f2958d000fb3c UNKNOWN
   * 80b7f76f24b5fb6704a4b2292543f8764ec19053 UNKNOWN
   * f1c7ddec67cf96365c63ff93d1ed4353b478eba4 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/159112519) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7172) 
   * 2c9926f618130a7d268ac2784fbb5e956e488088 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/159143719) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7175) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#issuecomment-603776093
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6621",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155064201",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155877268",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6755",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6839",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156597180",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6846",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "FAILURE",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156864478",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9a496a27a92e242519764b935012e44adade76a1 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/156864478) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6846) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] pnowojski commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
pnowojski commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r399367431
 
 

 ##########
 File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/CheckpointBarrierUnaligner.java
 ##########
 @@ -0,0 +1,242 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.streaming.runtime.io;
+
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.runtime.checkpoint.channel.ChannelStateWriter;
+import org.apache.flink.runtime.checkpoint.channel.InputChannelInfo;
+import org.apache.flink.runtime.io.network.api.CancelCheckpointMarker;
+import org.apache.flink.runtime.io.network.api.CheckpointBarrier;
+import org.apache.flink.runtime.io.network.buffer.Buffer;
+import org.apache.flink.runtime.jobgraph.tasks.AbstractInvokable;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import javax.annotation.Nullable;
+
+import java.util.Arrays;
+import java.util.concurrent.CompletableFuture;
+
+import static org.apache.flink.util.Preconditions.checkNotNull;
+
+/**
+ * {@link CheckpointBarrierUnaligner} is used for triggering checkpoint while reading the first barrier
+ * and keeping track of the number of received barriers and consumed barriers.
+ */
+@Internal
+public class CheckpointBarrierUnaligner extends CheckpointBarrierHandler {
+
+	private static final Logger LOG = LoggerFactory.getLogger(CheckpointBarrierUnaligner.class);
+
+	private final String taskName;
+
+	/**
+	 * Tag the state of which input channel has read the barrier. If one channel has read the barrier by task,
+	 * the respective in-flight input buffers should be empty when triggering unaligned checkpoint.
+	 */
+	private final boolean[] barrierConsumedChannels;
+
+	/**
+	 * Tag the state of which input channel has received the barrier. Until the barrier of a specific channel is
+	 * received, all new buffers need to be persisted after unaligned checkpointing has been started.
+	 */
+	private final boolean[] barrierReceivedChannels;
+
+	/**
+	 * Contains the offsets of the channel indices for each gate when flattening the channels of all gates.
+	 *
+	 * <p>For example, consider 3 gates with 4 channels, {@code gateChannelOffsets = [0, 4, 8]}.
+	 */
+	private final int[] gateChannelOffsets;
+
+	/**
+	 * The number of input channels which has read the barrier by task.
+	 */
+	private int numBarriersReceived;
+
+	/**
+	 * The checkpoint id to guarantee that we would trigger only one checkpoint when reading the same barrier from
+	 * different channels.
+	 */
+	private long currentCheckpointId = -1L;
+
+	private final ChannelStateWriter channelStateWriter;
+
+	private CompletableFuture<?> allBarriersReceivedFuture;
+
+	CheckpointBarrierUnaligner(
+			int[] numberOfInputChannelsPerGate,
+			ChannelStateWriter channelStateWriter,
+			String taskName,
+			@Nullable AbstractInvokable toNotifyOnCheckpoint) {
+		super(toNotifyOnCheckpoint);
+
+		this.taskName = taskName;
+		this.channelStateWriter = checkNotNull(channelStateWriter);
+
+		final int numGates = numberOfInputChannelsPerGate.length;
+
+		gateChannelOffsets = new int[numGates];
+		for (int index = 1; index < numGates; index++) {
+			gateChannelOffsets[index] = gateChannelOffsets[index - 1] + numberOfInputChannelsPerGate[index - 1];
+		}
+
+		final int totalNumChannels = gateChannelOffsets[numGates - 1] + numberOfInputChannelsPerGate[numGates - 1];
+		barrierConsumedChannels = new boolean[totalNumChannels];
+		Arrays.fill(barrierConsumedChannels, true);
+		barrierReceivedChannels = new boolean[totalNumChannels];
+		Arrays.fill(barrierReceivedChannels, true);
+	}
+
+	@Override
+	public void releaseBlocksAndResetBarriers() {
+	}
+
+	/**
+	 * For unaligned checkpoint, it never blocks processing from the task aspect.
+	 *
+	 * <p>For PoC, we do not consider the possibility that the unaligned checkpoint would
+	 * not perform due to the max configured unaligned checkpoint size.
+	 */
+	@Override
+	public boolean isBlocked(int channelIndex) {
+		return false;
+	}
+
+	/**
+	 * We still need to trigger checkpoint while reading the first barrier from one channel, because this might happen
+	 * earlier than the previous async trigger via mailbox by netty thread. And the {@link AbstractInvokable} has the
+	 * deduplication logic to guarantee trigger checkpoint only once finally.
+	 *
+	 * <p>Note this is also suitable for the trigger case of local input channel.
+	 */
+	@Override
+	public synchronized boolean processBarrier(
+			CheckpointBarrier receivedBarrier,
+			int channelIndex,
+			long bufferedBytes) {
+		long barrierId = receivedBarrier.getId();
+		if (checkNewCheckpoint(barrierId)) {
+			notifyCheckpointAsync(receivedBarrier, bufferedBytes, 0);
+		}
+		barrierConsumedChannels[channelIndex] = true;
+		return false;
+	}
+
+	@Override
+	public boolean processCancellationBarrier(CancelCheckpointMarker cancelBarrier) {
+		return false;
+	}
+
+	@Override
+	public boolean processEndOfPartition() {
+		return false;
+	}
+
+	@Override
+	public long getLatestCheckpointId() {
+		return currentCheckpointId;
+	}
+
+	@Override
+	public long getAlignmentDurationNanos() {
+		return 0;
+	}
+
+	@Override
+	public String toString() {
+		return String.format("%s: last checkpoint: %d", taskName, currentCheckpointId);
+	}
+
+	@Override
+	public void checkpointSizeLimitExceeded(long maxBufferedBytes) {
+	}
+
+	@Override
+	protected boolean isBarrierConsumed(long checkpointId, int channelIndex) {
+		if (checkpointId < currentCheckpointId) {
+			return true;
+		}
+		if (checkpointId > currentCheckpointId) {
+			return false;
+		}
+		return barrierConsumedChannels[channelIndex];
+	}
+
+	public CompletableFuture<?> getAllBarriersReceivedFuture(long checkpointId) {
 
 Review comment:
   I don't like the solution with `volatile` it makes reasoning about this class so much more complicated... Making the future `volatile` is even worse pattern, as future itself is already a wrapper around `volatile` variable.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#issuecomment-603776093
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6621",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155064201",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155877268",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6755",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6839",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156597180",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6846",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156864478",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6873",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156994047",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157330632",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6900",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157451694",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6916",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157494634",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6933",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157589655",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6944",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6991",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157754467",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158102285",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7007",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7023",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158153241",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158188400",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7040",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7048",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158276096",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158831429",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7117",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7121",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158855200",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159112519",
       "triggerID" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7172",
       "triggerID" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159143719",
       "triggerID" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7175",
       "triggerID" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "triggerType" : "PUSH"
     }, {
       "hash" : "35ec088ef24e841beae78c33488975d2d8d0a40d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "35ec088ef24e841beae78c33488975d2d8d0a40d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7194",
       "triggerID" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159244661",
       "triggerID" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "triggerType" : "PUSH"
     }, {
       "hash" : "334458afaa98b601eec12c490e71caa8274be055",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "334458afaa98b601eec12c490e71caa8274be055",
       "triggerType" : "PUSH"
     }, {
       "hash" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7212",
       "triggerID" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "triggerType" : "PUSH"
     }, {
       "hash" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159269141",
       "triggerID" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7226",
       "triggerID" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159307415",
       "triggerID" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7297",
       "triggerID" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159652918",
       "triggerID" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "559816dcea4999dd46b09ee1091ddc0e1a5a7a54",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "559816dcea4999dd46b09ee1091ddc0e1a5a7a54",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6cd76afe4990f56a5166e1592374aa8f86fe883f",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "6cd76afe4990f56a5166e1592374aa8f86fe883f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7302",
       "triggerID" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159678447",
       "triggerID" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159695914",
       "triggerID" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7305",
       "triggerID" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ac996f5c703560ecbe6cad7394cc8ad54d6f0029",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "ac996f5c703560ecbe6cad7394cc8ad54d6f0029",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7347",
       "triggerID" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159875195",
       "triggerID" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "75c8130873e9b91e21e1e833d3d05f1ad9b5d2b8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7354",
       "triggerID" : "75c8130873e9b91e21e1e833d3d05f1ad9b5d2b8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7369",
       "triggerID" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "triggerType" : "PUSH"
     }, {
       "hash" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159960514",
       "triggerID" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7373",
       "triggerID" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159990549",
       "triggerID" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "triggerType" : "PUSH"
     }, {
       "hash" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7443",
       "triggerID" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160172375",
       "triggerID" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "536d9fb04a7a8142c04c94344dd0b3c0f2c10999",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160215439",
       "triggerID" : "536d9fb04a7a8142c04c94344dd0b3c0f2c10999",
       "triggerType" : "PUSH"
     }, {
       "hash" : "536d9fb04a7a8142c04c94344dd0b3c0f2c10999",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7469",
       "triggerID" : "536d9fb04a7a8142c04c94344dd0b3c0f2c10999",
       "triggerType" : "PUSH"
     }, {
       "hash" : "67018bacf5bc2daa8a03a1aafa880efc1db86808",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7500",
       "triggerID" : "67018bacf5bc2daa8a03a1aafa880efc1db86808",
       "triggerType" : "PUSH"
     }, {
       "hash" : "67018bacf5bc2daa8a03a1aafa880efc1db86808",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160347006",
       "triggerID" : "67018bacf5bc2daa8a03a1aafa880efc1db86808",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * dee2b337e5e72d8f7b1f5098b74f2958d000fb3c UNKNOWN
   * 80b7f76f24b5fb6704a4b2292543f8764ec19053 UNKNOWN
   * 35ec088ef24e841beae78c33488975d2d8d0a40d UNKNOWN
   * 334458afaa98b601eec12c490e71caa8274be055 UNKNOWN
   * 559816dcea4999dd46b09ee1091ddc0e1a5a7a54 UNKNOWN
   * 6cd76afe4990f56a5166e1592374aa8f86fe883f UNKNOWN
   * ac996f5c703560ecbe6cad7394cc8ad54d6f0029 UNKNOWN
   * 536d9fb04a7a8142c04c94344dd0b3c0f2c10999 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/160215439) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7469) 
   * 67018bacf5bc2daa8a03a1aafa880efc1db86808 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/160347006) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7500) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#issuecomment-603776093
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6621",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155064201",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155877268",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6755",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6839",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156597180",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6846",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156864478",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6873",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156994047",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157330632",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6900",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157451694",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6916",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157494634",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6933",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157589655",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6944",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6991",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157754467",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158102285",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7007",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7023",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158153241",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158188400",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7040",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7048",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158276096",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158831429",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7117",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7121",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158855200",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159112519",
       "triggerID" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7172",
       "triggerID" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159143719",
       "triggerID" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7175",
       "triggerID" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "triggerType" : "PUSH"
     }, {
       "hash" : "35ec088ef24e841beae78c33488975d2d8d0a40d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "35ec088ef24e841beae78c33488975d2d8d0a40d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7194",
       "triggerID" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159244661",
       "triggerID" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "triggerType" : "PUSH"
     }, {
       "hash" : "334458afaa98b601eec12c490e71caa8274be055",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "334458afaa98b601eec12c490e71caa8274be055",
       "triggerType" : "PUSH"
     }, {
       "hash" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7212",
       "triggerID" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "triggerType" : "PUSH"
     }, {
       "hash" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159269141",
       "triggerID" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7226",
       "triggerID" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159307415",
       "triggerID" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7297",
       "triggerID" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159652918",
       "triggerID" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "559816dcea4999dd46b09ee1091ddc0e1a5a7a54",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "559816dcea4999dd46b09ee1091ddc0e1a5a7a54",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6cd76afe4990f56a5166e1592374aa8f86fe883f",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "6cd76afe4990f56a5166e1592374aa8f86fe883f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7302",
       "triggerID" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159678447",
       "triggerID" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159695914",
       "triggerID" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7305",
       "triggerID" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ac996f5c703560ecbe6cad7394cc8ad54d6f0029",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "ac996f5c703560ecbe6cad7394cc8ad54d6f0029",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7347",
       "triggerID" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159875195",
       "triggerID" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "75c8130873e9b91e21e1e833d3d05f1ad9b5d2b8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7354",
       "triggerID" : "75c8130873e9b91e21e1e833d3d05f1ad9b5d2b8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7369",
       "triggerID" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "triggerType" : "PUSH"
     }, {
       "hash" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159960514",
       "triggerID" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7373",
       "triggerID" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159990549",
       "triggerID" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "triggerType" : "PUSH"
     }, {
       "hash" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7443",
       "triggerID" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160172375",
       "triggerID" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "536d9fb04a7a8142c04c94344dd0b3c0f2c10999",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160215439",
       "triggerID" : "536d9fb04a7a8142c04c94344dd0b3c0f2c10999",
       "triggerType" : "PUSH"
     }, {
       "hash" : "536d9fb04a7a8142c04c94344dd0b3c0f2c10999",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7469",
       "triggerID" : "536d9fb04a7a8142c04c94344dd0b3c0f2c10999",
       "triggerType" : "PUSH"
     }, {
       "hash" : "67018bacf5bc2daa8a03a1aafa880efc1db86808",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7500",
       "triggerID" : "67018bacf5bc2daa8a03a1aafa880efc1db86808",
       "triggerType" : "PUSH"
     }, {
       "hash" : "67018bacf5bc2daa8a03a1aafa880efc1db86808",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160347006",
       "triggerID" : "67018bacf5bc2daa8a03a1aafa880efc1db86808",
       "triggerType" : "PUSH"
     }, {
       "hash" : "79c116a6a1f5fe314f801e81f0265dea8b9ac1a7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7522",
       "triggerID" : "79c116a6a1f5fe314f801e81f0265dea8b9ac1a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "79c116a6a1f5fe314f801e81f0265dea8b9ac1a7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160377553",
       "triggerID" : "79c116a6a1f5fe314f801e81f0265dea8b9ac1a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "27ce4bfad8e99989dd64f8c636c934727da8a062",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "27ce4bfad8e99989dd64f8c636c934727da8a062",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ce0dfc7324679ebf2da84278eac8f5f59d748319",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7539",
       "triggerID" : "ce0dfc7324679ebf2da84278eac8f5f59d748319",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ce0dfc7324679ebf2da84278eac8f5f59d748319",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160418181",
       "triggerID" : "ce0dfc7324679ebf2da84278eac8f5f59d748319",
       "triggerType" : "PUSH"
     }, {
       "hash" : "05c934bf483d4fb673496783ef8ff85b40b86708",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "05c934bf483d4fb673496783ef8ff85b40b86708",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4bbe67a13a75f4491898fbb1cd2315237dbca30e",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160443829",
       "triggerID" : "4bbe67a13a75f4491898fbb1cd2315237dbca30e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4bbe67a13a75f4491898fbb1cd2315237dbca30e",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7543",
       "triggerID" : "4bbe67a13a75f4491898fbb1cd2315237dbca30e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * dee2b337e5e72d8f7b1f5098b74f2958d000fb3c UNKNOWN
   * 80b7f76f24b5fb6704a4b2292543f8764ec19053 UNKNOWN
   * 35ec088ef24e841beae78c33488975d2d8d0a40d UNKNOWN
   * 334458afaa98b601eec12c490e71caa8274be055 UNKNOWN
   * 559816dcea4999dd46b09ee1091ddc0e1a5a7a54 UNKNOWN
   * 6cd76afe4990f56a5166e1592374aa8f86fe883f UNKNOWN
   * ac996f5c703560ecbe6cad7394cc8ad54d6f0029 UNKNOWN
   * 27ce4bfad8e99989dd64f8c636c934727da8a062 UNKNOWN
   * 05c934bf483d4fb673496783ef8ff85b40b86708 UNKNOWN
   * 4bbe67a13a75f4491898fbb1cd2315237dbca30e Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/160443829) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7543) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#issuecomment-603776093
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6621",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155064201",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155877268",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6755",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6839",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156597180",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6846",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156864478",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6873",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156994047",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157330632",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6900",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157451694",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6916",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157494634",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6933",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157589655",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6944",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6991",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157754467",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158102285",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7007",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7023",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158153241",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158188400",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7040",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7048",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158276096",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158831429",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7117",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7121",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158855200",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159112519",
       "triggerID" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7172",
       "triggerID" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "status" : "CANCELED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159143719",
       "triggerID" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7175",
       "triggerID" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "triggerType" : "PUSH"
     }, {
       "hash" : "35ec088ef24e841beae78c33488975d2d8d0a40d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "35ec088ef24e841beae78c33488975d2d8d0a40d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * dee2b337e5e72d8f7b1f5098b74f2958d000fb3c UNKNOWN
   * 80b7f76f24b5fb6704a4b2292543f8764ec19053 UNKNOWN
   * 2c9926f618130a7d268ac2784fbb5e956e488088 Travis: [CANCELED](https://travis-ci.com/github/flink-ci/flink/builds/159143719) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7175) 
   * 35ec088ef24e841beae78c33488975d2d8d0a40d UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#issuecomment-603776093
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6621",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155064201",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155877268",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6755",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6839",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156597180",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6846",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156864478",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6873",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156994047",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157330632",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6900",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157451694",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6916",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157494634",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6933",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157589655",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6944",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6991",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157754467",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158102285",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7007",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7023",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158153241",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158188400",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7040",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7048",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158276096",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158831429",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7117",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7121",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158855200",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159112519",
       "triggerID" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7172",
       "triggerID" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159143719",
       "triggerID" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7175",
       "triggerID" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "triggerType" : "PUSH"
     }, {
       "hash" : "35ec088ef24e841beae78c33488975d2d8d0a40d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "35ec088ef24e841beae78c33488975d2d8d0a40d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7194",
       "triggerID" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "status" : "CANCELED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159244661",
       "triggerID" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "triggerType" : "PUSH"
     }, {
       "hash" : "334458afaa98b601eec12c490e71caa8274be055",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "334458afaa98b601eec12c490e71caa8274be055",
       "triggerType" : "PUSH"
     }, {
       "hash" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7212",
       "triggerID" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "triggerType" : "PUSH"
     }, {
       "hash" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159269141",
       "triggerID" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * dee2b337e5e72d8f7b1f5098b74f2958d000fb3c UNKNOWN
   * 80b7f76f24b5fb6704a4b2292543f8764ec19053 UNKNOWN
   * 35ec088ef24e841beae78c33488975d2d8d0a40d UNKNOWN
   * ee3ad987187409939aa7c211778ed88dd64f6479 Travis: [CANCELED](https://travis-ci.com/github/flink-ci/flink/builds/159244661) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7194) 
   * 334458afaa98b601eec12c490e71caa8274be055 UNKNOWN
   * 17d1689c8376c55a8c5e41f78908d047b14f5631 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/159269141) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7212) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] rkhachatryan commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r408027643
 
 

 ##########
 File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/CheckpointedInputGate.java
 ##########
 @@ -171,6 +176,18 @@ else if (bufferOrEvent.getEvent().getClass() == CancelCheckpointMarker.class) {
 		}
 	}
 
+	public List<Buffer> requestInflightBuffers(long checkpointId, int channelIndex) throws IOException {
+		if (((CheckpointBarrierUnaligner) barrierHandler).hasInflightData(checkpointId, channelIndex)) {
+			return inputGate.getChannel(channelIndex).requestInflightBuffers(checkpointId);
 
 Review comment:
   I think that `CheckpointBarrierUnaligner.hasInflightData` and the actual InflightBuffers in the input channel
   can be inconsistent as they are updated by different threads.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] rkhachatryan commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r408144900
 
 

 ##########
 File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/CheckpointedInputGate.java
 ##########
 @@ -171,6 +176,18 @@ else if (bufferOrEvent.getEvent().getClass() == CancelCheckpointMarker.class) {
 		}
 	}
 
+	public List<Buffer> requestInflightBuffers(long checkpointId, int channelIndex) throws IOException {
+		if (((CheckpointBarrierUnaligner) barrierHandler).hasInflightData(checkpointId, channelIndex)) {
+			return inputGate.getChannel(channelIndex).requestInflightBuffers(checkpointId);
 
 Review comment:
   I mean the case when:
   1. task thread is suspended by OS scheduler
   1. netty thread receives a buffer `X` and adds it to `RemoteInputChannel.receivedBuffers`
   1. netty thread receives a barrier and schedules a checkpoint by enqueueing a mail (`RIC.onBuffer` -> `ThreadSafeUnaligner#notifyBarrierReceived`)
   1. task thread wakes up and sees a **mail** (not a default action);
   1. task thread performs a checkpoint; it checks `CheckpointBarrierUnaligner.hasInflightData` and reads `false` so it doesn't go into `requestInflightBuffers`
   
   Now:
   - The buffer `X` added in the beginning is missing in the checkpoint; 
   - `RemoteInputChannel#lastRequestedCheckpointId` is not updated;
   
   Am I missing something?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] pnowojski edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
pnowojski edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#issuecomment-615084597
 
 
   Both azure test failures are unrelated and exist on master. Will merge this soon.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#issuecomment-603776093
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6621",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155064201",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155877268",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6755",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6839",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156597180",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6846",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156864478",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6873",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156994047",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157330632",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6900",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157451694",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6916",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157494634",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6933",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157589655",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6944",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6991",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157754467",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158102285",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7007",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7023",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158153241",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158188400",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7040",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7048",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158276096",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158831429",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7117",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7121",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158855200",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159112519",
       "triggerID" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7172",
       "triggerID" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159143719",
       "triggerID" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7175",
       "triggerID" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "triggerType" : "PUSH"
     }, {
       "hash" : "35ec088ef24e841beae78c33488975d2d8d0a40d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "35ec088ef24e841beae78c33488975d2d8d0a40d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7194",
       "triggerID" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159244661",
       "triggerID" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "triggerType" : "PUSH"
     }, {
       "hash" : "334458afaa98b601eec12c490e71caa8274be055",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "334458afaa98b601eec12c490e71caa8274be055",
       "triggerType" : "PUSH"
     }, {
       "hash" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7212",
       "triggerID" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "triggerType" : "PUSH"
     }, {
       "hash" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159269141",
       "triggerID" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7226",
       "triggerID" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159307415",
       "triggerID" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7297",
       "triggerID" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159652918",
       "triggerID" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "559816dcea4999dd46b09ee1091ddc0e1a5a7a54",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "559816dcea4999dd46b09ee1091ddc0e1a5a7a54",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6cd76afe4990f56a5166e1592374aa8f86fe883f",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "6cd76afe4990f56a5166e1592374aa8f86fe883f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7302",
       "triggerID" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159678447",
       "triggerID" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159695914",
       "triggerID" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7305",
       "triggerID" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ac996f5c703560ecbe6cad7394cc8ad54d6f0029",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "ac996f5c703560ecbe6cad7394cc8ad54d6f0029",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7347",
       "triggerID" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159875195",
       "triggerID" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * dee2b337e5e72d8f7b1f5098b74f2958d000fb3c UNKNOWN
   * 80b7f76f24b5fb6704a4b2292543f8764ec19053 UNKNOWN
   * 35ec088ef24e841beae78c33488975d2d8d0a40d UNKNOWN
   * 334458afaa98b601eec12c490e71caa8274be055 UNKNOWN
   * 559816dcea4999dd46b09ee1091ddc0e1a5a7a54 UNKNOWN
   * 6cd76afe4990f56a5166e1592374aa8f86fe883f UNKNOWN
   * ac996f5c703560ecbe6cad7394cc8ad54d6f0029 UNKNOWN
   * 2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/159875195) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7347) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#issuecomment-603776093
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6621",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155064201",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155877268",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6755",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6839",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156597180",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6846",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156864478",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6873",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156994047",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157330632",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6900",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157451694",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6916",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157494634",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6933",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157589655",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6944",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6991",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157754467",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158102285",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7007",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7023",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158153241",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158188400",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7040",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7048",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158276096",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158831429",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7117",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7121",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158855200",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159112519",
       "triggerID" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7172",
       "triggerID" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159143719",
       "triggerID" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7175",
       "triggerID" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "triggerType" : "PUSH"
     }, {
       "hash" : "35ec088ef24e841beae78c33488975d2d8d0a40d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "35ec088ef24e841beae78c33488975d2d8d0a40d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7194",
       "triggerID" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159244661",
       "triggerID" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "triggerType" : "PUSH"
     }, {
       "hash" : "334458afaa98b601eec12c490e71caa8274be055",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "334458afaa98b601eec12c490e71caa8274be055",
       "triggerType" : "PUSH"
     }, {
       "hash" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7212",
       "triggerID" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "triggerType" : "PUSH"
     }, {
       "hash" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159269141",
       "triggerID" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7226",
       "triggerID" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159307415",
       "triggerID" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7297",
       "triggerID" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159652918",
       "triggerID" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "559816dcea4999dd46b09ee1091ddc0e1a5a7a54",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "559816dcea4999dd46b09ee1091ddc0e1a5a7a54",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6cd76afe4990f56a5166e1592374aa8f86fe883f",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "6cd76afe4990f56a5166e1592374aa8f86fe883f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7302",
       "triggerID" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159678447",
       "triggerID" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159695914",
       "triggerID" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7305",
       "triggerID" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ac996f5c703560ecbe6cad7394cc8ad54d6f0029",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "ac996f5c703560ecbe6cad7394cc8ad54d6f0029",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7347",
       "triggerID" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159875195",
       "triggerID" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "75c8130873e9b91e21e1e833d3d05f1ad9b5d2b8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7354",
       "triggerID" : "75c8130873e9b91e21e1e833d3d05f1ad9b5d2b8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7369",
       "triggerID" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "triggerType" : "PUSH"
     }, {
       "hash" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159960514",
       "triggerID" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7373",
       "triggerID" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159990549",
       "triggerID" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "triggerType" : "PUSH"
     }, {
       "hash" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7443",
       "triggerID" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160172375",
       "triggerID" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "536d9fb04a7a8142c04c94344dd0b3c0f2c10999",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160215439",
       "triggerID" : "536d9fb04a7a8142c04c94344dd0b3c0f2c10999",
       "triggerType" : "PUSH"
     }, {
       "hash" : "536d9fb04a7a8142c04c94344dd0b3c0f2c10999",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7469",
       "triggerID" : "536d9fb04a7a8142c04c94344dd0b3c0f2c10999",
       "triggerType" : "PUSH"
     }, {
       "hash" : "67018bacf5bc2daa8a03a1aafa880efc1db86808",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "67018bacf5bc2daa8a03a1aafa880efc1db86808",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * dee2b337e5e72d8f7b1f5098b74f2958d000fb3c UNKNOWN
   * 80b7f76f24b5fb6704a4b2292543f8764ec19053 UNKNOWN
   * 35ec088ef24e841beae78c33488975d2d8d0a40d UNKNOWN
   * 334458afaa98b601eec12c490e71caa8274be055 UNKNOWN
   * 559816dcea4999dd46b09ee1091ddc0e1a5a7a54 UNKNOWN
   * 6cd76afe4990f56a5166e1592374aa8f86fe883f UNKNOWN
   * ac996f5c703560ecbe6cad7394cc8ad54d6f0029 UNKNOWN
   * 536d9fb04a7a8142c04c94344dd0b3c0f2c10999 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/160215439) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7469) 
   * 67018bacf5bc2daa8a03a1aafa880efc1db86808 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#issuecomment-603776093
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6621",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155064201",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155877268",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6755",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6839",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156597180",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6846",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156864478",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6873",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156994047",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157330632",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6900",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157451694",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6916",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157494634",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6933",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157589655",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6944",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6991",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157754467",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158102285",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7007",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7023",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158153241",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158188400",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7040",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7048",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158276096",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158831429",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7117",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7121",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158855200",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159112519",
       "triggerID" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7172",
       "triggerID" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159143719",
       "triggerID" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7175",
       "triggerID" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "triggerType" : "PUSH"
     }, {
       "hash" : "35ec088ef24e841beae78c33488975d2d8d0a40d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "35ec088ef24e841beae78c33488975d2d8d0a40d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7194",
       "triggerID" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159244661",
       "triggerID" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "triggerType" : "PUSH"
     }, {
       "hash" : "334458afaa98b601eec12c490e71caa8274be055",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "334458afaa98b601eec12c490e71caa8274be055",
       "triggerType" : "PUSH"
     }, {
       "hash" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7212",
       "triggerID" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "triggerType" : "PUSH"
     }, {
       "hash" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159269141",
       "triggerID" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7226",
       "triggerID" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159307415",
       "triggerID" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7297",
       "triggerID" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159652918",
       "triggerID" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "559816dcea4999dd46b09ee1091ddc0e1a5a7a54",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "559816dcea4999dd46b09ee1091ddc0e1a5a7a54",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6cd76afe4990f56a5166e1592374aa8f86fe883f",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "6cd76afe4990f56a5166e1592374aa8f86fe883f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7302",
       "triggerID" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159678447",
       "triggerID" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159695914",
       "triggerID" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7305",
       "triggerID" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ac996f5c703560ecbe6cad7394cc8ad54d6f0029",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "ac996f5c703560ecbe6cad7394cc8ad54d6f0029",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7347",
       "triggerID" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159875195",
       "triggerID" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "75c8130873e9b91e21e1e833d3d05f1ad9b5d2b8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7354",
       "triggerID" : "75c8130873e9b91e21e1e833d3d05f1ad9b5d2b8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7369",
       "triggerID" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "triggerType" : "PUSH"
     }, {
       "hash" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159960514",
       "triggerID" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7373",
       "triggerID" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159990549",
       "triggerID" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "triggerType" : "PUSH"
     }, {
       "hash" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7443",
       "triggerID" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160172375",
       "triggerID" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "536d9fb04a7a8142c04c94344dd0b3c0f2c10999",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160215439",
       "triggerID" : "536d9fb04a7a8142c04c94344dd0b3c0f2c10999",
       "triggerType" : "PUSH"
     }, {
       "hash" : "536d9fb04a7a8142c04c94344dd0b3c0f2c10999",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7469",
       "triggerID" : "536d9fb04a7a8142c04c94344dd0b3c0f2c10999",
       "triggerType" : "PUSH"
     }, {
       "hash" : "67018bacf5bc2daa8a03a1aafa880efc1db86808",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7500",
       "triggerID" : "67018bacf5bc2daa8a03a1aafa880efc1db86808",
       "triggerType" : "PUSH"
     }, {
       "hash" : "67018bacf5bc2daa8a03a1aafa880efc1db86808",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160347006",
       "triggerID" : "67018bacf5bc2daa8a03a1aafa880efc1db86808",
       "triggerType" : "PUSH"
     }, {
       "hash" : "79c116a6a1f5fe314f801e81f0265dea8b9ac1a7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7522",
       "triggerID" : "79c116a6a1f5fe314f801e81f0265dea8b9ac1a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "79c116a6a1f5fe314f801e81f0265dea8b9ac1a7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160377553",
       "triggerID" : "79c116a6a1f5fe314f801e81f0265dea8b9ac1a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "27ce4bfad8e99989dd64f8c636c934727da8a062",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "27ce4bfad8e99989dd64f8c636c934727da8a062",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ce0dfc7324679ebf2da84278eac8f5f59d748319",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7539",
       "triggerID" : "ce0dfc7324679ebf2da84278eac8f5f59d748319",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ce0dfc7324679ebf2da84278eac8f5f59d748319",
       "status" : "FAILURE",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160418181",
       "triggerID" : "ce0dfc7324679ebf2da84278eac8f5f59d748319",
       "triggerType" : "PUSH"
     }, {
       "hash" : "05c934bf483d4fb673496783ef8ff85b40b86708",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "05c934bf483d4fb673496783ef8ff85b40b86708",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4bbe67a13a75f4491898fbb1cd2315237dbca30e",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160443829",
       "triggerID" : "4bbe67a13a75f4491898fbb1cd2315237dbca30e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4bbe67a13a75f4491898fbb1cd2315237dbca30e",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7543",
       "triggerID" : "4bbe67a13a75f4491898fbb1cd2315237dbca30e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * dee2b337e5e72d8f7b1f5098b74f2958d000fb3c UNKNOWN
   * 80b7f76f24b5fb6704a4b2292543f8764ec19053 UNKNOWN
   * 35ec088ef24e841beae78c33488975d2d8d0a40d UNKNOWN
   * 334458afaa98b601eec12c490e71caa8274be055 UNKNOWN
   * 559816dcea4999dd46b09ee1091ddc0e1a5a7a54 UNKNOWN
   * 6cd76afe4990f56a5166e1592374aa8f86fe883f UNKNOWN
   * ac996f5c703560ecbe6cad7394cc8ad54d6f0029 UNKNOWN
   * 27ce4bfad8e99989dd64f8c636c934727da8a062 UNKNOWN
   * ce0dfc7324679ebf2da84278eac8f5f59d748319 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/160418181) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7539) 
   * 05c934bf483d4fb673496783ef8ff85b40b86708 UNKNOWN
   * 4bbe67a13a75f4491898fbb1cd2315237dbca30e Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/160443829) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7543) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zhijiangW commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
zhijiangW commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r399072362
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/SingleInputGate.java
 ##########
 @@ -245,6 +257,11 @@ void requestPartitions() throws IOException, InterruptedException {
 		}
 	}
 
+	@Override
+	public void registerBufferReceivedListener(BufferReceivedListener bufferReceivedListener) {
+		this.bufferReceivedListener = checkNotNull(bufferReceivedListener);
 
 Review comment:
   Agree, we should check whether the current class field `bufferReceivedListener` was already set before.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#issuecomment-603776093
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6621",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155064201",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155877268",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6755",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6839",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156597180",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6846",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156864478",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6873",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156994047",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157330632",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6900",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157451694",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6916",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157494634",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6933",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157589655",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6944",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6991",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157754467",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158102285",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7007",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7023",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158153241",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158188400",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7040",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7048",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158276096",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158831429",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7117",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7121",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158855200",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159112519",
       "triggerID" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7172",
       "triggerID" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159143719",
       "triggerID" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7175",
       "triggerID" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "triggerType" : "PUSH"
     }, {
       "hash" : "35ec088ef24e841beae78c33488975d2d8d0a40d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "35ec088ef24e841beae78c33488975d2d8d0a40d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7194",
       "triggerID" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159244661",
       "triggerID" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "triggerType" : "PUSH"
     }, {
       "hash" : "334458afaa98b601eec12c490e71caa8274be055",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "334458afaa98b601eec12c490e71caa8274be055",
       "triggerType" : "PUSH"
     }, {
       "hash" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7212",
       "triggerID" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "triggerType" : "PUSH"
     }, {
       "hash" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "status" : "CANCELED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159269141",
       "triggerID" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7226",
       "triggerID" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159307415",
       "triggerID" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * dee2b337e5e72d8f7b1f5098b74f2958d000fb3c UNKNOWN
   * 80b7f76f24b5fb6704a4b2292543f8764ec19053 UNKNOWN
   * 35ec088ef24e841beae78c33488975d2d8d0a40d UNKNOWN
   * 334458afaa98b601eec12c490e71caa8274be055 UNKNOWN
   * 17d1689c8376c55a8c5e41f78908d047b14f5631 Travis: [CANCELED](https://travis-ci.com/github/flink-ci/flink/builds/159269141) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7212) 
   * 06eece5430689d2da418e0cea10eedae22c6fbb1 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/159307415) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7226) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zhijiangW commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
zhijiangW commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r400294892
 
 

 ##########
 File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
 ##########
 @@ -858,7 +866,12 @@ private boolean performCheckpoint(
 				// make sure it can skip outgoing buffers if unaligned
 				operatorChain.broadcastEvent(message, configuration.isUnalignedCheckpointsEnabled());
 
-				// Step (3): Take the state snapshot. This should be largely asynchronous, to not
+				// Step (3): Prepare to spill the inflighting buffers for input and output
 
 Review comment:
   nit: inflighting -> in-flight

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zhijiangW commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
zhijiangW commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r399059452
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/InputChannel.java
 ##########
 @@ -20,13 +20,18 @@
 
 import org.apache.flink.metrics.Counter;
 import org.apache.flink.runtime.checkpoint.channel.InputChannelInfo;
+import org.apache.flink.runtime.event.AbstractEvent;
 import org.apache.flink.runtime.event.TaskEvent;
 import org.apache.flink.runtime.execution.CancelTaskException;
+import org.apache.flink.runtime.io.network.api.CheckpointBarrier;
+import org.apache.flink.runtime.io.network.api.serialization.EventSerializer;
 import org.apache.flink.runtime.io.network.buffer.Buffer;
 import org.apache.flink.runtime.io.network.partition.PartitionException;
 import org.apache.flink.runtime.io.network.partition.ResultPartitionID;
 import org.apache.flink.runtime.io.network.partition.ResultSubpartitionView;
 
+import javax.annotation.Nullable;
 
 Review comment:
   Invalid imports for above all if only see the commit "[FLINK-16587][network] Introduce BufferReceivedListener for".
   But it does not matter if we want to squash all the commits while merging.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#issuecomment-603776093
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6621",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155064201",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155877268",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6755",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6839",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156597180",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6846",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156864478",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6873",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156994047",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "FAILURE",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157330632",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6900",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * dee2b337e5e72d8f7b1f5098b74f2958d000fb3c UNKNOWN
   * 80b7f76f24b5fb6704a4b2292543f8764ec19053 UNKNOWN
   * f18687d568167f3d70715fc67762564bb9757ee6 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/157330632) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6900) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zhijiangW commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
zhijiangW commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r399072362
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/SingleInputGate.java
 ##########
 @@ -245,6 +257,11 @@ void requestPartitions() throws IOException, InterruptedException {
 		}
 	}
 
+	@Override
+	public void registerBufferReceivedListener(BufferReceivedListener bufferReceivedListener) {
+		this.bufferReceivedListener = checkNotNull(bufferReceivedListener);
 
 Review comment:
   Agree, we should check whether the current class field `bufferReceivedListener` was already been set before.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r402911412
 
 

 ##########
 File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/CheckpointBarrierUnaligner.java
 ##########
 @@ -0,0 +1,338 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.streaming.runtime.io;
+
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.runtime.checkpoint.CheckpointException;
+import org.apache.flink.runtime.checkpoint.CheckpointFailureReason;
+import org.apache.flink.runtime.checkpoint.channel.ChannelStateWriter;
+import org.apache.flink.runtime.checkpoint.channel.InputChannelInfo;
+import org.apache.flink.runtime.io.network.api.CancelCheckpointMarker;
+import org.apache.flink.runtime.io.network.api.CheckpointBarrier;
+import org.apache.flink.runtime.io.network.buffer.Buffer;
+import org.apache.flink.runtime.jobgraph.tasks.AbstractInvokable;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.IOException;
+import java.util.Arrays;
+import java.util.concurrent.CompletableFuture;
+
+import static org.apache.flink.util.Preconditions.checkNotNull;
+
+/**
+ * {@link CheckpointBarrierUnaligner} is used for triggering checkpoint while reading the first barrier
+ * and keeping track of the number of received barriers and consumed barriers.
+ */
+@Internal
+public class CheckpointBarrierUnaligner extends CheckpointBarrierHandler {
+
+	private static final Logger LOG = LoggerFactory.getLogger(CheckpointBarrierUnaligner.class);
+	public static final CompletableFuture<Void> DONE = CompletableFuture.completedFuture(null);
+
+	private final String taskName;
+
+	/**
+	 * Tag the state of which input channel has read the barrier. If one channel has read the barrier by task,
+	 * the respective in-flight input buffers should be empty when triggering unaligned checkpoint.
+	 */
+	private final boolean[] barrierConsumedChannels;
+
+	/**
+	 * Tag the state of which input channel has received the barrier. Until the barrier of a specific channel is
+	 * received, all new buffers need to be persisted after unaligned checkpointing has been started.
+	 */
+	private final boolean[] barrierReceivedChannels;
+
+	/**
+	 * Contains the offsets of the channel indices for each gate when flattening the channels of all gates.
+	 *
+	 * <p>For example, consider 3 gates with 4 channels, {@code gateChannelOffsets = [0, 4, 8]}.
+	 */
+	private final int[] gateChannelOffsets;
+
+	/**
+	 * The number of input channels which has read the barrier by task.
+	 */
+	private int numBarriersReceived;
+
+	/**
+	 * The checkpoint id to guarantee that we would trigger only one checkpoint when reading the same barrier from
+	 * different channels.
+	 */
+	private long currentCheckpointId = -1L;
+
+	/** The number of opened channels. */
+	private int numOpenChannels;
+
+	/** A future indicating that all barriers of the a given checkpoint have been read. */
+	private CompletableFuture<Void> allBarriersReceivedFuture = DONE;
+
+	private final ChannelStateWriter channelStateWriter;
+
+	CheckpointBarrierUnaligner(
+			int[] numberOfInputChannelsPerGate,
+			ChannelStateWriter channelStateWriter,
+			String taskName,
+			AbstractInvokable toNotifyOnCheckpoint) {
+		super(toNotifyOnCheckpoint);
+
+		this.taskName = taskName;
+		this.channelStateWriter = checkNotNull(channelStateWriter);
+
+		final int numGates = numberOfInputChannelsPerGate.length;
+
+		gateChannelOffsets = new int[numGates];
+		for (int index = 1; index < numGates; index++) {
+			gateChannelOffsets[index] = gateChannelOffsets[index - 1] + numberOfInputChannelsPerGate[index - 1];
+		}
+
+		final int totalNumChannels = gateChannelOffsets[numGates - 1] + numberOfInputChannelsPerGate[numGates - 1];
+		barrierConsumedChannels = new boolean[totalNumChannels];
+		Arrays.fill(barrierConsumedChannels, true);
+		barrierReceivedChannels = new boolean[totalNumChannels];
+		Arrays.fill(barrierReceivedChannels, true);
+		numOpenChannels = totalNumChannels;
+	}
+
+	@Override
+	public void releaseBlocksAndResetBarriers() {
+		// make sure no additional data is persisted
+		Arrays.fill(barrierConsumedChannels, true);
 
 Review comment:
   I thought about it even more, since your point is valid. Probably both fields are too technical as of now to meet my needs.
   They should be `barrierReceivedChannels` -> `storeNewBuffers` (invert boolean) and `barrierConsumedChannels` -> `hasInflightBuffers` (invert boolean) .
   WDYT?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#issuecomment-603776093
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6621",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155064201",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155877268",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6755",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6839",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156597180",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6846",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156864478",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6873",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156994047",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157330632",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6900",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157451694",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6916",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157494634",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6933",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157589655",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6944",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6991",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157754467",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158102285",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7007",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7023",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158153241",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158188400",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7040",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7048",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158276096",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158831429",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7117",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7121",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158855200",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159112519",
       "triggerID" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7172",
       "triggerID" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159143719",
       "triggerID" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7175",
       "triggerID" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "triggerType" : "PUSH"
     }, {
       "hash" : "35ec088ef24e841beae78c33488975d2d8d0a40d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "35ec088ef24e841beae78c33488975d2d8d0a40d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7194",
       "triggerID" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159244661",
       "triggerID" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "triggerType" : "PUSH"
     }, {
       "hash" : "334458afaa98b601eec12c490e71caa8274be055",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "334458afaa98b601eec12c490e71caa8274be055",
       "triggerType" : "PUSH"
     }, {
       "hash" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7212",
       "triggerID" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "triggerType" : "PUSH"
     }, {
       "hash" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159269141",
       "triggerID" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7226",
       "triggerID" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159307415",
       "triggerID" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7297",
       "triggerID" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159652918",
       "triggerID" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "559816dcea4999dd46b09ee1091ddc0e1a5a7a54",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "559816dcea4999dd46b09ee1091ddc0e1a5a7a54",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6cd76afe4990f56a5166e1592374aa8f86fe883f",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "6cd76afe4990f56a5166e1592374aa8f86fe883f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7302",
       "triggerID" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159678447",
       "triggerID" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159695914",
       "triggerID" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7305",
       "triggerID" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ac996f5c703560ecbe6cad7394cc8ad54d6f0029",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "ac996f5c703560ecbe6cad7394cc8ad54d6f0029",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7347",
       "triggerID" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159875195",
       "triggerID" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "75c8130873e9b91e21e1e833d3d05f1ad9b5d2b8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7354",
       "triggerID" : "75c8130873e9b91e21e1e833d3d05f1ad9b5d2b8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7369",
       "triggerID" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "triggerType" : "PUSH"
     }, {
       "hash" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "status" : "FAILURE",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159960514",
       "triggerID" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * dee2b337e5e72d8f7b1f5098b74f2958d000fb3c UNKNOWN
   * 80b7f76f24b5fb6704a4b2292543f8764ec19053 UNKNOWN
   * 35ec088ef24e841beae78c33488975d2d8d0a40d UNKNOWN
   * 334458afaa98b601eec12c490e71caa8274be055 UNKNOWN
   * 559816dcea4999dd46b09ee1091ddc0e1a5a7a54 UNKNOWN
   * 6cd76afe4990f56a5166e1592374aa8f86fe883f UNKNOWN
   * ac996f5c703560ecbe6cad7394cc8ad54d6f0029 UNKNOWN
   * 54a27acd416fbed48aa7876fda85036b90c641ab Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/159960514) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7369) 
   * 3242e942c07ec35f2532af7cd737af8bc1ce7749 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#issuecomment-603776093
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6621",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155064201",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155877268",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6755",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6839",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156597180",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6846",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156864478",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6873",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156994047",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157330632",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6900",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157451694",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6916",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157494634",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6933",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157589655",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6944",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6991",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157754467",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158102285",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7007",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7023",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158153241",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158188400",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7040",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7048",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158276096",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158831429",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7117",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7121",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158855200",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159112519",
       "triggerID" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7172",
       "triggerID" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159143719",
       "triggerID" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7175",
       "triggerID" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "triggerType" : "PUSH"
     }, {
       "hash" : "35ec088ef24e841beae78c33488975d2d8d0a40d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "35ec088ef24e841beae78c33488975d2d8d0a40d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7194",
       "triggerID" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159244661",
       "triggerID" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "triggerType" : "PUSH"
     }, {
       "hash" : "334458afaa98b601eec12c490e71caa8274be055",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "334458afaa98b601eec12c490e71caa8274be055",
       "triggerType" : "PUSH"
     }, {
       "hash" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7212",
       "triggerID" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "triggerType" : "PUSH"
     }, {
       "hash" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159269141",
       "triggerID" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7226",
       "triggerID" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159307415",
       "triggerID" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7297",
       "triggerID" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159652918",
       "triggerID" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "559816dcea4999dd46b09ee1091ddc0e1a5a7a54",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "559816dcea4999dd46b09ee1091ddc0e1a5a7a54",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6cd76afe4990f56a5166e1592374aa8f86fe883f",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "6cd76afe4990f56a5166e1592374aa8f86fe883f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7302",
       "triggerID" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159678447",
       "triggerID" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159695914",
       "triggerID" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7305",
       "triggerID" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ac996f5c703560ecbe6cad7394cc8ad54d6f0029",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "ac996f5c703560ecbe6cad7394cc8ad54d6f0029",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7347",
       "triggerID" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159875195",
       "triggerID" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "75c8130873e9b91e21e1e833d3d05f1ad9b5d2b8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7354",
       "triggerID" : "75c8130873e9b91e21e1e833d3d05f1ad9b5d2b8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7369",
       "triggerID" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "triggerType" : "PUSH"
     }, {
       "hash" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159960514",
       "triggerID" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7373",
       "triggerID" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159990549",
       "triggerID" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "triggerType" : "PUSH"
     }, {
       "hash" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7443",
       "triggerID" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160172375",
       "triggerID" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "536d9fb04a7a8142c04c94344dd0b3c0f2c10999",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160215439",
       "triggerID" : "536d9fb04a7a8142c04c94344dd0b3c0f2c10999",
       "triggerType" : "PUSH"
     }, {
       "hash" : "536d9fb04a7a8142c04c94344dd0b3c0f2c10999",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7469",
       "triggerID" : "536d9fb04a7a8142c04c94344dd0b3c0f2c10999",
       "triggerType" : "PUSH"
     }, {
       "hash" : "67018bacf5bc2daa8a03a1aafa880efc1db86808",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7500",
       "triggerID" : "67018bacf5bc2daa8a03a1aafa880efc1db86808",
       "triggerType" : "PUSH"
     }, {
       "hash" : "67018bacf5bc2daa8a03a1aafa880efc1db86808",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160347006",
       "triggerID" : "67018bacf5bc2daa8a03a1aafa880efc1db86808",
       "triggerType" : "PUSH"
     }, {
       "hash" : "79c116a6a1f5fe314f801e81f0265dea8b9ac1a7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7522",
       "triggerID" : "79c116a6a1f5fe314f801e81f0265dea8b9ac1a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "79c116a6a1f5fe314f801e81f0265dea8b9ac1a7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160377553",
       "triggerID" : "79c116a6a1f5fe314f801e81f0265dea8b9ac1a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "27ce4bfad8e99989dd64f8c636c934727da8a062",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "27ce4bfad8e99989dd64f8c636c934727da8a062",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ce0dfc7324679ebf2da84278eac8f5f59d748319",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7539",
       "triggerID" : "ce0dfc7324679ebf2da84278eac8f5f59d748319",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ce0dfc7324679ebf2da84278eac8f5f59d748319",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160418181",
       "triggerID" : "ce0dfc7324679ebf2da84278eac8f5f59d748319",
       "triggerType" : "PUSH"
     }, {
       "hash" : "05c934bf483d4fb673496783ef8ff85b40b86708",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "05c934bf483d4fb673496783ef8ff85b40b86708",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4bbe67a13a75f4491898fbb1cd2315237dbca30e",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160443829",
       "triggerID" : "4bbe67a13a75f4491898fbb1cd2315237dbca30e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4bbe67a13a75f4491898fbb1cd2315237dbca30e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7543",
       "triggerID" : "4bbe67a13a75f4491898fbb1cd2315237dbca30e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "cb5258f13c64ed033db7b8476122721ac418d798",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160496434",
       "triggerID" : "cb5258f13c64ed033db7b8476122721ac418d798",
       "triggerType" : "PUSH"
     }, {
       "hash" : "cb5258f13c64ed033db7b8476122721ac418d798",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7560",
       "triggerID" : "cb5258f13c64ed033db7b8476122721ac418d798",
       "triggerType" : "PUSH"
     }, {
       "hash" : "fdc673b8583650ce40a6f13b8a44d9773e14c370",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7597",
       "triggerID" : "fdc673b8583650ce40a6f13b8a44d9773e14c370",
       "triggerType" : "PUSH"
     }, {
       "hash" : "fdc673b8583650ce40a6f13b8a44d9773e14c370",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160543449",
       "triggerID" : "fdc673b8583650ce40a6f13b8a44d9773e14c370",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1123cc69ed817c9935bae5ffbba5e48f5bbe0f25",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7611",
       "triggerID" : "1123cc69ed817c9935bae5ffbba5e48f5bbe0f25",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1123cc69ed817c9935bae5ffbba5e48f5bbe0f25",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160619473",
       "triggerID" : "1123cc69ed817c9935bae5ffbba5e48f5bbe0f25",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dd5b4999b59b53950c2fb3784fc50ed97617f5aa",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "dd5b4999b59b53950c2fb3784fc50ed97617f5aa",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * dee2b337e5e72d8f7b1f5098b74f2958d000fb3c UNKNOWN
   * 80b7f76f24b5fb6704a4b2292543f8764ec19053 UNKNOWN
   * 35ec088ef24e841beae78c33488975d2d8d0a40d UNKNOWN
   * 334458afaa98b601eec12c490e71caa8274be055 UNKNOWN
   * 559816dcea4999dd46b09ee1091ddc0e1a5a7a54 UNKNOWN
   * 6cd76afe4990f56a5166e1592374aa8f86fe883f UNKNOWN
   * ac996f5c703560ecbe6cad7394cc8ad54d6f0029 UNKNOWN
   * 27ce4bfad8e99989dd64f8c636c934727da8a062 UNKNOWN
   * 05c934bf483d4fb673496783ef8ff85b40b86708 UNKNOWN
   * 1123cc69ed817c9935bae5ffbba5e48f5bbe0f25 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/160619473) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7611) 
   * dd5b4999b59b53950c2fb3784fc50ed97617f5aa UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r404581205
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/serialization/SpillingAdaptiveSpanningRecordDeserializer.java
 ##########
 @@ -557,6 +579,28 @@ private void addNextChunkFromMemorySegment(MemorySegment segment, int offset, in
 			}
 		}
 
+		@Nullable
+		MemorySegment copyToTargetSegment() {
+			// for the case of only partial length, no data
+			final int position = lengthBuffer.position();
+			if (position > 0) {
+				MemorySegment segment = MemorySegmentFactory.allocateUnpooledSegment(lengthBuffer.remaining());
+				segment.put(0, lengthBuffer, lengthBuffer.remaining());
+				lengthBuffer.position(position);
+				return segment;
+			}
+
+			// for the case of full length, partial data in buffer
+			if (recordLength != -1) {
+				// In the PoC we skip the case of large record which size exceeds THRESHOLD_FOR_SPILLING,
 
 Review comment:
   I had an idea, since Roman's `ChannelStateByteBuffer` is reading in chunks of 1024 bytes from the `Buffer(Builder)`, could we create a virtual buffer that spans over all parts?
   We could even try to evaluate if that is also a proper abstraction to be used instead of `SpillingAdaptiveSpanningRecordDeserializer` in some future PR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] rkhachatryan commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r398948746
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
 ##########
 @@ -514,20 +532,29 @@ public void onBuffer(Buffer buffer, int sequenceNumber, int backlog) throws IOEx
 
 		try {
 
-			final boolean wasEmpty;
-			synchronized (receivedBuffers) {
-				// Similar to notifyBufferAvailable(), make sure that we never add a buffer
-				// after releaseAllResources() released all buffers from receivedBuffers
-				// (see above for details).
-				if (isReleased.get()) {
-					return;
-				}
+			// Similar to notifyBufferAvailable(), make sure that we never add a buffer
+			// after releaseAllResources() released all buffers from receivedBuffers
+			// (see above for details).
+			if (isReleased.get()) {
+				return;
+			}
 
-				if (expectedSequenceNumber != sequenceNumber) {
-					onError(new BufferReorderingException(expectedSequenceNumber, sequenceNumber));
-					return;
+			if (expectedSequenceNumber != sequenceNumber) {
+				onError(new BufferReorderingException(expectedSequenceNumber, sequenceNumber));
+				return;
+			}
+
+			if (inputGate.bufferReceivedListener != null) {
+				CheckpointBarrier checkpointBarrier = parseCheckpointBarrier(buffer);
+				if (checkpointBarrier == null) {
+					inputGate.bufferReceivedListener.notifyBufferReceived(buffer, channelInfo);
+				} else {
+					inputGate.bufferReceivedListener.notifyBarrierReceived(checkpointBarrier, channelInfo);
 				}
+			}
 
+			final boolean wasEmpty;
+			synchronized (receivedBuffers) {
 
 Review comment:
   Do we miss a second check for `isReleased.get()` after `synchronized`?
   If between the 1st check and `synchronized` some other thread enters `releaseAllResources`, sets the flag and releases all the buffers; then we don't see it and continue; which I believe is an error.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zhijiangW commented on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
zhijiangW commented on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#issuecomment-609445924
 
 
   @AHeise I confirmed the related comments and resolved most of them. Except for the main concerns for handling local input channel and internal logics inside `CheckpointBarrierUnaligner`, I need more time to think though them, and might reply some comments later. :)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zhijiangW commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
zhijiangW commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r400828361
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/InputGate.java
 ##########
 @@ -107,6 +107,20 @@
 		return availabilityHelper.getAvailableFuture();
 	}
 
+	/**
+	 * Returns the index of this gate in respect to the consuming operator instance.
+	 */
+	public int getGateIndex() {
+		throw new UnsupportedOperationException();
+	}
+
+	/**
+	 * Returns the channel of this gate.
+	 */
+	public InputChannel getChannel(int channelIndex) {
 
 Review comment:
   ditto

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zhijiangW commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
zhijiangW commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r400820857
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/UnionInputGate.java
 ##########
 @@ -77,37 +77,34 @@
 	 */
 	private final LinkedHashSet<InputGate> inputGatesWithData = new LinkedHashSet<>();
 
-	/** The total number of input channels across all unioned input gates. */
-	private final int totalNumberOfInputChannels;
+	/** Input channels across all unioned input gates. */
+	private final InputChannel[] inputChannels;
 
 	/**
 	 * A mapping from input gate to (logical) channel index offset. Valid channel indexes go from 0
 	 * (inclusive) to the total number of input channels (exclusive).
 	 */
-	private final Map<InputGate, Integer> inputGateToIndexOffsetMap;
+	private final int[] inputGateChannelIndexOffsets;
 
 	public UnionInputGate(InputGate... inputGates) {
 		this.inputGates = checkNotNull(inputGates);
 		checkArgument(inputGates.length > 1, "Union input gate should union at least two input gates.");
 
-		this.inputGateToIndexOffsetMap = Maps.newHashMapWithExpectedSize(inputGates.length);
 		this.inputGatesWithRemainingData = Sets.newHashSetWithExpectedSize(inputGates.length);
 
+		final int maxGateIndex = Arrays.stream(inputGates).mapToInt(InputGate::getGateIndex).max().orElse(0);
+		inputGateChannelIndexOffsets = new int[maxGateIndex + 1];
 
 Review comment:
   why need length `maxGateIndex + 1`? `maxGateIndex` is enough?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#issuecomment-603776093
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6621",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155064201",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155877268",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6755",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6839",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156597180",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6846",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156864478",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6873",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156994047",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157330632",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6900",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157451694",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6916",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157494634",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6933",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157589655",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6944",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6991",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157754467",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158102285",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7007",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7023",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158153241",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158188400",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7040",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7048",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158276096",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158831429",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7117",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7121",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158855200",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159112519",
       "triggerID" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7172",
       "triggerID" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159143719",
       "triggerID" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7175",
       "triggerID" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "triggerType" : "PUSH"
     }, {
       "hash" : "35ec088ef24e841beae78c33488975d2d8d0a40d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "35ec088ef24e841beae78c33488975d2d8d0a40d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7194",
       "triggerID" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159244661",
       "triggerID" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "triggerType" : "PUSH"
     }, {
       "hash" : "334458afaa98b601eec12c490e71caa8274be055",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "334458afaa98b601eec12c490e71caa8274be055",
       "triggerType" : "PUSH"
     }, {
       "hash" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7212",
       "triggerID" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "triggerType" : "PUSH"
     }, {
       "hash" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159269141",
       "triggerID" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7226",
       "triggerID" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159307415",
       "triggerID" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7297",
       "triggerID" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159652918",
       "triggerID" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "559816dcea4999dd46b09ee1091ddc0e1a5a7a54",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "559816dcea4999dd46b09ee1091ddc0e1a5a7a54",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6cd76afe4990f56a5166e1592374aa8f86fe883f",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "6cd76afe4990f56a5166e1592374aa8f86fe883f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7302",
       "triggerID" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159678447",
       "triggerID" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159695914",
       "triggerID" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7305",
       "triggerID" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ac996f5c703560ecbe6cad7394cc8ad54d6f0029",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "ac996f5c703560ecbe6cad7394cc8ad54d6f0029",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7347",
       "triggerID" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159875195",
       "triggerID" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "75c8130873e9b91e21e1e833d3d05f1ad9b5d2b8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7354",
       "triggerID" : "75c8130873e9b91e21e1e833d3d05f1ad9b5d2b8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7369",
       "triggerID" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "triggerType" : "PUSH"
     }, {
       "hash" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159960514",
       "triggerID" : "54a27acd416fbed48aa7876fda85036b90c641ab",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7373",
       "triggerID" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159990549",
       "triggerID" : "3242e942c07ec35f2532af7cd737af8bc1ce7749",
       "triggerType" : "PUSH"
     }, {
       "hash" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7443",
       "triggerID" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160172375",
       "triggerID" : "11d69a1fed933cd4894f84e429d91e9b965d121b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "536d9fb04a7a8142c04c94344dd0b3c0f2c10999",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160215439",
       "triggerID" : "536d9fb04a7a8142c04c94344dd0b3c0f2c10999",
       "triggerType" : "PUSH"
     }, {
       "hash" : "536d9fb04a7a8142c04c94344dd0b3c0f2c10999",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7469",
       "triggerID" : "536d9fb04a7a8142c04c94344dd0b3c0f2c10999",
       "triggerType" : "PUSH"
     }, {
       "hash" : "67018bacf5bc2daa8a03a1aafa880efc1db86808",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7500",
       "triggerID" : "67018bacf5bc2daa8a03a1aafa880efc1db86808",
       "triggerType" : "PUSH"
     }, {
       "hash" : "67018bacf5bc2daa8a03a1aafa880efc1db86808",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160347006",
       "triggerID" : "67018bacf5bc2daa8a03a1aafa880efc1db86808",
       "triggerType" : "PUSH"
     }, {
       "hash" : "79c116a6a1f5fe314f801e81f0265dea8b9ac1a7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7522",
       "triggerID" : "79c116a6a1f5fe314f801e81f0265dea8b9ac1a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "79c116a6a1f5fe314f801e81f0265dea8b9ac1a7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160377553",
       "triggerID" : "79c116a6a1f5fe314f801e81f0265dea8b9ac1a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "27ce4bfad8e99989dd64f8c636c934727da8a062",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "27ce4bfad8e99989dd64f8c636c934727da8a062",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ce0dfc7324679ebf2da84278eac8f5f59d748319",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7539",
       "triggerID" : "ce0dfc7324679ebf2da84278eac8f5f59d748319",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ce0dfc7324679ebf2da84278eac8f5f59d748319",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160418181",
       "triggerID" : "ce0dfc7324679ebf2da84278eac8f5f59d748319",
       "triggerType" : "PUSH"
     }, {
       "hash" : "05c934bf483d4fb673496783ef8ff85b40b86708",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "05c934bf483d4fb673496783ef8ff85b40b86708",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4bbe67a13a75f4491898fbb1cd2315237dbca30e",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160443829",
       "triggerID" : "4bbe67a13a75f4491898fbb1cd2315237dbca30e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4bbe67a13a75f4491898fbb1cd2315237dbca30e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7543",
       "triggerID" : "4bbe67a13a75f4491898fbb1cd2315237dbca30e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "cb5258f13c64ed033db7b8476122721ac418d798",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160496434",
       "triggerID" : "cb5258f13c64ed033db7b8476122721ac418d798",
       "triggerType" : "PUSH"
     }, {
       "hash" : "cb5258f13c64ed033db7b8476122721ac418d798",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7560",
       "triggerID" : "cb5258f13c64ed033db7b8476122721ac418d798",
       "triggerType" : "PUSH"
     }, {
       "hash" : "fdc673b8583650ce40a6f13b8a44d9773e14c370",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7597",
       "triggerID" : "fdc673b8583650ce40a6f13b8a44d9773e14c370",
       "triggerType" : "PUSH"
     }, {
       "hash" : "fdc673b8583650ce40a6f13b8a44d9773e14c370",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160543449",
       "triggerID" : "fdc673b8583650ce40a6f13b8a44d9773e14c370",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1123cc69ed817c9935bae5ffbba5e48f5bbe0f25",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "1123cc69ed817c9935bae5ffbba5e48f5bbe0f25",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * dee2b337e5e72d8f7b1f5098b74f2958d000fb3c UNKNOWN
   * 80b7f76f24b5fb6704a4b2292543f8764ec19053 UNKNOWN
   * 35ec088ef24e841beae78c33488975d2d8d0a40d UNKNOWN
   * 334458afaa98b601eec12c490e71caa8274be055 UNKNOWN
   * 559816dcea4999dd46b09ee1091ddc0e1a5a7a54 UNKNOWN
   * 6cd76afe4990f56a5166e1592374aa8f86fe883f UNKNOWN
   * ac996f5c703560ecbe6cad7394cc8ad54d6f0029 UNKNOWN
   * 27ce4bfad8e99989dd64f8c636c934727da8a062 UNKNOWN
   * 05c934bf483d4fb673496783ef8ff85b40b86708 UNKNOWN
   * fdc673b8583650ce40a6f13b8a44d9773e14c370 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/160543449) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7597) 
   * 1123cc69ed817c9935bae5ffbba5e48f5bbe0f25 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#issuecomment-603776093
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6621",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155064201",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155877268",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6755",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6839",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156597180",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6846",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156864478",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6873",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156994047",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157330632",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6900",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157451694",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6916",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157494634",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6933",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157589655",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6944",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6991",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157754467",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158102285",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7007",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7023",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158153241",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158188400",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7040",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7048",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158276096",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158831429",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7117",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7121",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158855200",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159112519",
       "triggerID" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7172",
       "triggerID" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "status" : "CANCELED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159143719",
       "triggerID" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7175",
       "triggerID" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "triggerType" : "PUSH"
     }, {
       "hash" : "35ec088ef24e841beae78c33488975d2d8d0a40d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "35ec088ef24e841beae78c33488975d2d8d0a40d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * dee2b337e5e72d8f7b1f5098b74f2958d000fb3c UNKNOWN
   * 80b7f76f24b5fb6704a4b2292543f8764ec19053 UNKNOWN
   * 2c9926f618130a7d268ac2784fbb5e956e488088 Travis: [CANCELED](https://travis-ci.com/github/flink-ci/flink/builds/159143719) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7175) 
   * 35ec088ef24e841beae78c33488975d2d8d0a40d UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] rkhachatryan commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r406420587
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
 ##########
 @@ -542,6 +573,16 @@ public void onBuffer(Buffer buffer, int sequenceNumber, int backlog) throws IOEx
 			if (backlog >= 0) {
 				onSenderBacklog(backlog);
 			}
+
+			if (checkpointBarrier != null) {
+				receivedCheckpointId = checkpointBarrier.getId();
+			}
+			if (checkpointBarrier != null && inputGate.bufferReceivedListener != null) {
+				inputGate.bufferReceivedListener.notifyBarrierReceived(checkpointBarrier, channelInfo);
+			}
+			if (notifyReceivedBuffer != null && inputGate.bufferReceivedListener != null) {
 
 Review comment:
   I think if `notifyReceivedBuffer != null` but `bufferReceivedListener is null`
   then `notifyReceivedBuffer` should be recycled (or retained here, not before).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r405056341
 
 

 ##########
 File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/CheckpointBarrierUnaligner.java
 ##########
 @@ -0,0 +1,417 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.streaming.runtime.io;
+
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.runtime.checkpoint.CheckpointException;
+import org.apache.flink.runtime.checkpoint.CheckpointFailureReason;
+import org.apache.flink.runtime.checkpoint.channel.ChannelStateWriter;
+import org.apache.flink.runtime.checkpoint.channel.InputChannelInfo;
+import org.apache.flink.runtime.concurrent.FutureUtils;
+import org.apache.flink.runtime.io.network.api.CancelCheckpointMarker;
+import org.apache.flink.runtime.io.network.api.CheckpointBarrier;
+import org.apache.flink.runtime.io.network.buffer.Buffer;
+import org.apache.flink.runtime.io.network.buffer.BufferReceivedListener;
+import org.apache.flink.runtime.jobgraph.tasks.AbstractInvokable;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.Closeable;
+import java.io.IOException;
+import java.util.Arrays;
+import java.util.Optional;
+import java.util.concurrent.CompletableFuture;
+import java.util.function.Function;
+import java.util.stream.IntStream;
+
+import static org.apache.flink.util.Preconditions.checkNotNull;
+
+/**
+ * {@link CheckpointBarrierUnaligner} is used for triggering checkpoint while reading the first barrier
+ * and keeping track of the number of received barriers and consumed barriers.
+ */
+@Internal
+public class CheckpointBarrierUnaligner extends CheckpointBarrierHandler {
+
+	private static final Logger LOG = LoggerFactory.getLogger(CheckpointBarrierUnaligner.class);
+
+	private final String taskName;
+
+	/**
+	 * Tag the state of which input channel has read the barrier. If one channel has read the barrier by task,
+	 * the respective in-flight input buffers should be empty when triggering unaligned checkpoint.
+	 */
+	private final boolean[] barrierConsumedChannels;
+
+	private int numBarrierConsumed;
+
+	/**
+	 * Contains the offsets of the channel indices for each gate when flattening the channels of all gates.
+	 *
+	 * <p>For example, consider 3 gates with 4 channels, {@code gateChannelOffsets = [0, 4, 8]}.
+	 */
+	private final int[] gateChannelOffsets;
+
+	private final InputChannelInfo[] channelInfos;
+
+	/**
+	 * The checkpoint id to guarantee that we would trigger only one checkpoint when reading the same barrier from
+	 * different channels.
+	 *
+	 * <p>Note: this checkpoint is valid in respect to <b>consumed</b> barriers in contrast to
+	 * {@link ThreadSafeUnaligner#currentCheckpointId}.
+	 */
+	private long currentCheckpointId = -1L;
+
+	/** Encapsulates state that is shared between netty threads and task thread. */
+	private final ThreadSafeUnaligner threadSafeUnaligner;
+
+	CheckpointBarrierUnaligner(
+			int[] numberOfInputChannelsPerGate,
+			ChannelStateWriter channelStateWriter,
+			String taskName,
+			AbstractInvokable toNotifyOnCheckpoint) {
+		super(toNotifyOnCheckpoint);
+
+		this.taskName = taskName;
+
+		final int numGates = numberOfInputChannelsPerGate.length;
+
+		gateChannelOffsets = new int[numGates];
+		for (int index = 1; index < numGates; index++) {
+			gateChannelOffsets[index] = gateChannelOffsets[index - 1] + numberOfInputChannelsPerGate[index - 1];
+		}
+
+		final int totalNumChannels = gateChannelOffsets[numGates - 1] + numberOfInputChannelsPerGate[numGates - 1];
+		barrierConsumedChannels = new boolean[totalNumChannels];
+		Arrays.fill(barrierConsumedChannels, true);
+
+		channelInfos = IntStream.range(0, numGates)
+			.mapToObj(gateIndex -> IntStream.range(0, numberOfInputChannelsPerGate[gateIndex])
+				.mapToObj(channelIndex -> new InputChannelInfo(gateIndex, channelIndex)))
+			.flatMap(Function.identity())
+			.toArray(InputChannelInfo[]::new);
+
+		threadSafeUnaligner = new ThreadSafeUnaligner(totalNumChannels,	checkNotNull(channelStateWriter), this);
+	}
+
+	@Override
+	public void releaseBlocksAndResetBarriers() {
+		// make sure no additional data is persisted
+		Arrays.fill(barrierConsumedChannels, true);
+		// the next barrier that comes must assume it is the first
+		numBarrierConsumed = 0;
+		threadSafeUnaligner.releaseBlocksAndResetBarriers();
+	}
+
+	/**
+	 * For unaligned checkpoint, it never blocks processing from the task aspect.
+	 *
+	 * <p>For PoC, we do not consider the possibility that the unaligned checkpoint would
+	 * not perform due to the max configured unaligned checkpoint size.
+	 */
+	@Override
+	public boolean isBlocked(int channelIndex) {
+		return false;
+	}
+
+	/**
+	 * We still need to trigger checkpoint while reading the first barrier from one channel, because this might happen
+	 * earlier than the previous async trigger via mailbox by netty thread. And the {@link AbstractInvokable} has the
+	 * deduplication logic to guarantee trigger checkpoint only once finally.
+	 *
+	 * <p>Note this is also suitable for the trigger case of local input channel.
+	 */
+	@Override
+	public boolean processBarrier(
+			CheckpointBarrier receivedBarrier,
+			int channelIndex,
+			long bufferedBytes) throws IOException {
+		long barrierId = receivedBarrier.getId();
+		if (currentCheckpointId < barrierId) {
+			currentCheckpointId = barrierId;
+			numBarrierConsumed = 0;
+			Arrays.fill(barrierConsumedChannels, false);
+		}
+		if (currentCheckpointId == barrierId) {
+			barrierConsumedChannels[channelIndex] = true;
+			numBarrierConsumed++;
+		}
+		// processBarrier is called from task thread and can actually happen before notifyBarrierReceived on empty
+		// buffer queues
+		// to avoid replicating any logic, we simply call notifyBarrierReceived here as well
+		threadSafeUnaligner.notifyBarrierReceived(receivedBarrier, channelInfos[channelIndex]);
+		return false;
+	}
+
+	@Override
+	public boolean processCancellationBarrier(CancelCheckpointMarker cancelBarrier) throws Exception {
+		final long barrierId = cancelBarrier.getCheckpointId();
+
+		if (numBarrierConsumed > 0) {
+			// this is only true if some alignment is in progress and nothing was canceled
+
+			if (barrierId == currentCheckpointId) {
+				// cancel this alignment
+				if (LOG.isDebugEnabled()) {
+					LOG.debug("{}: Checkpoint {} canceled, aborting alignment.", taskName, barrierId);
+				}
+
+				releaseBlocksAndResetBarriers();
+				notifyAbortOnCancellationBarrier(barrierId);
+			}
+			else if (barrierId > currentCheckpointId) {
+				// we canceled the next which also cancels the current
+				LOG.warn("{}: Received cancellation barrier for checkpoint {} before completing current checkpoint {}. " +
+						"Skipping current checkpoint.",
+					taskName,
+					barrierId,
+					currentCheckpointId);
+
+				// this stops the current alignment
+				releaseBlocksAndResetBarriers();
+
+				// the next checkpoint starts as canceled
+				currentCheckpointId = barrierId;
+				threadSafeUnaligner.setCurrentCheckpointId(currentCheckpointId);
+				notifyAbortOnCancellationBarrier(barrierId);
+			}
+
+			// else: ignore trailing (cancellation) barrier from an earlier checkpoint (obsolete now)
+
+		}
+		else if (barrierId > currentCheckpointId) {
+			// first barrier of a new checkpoint is directly a cancellation
+
+			// by setting the currentCheckpointId to this checkpoint while keeping the numBarriers
+			// at zero means that no checkpoint barrier can start a new alignment
+			currentCheckpointId = barrierId;
+			threadSafeUnaligner.setCurrentCheckpointId(currentCheckpointId);
+
+			if (LOG.isDebugEnabled()) {
+				LOG.debug("{}: Checkpoint {} canceled, skipping alignment.", taskName, barrierId);
+			}
+
+			notifyAbortOnCancellationBarrier(barrierId);
+		}
+
+		// else: trailing barrier from either
+		//   - a previous (subsumed) checkpoint
+		//   - the current checkpoint if it was already canceled
+		return false;
+	}
+
+	@Override
+	public boolean processEndOfPartition() throws Exception {
+		threadSafeUnaligner.processEndOfPartition();
+
+		if (numBarrierConsumed > 0) {
+			// let the task know we skip a checkpoint
+			notifyAbort(
+				currentCheckpointId,
+				new CheckpointException(CheckpointFailureReason.CHECKPOINT_DECLINED_INPUT_END_OF_STREAM));
+			// no chance to complete this checkpoint
+			releaseBlocksAndResetBarriers();
+			return true;
+		}
+		return false;
+	}
+
+	@Override
+	public long getLatestCheckpointId() {
+		return currentCheckpointId;
+	}
+
+	@Override
+	public long getAlignmentDurationNanos() {
+		return 0;
+	}
+
+	@Override
+	public String toString() {
+		return String.format("%s: last checkpoint: %d", taskName, currentCheckpointId);
+	}
+
+	@Override
+	public void checkpointSizeLimitExceeded(long maxBufferedBytes) {
+	}
+
+	@Override
+	public void close() throws IOException {
+		super.close();
+		threadSafeUnaligner.close();
+	}
+
+	@Override
+	protected boolean isBarrierConsumed(long checkpointId, int channelIndex) {
+		if (checkpointId < currentCheckpointId) {
+			return true;
+		}
+		if (checkpointId > currentCheckpointId) {
+			return false;
+		}
+		return barrierConsumedChannels[channelIndex];
+	}
+
+	public CompletableFuture<Void> getAllBarriersReceivedFuture(long checkpointId) {
+		return threadSafeUnaligner.getAllBarriersReceivedFuture(checkpointId);
+	}
+
+	@Override
+	public Optional<BufferReceivedListener> getBufferReceivedListener() {
+		return Optional.of(threadSafeUnaligner);
+	}
+
+	private int getFlattenedChannelIndex(InputChannelInfo channelInfo) {
+		return gateChannelOffsets[channelInfo.getGateIdx()] + channelInfo.getInputChannelIdx();
+	}
+
+	private static class ThreadSafeUnaligner implements BufferReceivedListener, Closeable {
+
+		/**
+		 * Tag the state of which input channel has received the barrier. Until the barrier of a specific channel is
+		 * received, all new buffers need to be persisted after unaligned checkpointing has been started.
+		 */
+		private final boolean[] barrierReceivedChannels;
+
+		/**
+		 * The number of input channels which has read the barrier by task.
+		 */
+		private int numBarriersReceived;
+
+		/** A future indicating that all barriers of the a given checkpoint have been read. */
+		private CompletableFuture<Void> allBarriersReceivedFuture = FutureUtils.completedVoidFuture();
+
+		/**
+		 * The checkpoint id to guarantee that we would trigger only one checkpoint when reading the same barrier from
+		 * different channels.
+		 *
+		 * <p>Note: this checkpoint is valid in respect to <b>received</b> barriers in contrast to
+		 * {@link CheckpointBarrierUnaligner#currentCheckpointId}.
+		 */
+		private long currentCheckpointId = -1L;
+
+		/** The number of opened channels. */
+		private int numOpenChannels;
+
+		private final ChannelStateWriter channelStateWriter;
+
+		private final CheckpointBarrierUnaligner handler;
 
 Review comment:
   Like I said above: it's basically two sides of the same coin for me. Hence, I don't see an issue of the close coupling. If there was some value of `ThreadSafeUnaligner` on its own, I'd definitely go your proposed way.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#issuecomment-603776093
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6621",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155064201",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155877268",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6755",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6839",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156597180",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6846",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156864478",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6873",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156994047",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157330632",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6900",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157451694",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6916",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157494634",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6933",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157589655",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6944",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6991",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157754467",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158102285",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7007",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7023",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158153241",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158188400",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7040",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7048",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158276096",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158831429",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7117",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7121",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158855200",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159112519",
       "triggerID" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7172",
       "triggerID" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159143719",
       "triggerID" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7175",
       "triggerID" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "triggerType" : "PUSH"
     }, {
       "hash" : "35ec088ef24e841beae78c33488975d2d8d0a40d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "35ec088ef24e841beae78c33488975d2d8d0a40d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7194",
       "triggerID" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159244661",
       "triggerID" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "triggerType" : "PUSH"
     }, {
       "hash" : "334458afaa98b601eec12c490e71caa8274be055",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "334458afaa98b601eec12c490e71caa8274be055",
       "triggerType" : "PUSH"
     }, {
       "hash" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7212",
       "triggerID" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "triggerType" : "PUSH"
     }, {
       "hash" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159269141",
       "triggerID" : "17d1689c8376c55a8c5e41f78908d047b14f5631",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7226",
       "triggerID" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159307415",
       "triggerID" : "06eece5430689d2da418e0cea10eedae22c6fbb1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7297",
       "triggerID" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159652918",
       "triggerID" : "9e9d2c6d897a48e02ce6ecb4bdc5d54ac4e14fc7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "559816dcea4999dd46b09ee1091ddc0e1a5a7a54",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "559816dcea4999dd46b09ee1091ddc0e1a5a7a54",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6cd76afe4990f56a5166e1592374aa8f86fe883f",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "6cd76afe4990f56a5166e1592374aa8f86fe883f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7302",
       "triggerID" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159678447",
       "triggerID" : "71a489567e8b02abdf0ccc7ec56f85d93549eedb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "status" : "CANCELED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159695914",
       "triggerID" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7305",
       "triggerID" : "a7dd8d3321593ab8211487c0ad27eb299e876a8a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ac996f5c703560ecbe6cad7394cc8ad54d6f0029",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "ac996f5c703560ecbe6cad7394cc8ad54d6f0029",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * dee2b337e5e72d8f7b1f5098b74f2958d000fb3c UNKNOWN
   * 80b7f76f24b5fb6704a4b2292543f8764ec19053 UNKNOWN
   * 35ec088ef24e841beae78c33488975d2d8d0a40d UNKNOWN
   * 334458afaa98b601eec12c490e71caa8274be055 UNKNOWN
   * 559816dcea4999dd46b09ee1091ddc0e1a5a7a54 UNKNOWN
   * 6cd76afe4990f56a5166e1592374aa8f86fe883f UNKNOWN
   * a7dd8d3321593ab8211487c0ad27eb299e876a8a Travis: [CANCELED](https://travis-ci.com/github/flink-ci/flink/builds/159695914) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7305) 
   * ac996f5c703560ecbe6cad7394cc8ad54d6f0029 UNKNOWN
   * 2b3ee5c78f256e3e5954dce05b4f0e370a49e4d1 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] pnowojski commented on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
pnowojski commented on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#issuecomment-612878225
 
 
   `RecordDeserializer#getUnconsumedBuffer` is also not covered by tests, but I will add coverage as part of: https://issues.apache.org/jira/browse/FLINK-17051

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] rkhachatryan commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r407979727
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
 ##########
 @@ -513,8 +540,15 @@ public void onBuffer(Buffer buffer, int sequenceNumber, int backlog) throws IOEx
 		boolean recycleBuffer = true;
 
 		try {
+			if (expectedSequenceNumber != sequenceNumber) {
+				onError(new BufferReorderingException(expectedSequenceNumber, sequenceNumber));
+				return;
+			}
 
 			final boolean wasEmpty;
+			CheckpointBarrier notifyReceivedBarrier = null;
+			Buffer notifyReceivedBuffer = null;
+			final boolean hasListener = inputGate.bufferReceivedListener != null;
 
 Review comment:
   I'm concerned about thread-safety of `inputGate.bufferReceivedListener`.
   It's not `final` or `volatile` and can be updated by the other (task) thread.
   (this is also valid for the actual use of it below when notifying)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#issuecomment-603776093
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6621",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155064201",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155877268",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6755",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6839",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156597180",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6846",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156864478",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6873",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156994047",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157330632",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6900",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157451694",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6916",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157494634",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6933",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157589655",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6944",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6991",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "FAILURE",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157754467",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158102285",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7007",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * dee2b337e5e72d8f7b1f5098b74f2958d000fb3c UNKNOWN
   * 80b7f76f24b5fb6704a4b2292543f8764ec19053 UNKNOWN
   * e148bdc935791d691e3d09c6576c3e3fa04e2ac8 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/157754467) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6991) 
   * 77476642d8fe2f648f2079fc9e4b43c9506c2024 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/158102285) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7007) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#issuecomment-603776093
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6621",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155064201",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155877268",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6755",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6839",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "FAILURE",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156597180",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 2a84fd2fe1659cab80b711384febf50669561257 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/156597180) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6839) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#issuecomment-603776093
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6621",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155064201",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155877268",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6755",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6839",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156597180",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6846",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156864478",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6873",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156994047",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157330632",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6900",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157451694",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6916",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157494634",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6933",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157589655",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6944",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6991",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157754467",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158102285",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7007",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7023",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "FAILURE",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158153241",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * dee2b337e5e72d8f7b1f5098b74f2958d000fb3c UNKNOWN
   * 80b7f76f24b5fb6704a4b2292543f8764ec19053 UNKNOWN
   * 9b2544fc4e77e2fb607cb801f24d6fa970387517 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/158153241) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7023) 
   * 49d5d3e1e8e1bf962716241b79db1f2e28e506b4 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zhijiangW commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
zhijiangW commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r400292082
 
 

 ##########
 File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/StreamTwoInputProcessor.java
 ##########
 @@ -109,13 +111,13 @@ public StreamTwoInputProcessor(
 			checkpointedInputGates[0],
 			inputSerializer1,
 			ioManager,
-			new StatusWatermarkValve(checkpointedInputGates[0].getNumberOfInputChannels(), output1),
+			channelStateWriter, new StatusWatermarkValve(checkpointedInputGates[0].getNumberOfInputChannels(), output1),
 
 Review comment:
   nit: should be separate line for each argument

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#issuecomment-603776093
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6621",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155064201",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155877268",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6755",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6839",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156597180",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6846",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156864478",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6873",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156994047",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157330632",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6900",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157451694",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6916",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157494634",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6933",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157589655",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6944",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6991",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157754467",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "FAILURE",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158102285",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7007",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7023",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158153241",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * dee2b337e5e72d8f7b1f5098b74f2958d000fb3c UNKNOWN
   * 80b7f76f24b5fb6704a4b2292543f8764ec19053 UNKNOWN
   * 77476642d8fe2f648f2079fc9e4b43c9506c2024 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/158102285) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7007) 
   * 9b2544fc4e77e2fb607cb801f24d6fa970387517 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/158153241) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7023) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zhijiangW commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
zhijiangW commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r399043562
 
 

 ##########
 File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/CheckpointBarrierUnaligner.java
 ##########
 @@ -0,0 +1,242 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.streaming.runtime.io;
+
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.runtime.checkpoint.channel.ChannelStateWriter;
+import org.apache.flink.runtime.checkpoint.channel.InputChannelInfo;
+import org.apache.flink.runtime.io.network.api.CancelCheckpointMarker;
+import org.apache.flink.runtime.io.network.api.CheckpointBarrier;
+import org.apache.flink.runtime.io.network.buffer.Buffer;
+import org.apache.flink.runtime.jobgraph.tasks.AbstractInvokable;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import javax.annotation.Nullable;
+
+import java.util.Arrays;
+import java.util.concurrent.CompletableFuture;
+
+import static org.apache.flink.util.Preconditions.checkNotNull;
+
+/**
+ * {@link CheckpointBarrierUnaligner} is used for triggering checkpoint while reading the first barrier
+ * and keeping track of the number of received barriers and consumed barriers.
+ */
+@Internal
+public class CheckpointBarrierUnaligner extends CheckpointBarrierHandler {
 
 Review comment:
   I prefer a bit `CheckpointBarrierUnaligner` -> `UnalignedCheckpointBarrierHandler` :)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#issuecomment-603776093
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6621",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155064201",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155877268",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6755",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6839",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156597180",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6846",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156864478",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6873",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156994047",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157330632",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6900",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157451694",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6916",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157494634",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6933",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157589655",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6944",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6991",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157754467",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158102285",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7007",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7023",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158153241",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "FAILURE",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158188400",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7040",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * dee2b337e5e72d8f7b1f5098b74f2958d000fb3c UNKNOWN
   * 80b7f76f24b5fb6704a4b2292543f8764ec19053 UNKNOWN
   * 49d5d3e1e8e1bf962716241b79db1f2e28e506b4 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/158188400) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7040) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#issuecomment-603776093
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6621",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155064201",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155877268",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6755",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6839",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156597180",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6846",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156864478",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6873",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156994047",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157330632",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6900",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157451694",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6916",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157494634",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6933",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157589655",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6944",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6991",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157754467",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158102285",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7007",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7023",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158153241",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158188400",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7040",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7048",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158276096",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158831429",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7117",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7121",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158855200",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159112519",
       "triggerID" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7172",
       "triggerID" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "status" : "CANCELED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159143719",
       "triggerID" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7175",
       "triggerID" : "2c9926f618130a7d268ac2784fbb5e956e488088",
       "triggerType" : "PUSH"
     }, {
       "hash" : "35ec088ef24e841beae78c33488975d2d8d0a40d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "35ec088ef24e841beae78c33488975d2d8d0a40d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7194",
       "triggerID" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159244661",
       "triggerID" : "ee3ad987187409939aa7c211778ed88dd64f6479",
       "triggerType" : "PUSH"
     }, {
       "hash" : "334458afaa98b601eec12c490e71caa8274be055",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "334458afaa98b601eec12c490e71caa8274be055",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * dee2b337e5e72d8f7b1f5098b74f2958d000fb3c UNKNOWN
   * 80b7f76f24b5fb6704a4b2292543f8764ec19053 UNKNOWN
   * 2c9926f618130a7d268ac2784fbb5e956e488088 Travis: [CANCELED](https://travis-ci.com/github/flink-ci/flink/builds/159143719) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7175) 
   * 35ec088ef24e841beae78c33488975d2d8d0a40d UNKNOWN
   * ee3ad987187409939aa7c211778ed88dd64f6479 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/159244661) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7194) 
   * 334458afaa98b601eec12c490e71caa8274be055 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r406328788
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartition.java
 ##########
 @@ -83,24 +86,45 @@
 	/** The total number of bytes (both data and event buffers). */
 	private long totalNumberOfBytes;
 
+	/** The collection of buffers which are spanned over by checkpoint barrier and needs to be persisted for snapshot. */
+	private final List<Buffer> inflightBufferSnapshot = new ArrayList<>();
+
 	// ------------------------------------------------------------------------
 
 	PipelinedSubpartition(int index, ResultPartition parent) {
 		super(index, parent);
 	}
 
 	@Override
-	public boolean add(BufferConsumer bufferConsumer) {
-		return add(bufferConsumer, false);
+	public boolean add(BufferConsumer bufferConsumer) throws IOException {
+		return add(bufferConsumer, false, false);
 	}
 
 	@Override
 	public void finish() throws IOException {
-		add(EventSerializer.toBufferConsumer(EndOfPartitionEvent.INSTANCE), true);
+		add(EventSerializer.toBufferConsumer(EndOfPartitionEvent.INSTANCE), true, false);
 		LOG.debug("{}: Finished {}.", parent.getOwningTaskName(), this);
 	}
 
-	private boolean add(BufferConsumer bufferConsumer, boolean finish) {
+	@Override
+	public EnqueueAction priorityEvent(AbstractEvent event, BufferConsumer eventBufferConsumer) throws IOException {
+		if (readView != null) {
+			switch (readView.priorityEvent(event, eventBufferConsumer)) {
 
 Review comment:
   Merging `PriorityEventListener` into `BufferAvailabilityListener` also greatly helped to reduce commit size.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] pnowojski commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
pnowojski commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r405550326
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/writer/RecordWriter.java
 ##########
 @@ -153,13 +153,17 @@ protected boolean copyFromSerializerToTargetChannel(int targetChannel) throws IO
 		return pruneTriggered;
 	}
 
-	public void broadcastEvent(AbstractEvent event) throws IOException {
+	public void broadcastEvent(AbstractEvent event, boolean isPriorityEvent) throws IOException {
 		try (BufferConsumer eventBufferConsumer = EventSerializer.toBufferConsumer(event)) {
 			for (int targetChannel = 0; targetChannel < numberOfChannels; targetChannel++) {
 				tryFinishCurrentBufferBuilder(targetChannel);
 
-				// Retain the buffer so that it can be recycled by each channel of targetPartition
-				targetPartition.addBufferConsumer(eventBufferConsumer.copy(), targetChannel);
+				if (isPriorityEvent) {
+					targetPartition.addPriorityEvent(event, targetChannel, eventBufferConsumer);
 
 Review comment:
   > My main motivation was to avoid unnecessary (de)serialization. In certain cases (local input channel), you can directly pass the event.
   
   We can safely ignore those optimisations for local channels. Events are rare, that's one thing. Local channels are even more rare. And I agree that having both parameters is a bit confusing. The same applies to the difference how `bufferConsumer` is being copied.
   
   > In general, I think it's up to the consumer to copy a buffer or not. If it can immediately process the buffer, why copy and recycle at all?
   
   Maybe, I'm not sure. Less efficient but more unified approach vs more specialised one. As it is on the master, the contract is clear, callee has a full ownership of the `bufferConsumer`. Always. With your proposal, some branches/private methods would be behaving differently.
   
   Either way it should be consistent across all of the public methods, so for now I would be in favour of always copying and if you want, we could follow up on this on trying out if changing the contract makes sense/is worth it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zhijiangW commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
zhijiangW commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r400289287
 
 

 ##########
 File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/InputProcessorUtil.java
 ##########
 @@ -93,6 +97,12 @@ public static CheckpointedInputGate createCheckpointedInputGate(
 			toNotifyOnCheckpoint);
 		registerCheckpointMetrics(taskIOMetricGroup, barrierHandler);
 
+		if (config.isUnalignedCheckpointsEnabled()) {
 
 Review comment:
   Not sure for N-array input processor, it is not a big issue for me. It is up to your judgement.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] rkhachatryan commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r404995104
 
 

 ##########
 File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/CheckpointBarrierUnaligner.java
 ##########
 @@ -0,0 +1,420 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.streaming.runtime.io;
+
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.runtime.checkpoint.CheckpointException;
+import org.apache.flink.runtime.checkpoint.CheckpointFailureReason;
+import org.apache.flink.runtime.checkpoint.channel.ChannelStateWriter;
+import org.apache.flink.runtime.checkpoint.channel.InputChannelInfo;
+import org.apache.flink.runtime.concurrent.FutureUtils;
+import org.apache.flink.runtime.io.network.api.CancelCheckpointMarker;
+import org.apache.flink.runtime.io.network.api.CheckpointBarrier;
+import org.apache.flink.runtime.io.network.buffer.Buffer;
+import org.apache.flink.runtime.io.network.buffer.BufferReceivedListener;
+import org.apache.flink.runtime.jobgraph.tasks.AbstractInvokable;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.Closeable;
+import java.io.IOException;
+import java.util.Arrays;
+import java.util.Optional;
+import java.util.concurrent.CompletableFuture;
+import java.util.function.Function;
+import java.util.stream.IntStream;
+
+import static org.apache.flink.util.Preconditions.checkNotNull;
+
+/**
+ * {@link CheckpointBarrierUnaligner} is used for triggering checkpoint while reading the first barrier
+ * and keeping track of the number of received barriers and consumed barriers.
+ */
+@Internal
+public class CheckpointBarrierUnaligner extends CheckpointBarrierHandler {
+
+	private static final Logger LOG = LoggerFactory.getLogger(CheckpointBarrierUnaligner.class);
+
+	private final String taskName;
+
+	/**
+	 * Tag the state of which input channel has read the barrier. If one channel has read the barrier by task,
+	 * the respective in-flight input buffers should be empty when triggering unaligned checkpoint.
+	 */
+	private final boolean[] barrierConsumedChannels;
+
+	private int numBarrierConsumed;
+
+	/**
+	 * Contains the offsets of the channel indices for each gate when flattening the channels of all gates.
+	 *
+	 * <p>For example, consider 3 gates with 4 channels, {@code gateChannelOffsets = [0, 4, 8]}.
+	 */
+	private final int[] gateChannelOffsets;
+
+	private final InputChannelInfo[] channelInfos;
+
+	/**
+	 * The checkpoint id to guarantee that we would trigger only one checkpoint when reading the same barrier from
+	 * different channels.
+	 *
+	 * <p>Note: this checkpoint is valid in respect to <b>consumed</b> barriers in contrast to
+	 * {@link ThreadSafeUnaligner#currentCheckpointId}.
+	 */
+	private long currentCheckpointId = -1L;
+
+	/** Encapsulates state that is shared between netty threads and task thread. */
+	private final ThreadSafeUnaligner threadSafeUnaligner;
+
+	CheckpointBarrierUnaligner(
+			int[] numberOfInputChannelsPerGate,
+			ChannelStateWriter channelStateWriter,
+			String taskName,
+			AbstractInvokable toNotifyOnCheckpoint) {
+		super(toNotifyOnCheckpoint);
+
+		this.taskName = taskName;
+
+		final int numGates = numberOfInputChannelsPerGate.length;
+
+		gateChannelOffsets = new int[numGates];
+		for (int index = 1; index < numGates; index++) {
+			gateChannelOffsets[index] = gateChannelOffsets[index - 1] + numberOfInputChannelsPerGate[index - 1];
+		}
+
+		final int totalNumChannels = gateChannelOffsets[numGates - 1] + numberOfInputChannelsPerGate[numGates - 1];
+		barrierConsumedChannels = new boolean[totalNumChannels];
+		Arrays.fill(barrierConsumedChannels, true);
+
+		channelInfos = IntStream.range(0, numGates)
+			.mapToObj(gateIndex -> IntStream.range(0, numberOfInputChannelsPerGate[gateIndex])
+				.mapToObj(channelIndex -> new InputChannelInfo(gateIndex, channelIndex)))
+			.flatMap(Function.identity())
+			.toArray(InputChannelInfo[]::new);
+
+		threadSafeUnaligner = new ThreadSafeUnaligner(totalNumChannels,	checkNotNull(channelStateWriter), this);
+	}
+
+	@Override
+	public void releaseBlocksAndResetBarriers() {
+		// make sure no additional data is persisted
+		Arrays.fill(barrierConsumedChannels, true);
+		// the next barrier that comes must assume it is the first
+		numBarrierConsumed = 0;
+		threadSafeUnaligner.releaseBlocksAndResetBarriers();
+	}
+
+	/**
+	 * For unaligned checkpoint, it never blocks processing from the task aspect.
+	 *
+	 * <p>For PoC, we do not consider the possibility that the unaligned checkpoint would
+	 * not perform due to the max configured unaligned checkpoint size.
+	 */
+	@Override
+	public boolean isBlocked(int channelIndex) {
+		return false;
+	}
+
+	/**
+	 * We still need to trigger checkpoint while reading the first barrier from one channel, because this might happen
+	 * earlier than the previous async trigger via mailbox by netty thread. And the {@link AbstractInvokable} has the
+	 * deduplication logic to guarantee trigger checkpoint only once finally.
+	 *
+	 * <p>Note this is also suitable for the trigger case of local input channel.
+	 */
+	@Override
+	public boolean processBarrier(
+			CheckpointBarrier receivedBarrier,
+			int channelIndex,
+			long bufferedBytes) throws IOException {
+		long barrierId = receivedBarrier.getId();
+		if (currentCheckpointId < barrierId) {
+			currentCheckpointId = barrierId;
+			numBarrierConsumed = 0;
+			Arrays.fill(barrierConsumedChannels, false);
+		}
+		if (currentCheckpointId == barrierId) {
+			barrierConsumedChannels[channelIndex] = true;
+			numBarrierConsumed++;
+		}
+		// processBarrier is called from task thread and can actually happen before notifyBarrierReceived on empty
+		// buffer queues
+		// to avoid replicating any logic, we simply call notifyBarrierReceived here as well
+		threadSafeUnaligner.notifyBarrierReceived(receivedBarrier, channelInfos[channelIndex]);
+		return false;
+	}
+
+	@Override
+	public boolean processCancellationBarrier(CancelCheckpointMarker cancelBarrier) throws Exception {
+		final long barrierId = cancelBarrier.getCheckpointId();
+
+		if (numBarrierConsumed > 0) {
+			// this is only true if some alignment is in progress and nothing was canceled
+
+			if (barrierId == currentCheckpointId) {
+				// cancel this alignment
+				if (LOG.isDebugEnabled()) {
+					LOG.debug("{}: Checkpoint {} canceled, aborting alignment.", taskName, barrierId);
+				}
+
+				releaseBlocksAndResetBarriers();
+				notifyAbortOnCancellationBarrier(barrierId);
+			}
+			else if (barrierId > currentCheckpointId) {
+				// we canceled the next which also cancels the current
+				LOG.warn("{}: Received cancellation barrier for checkpoint {} before completing current checkpoint {}. " +
+						"Skipping current checkpoint.",
+					taskName,
+					barrierId,
+					currentCheckpointId);
+
+				// this stops the current alignment
+				releaseBlocksAndResetBarriers();
+
+				// the next checkpoint starts as canceled
+				currentCheckpointId = barrierId;
+				threadSafeUnaligner.setCurrentCheckpointId(currentCheckpointId);
+				notifyAbortOnCancellationBarrier(barrierId);
+			}
+
+			// else: ignore trailing (cancellation) barrier from an earlier checkpoint (obsolete now)
+
+		}
+		else if (barrierId > currentCheckpointId) {
+			// first barrier of a new checkpoint is directly a cancellation
+
+			// by setting the currentCheckpointId to this checkpoint while keeping the numBarriers
+			// at zero means that no checkpoint barrier can start a new alignment
 
 Review comment:
   This currently doesn't hold.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] rkhachatryan commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r406409278
 
 

 ##########
 File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/CheckpointBarrierUnaligner.java
 ##########
 @@ -0,0 +1,430 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.streaming.runtime.io;
+
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.runtime.checkpoint.CheckpointException;
+import org.apache.flink.runtime.checkpoint.CheckpointFailureReason;
+import org.apache.flink.runtime.checkpoint.channel.ChannelStateWriter;
+import org.apache.flink.runtime.checkpoint.channel.InputChannelInfo;
+import org.apache.flink.runtime.concurrent.FutureUtils;
+import org.apache.flink.runtime.io.network.api.CancelCheckpointMarker;
+import org.apache.flink.runtime.io.network.api.CheckpointBarrier;
+import org.apache.flink.runtime.io.network.buffer.Buffer;
+import org.apache.flink.runtime.io.network.buffer.BufferReceivedListener;
+import org.apache.flink.runtime.jobgraph.tasks.AbstractInvokable;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import javax.annotation.concurrent.NotThreadSafe;
+import javax.annotation.concurrent.ThreadSafe;
+
+import java.io.Closeable;
+import java.io.IOException;
+import java.util.Arrays;
+import java.util.Optional;
+import java.util.concurrent.CompletableFuture;
+import java.util.function.Function;
+import java.util.stream.IntStream;
+
+import static org.apache.flink.util.Preconditions.checkNotNull;
+
+/**
+ * {@link CheckpointBarrierUnaligner} is used for triggering checkpoint while reading the first barrier
+ * and keeping track of the number of received barriers and consumed barriers.
+ */
+@Internal
+@NotThreadSafe
+public class CheckpointBarrierUnaligner extends CheckpointBarrierHandler {
+
+	private static final Logger LOG = LoggerFactory.getLogger(CheckpointBarrierUnaligner.class);
+
+	private final String taskName;
+
+	/**
+	 * Tag the state of which input channel has pending in-flight buffers; that is, already received buffers that
+	 * predate the checkpoint barrier of the current checkpoint.
+	 */
+	private final boolean[] hasInflightBuffers;
+
+	private int numBarrierConsumed;
+
+	/**
+	 * Contains the offsets of the channel indices for each gate when flattening the channels of all gates.
+	 *
+	 * <p>For example, consider 3 gates with 4 channels, {@code gateChannelOffsets = [0, 4, 8]}.
+	 */
+	private final int[] gateChannelOffsets;
+
+	private final InputChannelInfo[] channelInfos;
+
+	/**
+	 * The checkpoint id to guarantee that we would trigger only one checkpoint when reading the same barrier from
+	 * different channels.
+	 *
+	 * <p>Note: this checkpoint is valid in respect to <b>consumed</b> barriers in contrast to
+	 * {@link ThreadSafeUnaligner#currentReceivedCheckpointId}.
+	 */
+	private long currentConsumedCheckpointId = -1L;
+
+	/** Encapsulates state that is shared between netty threads and task thread. */
+	private final ThreadSafeUnaligner threadSafeUnaligner;
+
+	CheckpointBarrierUnaligner(
+			int[] numberOfInputChannelsPerGate,
+			ChannelStateWriter channelStateWriter,
+			String taskName,
+			AbstractInvokable toNotifyOnCheckpoint) {
+		super(toNotifyOnCheckpoint);
+
+		this.taskName = taskName;
+
+		final int numGates = numberOfInputChannelsPerGate.length;
+
+		gateChannelOffsets = new int[numGates];
+		for (int index = 1; index < numGates; index++) {
+			gateChannelOffsets[index] = gateChannelOffsets[index - 1] + numberOfInputChannelsPerGate[index - 1];
+		}
+
+		final int totalNumChannels = gateChannelOffsets[numGates - 1] + numberOfInputChannelsPerGate[numGates - 1];
+		hasInflightBuffers = new boolean[totalNumChannels];
+
+		channelInfos = IntStream.range(0, numGates)
+			.mapToObj(gateIndex -> IntStream.range(0, numberOfInputChannelsPerGate[gateIndex])
+				.mapToObj(channelIndex -> new InputChannelInfo(gateIndex, channelIndex)))
+			.flatMap(Function.identity())
+			.toArray(InputChannelInfo[]::new);
+
+		threadSafeUnaligner = new ThreadSafeUnaligner(totalNumChannels,	checkNotNull(channelStateWriter), this);
+	}
+
+	@Override
+	public void releaseBlocksAndResetBarriers() {
+		// make sure no additional data is persisted
+		Arrays.fill(hasInflightBuffers, false);
+		threadSafeUnaligner.resetReceivedBarriers(currentConsumedCheckpointId);
+		// the next barrier that comes must assume it is the first
+		numBarrierConsumed = 0;
+	}
+
+	/**
+	 * For unaligned checkpoint, it never blocks processing from the task aspect.
+	 *
+	 * <p>For PoC, we do not consider the possibility that the unaligned checkpoint would
+	 * not perform due to the max configured unaligned checkpoint size.
+	 */
+	@Override
+	public boolean isBlocked(int channelIndex) {
+		return false;
+	}
+
+	/**
+	 * We still need to trigger checkpoint while reading the first barrier from one channel, because this might happen
+	 * earlier than the previous async trigger via mailbox by netty thread. And the {@link AbstractInvokable} has the
+	 * deduplication logic to guarantee trigger checkpoint only once finally.
+	 *
+	 * <p>Note this is also suitable for the trigger case of local input channel.
+	 */
+	@Override
+	public boolean processBarrier(
+			CheckpointBarrier receivedBarrier,
+			int channelIndex,
+			long bufferedBytes) {
+		long barrierId = receivedBarrier.getId();
+		if (currentConsumedCheckpointId < barrierId) {
+			currentConsumedCheckpointId = barrierId;
+			numBarrierConsumed = 0;
+			Arrays.fill(hasInflightBuffers, true);
+		}
+		if (currentConsumedCheckpointId == barrierId) {
+			hasInflightBuffers[channelIndex] = false;
+			numBarrierConsumed++;
+		}
+		// processBarrier is called from task thread and can actually happen before notifyBarrierReceived on empty
+		// buffer queues
+		// to avoid replicating any logic, we simply call notifyBarrierReceived here as well
+		threadSafeUnaligner.notifyBarrierReceived(receivedBarrier, channelInfos[channelIndex]);
+		return false;
+	}
+
+	@Override
+	public boolean processCancellationBarrier(CancelCheckpointMarker cancelBarrier) throws Exception {
+		final long barrierId = cancelBarrier.getCheckpointId();
+
+		if (numBarrierConsumed > 0) {
+			// this is only true if some alignment is in progress and nothing was canceled
+
+			if (barrierId == currentConsumedCheckpointId) {
+				// cancel this alignment
+				if (LOG.isDebugEnabled()) {
+					LOG.debug("{}: Checkpoint {} canceled, aborting alignment.", taskName, barrierId);
+				}
+
+				releaseBlocksAndResetBarriers();
+				notifyAbortOnCancellationBarrier(barrierId);
+			}
+			else if (barrierId > currentConsumedCheckpointId) {
+				// we canceled the next which also cancels the current
+				LOG.warn("{}: Received cancellation barrier for checkpoint {} before completing current checkpoint {}. " +
+						"Skipping current checkpoint.",
+					taskName,
+					barrierId,
+					currentConsumedCheckpointId);
+
+				// this stops the current alignment
+				releaseBlocksAndResetBarriers();
+
+				// the next checkpoint starts as canceled
+				currentConsumedCheckpointId = barrierId;
+				threadSafeUnaligner.setCurrentReceivedCheckpointId(currentConsumedCheckpointId);
 
 Review comment:
   Shouldn't we have this call also for the above branch (`barrierId == currentConsumedCheckpointId`)? 
   
   I'm starting to think that the idea of `ThreadSafeUnaligner` wasn't so great 🤔☺️

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zhijiangW commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
zhijiangW commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r400301277
 
 

 ##########
 File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
 ##########
 @@ -1096,14 +1134,18 @@ void handleAsyncException(String message, Throwable exception) {
 		private final AtomicReference<CheckpointingOperation.AsyncCheckpointState> asyncCheckpointState = new AtomicReference<>(
 			CheckpointingOperation.AsyncCheckpointState.RUNNING);
 
+		private final Future<?> bufferPersistingFuture;
 
 Review comment:
   `Future<?>` -> `Future<Collection<StateObject>>`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zhijiangW commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
zhijiangW commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r399080439
 
 

 ##########
 File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/CheckpointBarrierUnaligner.java
 ##########
 @@ -0,0 +1,213 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.streaming.runtime.io;
+
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.runtime.checkpoint.channel.InputChannelInfo;
+import org.apache.flink.runtime.io.network.api.CancelCheckpointMarker;
+import org.apache.flink.runtime.io.network.api.CheckpointBarrier;
+import org.apache.flink.runtime.io.network.buffer.Buffer;
+import org.apache.flink.runtime.jobgraph.tasks.AbstractInvokable;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import javax.annotation.Nullable;
+
+import java.util.Arrays;
+
+/**
+ * {@link CheckpointBarrierUnaligner} is used for triggering checkpoint while reading the first barrier
+ * and keeping track of the number of received barriers and consumed barriers.
+ */
+@Internal
+public class CheckpointBarrierUnaligner extends CheckpointBarrierHandler {
+
+	private static final Logger LOG = LoggerFactory.getLogger(CheckpointBarrierUnaligner.class);
+
+	private final String taskName;
+
+	/**
+	 * Tag the state of which input channel has read the barrier. If one channel has read the barrier by task,
+	 * the respective in-flight input buffers should be empty when triggering unaligned checkpoint.
+	 */
+	private final boolean[] barrierConsumedChannels;
+
+	/**
+	 * Tag the state of which input channel has received the barrier. Until the barrier of a specific channel is
+	 * received, all new buffers need to be persisted after unaligned checkpointing has been started.
+	 */
+	private final boolean[] barrierReceivedChannels;
+
+	/**
+	 * Contains the offsets of the channel indices for each gate when flattening the channels of all gates.
+	 *
+	 * <p>For example, consider 3 gates with 4 channels, {@code gateChannelOffsets = [0, 4, 8]}.
+	 */
+	private final int[] gateChannelOffsets;
+
+	/**
+	 * The number of input channels which has read the barrier by task.
+	 */
+	private int numBarriersReceived;
+
+	/**
+	 * The checkpoint id to guarantee that we would trigger only one checkpoint when reading the same barrier from
+	 * different channels.
+	 */
+	private long currentCheckpointId = -1L;
+
+	CheckpointBarrierUnaligner(
+			int[] numberOfInputChannelsPerGate,
+			String taskName,
+			@Nullable AbstractInvokable toNotifyOnCheckpoint) {
 
 Review comment:
   remove `@Nullable`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zhijiangW commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
zhijiangW commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r400257062
 
 

 ##########
 File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/CheckpointBarrierUnaligner.java
 ##########
 @@ -0,0 +1,338 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.streaming.runtime.io;
+
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.runtime.checkpoint.CheckpointException;
+import org.apache.flink.runtime.checkpoint.CheckpointFailureReason;
+import org.apache.flink.runtime.checkpoint.channel.ChannelStateWriter;
+import org.apache.flink.runtime.checkpoint.channel.InputChannelInfo;
+import org.apache.flink.runtime.io.network.api.CancelCheckpointMarker;
+import org.apache.flink.runtime.io.network.api.CheckpointBarrier;
+import org.apache.flink.runtime.io.network.buffer.Buffer;
+import org.apache.flink.runtime.jobgraph.tasks.AbstractInvokable;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.IOException;
+import java.util.Arrays;
+import java.util.concurrent.CompletableFuture;
+
+import static org.apache.flink.util.Preconditions.checkNotNull;
+
+/**
+ * {@link CheckpointBarrierUnaligner} is used for triggering checkpoint while reading the first barrier
+ * and keeping track of the number of received barriers and consumed barriers.
+ */
+@Internal
+public class CheckpointBarrierUnaligner extends CheckpointBarrierHandler {
+
+	private static final Logger LOG = LoggerFactory.getLogger(CheckpointBarrierUnaligner.class);
+	public static final CompletableFuture<Void> DONE = CompletableFuture.completedFuture(null);
+
+	private final String taskName;
+
+	/**
+	 * Tag the state of which input channel has read the barrier. If one channel has read the barrier by task,
+	 * the respective in-flight input buffers should be empty when triggering unaligned checkpoint.
+	 */
+	private final boolean[] barrierConsumedChannels;
+
+	/**
+	 * Tag the state of which input channel has received the barrier. Until the barrier of a specific channel is
+	 * received, all new buffers need to be persisted after unaligned checkpointing has been started.
+	 */
+	private final boolean[] barrierReceivedChannels;
+
+	/**
+	 * Contains the offsets of the channel indices for each gate when flattening the channels of all gates.
+	 *
+	 * <p>For example, consider 3 gates with 4 channels, {@code gateChannelOffsets = [0, 4, 8]}.
+	 */
+	private final int[] gateChannelOffsets;
+
+	/**
+	 * The number of input channels which has read the barrier by task.
+	 */
+	private int numBarriersReceived;
+
+	/**
+	 * The checkpoint id to guarantee that we would trigger only one checkpoint when reading the same barrier from
+	 * different channels.
+	 */
+	private long currentCheckpointId = -1L;
+
+	/** The number of opened channels. */
+	private int numOpenChannels;
+
+	/** A future indicating that all barriers of the a given checkpoint have been read. */
+	private CompletableFuture<Void> allBarriersReceivedFuture = DONE;
+
+	private final ChannelStateWriter channelStateWriter;
+
+	CheckpointBarrierUnaligner(
+			int[] numberOfInputChannelsPerGate,
+			ChannelStateWriter channelStateWriter,
+			String taskName,
+			AbstractInvokable toNotifyOnCheckpoint) {
+		super(toNotifyOnCheckpoint);
+
+		this.taskName = taskName;
+		this.channelStateWriter = checkNotNull(channelStateWriter);
+
+		final int numGates = numberOfInputChannelsPerGate.length;
+
+		gateChannelOffsets = new int[numGates];
+		for (int index = 1; index < numGates; index++) {
+			gateChannelOffsets[index] = gateChannelOffsets[index - 1] + numberOfInputChannelsPerGate[index - 1];
+		}
+
+		final int totalNumChannels = gateChannelOffsets[numGates - 1] + numberOfInputChannelsPerGate[numGates - 1];
+		barrierConsumedChannels = new boolean[totalNumChannels];
+		Arrays.fill(barrierConsumedChannels, true);
 
 Review comment:
   The default value should be false for `barrierConsumedChannels`, otherwise it seems inconsistent with the variable semantic. Only after task processing the barrier from respective channel, it should be set true.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zhijiangW commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
zhijiangW commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r400815721
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/UnionInputGate.java
 ##########
 @@ -77,37 +77,34 @@
 	 */
 	private final LinkedHashSet<InputGate> inputGatesWithData = new LinkedHashSet<>();
 
-	/** The total number of input channels across all unioned input gates. */
-	private final int totalNumberOfInputChannels;
+	/** Input channels across all unioned input gates. */
+	private final InputChannel[] inputChannels;
 
 	/**
 	 * A mapping from input gate to (logical) channel index offset. Valid channel indexes go from 0
 	 * (inclusive) to the total number of input channels (exclusive).
 	 */
-	private final Map<InputGate, Integer> inputGateToIndexOffsetMap;
+	private final int[] inputGateChannelIndexOffsets;
 
 	public UnionInputGate(InputGate... inputGates) {
 		this.inputGates = checkNotNull(inputGates);
 		checkArgument(inputGates.length > 1, "Union input gate should union at least two input gates.");
 
-		this.inputGateToIndexOffsetMap = Maps.newHashMapWithExpectedSize(inputGates.length);
 		this.inputGatesWithRemainingData = Sets.newHashSetWithExpectedSize(inputGates.length);
 
+		final int maxGateIndex = Arrays.stream(inputGates).mapToInt(InputGate::getGateIndex).max().orElse(0);
+		inputGateChannelIndexOffsets = new int[maxGateIndex + 1];
 		int currentNumberOfInputChannels = 0;
+		for (final InputGate inputGate : inputGates) {
+			currentNumberOfInputChannels += inputGate.getNumberOfInputChannels();
+			inputGateChannelIndexOffsets[inputGate.getGateIndex()] = currentNumberOfInputChannels;
+		}
+		inputChannels = Arrays.stream(inputGates)
+			.flatMap(gate -> IntStream.range(0, gate.getNumberOfInputChannels()).mapToObj(gate::getChannel))
+			.toArray(InputChannel[]::new);
 
 		synchronized (inputGatesWithData) {
 			for (InputGate inputGate : inputGates) {
-				if (inputGate instanceof UnionInputGate) {
-					// if we want to add support for this, we need to implement pollNext()
-					throw new UnsupportedOperationException("Cannot union a union of input gates.");
-				}
-
-				// The offset to use for buffer or event instances received from this input gate.
-				inputGateToIndexOffsetMap.put(checkNotNull(inputGate), currentNumberOfInputChannels);
-				inputGatesWithRemainingData.add(inputGate);
 
 Review comment:
   why remove this `inputGatesWithRemainingData.add(inputGate)`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r399265772
 
 

 ##########
 File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/CheckpointBarrierUnaligner.java
 ##########
 @@ -0,0 +1,242 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.streaming.runtime.io;
+
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.runtime.checkpoint.channel.ChannelStateWriter;
+import org.apache.flink.runtime.checkpoint.channel.InputChannelInfo;
+import org.apache.flink.runtime.io.network.api.CancelCheckpointMarker;
+import org.apache.flink.runtime.io.network.api.CheckpointBarrier;
+import org.apache.flink.runtime.io.network.buffer.Buffer;
+import org.apache.flink.runtime.jobgraph.tasks.AbstractInvokable;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import javax.annotation.Nullable;
+
+import java.util.Arrays;
+import java.util.concurrent.CompletableFuture;
+
+import static org.apache.flink.util.Preconditions.checkNotNull;
+
+/**
+ * {@link CheckpointBarrierUnaligner} is used for triggering checkpoint while reading the first barrier
+ * and keeping track of the number of received barriers and consumed barriers.
+ */
+@Internal
+public class CheckpointBarrierUnaligner extends CheckpointBarrierHandler {
+
+	private static final Logger LOG = LoggerFactory.getLogger(CheckpointBarrierUnaligner.class);
+
+	private final String taskName;
+
+	/**
+	 * Tag the state of which input channel has read the barrier. If one channel has read the barrier by task,
+	 * the respective in-flight input buffers should be empty when triggering unaligned checkpoint.
+	 */
+	private final boolean[] barrierConsumedChannels;
+
+	/**
+	 * Tag the state of which input channel has received the barrier. Until the barrier of a specific channel is
+	 * received, all new buffers need to be persisted after unaligned checkpointing has been started.
+	 */
+	private final boolean[] barrierReceivedChannels;
+
+	/**
+	 * Contains the offsets of the channel indices for each gate when flattening the channels of all gates.
+	 *
+	 * <p>For example, consider 3 gates with 4 channels, {@code gateChannelOffsets = [0, 4, 8]}.
+	 */
+	private final int[] gateChannelOffsets;
+
+	/**
+	 * The number of input channels which has read the barrier by task.
+	 */
+	private int numBarriersReceived;
+
+	/**
+	 * The checkpoint id to guarantee that we would trigger only one checkpoint when reading the same barrier from
+	 * different channels.
+	 */
+	private long currentCheckpointId = -1L;
+
+	private final ChannelStateWriter channelStateWriter;
+
+	private CompletableFuture<?> allBarriersReceivedFuture;
 
 Review comment:
   I'd argue that `<?>` captures that meaning even better. However, in flink-runtime there are only 150 places with `<?>` and 450 places with `<Void>`, so I will change it, so that we can hopefully converge.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] pnowojski commented on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
pnowojski commented on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#issuecomment-615084597
 
 
   Both test failures in azure are unrelated and exists on master. Will merge this soon.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r404301277
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/UnionInputGate.java
 ##########
 @@ -77,37 +77,34 @@
 	 */
 	private final LinkedHashSet<InputGate> inputGatesWithData = new LinkedHashSet<>();
 
-	/** The total number of input channels across all unioned input gates. */
-	private final int totalNumberOfInputChannels;
+	/** Input channels across all unioned input gates. */
+	private final InputChannel[] inputChannels;
 
 	/**
 	 * A mapping from input gate to (logical) channel index offset. Valid channel indexes go from 0
 	 * (inclusive) to the total number of input channels (exclusive).
 	 */
-	private final Map<InputGate, Integer> inputGateToIndexOffsetMap;
+	private final int[] inputGateChannelIndexOffsets;
 
 	public UnionInputGate(InputGate... inputGates) {
 		this.inputGates = checkNotNull(inputGates);
 		checkArgument(inputGates.length > 1, "Union input gate should union at least two input gates.");
 
-		this.inputGateToIndexOffsetMap = Maps.newHashMapWithExpectedSize(inputGates.length);
 		this.inputGatesWithRemainingData = Sets.newHashSetWithExpectedSize(inputGates.length);
 
+		final int maxGateIndex = Arrays.stream(inputGates).mapToInt(InputGate::getGateIndex).max().orElse(0);
 
 Review comment:
   Changed it even more with an extra commit that introduces `IndexedInputGate`. Only this `InputGate` has an `getIndex` and union gate can only be composed by these gates (turning the runtime into a compile time check).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#issuecomment-603776093
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6621",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155064201",
       "triggerID" : "46c39891af3d5ae037620c384f15d01b77419b1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/155877268",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6755",
       "triggerID" : "c45c6a352fc2f7760dcf942a75728d4d1f1777a7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6839",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2a84fd2fe1659cab80b711384febf50669561257",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156597180",
       "triggerID" : "2a84fd2fe1659cab80b711384febf50669561257",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6846",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a496a27a92e242519764b935012e44adade76a1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156864478",
       "triggerID" : "9a496a27a92e242519764b935012e44adade76a1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "dee2b337e5e72d8f7b1f5098b74f2958d000fb3c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "80b7f76f24b5fb6704a4b2292543f8764ec19053",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6873",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156994047",
       "triggerID" : "ed38c05c90208ed62c1c5bd2bc769cf8844356a0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157330632",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6900",
       "triggerID" : "f18687d568167f3d70715fc67762564bb9757ee6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157451694",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d5d714a4d954b82862972864805a151d04c3a513",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6916",
       "triggerID" : "d5d714a4d954b82862972864805a151d04c3a513",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157494634",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6933",
       "triggerID" : "734812c326634e1fd0da63465dcfbffa53cff792",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157589655",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6944",
       "triggerID" : "707cb2dc5af184ebd495d7381d8e4e944436b936",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6991",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157754467",
       "triggerID" : "e148bdc935791d691e3d09c6576c3e3fa04e2ac8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158102285",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7007",
       "triggerID" : "77476642d8fe2f648f2079fc9e4b43c9506c2024",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7023",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158153241",
       "triggerID" : "9b2544fc4e77e2fb607cb801f24d6fa970387517",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158188400",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7040",
       "triggerID" : "49d5d3e1e8e1bf962716241b79db1f2e28e506b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7048",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158276096",
       "triggerID" : "a8335f0def293f04fd74bfc47c1b31fc98a46a23",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158831429",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7117",
       "triggerID" : "a3eed025c7faad5d680ab09e83d8af2819f0048b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7121",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "status" : "FAILURE",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158855200",
       "triggerID" : "a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "f1c7ddec67cf96365c63ff93d1ed4353b478eba4",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * dee2b337e5e72d8f7b1f5098b74f2958d000fb3c UNKNOWN
   * 80b7f76f24b5fb6704a4b2292543f8764ec19053 UNKNOWN
   * a4c3929d5dd9053cdd23b9f8a935c4a8d68889aa Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/158855200) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7121) 
   * f1c7ddec67cf96365c63ff93d1ed4353b478eba4 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r399238657
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
 ##########
 @@ -206,6 +210,20 @@ void retriggerSubpartitionRequest(int subpartitionIndex) throws IOException {
 		return Optional.of(new BufferAndAvailability(next, moreAvailable, getSenderBacklog()));
 	}
 
+	@Override
+	public List<Buffer> getInflightBuffers(long checkpointId) throws IOException {
+		final ArrayList<Buffer> inflightBuffers = new ArrayList<>(receivedBuffers.size());
 
 Review comment:
   We can move construction inside the synchronized block. 
   
   I don't see how `size` could be negative as that would violate the collection contract. `size` is also just a hint and does not need to be exact.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zhijiangW commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
zhijiangW commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r400632538
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/serialization/SpillingAdaptiveSpanningRecordDeserializer.java
 ##########
 @@ -557,6 +579,28 @@ private void addNextChunkFromMemorySegment(MemorySegment segment, int offset, in
 			}
 		}
 
+		@Nullable
+		MemorySegment copyToTargetSegment() {
+			// for the case of only partial length, no data
+			final int position = lengthBuffer.position();
+			if (position > 0) {
+				MemorySegment segment = MemorySegmentFactory.allocateUnpooledSegment(lengthBuffer.remaining());
+				segment.put(0, lengthBuffer, lengthBuffer.remaining());
+				lengthBuffer.position(position);
+				return segment;
+			}
+
+			// for the case of full length, partial data in buffer
+			if (recordLength != -1) {
+				// In the PoC we skip the case of large record which size exceeds THRESHOLD_FOR_SPILLING,
 
 Review comment:
   I guess we also need to consider this case in MVP.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] rkhachatryan commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r406409278
 
 

 ##########
 File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/CheckpointBarrierUnaligner.java
 ##########
 @@ -0,0 +1,430 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.streaming.runtime.io;
+
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.runtime.checkpoint.CheckpointException;
+import org.apache.flink.runtime.checkpoint.CheckpointFailureReason;
+import org.apache.flink.runtime.checkpoint.channel.ChannelStateWriter;
+import org.apache.flink.runtime.checkpoint.channel.InputChannelInfo;
+import org.apache.flink.runtime.concurrent.FutureUtils;
+import org.apache.flink.runtime.io.network.api.CancelCheckpointMarker;
+import org.apache.flink.runtime.io.network.api.CheckpointBarrier;
+import org.apache.flink.runtime.io.network.buffer.Buffer;
+import org.apache.flink.runtime.io.network.buffer.BufferReceivedListener;
+import org.apache.flink.runtime.jobgraph.tasks.AbstractInvokable;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import javax.annotation.concurrent.NotThreadSafe;
+import javax.annotation.concurrent.ThreadSafe;
+
+import java.io.Closeable;
+import java.io.IOException;
+import java.util.Arrays;
+import java.util.Optional;
+import java.util.concurrent.CompletableFuture;
+import java.util.function.Function;
+import java.util.stream.IntStream;
+
+import static org.apache.flink.util.Preconditions.checkNotNull;
+
+/**
+ * {@link CheckpointBarrierUnaligner} is used for triggering checkpoint while reading the first barrier
+ * and keeping track of the number of received barriers and consumed barriers.
+ */
+@Internal
+@NotThreadSafe
+public class CheckpointBarrierUnaligner extends CheckpointBarrierHandler {
+
+	private static final Logger LOG = LoggerFactory.getLogger(CheckpointBarrierUnaligner.class);
+
+	private final String taskName;
+
+	/**
+	 * Tag the state of which input channel has pending in-flight buffers; that is, already received buffers that
+	 * predate the checkpoint barrier of the current checkpoint.
+	 */
+	private final boolean[] hasInflightBuffers;
+
+	private int numBarrierConsumed;
+
+	/**
+	 * Contains the offsets of the channel indices for each gate when flattening the channels of all gates.
+	 *
+	 * <p>For example, consider 3 gates with 4 channels, {@code gateChannelOffsets = [0, 4, 8]}.
+	 */
+	private final int[] gateChannelOffsets;
+
+	private final InputChannelInfo[] channelInfos;
+
+	/**
+	 * The checkpoint id to guarantee that we would trigger only one checkpoint when reading the same barrier from
+	 * different channels.
+	 *
+	 * <p>Note: this checkpoint is valid in respect to <b>consumed</b> barriers in contrast to
+	 * {@link ThreadSafeUnaligner#currentReceivedCheckpointId}.
+	 */
+	private long currentConsumedCheckpointId = -1L;
+
+	/** Encapsulates state that is shared between netty threads and task thread. */
+	private final ThreadSafeUnaligner threadSafeUnaligner;
+
+	CheckpointBarrierUnaligner(
+			int[] numberOfInputChannelsPerGate,
+			ChannelStateWriter channelStateWriter,
+			String taskName,
+			AbstractInvokable toNotifyOnCheckpoint) {
+		super(toNotifyOnCheckpoint);
+
+		this.taskName = taskName;
+
+		final int numGates = numberOfInputChannelsPerGate.length;
+
+		gateChannelOffsets = new int[numGates];
+		for (int index = 1; index < numGates; index++) {
+			gateChannelOffsets[index] = gateChannelOffsets[index - 1] + numberOfInputChannelsPerGate[index - 1];
+		}
+
+		final int totalNumChannels = gateChannelOffsets[numGates - 1] + numberOfInputChannelsPerGate[numGates - 1];
+		hasInflightBuffers = new boolean[totalNumChannels];
+
+		channelInfos = IntStream.range(0, numGates)
+			.mapToObj(gateIndex -> IntStream.range(0, numberOfInputChannelsPerGate[gateIndex])
+				.mapToObj(channelIndex -> new InputChannelInfo(gateIndex, channelIndex)))
+			.flatMap(Function.identity())
+			.toArray(InputChannelInfo[]::new);
+
+		threadSafeUnaligner = new ThreadSafeUnaligner(totalNumChannels,	checkNotNull(channelStateWriter), this);
+	}
+
+	@Override
+	public void releaseBlocksAndResetBarriers() {
+		// make sure no additional data is persisted
+		Arrays.fill(hasInflightBuffers, false);
+		threadSafeUnaligner.resetReceivedBarriers(currentConsumedCheckpointId);
+		// the next barrier that comes must assume it is the first
+		numBarrierConsumed = 0;
+	}
+
+	/**
+	 * For unaligned checkpoint, it never blocks processing from the task aspect.
+	 *
+	 * <p>For PoC, we do not consider the possibility that the unaligned checkpoint would
+	 * not perform due to the max configured unaligned checkpoint size.
+	 */
+	@Override
+	public boolean isBlocked(int channelIndex) {
+		return false;
+	}
+
+	/**
+	 * We still need to trigger checkpoint while reading the first barrier from one channel, because this might happen
+	 * earlier than the previous async trigger via mailbox by netty thread. And the {@link AbstractInvokable} has the
+	 * deduplication logic to guarantee trigger checkpoint only once finally.
+	 *
+	 * <p>Note this is also suitable for the trigger case of local input channel.
+	 */
+	@Override
+	public boolean processBarrier(
+			CheckpointBarrier receivedBarrier,
+			int channelIndex,
+			long bufferedBytes) {
+		long barrierId = receivedBarrier.getId();
+		if (currentConsumedCheckpointId < barrierId) {
+			currentConsumedCheckpointId = barrierId;
+			numBarrierConsumed = 0;
+			Arrays.fill(hasInflightBuffers, true);
+		}
+		if (currentConsumedCheckpointId == barrierId) {
+			hasInflightBuffers[channelIndex] = false;
+			numBarrierConsumed++;
+		}
+		// processBarrier is called from task thread and can actually happen before notifyBarrierReceived on empty
+		// buffer queues
+		// to avoid replicating any logic, we simply call notifyBarrierReceived here as well
+		threadSafeUnaligner.notifyBarrierReceived(receivedBarrier, channelInfos[channelIndex]);
+		return false;
+	}
+
+	@Override
+	public boolean processCancellationBarrier(CancelCheckpointMarker cancelBarrier) throws Exception {
+		final long barrierId = cancelBarrier.getCheckpointId();
+
+		if (numBarrierConsumed > 0) {
+			// this is only true if some alignment is in progress and nothing was canceled
+
+			if (barrierId == currentConsumedCheckpointId) {
+				// cancel this alignment
+				if (LOG.isDebugEnabled()) {
+					LOG.debug("{}: Checkpoint {} canceled, aborting alignment.", taskName, barrierId);
+				}
+
+				releaseBlocksAndResetBarriers();
+				notifyAbortOnCancellationBarrier(barrierId);
+			}
+			else if (barrierId > currentConsumedCheckpointId) {
+				// we canceled the next which also cancels the current
+				LOG.warn("{}: Received cancellation barrier for checkpoint {} before completing current checkpoint {}. " +
+						"Skipping current checkpoint.",
+					taskName,
+					barrierId,
+					currentConsumedCheckpointId);
+
+				// this stops the current alignment
+				releaseBlocksAndResetBarriers();
+
+				// the next checkpoint starts as canceled
+				currentConsumedCheckpointId = barrierId;
+				threadSafeUnaligner.setCurrentReceivedCheckpointId(currentConsumedCheckpointId);
 
 Review comment:
   Shouldn't we have this call also for the above branch (`barrierId == currentConsumedCheckpointId`)? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zhijiangW commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint

Posted by GitBox <gi...@apache.org>.
zhijiangW commented on a change in pull request #11507: [FLINK-16587] Add basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r400806571
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/UnionInputGate.java
 ##########
 @@ -77,37 +77,34 @@
 	 */
 	private final LinkedHashSet<InputGate> inputGatesWithData = new LinkedHashSet<>();
 
-	/** The total number of input channels across all unioned input gates. */
-	private final int totalNumberOfInputChannels;
+	/** Input channels across all unioned input gates. */
+	private final InputChannel[] inputChannels;
 
 	/**
 	 * A mapping from input gate to (logical) channel index offset. Valid channel indexes go from 0
 
 Review comment:
   nit: should also adjust the javadoc after changing the data structure

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services