You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by "IOhacker (via GitHub)" <gi...@apache.org> on 2023/01/25 01:30:20 UTC

[GitHub] [fineract] IOhacker opened a new pull request, #2919: FINERACT-1866 Avoid StackOverflow Exception because an Infinite Lookup of WorkingDay

IOhacker opened a new pull request, #2919:
URL: https://github.com/apache/fineract/pull/2919

   …p of WorkingDay
   
   ## Description
   
   Avoid StackOverflow Exception because an Infinite Lookup of WorkingDay using the Tenant Time Zone instead of System Time Zone.
   
   Ignore if these details are present on the associated [Apache Fineract JIRA ticket](https://github.com/apache/fineract/pull/1284).
   
   
   ## Checklist
   
   Please make sure these boxes are checked before submitting your pull request - thanks!
   
   - [X] Write the commit message as per https://github.com/apache/fineract/#pull-requests
   
   - [X] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
   
   - [X] Create/update unit or integration tests for verifying the changes made.
   
   - [X] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
   
   - [X] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
   
   - [X] Submission is not a "code dump".  (Large changes can be made "in repository" via a branch.  Ask on the developer mailing list for guidance, if required.)
   
   FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] IOhacker closed pull request #2919: FINERACT-1866 Avoid StackOverflow Exception because an Infinite Lookup of WorkingDay

Posted by "IOhacker (via GitHub)" <gi...@apache.org>.
IOhacker closed pull request #2919: FINERACT-1866 Avoid StackOverflow Exception because an Infinite Lookup of WorkingDay
URL: https://github.com/apache/fineract/pull/2919


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] IOhacker commented on pull request #2919: FINERACT-1866 Avoid StackOverflow Exception because an Infinite Lookup of WorkingDay

Posted by "IOhacker (via GitHub)" <gi...@apache.org>.
IOhacker commented on PR #2919:
URL: https://github.com/apache/fineract/pull/2919#issuecomment-1403726423

   @adamsaghy taking a look. I will send another PR.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] adamsaghy commented on pull request #2919: FINERACT-1866 Avoid StackOverflow Exception because an Infinite Lookup of WorkingDay

Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on PR #2919:
URL: https://github.com/apache/fineract/pull/2919#issuecomment-1403260094

   Please squash the commits and please take a look on the https://issues.apache.org/jira/browse/FINERACT-1394 which explicitly changed the zone from tenant timezone to system timezone. 
   @avikganguly01 FYI


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org