You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@guacamole.apache.org by chrisgavin <gi...@git.apache.org> on 2017/05/07 11:03:45 UTC

[GitHub] incubator-guacamole-client pull request #155: Fix an incorrect comparison wi...

GitHub user chrisgavin opened a pull request:

    https://github.com/apache/incubator-guacamole-client/pull/155

    Fix an incorrect comparison with NaN.

    I spotted this check of a number against `NaN` that don't seem to be correct. In JavaScript `NaN` is not equal to anything, not even itself. I've fixed this check to use the built in `isNaN` function instead which should correctly check if the variable is `NaN`.
    
    ---
    
    I found this issue through [lgtm.com](https://lgtm.com/projects/g/apache/incubator-guacamole-client/alerts/), a service that analyzes open-source code to look for potential problems. (Full disclosure: I work for the company that operates it.)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/chrisgavin/incubator-guacamole-client nan

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-guacamole-client/pull/155.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #155
    
----
commit 031a3a22e3602dfb29987ddd7edd87ff24847bc9
Author: Chris Gavin <ch...@chrisgavin.me>
Date:   2017-05-07T10:04:12Z

    Fix an incorrect comparison with NaN.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-guacamole-client pull request #155: GUACAMOLE-295: Fix an incorrec...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-guacamole-client/pull/155


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---