You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Prasad Mujumdar <pr...@cloudera.com> on 2014/05/15 01:54:42 UTC
Review Request 21470: SENTRY-200: Remove sentry-provider dependencies on hive
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21470/
-----------------------------------------------------------
Review request for sentry, Lenni Kuff and Sravya Tirukkovalur.
Bugs: SENTRY-200
https://issues.apache.org/jira/browse/SENTRY-200
Repository: sentry
Description
-------
Remove hive metastore dependency from db-provider.
- removed unused hive imports
- removed maven dependency on metastore which was due to those unused imports
- update comments in schema tool code
Diffs
-----
sentry-provider/sentry-provider-db/pom.xml f272fb6
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStoreSchemaInfo.java 22f1b08
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/tools/SentrySchemaTool.java 124c17e
Diff: https://reviews.apache.org/r/21470/diff/
Testing
-------
TestSentrySchemaTool pass with the changes.
Thanks,
Prasad Mujumdar
Re: Review Request 21470: SENTRY-200: Remove sentry-provider dependencies on
hive
Posted by Sravya Tirukkovalur <sr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21470/#review43105
-----------------------------------------------------------
Ship it!
Ship It!
- Sravya Tirukkovalur
On May 14, 2014, 11:54 p.m., Prasad Mujumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21470/
> -----------------------------------------------------------
>
> (Updated May 14, 2014, 11:54 p.m.)
>
>
> Review request for sentry, Lenni Kuff and Sravya Tirukkovalur.
>
>
> Bugs: SENTRY-200
> https://issues.apache.org/jira/browse/SENTRY-200
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Remove hive metastore dependency from db-provider.
> - removed unused hive imports
> - removed maven dependency on metastore which was due to those unused imports
> - update comments in schema tool code
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/pom.xml f272fb6
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStoreSchemaInfo.java 22f1b08
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/tools/SentrySchemaTool.java 124c17e
>
> Diff: https://reviews.apache.org/r/21470/diff/
>
>
> Testing
> -------
>
> TestSentrySchemaTool pass with the changes.
>
>
> Thanks,
>
> Prasad Mujumdar
>
>
Re: Review Request 21470: SENTRY-200: Remove sentry-provider dependencies on
hive
Posted by Lenni Kuff <ls...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21470/#review43211
-----------------------------------------------------------
Ship it!
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/tools/SentrySchemaTool.java
<https://reviews.apache.org/r/21470/#comment77291>
update comment (this doesn't throw a MetaException) here and elsewhere.
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/tools/SentrySchemaTool.java
<https://reviews.apache.org/r/21470/#comment77290>
rename "getConnectionToMetastore"?
- Lenni Kuff
On May 14, 2014, 11:54 p.m., Prasad Mujumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21470/
> -----------------------------------------------------------
>
> (Updated May 14, 2014, 11:54 p.m.)
>
>
> Review request for sentry, Lenni Kuff and Sravya Tirukkovalur.
>
>
> Bugs: SENTRY-200
> https://issues.apache.org/jira/browse/SENTRY-200
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Remove hive metastore dependency from db-provider.
> - removed unused hive imports
> - removed maven dependency on metastore which was due to those unused imports
> - update comments in schema tool code
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/pom.xml f272fb6
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStoreSchemaInfo.java 22f1b08
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/tools/SentrySchemaTool.java 124c17e
>
> Diff: https://reviews.apache.org/r/21470/diff/
>
>
> Testing
> -------
>
> TestSentrySchemaTool pass with the changes.
>
>
> Thanks,
>
> Prasad Mujumdar
>
>