You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by "Fernando (JIRA)" <ji...@apache.org> on 2008/12/09 20:57:44 UTC

[jira] Created: (TAP5-406) turn off some eclipse "errors"

turn off some eclipse "errors"
------------------------------

                 Key: TAP5-406
                 URL: https://issues.apache.org/jira/browse/TAP5-406
             Project: Tapestry 5
          Issue Type: Improvement
          Components: tapestry-core
    Affects Versions: 5.1
            Reporter: Fernando


just a very small patch to turn off invalid errors from eclipse..

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


[jira] Commented: (TAP5-406) turn off some eclipse "errors"

Posted by "Andreas Andreou (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TAP5-406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12654996#action_12654996 ] 

Andreas Andreou commented on TAP5-406:
--------------------------------------

Why not fix those the other way around, i.e. by adding @Override where it's missing, or removing the unnecessary casts, e.t.c.

Unless you're saying that eclipse reports false positives.

> turn off some eclipse "errors"
> ------------------------------
>
>                 Key: TAP5-406
>                 URL: https://issues.apache.org/jira/browse/TAP5-406
>             Project: Tapestry 5
>          Issue Type: Improvement
>          Components: tapestry-core
>    Affects Versions: 5.1
>            Reporter: Fernando
>         Attachments: less-errors.diff
>
>
> just a very small patch to turn off invalid errors from eclipse..

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


[jira] Commented: (TAP5-406) Change included Eclipse configure to configure certain "errors" (that do occur in the code) as warnings

Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TAP5-406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12659866#action_12659866 ] 

Howard M. Lewis Ship commented on TAP5-406:
-------------------------------------------

I think Andreas is right about IDE specific files, though I'm not sure why they get marked as dirty for others; I thought I only checked in the ones that should be the same across users and workspaces (i.e., no absolute file names).  I may be wrong, because it looks like IDEA plugs can get in and change the files as well, so unless all developers are using the exact same set of plugins, some of the files may be corrupted.

> Change included Eclipse configure to configure certain "errors" (that do occur in the code) as warnings
> -------------------------------------------------------------------------------------------------------
>
>                 Key: TAP5-406
>                 URL: https://issues.apache.org/jira/browse/TAP5-406
>             Project: Tapestry 5
>          Issue Type: Improvement
>          Components: tapestry-core
>    Affects Versions: 5.1
>            Reporter: Fernando
>            Assignee: Howard M. Lewis Ship
>            Priority: Trivial
>             Fix For: 5.1.0.0
>
>         Attachments: less-errors.diff
>
>
> just a very small patch to turn off invalid errors from eclipse..

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


[jira] Closed: (TAP5-406) Change included Eclipse configure to configure certain "errors" (that do occur in the code) as warnings

Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TAP5-406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Howard M. Lewis Ship closed TAP5-406.
-------------------------------------

       Resolution: Fixed
    Fix Version/s: 5.1.0.0

> Change included Eclipse configure to configure certain "errors" (that do occur in the code) as warnings
> -------------------------------------------------------------------------------------------------------
>
>                 Key: TAP5-406
>                 URL: https://issues.apache.org/jira/browse/TAP5-406
>             Project: Tapestry 5
>          Issue Type: Improvement
>          Components: tapestry-core
>    Affects Versions: 5.1
>            Reporter: Fernando
>            Assignee: Howard M. Lewis Ship
>            Priority: Trivial
>             Fix For: 5.1.0.0
>
>         Attachments: less-errors.diff
>
>
> just a very small patch to turn off invalid errors from eclipse..

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


[jira] Assigned: (TAP5-406) turn off some eclipse "errors"

Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TAP5-406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Howard M. Lewis Ship reassigned TAP5-406:
-----------------------------------------

    Assignee: Howard M. Lewis Ship

> turn off some eclipse "errors"
> ------------------------------
>
>                 Key: TAP5-406
>                 URL: https://issues.apache.org/jira/browse/TAP5-406
>             Project: Tapestry 5
>          Issue Type: Improvement
>          Components: tapestry-core
>    Affects Versions: 5.1
>            Reporter: Fernando
>            Assignee: Howard M. Lewis Ship
>         Attachments: less-errors.diff
>
>
> just a very small patch to turn off invalid errors from eclipse..

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


[jira] Commented: (TAP5-406) turn off some eclipse "errors"

Posted by "Fernando (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TAP5-406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12655003#action_12655003 ] 

Fernando commented on TAP5-406:
-------------------------------

a long time ago Howard put turned up the warnings on eclipse to be errors.  But since then, Howard has moved off of eclipse, and noone is maintaining the code.  So without turning down these warnings, eclipse has lots of "errors".

And truly, these are not real errors, simply us being anal.  When we don't have to be.  Unless Howard can turn on the same "errors" on IntelliJ and be able to actively maintain them, they should be turned off. period. no use in maintaining different code standards for those using eclipse, versus Howard using IntelliJ.

> turn off some eclipse "errors"
> ------------------------------
>
>                 Key: TAP5-406
>                 URL: https://issues.apache.org/jira/browse/TAP5-406
>             Project: Tapestry 5
>          Issue Type: Improvement
>          Components: tapestry-core
>    Affects Versions: 5.1
>            Reporter: Fernando
>         Attachments: less-errors.diff
>
>
> just a very small patch to turn off invalid errors from eclipse..

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


[jira] Updated: (TAP5-406) Change included Eclipse configure to configure certain "errors" (that do occur in the code) as warnings

Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TAP5-406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Howard M. Lewis Ship updated TAP5-406:
--------------------------------------

    Priority: Trivial  (was: Major)
     Summary: Change included Eclipse configure to configure certain "errors" (that do occur in the code) as warnings  (was: turn off some eclipse "errors")

> Change included Eclipse configure to configure certain "errors" (that do occur in the code) as warnings
> -------------------------------------------------------------------------------------------------------
>
>                 Key: TAP5-406
>                 URL: https://issues.apache.org/jira/browse/TAP5-406
>             Project: Tapestry 5
>          Issue Type: Improvement
>          Components: tapestry-core
>    Affects Versions: 5.1
>            Reporter: Fernando
>            Assignee: Howard M. Lewis Ship
>            Priority: Trivial
>             Fix For: 5.1.0.0
>
>         Attachments: less-errors.diff
>
>
> just a very small patch to turn off invalid errors from eclipse..

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


[jira] Commented: (TAP5-406) turn off some eclipse "errors"

Posted by "Andreas Andreou (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TAP5-406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12655013#action_12655013 ] 

Andreas Andreou commented on TAP5-406:
--------------------------------------

Actually, i'd vote for removing ide specific files - there's the pom and at least 3 ways to work from that in each major IDE.

Also, I use idea and even howard's idea specific files are a bit annoying (=marked as dirty by svn)



> turn off some eclipse "errors"
> ------------------------------
>
>                 Key: TAP5-406
>                 URL: https://issues.apache.org/jira/browse/TAP5-406
>             Project: Tapestry 5
>          Issue Type: Improvement
>          Components: tapestry-core
>    Affects Versions: 5.1
>            Reporter: Fernando
>         Attachments: less-errors.diff
>
>
> just a very small patch to turn off invalid errors from eclipse..

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


[jira] Updated: (TAP5-406) turn off some eclipse "errors"

Posted by "Fernando (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TAP5-406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Fernando updated TAP5-406:
--------------------------

    Attachment: less-errors.diff

> turn off some eclipse "errors"
> ------------------------------
>
>                 Key: TAP5-406
>                 URL: https://issues.apache.org/jira/browse/TAP5-406
>             Project: Tapestry 5
>          Issue Type: Improvement
>          Components: tapestry-core
>    Affects Versions: 5.1
>            Reporter: Fernando
>         Attachments: less-errors.diff
>
>
> just a very small patch to turn off invalid errors from eclipse..

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


[jira] Commented: (TAP5-406) Change included Eclipse configure to configure certain "errors" (that do occur in the code) as warnings

Posted by "Andreas Andreou (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TAP5-406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12659890#action_12659890 ] 

Andreas Andreou commented on TAP5-406:
--------------------------------------

Howard, for the record, i prefer opening projects from the pom.xml - it basically allows 
me to open only a specific subproject i want to work on, e.t.c.

This however overwrites the subproject's *.iml file and that's why it's locally dirty.



> Change included Eclipse configure to configure certain "errors" (that do occur in the code) as warnings
> -------------------------------------------------------------------------------------------------------
>
>                 Key: TAP5-406
>                 URL: https://issues.apache.org/jira/browse/TAP5-406
>             Project: Tapestry 5
>          Issue Type: Improvement
>          Components: tapestry-core
>    Affects Versions: 5.1
>            Reporter: Fernando
>            Assignee: Howard M. Lewis Ship
>            Priority: Trivial
>             Fix For: 5.1.0.0
>
>         Attachments: less-errors.diff
>
>
> just a very small patch to turn off invalid errors from eclipse..

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


[jira] Commented: (TAP5-406) turn off some eclipse "errors"

Posted by "Fernando (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TAP5-406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12655018#action_12655018 ] 

Fernando commented on TAP5-406:
-------------------------------

well, for now, how about someone commit this little tiny inzy binzy patch file, to make us eclipse users happy.  we can discuss the bigger ideas later :)

though I might see you point, I like that projects have predefined eclipse files, for various reasons.. no need to manually keep the classpath in sync is one, and making sure that all users have the same formatter, etc etc..

in the .settings files we don't have to setup the compiler warnings at all, and just leave them as default too.. but we use it in our company to setup the default formatter, which is key to make sure we're all formatting the code the same way.

> turn off some eclipse "errors"
> ------------------------------
>
>                 Key: TAP5-406
>                 URL: https://issues.apache.org/jira/browse/TAP5-406
>             Project: Tapestry 5
>          Issue Type: Improvement
>          Components: tapestry-core
>    Affects Versions: 5.1
>            Reporter: Fernando
>         Attachments: less-errors.diff
>
>
> just a very small patch to turn off invalid errors from eclipse..

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org