You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by kr...@apache.org on 2019/03/29 20:06:56 UTC
[incubator-superset] branch master updated: chore: add main pull
request template (#7176)
This is an automated email from the ASF dual-hosted git repository.
kristw pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git
The following commit(s) were added to refs/heads/master by this push:
new ceb86df chore: add main pull request template (#7176)
ceb86df is described below
commit ceb86df063aaabc71f7aff6005c5d65202757b97
Author: michellethomas <mi...@gmail.com>
AuthorDate: Fri Mar 29 13:06:45 2019 -0700
chore: add main pull request template (#7176)
* Add main pull request template
* Removing individual pull request templates
---
.../feature.md => PULL_REQUEST_TEMPLATE.md | 5 +--
PULL_REQUEST_TEMPLATE/bugs.md | 40 ----------------------
PULL_REQUEST_TEMPLATE/documentation.md | 23 -------------
PULL_REQUEST_TEMPLATE/refactor.md | 37 --------------------
PULL_REQUEST_TEMPLATE/test.md | 28 ---------------
5 files changed, 3 insertions(+), 130 deletions(-)
diff --git a/PULL_REQUEST_TEMPLATE/feature.md b/PULL_REQUEST_TEMPLATE.md
similarity index 95%
rename from PULL_REQUEST_TEMPLATE/feature.md
rename to PULL_REQUEST_TEMPLATE.md
index ab1f88a..012fb23 100644
--- a/PULL_REQUEST_TEMPLATE/feature.md
+++ b/PULL_REQUEST_TEMPLATE.md
@@ -25,8 +25,6 @@ under the License.
##### TEST PLAN
<!--- What steps were taken to verify -->
-<!--- What tests were added to verify this feature -->
-
##### ADDITIONAL INFORMATION
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
<!--- Check any relevant boxes with "x" -->
@@ -35,6 +33,9 @@ under the License.
[ ] Requires DB Migration. Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API
+ [ ] Fixes bug
+ [ ] Refactors code
+ [ ] Adds test(s)
##### REVIEWERS
diff --git a/PULL_REQUEST_TEMPLATE/bugs.md b/PULL_REQUEST_TEMPLATE/bugs.md
deleted file mode 100644
index 7f75952..0000000
--- a/PULL_REQUEST_TEMPLATE/bugs.md
+++ /dev/null
@@ -1,40 +0,0 @@
-<!--
-Licensed to the Apache Software Foundation (ASF) under one
-or more contributor license agreements. See the NOTICE file
-distributed with this work for additional information
-regarding copyright ownership. The ASF licenses this file
-to you under the Apache License, Version 2.0 (the
-"License"); you may not use this file except in compliance
-with the License. You may obtain a copy of the License at
-
- http://www.apache.org/licenses/LICENSE-2.0
-
-Unless required by applicable law or agreed to in writing,
-software distributed under the License is distributed on an
-"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-KIND, either express or implied. See the License for the
-specific language governing permissions and limitations
-under the License.
--->
-##### SUMMARY
-<!--- Describe the change below, including rationale and design decisions -->
-
-##### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
-<!--- Skip this if not applicable -->
-
-##### TEST PLAN
-<!--- What steps were taken to verify -->
-
-<!--- What tests were added to catch this bug in the future -->
-
-##### ADDITIONAL INFORMATION
-<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
-<!--- Check any relevant boxes with "x" -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration. Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
-
-##### REVIEWERS
-
diff --git a/PULL_REQUEST_TEMPLATE/documentation.md b/PULL_REQUEST_TEMPLATE/documentation.md
deleted file mode 100644
index e226840..0000000
--- a/PULL_REQUEST_TEMPLATE/documentation.md
+++ /dev/null
@@ -1,23 +0,0 @@
-<!--
-Licensed to the Apache Software Foundation (ASF) under one
-or more contributor license agreements. See the NOTICE file
-distributed with this work for additional information
-regarding copyright ownership. The ASF licenses this file
-to you under the Apache License, Version 2.0 (the
-"License"); you may not use this file except in compliance
-with the License. You may obtain a copy of the License at
-
- http://www.apache.org/licenses/LICENSE-2.0
-
-Unless required by applicable law or agreed to in writing,
-software distributed under the License is distributed on an
-"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-KIND, either express or implied. See the License for the
-specific language governing permissions and limitations
-under the License.
--->
-##### SUMMARY
-<!--- Describe the change below, including rationale and design decisions -->
-
-##### REVIEWERS
-
diff --git a/PULL_REQUEST_TEMPLATE/refactor.md b/PULL_REQUEST_TEMPLATE/refactor.md
deleted file mode 100644
index 01b197b..0000000
--- a/PULL_REQUEST_TEMPLATE/refactor.md
+++ /dev/null
@@ -1,37 +0,0 @@
-<!--
-Licensed to the Apache Software Foundation (ASF) under one
-or more contributor license agreements. See the NOTICE file
-distributed with this work for additional information
-regarding copyright ownership. The ASF licenses this file
-to you under the Apache License, Version 2.0 (the
-"License"); you may not use this file except in compliance
-with the License. You may obtain a copy of the License at
-
- http://www.apache.org/licenses/LICENSE-2.0
-
-Unless required by applicable law or agreed to in writing,
-software distributed under the License is distributed on an
-"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-KIND, either express or implied. See the License for the
-specific language governing permissions and limitations
-under the License.
--->
-
-##### SUMMARY
-<!--- Describe the change below, including rationale and design decisions -->
-
-##### TEST PLAN
-<!--- What steps were taken to verify features impacted by refactor -->
-
-<!--- What tests were added to confirm this refactor won't cause regressions -->
-
-##### ADDITIONAL INFORMATION
-<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
-<!--- Check any relevant boxes with "x" -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration. Confirm DB Migration upgrade and downgrade tested.
- [ ] Removes existing feature or API
-
-##### REVIEWERS
-
diff --git a/PULL_REQUEST_TEMPLATE/test.md b/PULL_REQUEST_TEMPLATE/test.md
deleted file mode 100644
index c830537..0000000
--- a/PULL_REQUEST_TEMPLATE/test.md
+++ /dev/null
@@ -1,28 +0,0 @@
-<!--
-Licensed to the Apache Software Foundation (ASF) under one
-or more contributor license agreements. See the NOTICE file
-distributed with this work for additional information
-regarding copyright ownership. The ASF licenses this file
-to you under the Apache License, Version 2.0 (the
-"License"); you may not use this file except in compliance
-with the License. You may obtain a copy of the License at
-
- http://www.apache.org/licenses/LICENSE-2.0
-
-Unless required by applicable law or agreed to in writing,
-software distributed under the License is distributed on an
-"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-KIND, either express or implied. See the License for the
-specific language governing permissions and limitations
-under the License.
--->
-##### SUMMARY
-<!--- Describe the change below, including rationale -->
-
-##### ADDITIONAL INFORMATION
-<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
-<!--- Check box with "x" if relevant -->
- [ ] Has associated issue:
-
-##### REVIEWERS
-