You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by Jacek Laskowski <ja...@laskowski.net.pl> on 2006/11/02 00:17:52 UTC
Re: svn commit: r470013 - /geronimo/server/trunk/modules/geronimo-system/src/test/java/org/apache/geronimo/system/properties/NamingPropertiesTest.java
On 11/1/06, rickmcguire@apache.org <ri...@apache.org> wrote:
> Author: rickmcguire
> Date: Wed Nov 1 09:48:44 2006
> New Revision: 470013
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=470013
> Log:
> GERONIMO-1840 NamingPropertiesTest is not compatible with non-Sun VMs.
...
> + try {
> + // the above assumes we're running on a Sun JVM. If we can't load the class first,
> + // we'll skip the attempt at creating the InitialContext. We've already verified that the
> + // system properties have been set to the correct values, so this last bit is largely a formality.
> + Class.forName("NAME_FACTORY_INITIAL");
> + new InitialContext();
> + } catch (ClassNotFoundException e) {
> + }
It's not the first time I ask for some help understanding a change and
this one is not an exception.
Why do we look up the "NAME_FACTORY_INITIAL" class since it's deemed
to fail every time?
Jacek
--
Jacek Laskowski
http://www.jaceklaskowski.pl
Re: svn commit: r470013 - /geronimo/server/trunk/modules/geronimo-system/src/test/java/org/apache/geronimo/system/properties/NamingPropertiesTest.java
Posted by David Jencks <da...@yahoo.com>.
Since we now have our own class for this, can't we make the test vm
independent?
<attribute
name="namingFactoryInitial">org.apache.xbean.naming.global.GlobalContext
Manager</attribute>
from rmi-naming.
thanks
david jencks
On Nov 1, 2006, at 9:49 PM, Vamsavardhana Reddy wrote:
> There is a private static final String NAMING_FACTORY_INITIAL =
> "com.sun.jndi.rmi.registry.RegistryContextFactory" in the class.
> should it be
>
> Should it be Class.forName(NAMING_FACTORY_INITIAL) ?
>
> --vamsi
>
> On 11/2/06, Jacek Laskowski <ja...@laskowski.net.pl> wrote:
> On 11/1/06, rickmcguire@apache.org <ri...@apache.org> wrote:
> > Author: rickmcguire
> > Date: Wed Nov 1 09:48:44 2006
> > New Revision: 470013
> >
> > URL: http://svn.apache.org/viewvc?view=rev&rev=470013
> > Log:
> > GERONIMO-1840 NamingPropertiesTest is not compatible with non-Sun
> VMs.
> ...
> > + try {
> > + // the above assumes we're running on a Sun JVM. If
> we can't load the class first,
> > + // we'll skip the attempt at creating the
> InitialContext. We've already verified that the
> > + // system properties have been set to the correct
> values, so this last bit is largely a formality.
> > + Class.forName("NAME_FACTORY_INITIAL");
> > + new InitialContext();
> > + } catch (ClassNotFoundException e) {
> > + }
>
> It's not the first time I ask for some help understanding a change and
> this one is not an exception.
>
> Why do we look up the "NAME_FACTORY_INITIAL" class since it's deemed
> to fail every time?
>
> Jacek
>
> --
> Jacek Laskowski
> http://www.jaceklaskowski.pl
>
Re: svn commit: r470013 - /geronimo/server/trunk/modules/geronimo-system/src/test/java/org/apache/geronimo/system/properties/NamingPropertiesTest.java
Posted by Vamsavardhana Reddy <c1...@gmail.com>.
There is a private static final String NAMING_FACTORY_INITIAL = "
com.sun.jndi.rmi.registry.RegistryContextFactory" in the class. should it
be
Should it be Class.forName(NAMING_FACTORY_INITIAL) ?
--vamsi
On 11/2/06, Jacek Laskowski <ja...@laskowski.net.pl> wrote:
>
> On 11/1/06, rickmcguire@apache.org <ri...@apache.org> wrote:
> > Author: rickmcguire
> > Date: Wed Nov 1 09:48:44 2006
> > New Revision: 470013
> >
> > URL: http://svn.apache.org/viewvc?view=rev&rev=470013
> > Log:
> > GERONIMO-1840 NamingPropertiesTest is not compatible with non-Sun VMs.
> ...
> > + try {
> > + // the above assumes we're running on a Sun JVM. If we
> can't load the class first,
> > + // we'll skip the attempt at creating the
> InitialContext. We've already verified that the
> > + // system properties have been set to the correct values,
> so this last bit is largely a formality.
> > + Class.forName("NAME_FACTORY_INITIAL");
> > + new InitialContext();
> > + } catch (ClassNotFoundException e) {
> > + }
>
> It's not the first time I ask for some help understanding a change and
> this one is not an exception.
>
> Why do we look up the "NAME_FACTORY_INITIAL" class since it's deemed
> to fail every time?
>
> Jacek
>
> --
> Jacek Laskowski
> http://www.jaceklaskowski.pl
>
Re: svn commit: r470013 - /geronimo/server/trunk/modules/geronimo-system/src/test/java/org/apache/geronimo/system/properties/NamingPropertiesTest.java
Posted by Jason Dillon <ja...@planet57.com>.
Ya, this looks bogus...
--jason
On Nov 1, 2006, at 3:17 PM, Jacek Laskowski wrote:
> On 11/1/06, rickmcguire@apache.org <ri...@apache.org> wrote:
>> Author: rickmcguire
>> Date: Wed Nov 1 09:48:44 2006
>> New Revision: 470013
>>
>> URL: http://svn.apache.org/viewvc?view=rev&rev=470013
>> Log:
>> GERONIMO-1840 NamingPropertiesTest is not compatible with non-Sun
>> VMs.
> ...
>> + try {
>> + // the above assumes we're running on a Sun JVM. If
>> we can't load the class first,
>> + // we'll skip the attempt at creating the
>> InitialContext. We've already verified that the
>> + // system properties have been set to the correct
>> values, so this last bit is largely a formality.
>> + Class.forName("NAME_FACTORY_INITIAL");
>> + new InitialContext();
>> + } catch (ClassNotFoundException e) {
>> + }
>
> It's not the first time I ask for some help understanding a change and
> this one is not an exception.
>
> Why do we look up the "NAME_FACTORY_INITIAL" class since it's deemed
> to fail every time?
>
> Jacek
>
> --
> Jacek Laskowski
> http://www.jaceklaskowski.pl