[GitHub] metron pull request #955: METRON-1474 Add normalizecss

[xyztdanid4 <gi...@git.apache.org>]

GitHub user xyztdanid4 opened a pull request:

    https://github.com/apache/metron/pull/955

    METRON-1474 Add normalizecss

    THIS IS WIP. FIRST #952 SHOULD BE MERGED.
    ## Contributor Comments
    This PR adds normalizecss to the frontend projects. It is useful to bridge the differences between browsers.
    
    ## Pull Request Checklist
    
    Thank you for submitting a contribution to Apache Metron.  
    Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions.  
    Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides.  
    
    
    In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? If not one needs to be created at [https://issues.apache.org/jira/browse/METRON-1474](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
    - [X] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    
    ### For code changes:
    - [ ] Have you included steps to reproduce the behavior or problem that is being changed or addressed?
    - [ ] Have you included steps or a guide to how the change may be verified and tested manually?
    - [X] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
      ```
      mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh 
      ```
    
    - [ ] Have you written or updated unit tests and or integration tests to verify your changes?
    - [X] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
    - [X] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
    
    ### For documentation related changes:
    - [X] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`:
    
      ```
      cd site-book
      mvn site
      ```
    
    #### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
    It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/xyztdanid4/metron METRON-1474

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/metron/pull/955.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #955
    
----
commit 0812c6eca0bc009ddd0658f7976f5734daedb859
Author: Daniel Toth <dt...@...>
Date:   2018-03-07T10:40:01Z

    Add yarn as build tool

commit 9117dac298a42a0b434ab933354a54542724b6bc
Author: Daniel Toth <dt...@...>
Date:   2018-03-07T11:47:50Z

    Update ts to avoid 'app module is not an ng module error on build'

commit c4bef1662835051db430d657b479691f137d34ec
Author: Daniel Toth <dt...@...>
Date:   2018-03-07T13:44:29Z

    Add normalize css to the frontend

----


---

[GitHub] metron pull request #955: METRON-1474 Add normalizecss

[xyztdanid4 <gi...@git.apache.org>]

Github user xyztdanid4 closed the pull request at:

    https://github.com/apache/metron/pull/955


---

[GitHub] metron issue #955: METRON-1474 Add normalizecss

[simonellistonball <gi...@git.apache.org>]

Github user simonellistonball commented on the issue:

    https://github.com/apache/metron/pull/955
  
    Have the dependencies, License and Notices files been updated?


---