You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomee.apache.org by Thiago Veronezi <th...@veronezi.org> on 2015/01/26 12:13:08 UTC
issue - StackOverflow when dealing with webjars files (from [VOTE]
TomEE 1.7.2/OpenEJB 4.7.2 (staging-1045))
While preparing the rssreader example, I noticed another issue. TomEE 1.7.2
crashes when it processes a webjars resource. xbean issue?
Exception:
Jan 26, 2015 6:03:42 AM org.apache.catalina.core.ContainerBase
addChildInternal
SEVERE: ContainerBase.addChild: start:
org.apache.catalina.LifecycleException: Failed to start component
[StandardEngine[Catalina].StandardHost[localhost].StandardContext[/rssreader]]
at
org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:154)
at
org.apache.catalina.core.ContainerBase.addChildInternal(ContainerBase.java:901)
at
org.apache.catalina.core.ContainerBase.addChild(ContainerBase.java:877)
at
org.apache.catalina.core.StandardHost.addChild(StandardHost.java:649)
at
org.apache.catalina.startup.HostConfig.deployWAR(HostConfig.java:1081)
at
org.apache.catalina.startup.HostConfig$DeployWar.run(HostConfig.java:1877)
at
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
at java.util.concurrent.FutureTask.run(FutureTask.java:262)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:744)
Caused by: java.lang.StackOverflowError
at java.util.zip.ZipFile.getZipEntry(ZipFile.java:523)
at java.util.zip.ZipFile.access$900(ZipFile.java:56)
at java.util.zip.ZipFile$1.nextElement(ZipFile.java:513)
at java.util.zip.ZipFile$1.nextElement(ZipFile.java:483)
at java.util.jar.JarFile$1.nextElement(JarFile.java:243)
at java.util.jar.JarFile$1.nextElement(JarFile.java:238)
at
org.apache.xbean.finder.archive.JarArchive$JarIterator.advance(JarArchive.java:105)
at
org.apache.xbean.finder.archive.JarArchive$JarIterator.advance(JarArchive.java:109)
In TomEE 1.7.1 it works fine.
In order to reproduce the issue, apply this patch to the rssreader project
(file attached) and start the application. [
https://github.com/tveronezi/rssreader]
[]s,
Thiago
Index: ../../projects/rssreader/pom.xml
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
--- ../../projects/rssreader/pom.xml (revision
b28cd22a42d3729b75dcc6b8be0b01310f40977d)
+++ ../../projects/rssreader/pom.xml (revision )
@@ -22,12 +22,36 @@
<name>rssreader</name>
<properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
- <tomee.version>1.7.1</tomee.version>
- <openejb.version>4.7.1</openejb.version>
+ <tomee.version>1.7.2</tomee.version>
+ <openejb.version>4.7.2</openejb.version>
<javaee.api>6.0-5</javaee.api>
<junit.version>4.10</junit.version>
<groovy.version>2.3.9</groovy.version>
</properties>
+ <repositories>
+ <repository>
+ <id>apache.snapshots</id>
+ <url>
https://repository.apache.org/content/repositories/orgapachetomee-1045</url>
+ <releases>
+ <updatePolicy>daily</updatePolicy>
+ </releases>
+ <snapshots>
+ <updatePolicy>daily</updatePolicy>
+ </snapshots>
+ </repository>
+ </repositories>
+ <pluginRepositories>
+ <pluginRepository>
+ <id>apache.snapshots</id>
+ <url>
https://repository.apache.org/content/repositories/orgapachetomee-1045</url>
+ <releases>
+ <updatePolicy>daily</updatePolicy>
+ </releases>
+ <snapshots>
+ <updatePolicy>daily</updatePolicy>
+ </snapshots>
+ </pluginRepository>
+ </pluginRepositories>
<dependencies>
<dependency>
<groupId>org.apache.openejb</groupId>
@@ -57,6 +81,12 @@
<groupId>org.webjars</groupId>
<artifactId>jquery</artifactId>
<version>2.1.3</version>
+ <scope>runtime</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.webjars</groupId>
+ <artifactId>extjs</artifactId>
+ <version>4.2.1.883-1</version>
<scope>runtime</scope>
</dependency>
<dependency>
Index: ../../projects/rssreader/src/main/webapp/index.jsp
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
--- ../../projects/rssreader/src/main/webapp/index.jsp (revision
b28cd22a42d3729b75dcc6b8be0b01310f40977d)
+++ ../../projects/rssreader/src/main/webapp/index.jsp (revision )
@@ -21,9 +21,9 @@
<head>
<meta charset="utf-8">
<title>rssreader</title>
- <link rel="stylesheet" type="text/css" href="
http://cdn.sencha.io/ext-4.2.0-gpl/resources/ext-theme-neptune/ext-theme-neptune-all.css
">
+ <link rel="stylesheet" type="text/css" href="<c:url
value='/webjars/extjs/4.2.1.883/resources/css/ext-all-neptune.css'/>">
<link rel="stylesheet" type="text/css" href="<c:url
value='/app/app.css'/>">
- <script type="text/javascript" src="
http://cdn.sencha.io/ext-4.2.0-gpl/ext-all.js"></script>
+ <script type="text/javascript" src="<c:url
value='/webjars/extjs/4.2.1.883/ext-all.js'/>"></script>
<script type="text/javascript" src="<c:url
value='/webjars/jquery/2.1.3/jquery.min.js'/>"></script>
<script type="text/javascript" src="<c:url
value='/webjars/underscorejs/1.7.0/underscore-min.js'/>"></script>
<script type="text/javascript" src="<c:url
value='/webjars/backbonejs/1.1.2/backbone-min.js'/>"></script>
\ No newline at end of file
Re: issue - StackOverflow when dealing with webjars files (from
[VOTE] TomEE 1.7.2/OpenEJB 4.7.2 (staging-1045))
Posted by Romain Manni-Bucau <rm...@gmail.com>.
https://issues.apache.org/jira/browse/XBEAN-277
Romain Manni-Bucau
@rmannibucau
http://www.tomitribe.com
http://rmannibucau.wordpress.com
https://github.com/rmannibucau
2015-01-26 14:58 GMT+01:00 Romain Manni-Bucau <rm...@gmail.com>:
> Hi
>
> not sure it is a regression - shouldn't have worked previously.
>
> Cause is extjs has too much file - we need to make
> org.apache.xbean.finder.archive.JarArchive.JarIterator#advance not
> recursive (if you want to log an issue it would be welcomed).
>
> Solutions:
> - increase stack size
> - exclude extjs from scanning (exclusions.list for instance)
>
>
>
> Romain Manni-Bucau
> @rmannibucau
> http://www.tomitribe.com
> http://rmannibucau.wordpress.com
> https://github.com/rmannibucau
>
>
> 2015-01-26 12:13 GMT+01:00 Thiago Veronezi <th...@veronezi.org>:
>> While preparing the rssreader example, I noticed another issue. TomEE 1.7.2
>> crashes when it processes a webjars resource. xbean issue?
>>
>> Exception:
>> Jan 26, 2015 6:03:42 AM org.apache.catalina.core.ContainerBase
>> addChildInternal
>> SEVERE: ContainerBase.addChild: start:
>> org.apache.catalina.LifecycleException: Failed to start component
>> [StandardEngine[Catalina].StandardHost[localhost].StandardContext[/rssreader]]
>> at
>> org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:154)
>> at
>> org.apache.catalina.core.ContainerBase.addChildInternal(ContainerBase.java:901)
>> at
>> org.apache.catalina.core.ContainerBase.addChild(ContainerBase.java:877)
>> at
>> org.apache.catalina.core.StandardHost.addChild(StandardHost.java:649)
>> at
>> org.apache.catalina.startup.HostConfig.deployWAR(HostConfig.java:1081)
>> at
>> org.apache.catalina.startup.HostConfig$DeployWar.run(HostConfig.java:1877)
>> at
>> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
>> at java.util.concurrent.FutureTask.run(FutureTask.java:262)
>> at
>> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
>> at
>> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
>> at java.lang.Thread.run(Thread.java:744)
>> Caused by: java.lang.StackOverflowError
>> at java.util.zip.ZipFile.getZipEntry(ZipFile.java:523)
>> at java.util.zip.ZipFile.access$900(ZipFile.java:56)
>> at java.util.zip.ZipFile$1.nextElement(ZipFile.java:513)
>> at java.util.zip.ZipFile$1.nextElement(ZipFile.java:483)
>> at java.util.jar.JarFile$1.nextElement(JarFile.java:243)
>> at java.util.jar.JarFile$1.nextElement(JarFile.java:238)
>> at
>> org.apache.xbean.finder.archive.JarArchive$JarIterator.advance(JarArchive.java:105)
>> at
>> org.apache.xbean.finder.archive.JarArchive$JarIterator.advance(JarArchive.java:109)
>>
>> In TomEE 1.7.1 it works fine.
>>
>> In order to reproduce the issue, apply this patch to the rssreader project
>> (file attached) and start the application.
>> [https://github.com/tveronezi/rssreader]
>>
>> []s,
>> Thiago
>>
>> Index: ../../projects/rssreader/pom.xml
>> IDEA additional info:
>> Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
>> <+>UTF-8
>> ===================================================================
>> --- ../../projects/rssreader/pom.xml (revision
>> b28cd22a42d3729b75dcc6b8be0b01310f40977d)
>> +++ ../../projects/rssreader/pom.xml (revision )
>> @@ -22,12 +22,36 @@
>> <name>rssreader</name>
>> <properties>
>> <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
>> - <tomee.version>1.7.1</tomee.version>
>> - <openejb.version>4.7.1</openejb.version>
>> + <tomee.version>1.7.2</tomee.version>
>> + <openejb.version>4.7.2</openejb.version>
>> <javaee.api>6.0-5</javaee.api>
>> <junit.version>4.10</junit.version>
>> <groovy.version>2.3.9</groovy.version>
>> </properties>
>> + <repositories>
>> + <repository>
>> + <id>apache.snapshots</id>
>> +
>> <url>https://repository.apache.org/content/repositories/orgapachetomee-1045</url>
>> + <releases>
>> + <updatePolicy>daily</updatePolicy>
>> + </releases>
>> + <snapshots>
>> + <updatePolicy>daily</updatePolicy>
>> + </snapshots>
>> + </repository>
>> + </repositories>
>> + <pluginRepositories>
>> + <pluginRepository>
>> + <id>apache.snapshots</id>
>> +
>> <url>https://repository.apache.org/content/repositories/orgapachetomee-1045</url>
>> + <releases>
>> + <updatePolicy>daily</updatePolicy>
>> + </releases>
>> + <snapshots>
>> + <updatePolicy>daily</updatePolicy>
>> + </snapshots>
>> + </pluginRepository>
>> + </pluginRepositories>
>> <dependencies>
>> <dependency>
>> <groupId>org.apache.openejb</groupId>
>> @@ -57,6 +81,12 @@
>> <groupId>org.webjars</groupId>
>> <artifactId>jquery</artifactId>
>> <version>2.1.3</version>
>> + <scope>runtime</scope>
>> + </dependency>
>> + <dependency>
>> + <groupId>org.webjars</groupId>
>> + <artifactId>extjs</artifactId>
>> + <version>4.2.1.883-1</version>
>> <scope>runtime</scope>
>> </dependency>
>> <dependency>
>> Index: ../../projects/rssreader/src/main/webapp/index.jsp
>> IDEA additional info:
>> Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
>> <+>UTF-8
>> ===================================================================
>> --- ../../projects/rssreader/src/main/webapp/index.jsp (revision
>> b28cd22a42d3729b75dcc6b8be0b01310f40977d)
>> +++ ../../projects/rssreader/src/main/webapp/index.jsp (revision )
>> @@ -21,9 +21,9 @@
>> <head>
>> <meta charset="utf-8">
>> <title>rssreader</title>
>> - <link rel="stylesheet" type="text/css"
>> href="http://cdn.sencha.io/ext-4.2.0-gpl/resources/ext-theme-neptune/ext-theme-neptune-all.css">
>> + <link rel="stylesheet" type="text/css" href="<c:url
>> value='/webjars/extjs/4.2.1.883/resources/css/ext-all-neptune.css'/>">
>> <link rel="stylesheet" type="text/css" href="<c:url
>> value='/app/app.css'/>">
>> - <script type="text/javascript"
>> src="http://cdn.sencha.io/ext-4.2.0-gpl/ext-all.js"></script>
>> + <script type="text/javascript" src="<c:url
>> value='/webjars/extjs/4.2.1.883/ext-all.js'/>"></script>
>> <script type="text/javascript" src="<c:url
>> value='/webjars/jquery/2.1.3/jquery.min.js'/>"></script>
>> <script type="text/javascript" src="<c:url
>> value='/webjars/underscorejs/1.7.0/underscore-min.js'/>"></script>
>> <script type="text/javascript" src="<c:url
>> value='/webjars/backbonejs/1.1.2/backbone-min.js'/>"></script>
>> \ No newline at end of file
>>
Re: issue - StackOverflow when dealing with webjars files (from
[VOTE] TomEE 1.7.2/OpenEJB 4.7.2 (staging-1045))
Posted by Romain Manni-Bucau <rm...@gmail.com>.
Hi
not sure it is a regression - shouldn't have worked previously.
Cause is extjs has too much file - we need to make
org.apache.xbean.finder.archive.JarArchive.JarIterator#advance not
recursive (if you want to log an issue it would be welcomed).
Solutions:
- increase stack size
- exclude extjs from scanning (exclusions.list for instance)
Romain Manni-Bucau
@rmannibucau
http://www.tomitribe.com
http://rmannibucau.wordpress.com
https://github.com/rmannibucau
2015-01-26 12:13 GMT+01:00 Thiago Veronezi <th...@veronezi.org>:
> While preparing the rssreader example, I noticed another issue. TomEE 1.7.2
> crashes when it processes a webjars resource. xbean issue?
>
> Exception:
> Jan 26, 2015 6:03:42 AM org.apache.catalina.core.ContainerBase
> addChildInternal
> SEVERE: ContainerBase.addChild: start:
> org.apache.catalina.LifecycleException: Failed to start component
> [StandardEngine[Catalina].StandardHost[localhost].StandardContext[/rssreader]]
> at
> org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:154)
> at
> org.apache.catalina.core.ContainerBase.addChildInternal(ContainerBase.java:901)
> at
> org.apache.catalina.core.ContainerBase.addChild(ContainerBase.java:877)
> at
> org.apache.catalina.core.StandardHost.addChild(StandardHost.java:649)
> at
> org.apache.catalina.startup.HostConfig.deployWAR(HostConfig.java:1081)
> at
> org.apache.catalina.startup.HostConfig$DeployWar.run(HostConfig.java:1877)
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
> at java.util.concurrent.FutureTask.run(FutureTask.java:262)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
> at java.lang.Thread.run(Thread.java:744)
> Caused by: java.lang.StackOverflowError
> at java.util.zip.ZipFile.getZipEntry(ZipFile.java:523)
> at java.util.zip.ZipFile.access$900(ZipFile.java:56)
> at java.util.zip.ZipFile$1.nextElement(ZipFile.java:513)
> at java.util.zip.ZipFile$1.nextElement(ZipFile.java:483)
> at java.util.jar.JarFile$1.nextElement(JarFile.java:243)
> at java.util.jar.JarFile$1.nextElement(JarFile.java:238)
> at
> org.apache.xbean.finder.archive.JarArchive$JarIterator.advance(JarArchive.java:105)
> at
> org.apache.xbean.finder.archive.JarArchive$JarIterator.advance(JarArchive.java:109)
>
> In TomEE 1.7.1 it works fine.
>
> In order to reproduce the issue, apply this patch to the rssreader project
> (file attached) and start the application.
> [https://github.com/tveronezi/rssreader]
>
> []s,
> Thiago
>
> Index: ../../projects/rssreader/pom.xml
> IDEA additional info:
> Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
> <+>UTF-8
> ===================================================================
> --- ../../projects/rssreader/pom.xml (revision
> b28cd22a42d3729b75dcc6b8be0b01310f40977d)
> +++ ../../projects/rssreader/pom.xml (revision )
> @@ -22,12 +22,36 @@
> <name>rssreader</name>
> <properties>
> <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
> - <tomee.version>1.7.1</tomee.version>
> - <openejb.version>4.7.1</openejb.version>
> + <tomee.version>1.7.2</tomee.version>
> + <openejb.version>4.7.2</openejb.version>
> <javaee.api>6.0-5</javaee.api>
> <junit.version>4.10</junit.version>
> <groovy.version>2.3.9</groovy.version>
> </properties>
> + <repositories>
> + <repository>
> + <id>apache.snapshots</id>
> +
> <url>https://repository.apache.org/content/repositories/orgapachetomee-1045</url>
> + <releases>
> + <updatePolicy>daily</updatePolicy>
> + </releases>
> + <snapshots>
> + <updatePolicy>daily</updatePolicy>
> + </snapshots>
> + </repository>
> + </repositories>
> + <pluginRepositories>
> + <pluginRepository>
> + <id>apache.snapshots</id>
> +
> <url>https://repository.apache.org/content/repositories/orgapachetomee-1045</url>
> + <releases>
> + <updatePolicy>daily</updatePolicy>
> + </releases>
> + <snapshots>
> + <updatePolicy>daily</updatePolicy>
> + </snapshots>
> + </pluginRepository>
> + </pluginRepositories>
> <dependencies>
> <dependency>
> <groupId>org.apache.openejb</groupId>
> @@ -57,6 +81,12 @@
> <groupId>org.webjars</groupId>
> <artifactId>jquery</artifactId>
> <version>2.1.3</version>
> + <scope>runtime</scope>
> + </dependency>
> + <dependency>
> + <groupId>org.webjars</groupId>
> + <artifactId>extjs</artifactId>
> + <version>4.2.1.883-1</version>
> <scope>runtime</scope>
> </dependency>
> <dependency>
> Index: ../../projects/rssreader/src/main/webapp/index.jsp
> IDEA additional info:
> Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
> <+>UTF-8
> ===================================================================
> --- ../../projects/rssreader/src/main/webapp/index.jsp (revision
> b28cd22a42d3729b75dcc6b8be0b01310f40977d)
> +++ ../../projects/rssreader/src/main/webapp/index.jsp (revision )
> @@ -21,9 +21,9 @@
> <head>
> <meta charset="utf-8">
> <title>rssreader</title>
> - <link rel="stylesheet" type="text/css"
> href="http://cdn.sencha.io/ext-4.2.0-gpl/resources/ext-theme-neptune/ext-theme-neptune-all.css">
> + <link rel="stylesheet" type="text/css" href="<c:url
> value='/webjars/extjs/4.2.1.883/resources/css/ext-all-neptune.css'/>">
> <link rel="stylesheet" type="text/css" href="<c:url
> value='/app/app.css'/>">
> - <script type="text/javascript"
> src="http://cdn.sencha.io/ext-4.2.0-gpl/ext-all.js"></script>
> + <script type="text/javascript" src="<c:url
> value='/webjars/extjs/4.2.1.883/ext-all.js'/>"></script>
> <script type="text/javascript" src="<c:url
> value='/webjars/jquery/2.1.3/jquery.min.js'/>"></script>
> <script type="text/javascript" src="<c:url
> value='/webjars/underscorejs/1.7.0/underscore-min.js'/>"></script>
> <script type="text/javascript" src="<c:url
> value='/webjars/backbonejs/1.1.2/backbone-min.js'/>"></script>
> \ No newline at end of file
>