You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by eranwitkon <gi...@git.apache.org> on 2015/08/09 22:40:33 UTC

[GitHub] incubator-zeppelin pull request: ZEPPELIN213: Notebook toggleAllTa...

GitHub user eranwitkon opened a pull request:

    https://github.com/apache/incubator-zeppelin/pull/195

    ZEPPELIN213: Notebook toggleAllTable and toggleAllEditor does not mat…

    This fix match the notebook buttons (code & output) behavior to the paragraph behavior (code & output).
    BEFORE:
    ![selection_008](https://cloud.githubusercontent.com/assets/2227083/9156814/bd9fe70a-3eef-11e5-83db-f61dbd66ec0a.png)
    
    AFTER:
    ![selection_009](https://cloud.githubusercontent.com/assets/2227083/9156821/dac9d3a4-3eef-11e5-9326-95e43d4806bf.png)
    
     

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/eranwitkon/incubator-zeppelin master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-zeppelin/pull/195.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #195
    
----
commit 32b075423b1314e04ad2cda6763a485844c853b7
Author: cto <go...@gmail.com>
Date:   2015-08-09T20:34:00Z

    ZEPPELIN213: Notebook toggleAllTable and toggleAllEditor does not match paragraph button

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: ZEPPELIN213: Notebook toggleAllTa...

Posted by Leemoonsoo <gi...@git.apache.org>.

Github user Leemoonsoo commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/195#issuecomment-129260898
  
    Tested and LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: ZEPPELIN213: Notebook toggleAllTa...

Posted by tzolov <gi...@git.apache.org>.

Github user tzolov commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/195#issuecomment-129312988
  
    +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: ZEPPELIN213: Notebook toggleAllTa...

Posted by felixcheung <gi...@git.apache.org>.

Github user felixcheung commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/195#issuecomment-129270078
  
    Very cool. LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: ZEPPELIN213: Notebook toggleAllTa...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-zeppelin/pull/195


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---