You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@knox.apache.org by "Kevin Risden (JIRA)" <ji...@apache.org> on 2019/02/22 15:39:00 UTC

[jira] [Commented] (KNOX-1791) MasterService should be a field on GatewayServices

    [ https://issues.apache.org/jira/browse/KNOX-1791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16775290#comment-16775290 ] 

Kevin Risden commented on KNOX-1791:
------------------------------------

Pet peeve: the GatewayServices interface *_SERVICE fields aren't in alphabetical order so hard to tell what is defined.

Also there are some places where the GatewayService field is not used and a string is used instead. Would be good to clean this up to make it consistent like GatewayServer:372 "SSLService"

> MasterService should be a field on GatewayServices
> --------------------------------------------------
>
>                 Key: KNOX-1791
>                 URL: https://issues.apache.org/jira/browse/KNOX-1791
>             Project: Apache Knox
>          Issue Type: Improvement
>            Reporter: Kevin Risden
>            Priority: Trivial
>             Fix For: 1.3.0
>
>
> Currently "MasterService" is a string throughout the code base. This should be a field on the interface GatewayServices like other services. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)