You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "john-bodley (via GitHub)" <gi...@apache.org> on 2023/05/11 21:35:10 UTC
[GitHub] [superset] john-bodley opened a new pull request, #24029: chore: Update QUERY_LOGGER and SQL_QUERY_MUTATOR signatures
john-bodley opened a new pull request, #24029:
URL: https://github.com/apache/superset/pull/24029
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on pull request #24029: chore: Update QUERY_LOGGER and SQL_QUERY_MUTATOR signatures
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina commented on PR #24029:
URL: https://github.com/apache/superset/pull/24029#issuecomment-1577300111
> @michael-s-molina should we put something in the UPDATING file for 3.0 on this, too? This broke our integration, so maybe having the change in updating could help other people upgrading as well b/c they will have to import the user into their config overwrite from global now.
Definitely. I think there was a miscommunication in the review because there's breaking change text added in this PR but it seems it's not related to the particular change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho commented on pull request #24029: chore: Update QUERY_LOGGER and SQL_QUERY_MUTATOR signatures
Posted by "eschutho (via GitHub)" <gi...@apache.org>.
eschutho commented on PR #24029:
URL: https://github.com/apache/superset/pull/24029#issuecomment-1574379682
@john-bodley I'm just tagging this with risk:breaking-change for anyone that might be overriding the config.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on a diff in pull request #24029: chore: Update QUERY_LOGGER and SQL_QUERY_MUTATOR signatures
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina commented on code in PR #24029:
URL: https://github.com/apache/superset/pull/24029#discussion_r1195024131
##########
UPDATING.md:
##########
@@ -24,6 +24,7 @@ assists people when migrating to a new version.
## Next
+- [24029](https://github.com/apache/superset/pull/24029) Removes the `user` and `username` arguments for the QUERY_LOGGER and SQL_QUERY_MUTATOR methods respectively. If the username for the current user is required the `superset.utils.core.get_username` method should be used.
Review Comment:
Could you move this to the **Breaking Changes** section?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #24029: chore: Update QUERY_LOGGER and SQL_QUERY_MUTATOR signatures
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #24029:
URL: https://github.com/apache/superset/pull/24029#issuecomment-1549033752
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/24029?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#24029](https://app.codecov.io/gh/apache/superset/pull/24029?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (5ae7d3c) into [master](https://app.codecov.io/gh/apache/superset/commit/7a55625243e4d405ce27d72ee869cb8e8c785f6b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (7a55625) will **decrease** coverage by `9.56%`.
> The diff coverage is `62.22%`.
> :exclamation: Current head 5ae7d3c differs from pull request most recent head 211cc0c. Consider uploading reports for the commit 211cc0c to get more accurate results
```diff
@@ Coverage Diff @@
## master #24029 +/- ##
==========================================
- Coverage 66.54% 56.98% -9.56%
==========================================
Files 1941 1942 +1
Lines 75280 75215 -65
Branches 8168 8145 -23
==========================================
- Hits 50093 42862 -7231
- Misses 23098 30268 +7170
+ Partials 2089 2085 -4
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `53.16% <37.50%> (-0.02%)` | :arrow_down: |
| mysql | `?` | |
| postgres | `?` | |
| presto | `53.09% <47.50%> (?)` | |
| python | `59.59% <57.50%> (-19.72%)` | :arrow_down: |
| sqlite | `?` | |
| unit | `53.03% <37.50%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://app.codecov.io/gh/apache/superset/pull/24029?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...n-chart-handlebars/src/plugin/controls/columns.tsx](https://app.codecov.io/gh/apache/superset/pull/24029?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtaGFuZGxlYmFycy9zcmMvcGx1Z2luL2NvbnRyb2xzL2NvbHVtbnMudHN4) | `15.78% <0.00%> (+0.78%)` | :arrow_up: |
| [...frontend/src/SqlLab/components/ResultSet/index.tsx](https://app.codecov.io/gh/apache/superset/pull/24029?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1Jlc3VsdFNldC9pbmRleC50c3g=) | `63.05% <ø> (+0.39%)` | :arrow_up: |
| [...et-frontend/src/components/TableSelector/index.tsx](https://app.codecov.io/gh/apache/superset/pull/24029?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVTZWxlY3Rvci9pbmRleC50c3g=) | `81.08% <0.00%> (ø)` | |
| [superset/charts/api.py](https://app.codecov.io/gh/apache/superset/pull/24029?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `50.65% <ø> (-35.20%)` | :arrow_down: |
| [superset/config.py](https://app.codecov.io/gh/apache/superset/pull/24029?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `91.45% <ø> (-0.57%)` | :arrow_down: |
| [superset/dashboards/api.py](https://app.codecov.io/gh/apache/superset/pull/24029?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `51.40% <ø> (-41.18%)` | :arrow_down: |
| [superset/databases/api.py](https://app.codecov.io/gh/apache/superset/pull/24029?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `51.23% <ø> (-37.88%)` | :arrow_down: |
| [superset/datasets/api.py](https://app.codecov.io/gh/apache/superset/pull/24029?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `46.90% <ø> (-41.10%)` | :arrow_down: |
| [superset/db\_engine\_specs/db2.py](https://app.codecov.io/gh/apache/superset/pull/24029?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2RiMi5weQ==) | `91.66% <ø> (ø)` | |
| [superset/db\_engine\_specs/hive.py](https://app.codecov.io/gh/apache/superset/pull/24029?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `65.54% <ø> (-20.95%)` | :arrow_down: |
| ... and [26 more](https://app.codecov.io/gh/apache/superset/pull/24029?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [334 files with indirect coverage changes](https://app.codecov.io/gh/apache/superset/pull/24029/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] john-bodley merged pull request #24029: chore: Update QUERY_LOGGER and SQL_QUERY_MUTATOR signatures
Posted by "john-bodley (via GitHub)" <gi...@apache.org>.
john-bodley merged PR #24029:
URL: https://github.com/apache/superset/pull/24029
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho commented on pull request #24029: chore: Update QUERY_LOGGER and SQL_QUERY_MUTATOR signatures
Posted by "eschutho (via GitHub)" <gi...@apache.org>.
eschutho commented on PR #24029:
URL: https://github.com/apache/superset/pull/24029#issuecomment-1577291738
@michael-s-molina should we put something in the UPDATING file for 3.0 on this, too? This broke our integration, so maybe having the change in updating could help other people upgrading as well b/c they will have to import the user into their config overwrite from global now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on pull request #24029: chore: Update QUERY_LOGGER and SQL_QUERY_MUTATOR signatures
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina commented on PR #24029:
URL: https://github.com/apache/superset/pull/24029#issuecomment-1577386523
> > @michael-s-molina should we put something in the UPDATING file for 3.0 on this, too? This broke our integration, so maybe having the change in updating could help other people upgrading as well b/c they will have to import the user into their config overwrite from global now.
>
> Definitely. I think there was a miscommunication in the review because there's breaking change text added in this PR but it seems it's not related to the particular change.
@eschutho @john-bodley I added the breaking change text [here](https://github.com/apache/superset/pull/24295).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org