You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@phoenix.apache.org by comnetwork <gi...@git.apache.org> on 2018/08/01 04:56:56 UTC

[GitHub] phoenix pull request #321: PHOENIX-4820 V3

GitHub user comnetwork opened a pull request:

    https://github.com/apache/phoenix/pull/321

    PHOENIX-4820 V3

    This patch is mainly for :
    1. remove CoerceExpression in ExpressionUtil.IsColumnConstantExpressionVisitor, 
    conside following sql:
     
     select a.av1 
     from (select pk1 ak1,pk2 ak2,pk3 ak3, substr(v1,1,1) av1 from test_table order by pk1,pk2 limit 10) a 
     where cast(a.ak1 as integer)=2 group by a.ak1,a.av1 order by a.av1
    
    we can not infer a.ak1 is constant for " where cast(a.ak1 as integer)=2" if a.ak1 is double,
    
    2. add more unit tests and IT tests for  CoerceExpression .


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/comnetwork/phoenix 4.x-HBase-1.3

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/phoenix/pull/321.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #321
    
----
commit ef71627dbf7fd08a3093b7edaf34bc4092100e64
Author: chenglei <ch...@...>
Date:   2018-08-01T04:48:10Z

    PHOENIX-4820

----


---