[GitHub] flink issue #2543: [FLINK-4670] [cluster management] Add watch mechanism on ...

[beyond1920 <gi...@git.apache.org>]

Github user beyond1920 commented on the issue:

    https://github.com/apache/flink/pull/2543
  
    Hi, till. Thanks for your review.
    First sorry to bind to the wrong jira link, already correct it. 
    About heartbeatManager, i thought we could separate HeartbeatManager into two part, each part focus only on one function.
    1. Death watch to monitor liveness, it could register watch, unregister watch, and notify the dead targets. just like deathwatch in akka. Although now I implement it on Akka's dead watch functionality, but interface is defined. It's fine to give another implementation of it in future.
    2. Payload deliver periodically. But because data sync behavior is different in different component, e.g, TM,JM,RM, so I'm not sure it is good to extract the logic into a common logic.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---