You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datasketches.apache.org by GitBox <gi...@apache.org> on 2022/10/25 22:40:04 UTC
[GitHub] [datasketches-postgresql] cswarth opened a new issue, #53: compatible version of datasketches-cpp?
cswarth opened a new issue, #53:
URL: https://github.com/apache/datasketches-postgresql/issues/53
How can I determine which version of datasketches-cpp datasketches-postgres is compatible with? The README seems to leave that information out.
E.G. [current src/kll_float_sketch_c_adapter.cpp](https://github.com/apache/datasketches-postgresql/blob/master/src/kll_float_sketch_c_adapter.cpp#L26) references kll_sketch template with 4 parameters.
```
using kll_float_sketch = datasketches::kll_sketch<float, std::less<float>, datasketches::serde<float>, palloc_allocator<float>>;
```
But the current [kll_sketch.hpp in datasketches-cpp repo](https://github.com/apache/datasketches-cpp/blob/master/kll/include/kll_sketch.hpp#L153-L158) has only three parameters,
```
template <
typename T,
typename C = std::less<T>, // strict weak ordering function (see C++ named requirements: Compare)
typename A = std::allocator<T>
>
class kll_sketch {
```
Obviously datasketches-postgres is not compatible and cannot compile with this version of datasketches?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [datasketches-postgresql] cswarth closed issue #53: compatible version of datasketches-cpp?
Posted by GitBox <gi...@apache.org>.
cswarth closed issue #53: compatible version of datasketches-cpp?
URL: https://github.com/apache/datasketches-postgresql/issues/53
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [datasketches-postgresql] cswarth commented on issue #53: compatible version of datasketches-cpp?
Posted by GitBox <gi...@apache.org>.
cswarth commented on issue #53:
URL: https://github.com/apache/datasketches-postgresql/issues/53#issuecomment-1291221835
found this in package.sh. I'll try that version of datasketches-cpp
```
# version of datasketches-cpp core library to include
CORETAG=3.4.0
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [datasketches-postgresql] cswarth commented on issue #53: compatible version of datasketches-cpp?
Posted by GitBox <gi...@apache.org>.
cswarth commented on issue #53:
URL: https://github.com/apache/datasketches-postgresql/issues/53#issuecomment-1291226591
NVM, downloaded PGXN package that includes everything needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org