You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pegasus.apache.org by GitBox <gi...@apache.org> on 2022/01/21 08:04:33 UTC
[GitHub] [incubator-pegasus] levy5307 opened a new pull request #890: feat(remove slog): adapt to modifications in rdsn
levy5307 opened a new pull request #890:
URL: https://github.com/apache/incubator-pegasus/pull/890
slog is removed in rdsn, so the slog function test is useless
### Checklist <!--REMOVE the items that are not applicable-->
##### Tests <!-- At least one of them must be included. -->
- No code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] levy5307 commented on pull request #890: feat(remove slog): adapt to modifications in rdsn
Posted by GitBox <gi...@apache.org>.
levy5307 commented on pull request #890:
URL: https://github.com/apache/incubator-pegasus/pull/890#issuecomment-1018330074
> How about update the config changes in `src/server/config.ini` and `src/server/config.min.ini`?
Sure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] levy5307 commented on a change in pull request #890: feat(remove slog): adapt to modifications in rdsn
Posted by GitBox <gi...@apache.org>.
levy5307 commented on a change in pull request #890:
URL: https://github.com/apache/incubator-pegasus/pull/890#discussion_r789492825
##########
File path: src/server/config.ini
##########
@@ -250,11 +250,9 @@
fd_grace_seconds = 22
log_private_file_size_mb = 32
- log_private_batch_buffer_kb = 7
- log_private_batch_buffer_count = 512
- log_private_batch_buffer_flush_interval_ms = 30000
Review comment:
configuration changed in https://github.com/XiaoMi/rdsn/pull/1019
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] hycdong commented on pull request #890: feat(remove slog): adapt to modifications in rdsn
Posted by GitBox <gi...@apache.org>.
hycdong commented on pull request #890:
URL: https://github.com/apache/incubator-pegasus/pull/890#issuecomment-1018329543
How about update the config changes in `src/server/config.ini` and `src/server/config.min.ini`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] levy5307 merged pull request #890: feat(remove slog): adapt to modifications in rdsn
Posted by GitBox <gi...@apache.org>.
levy5307 merged pull request #890:
URL: https://github.com/apache/incubator-pegasus/pull/890
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org