[GitHub] [iceberg] jackye1995 commented on a change in pull request #3232: Throw better exception when dropping a Namespace with NessieCatalog

[GitBox <gi...@apache.org>]

jackye1995 commented on a change in pull request #3232:
URL: https://github.com/apache/iceberg/pull/3232#discussion_r724393671



##########
File path: nessie/src/main/java/org/apache/iceberg/nessie/NessieCatalog.java
##########
@@ -285,26 +285,29 @@ public void createNamespace(Namespace namespace, Map<String, String> metadata) {
   }
 
   /**
-   * Namespaces in Nessie are implicit and deleting them results in a no-op.
+   * Namespaces in Nessie are implicit and therefore cannot be dropped
    *
-   * @param namespace a namespace. {@link Namespace}
-   * @return always false.
+   * @param namespace The {@link Namespace} to drop.
+   * @throws UnsupportedOperationException Namespaces in Nessie are implicit and thus cannot be dropped.
    */
   @Override
   public boolean dropNamespace(Namespace namespace) throws NamespaceNotEmptyException {

Review comment:
       in this case, should we also remove `throws NamespaceNotEmptyException` for these method signatures?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org