You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/05/26 13:38:49 UTC

[GitHub] [tvm] lhutton1 opened a new pull request, #11469: [microNPU] Fix offloading incompatible average pool

lhutton1 opened a new pull request, #11469:
URL: https://github.com/apache/tvm/pull/11469

   Fixes offloading a few corner cases of average pooling. Specifically not offloading nn.avg_pool2d when:
   * The attribute count_include_pad=True
   * Padding exceeds the dimensions [3, 3, 4, 4]
   * The pool size is greater than [8, 8] when the pool uses padding
   
   cc @NicolaLancellotti @ekalda @manupa-arm 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] lhutton1 commented on pull request #11469: [microNPU] Fix offloading incompatible average pool

Posted by GitBox <gi...@apache.org>.
lhutton1 commented on PR #11469:
URL: https://github.com/apache/tvm/pull/11469#issuecomment-1168398326

   @tvm-bot rerun


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] lhutton1 commented on pull request #11469: [microNPU] Fix offloading incompatible average pool

Posted by GitBox <gi...@apache.org>.
lhutton1 commented on PR #11469:
URL: https://github.com/apache/tvm/pull/11469#issuecomment-1165909098

   @tvm-bot rerun


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] manupa-arm commented on pull request #11469: [microNPU] Fix offloading incompatible average pool

Posted by GitBox <gi...@apache.org>.
manupa-arm commented on PR #11469:
URL: https://github.com/apache/tvm/pull/11469#issuecomment-1171170839

   Thanks @ekalda @lhutton1 !


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] manupa-arm merged pull request #11469: [microNPU] Fix offloading incompatible average pool

Posted by GitBox <gi...@apache.org>.
manupa-arm merged PR #11469:
URL: https://github.com/apache/tvm/pull/11469


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] manupa-arm commented on pull request #11469: [microNPU] Fix offloading incompatible average pool

Posted by GitBox <gi...@apache.org>.
manupa-arm commented on PR #11469:
URL: https://github.com/apache/tvm/pull/11469#issuecomment-1171160128

   Might be better to add a test for to cover this case.
   (Happy to take a follow-up)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] lhutton1 commented on pull request #11469: [microNPU] Fix offloading incompatible average pool

Posted by GitBox <gi...@apache.org>.
lhutton1 commented on PR #11469:
URL: https://github.com/apache/tvm/pull/11469#issuecomment-1171166650

   Sure! Might be best to do in a follow up (CI seems quite flaky atm)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] lhutton1 commented on pull request #11469: [microNPU] Fix offloading incompatible average pool

Posted by GitBox <gi...@apache.org>.
lhutton1 commented on PR #11469:
URL: https://github.com/apache/tvm/pull/11469#issuecomment-1171055274

   This is finally green :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] lhutton1 commented on pull request #11469: [microNPU] Fix offloading incompatible average pool

Posted by GitBox <gi...@apache.org>.
lhutton1 commented on PR #11469:
URL: https://github.com/apache/tvm/pull/11469#issuecomment-1168629910

   @tvm-bot rerun


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org