You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/04/09 21:43:38 UTC

[GitHub] [beam] Hannah-Jiang commented on a change in pull request #11243: [BEAM-9136]Add licenses for dependencies for Java

Hannah-Jiang commented on a change in pull request #11243: [BEAM-9136]Add licenses for dependencies for Java
URL: https://github.com/apache/beam/pull/11243#discussion_r406494846
 
 

 ##########
 File path: sdks/java/container/build.gradle
 ##########
 @@ -68,6 +73,28 @@ golang {
   }
 }
 
+// this is a workaround to call generateLicenseReport task from project root directory.
+// generateLicenseReport does not return correct dependency list when not called from the root.
+task generateThirdPartyLicenses(type: Exec) {
+  workingDir project.rootProject.projectDir
+  commandLine './sdks/java/container/license_scripts/license_script.sh'
 
 Review comment:
   When the `generateLicenseReport` task is triggered by `dependsOn`, the task is not running at the project root directory regardless how to set project scope, and dependency list is not correct. This is a workaround to execute the `generateLicenseReport` from root directory and get correct dependency list.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services