You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/10/18 16:02:55 UTC

[GitHub] [shardingsphere-elasticjob] terrymanu opened a new pull request #1589: Move elasticjob-tracing from infra module to top level

terrymanu opened a new pull request #1589:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1589


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere-elasticjob] terrymanu merged pull request #1589: Move elasticjob-tracing from infra module to top level

Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #1589:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1589


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere-elasticjob] codecov-io commented on pull request #1589: Move elasticjob-tracing from infra module to top level

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1589:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1589#issuecomment-711263017


   # [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1589?src=pr&el=h1) Report
   > Merging [#1589](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1589?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere-elasticjob/commit/a88d5e87973667772c7f95ab9dc93e6d48dc853d?el=desc) will **decrease** coverage by `0.10%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1589/graphs/tree.svg?width=650&height=150&src=pr&token=8ZMVc4Yo4Z)](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1589?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1589      +/-   ##
   ============================================
   - Coverage     85.56%   85.46%   -0.11%     
     Complexity      102      102              
   ============================================
     Files           250      250              
     Lines          5668     5668              
     Branches        875      875              
   ============================================
   - Hits           4850     4844       -6     
   - Misses          506      510       +4     
   - Partials        312      314       +2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1589?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...shardingsphere/elasticjob/tracing/JobEventBus.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1589/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi10cmFjaW5nL2VsYXN0aWNqb2ItdHJhY2luZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvdHJhY2luZy9Kb2JFdmVudEJ1cy5qYXZh) | `95.65% <ø> (ø)` | `1.00 <0.00> (?)` | |
   | [...re/elasticjob/tracing/event/JobExecutionEvent.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1589/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi10cmFjaW5nL2VsYXN0aWNqb2ItdHJhY2luZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvdHJhY2luZy9ldmVudC9Kb2JFeGVjdXRpb25FdmVudC5qYXZh) | `100.00% <ø> (ø)` | `0.00 <0.00> (?)` | |
   | [.../elasticjob/tracing/event/JobStatusTraceEvent.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1589/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi10cmFjaW5nL2VsYXN0aWNqb2ItdHJhY2luZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvdHJhY2luZy9ldmVudC9Kb2JTdGF0dXNUcmFjZUV2ZW50LmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (?)` | |
   | [...acing/exception/TracingConfigurationException.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1589/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi10cmFjaW5nL2VsYXN0aWNqb2ItdHJhY2luZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvdHJhY2luZy9leGNlcHRpb24vVHJhY2luZ0NvbmZpZ3VyYXRpb25FeGNlcHRpb24uamF2YQ==) | `100.00% <ø> (ø)` | `2.00 <0.00> (?)` | |
   | [...icjob/tracing/listener/TracingListenerFactory.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1589/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi10cmFjaW5nL2VsYXN0aWNqb2ItdHJhY2luZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvdHJhY2luZy9saXN0ZW5lci9UcmFjaW5nTGlzdGVuZXJGYWN0b3J5LmphdmE=) | `100.00% <ø> (ø)` | `0.00 <0.00> (?)` | |
   | [...icjob/tracing/rdb/listener/RDBTracingListener.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1589/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi10cmFjaW5nL2VsYXN0aWNqb2ItdHJhY2luZy1yZGIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvdHJhY2luZy9yZGIvbGlzdGVuZXIvUkRCVHJhY2luZ0xpc3RlbmVyLmphdmE=) | `100.00% <ø> (ø)` | `0.00 <0.00> (?)` | |
   | [.../rdb/listener/RDBTracingListenerConfiguration.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1589/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi10cmFjaW5nL2VsYXN0aWNqb2ItdHJhY2luZy1yZGIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvdHJhY2luZy9yZGIvbGlzdGVuZXIvUkRCVHJhY2luZ0xpc3RlbmVyQ29uZmlndXJhdGlvbi5qYXZh) | `100.00% <ø> (ø)` | `0.00 <0.00> (?)` | |
   | [...ticjob/tracing/rdb/storage/RDBJobEventStorage.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1589/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi10cmFjaW5nL2VsYXN0aWNqb2ItdHJhY2luZy1yZGIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvdHJhY2luZy9yZGIvc3RvcmFnZS9SREJKb2JFdmVudFN0b3JhZ2UuamF2YQ==) | `81.39% <ø> (ø)` | `0.00 <0.00> (?)` | |
   | [...icjob/tracing/rdb/storage/RDBStorageSQLMapper.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1589/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi10cmFjaW5nL2VsYXN0aWNqb2ItdHJhY2luZy1yZGIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvdHJhY2luZy9yZGIvc3RvcmFnZS9SREJTdG9yYWdlU1FMTWFwcGVyLmphdmE=) | `90.00% <ø> (ø)` | `0.00 <0.00> (?)` | |
   | [...here/elasticjob/tracing/rdb/type/DatabaseType.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1589/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi10cmFjaW5nL2VsYXN0aWNqb2ItdHJhY2luZy1yZGIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvdHJhY2luZy9yZGIvdHlwZS9EYXRhYmFzZVR5cGUuamF2YQ==) | `100.00% <ø> (ø)` | `2.00 <0.00> (?)` | |
   | ... and [10 more](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1589/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1589?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1589?src=pr&el=footer). Last update [a88d5e8...e03d142](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1589?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere-elasticjob] codecov-io edited a comment on pull request #1589: Move elasticjob-tracing from infra module to top level

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1589:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1589#issuecomment-711263017


   # [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1589?src=pr&el=h1) Report
   > Merging [#1589](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1589?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere-elasticjob/commit/a88d5e87973667772c7f95ab9dc93e6d48dc853d?el=desc) will **decrease** coverage by `0.05%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1589/graphs/tree.svg?width=650&height=150&src=pr&token=8ZMVc4Yo4Z)](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1589?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1589      +/-   ##
   ============================================
   - Coverage     85.56%   85.51%   -0.06%     
     Complexity      102      102              
   ============================================
     Files           250      250              
     Lines          5668     5668              
     Branches        875      875              
   ============================================
   - Hits           4850     4847       -3     
   - Misses          506      509       +3     
     Partials        312      312              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1589?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...shardingsphere/elasticjob/tracing/JobEventBus.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1589/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi10cmFjaW5nL2VsYXN0aWNqb2ItdHJhY2luZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvdHJhY2luZy9Kb2JFdmVudEJ1cy5qYXZh) | `95.65% <ø> (ø)` | `1.00 <0.00> (?)` | |
   | [...re/elasticjob/tracing/event/JobExecutionEvent.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1589/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi10cmFjaW5nL2VsYXN0aWNqb2ItdHJhY2luZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvdHJhY2luZy9ldmVudC9Kb2JFeGVjdXRpb25FdmVudC5qYXZh) | `100.00% <ø> (ø)` | `0.00 <0.00> (?)` | |
   | [.../elasticjob/tracing/event/JobStatusTraceEvent.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1589/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi10cmFjaW5nL2VsYXN0aWNqb2ItdHJhY2luZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvdHJhY2luZy9ldmVudC9Kb2JTdGF0dXNUcmFjZUV2ZW50LmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (?)` | |
   | [...acing/exception/TracingConfigurationException.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1589/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi10cmFjaW5nL2VsYXN0aWNqb2ItdHJhY2luZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvdHJhY2luZy9leGNlcHRpb24vVHJhY2luZ0NvbmZpZ3VyYXRpb25FeGNlcHRpb24uamF2YQ==) | `100.00% <ø> (ø)` | `2.00 <0.00> (?)` | |
   | [...icjob/tracing/listener/TracingListenerFactory.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1589/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi10cmFjaW5nL2VsYXN0aWNqb2ItdHJhY2luZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvdHJhY2luZy9saXN0ZW5lci9UcmFjaW5nTGlzdGVuZXJGYWN0b3J5LmphdmE=) | `100.00% <ø> (ø)` | `0.00 <0.00> (?)` | |
   | [...icjob/tracing/rdb/listener/RDBTracingListener.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1589/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi10cmFjaW5nL2VsYXN0aWNqb2ItdHJhY2luZy1yZGIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvdHJhY2luZy9yZGIvbGlzdGVuZXIvUkRCVHJhY2luZ0xpc3RlbmVyLmphdmE=) | `100.00% <ø> (ø)` | `0.00 <0.00> (?)` | |
   | [.../rdb/listener/RDBTracingListenerConfiguration.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1589/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi10cmFjaW5nL2VsYXN0aWNqb2ItdHJhY2luZy1yZGIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvdHJhY2luZy9yZGIvbGlzdGVuZXIvUkRCVHJhY2luZ0xpc3RlbmVyQ29uZmlndXJhdGlvbi5qYXZh) | `100.00% <ø> (ø)` | `0.00 <0.00> (?)` | |
   | [...ticjob/tracing/rdb/storage/RDBJobEventStorage.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1589/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi10cmFjaW5nL2VsYXN0aWNqb2ItdHJhY2luZy1yZGIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvdHJhY2luZy9yZGIvc3RvcmFnZS9SREJKb2JFdmVudFN0b3JhZ2UuamF2YQ==) | `81.39% <ø> (ø)` | `0.00 <0.00> (?)` | |
   | [...icjob/tracing/rdb/storage/RDBStorageSQLMapper.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1589/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi10cmFjaW5nL2VsYXN0aWNqb2ItdHJhY2luZy1yZGIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvdHJhY2luZy9yZGIvc3RvcmFnZS9SREJTdG9yYWdlU1FMTWFwcGVyLmphdmE=) | `90.00% <ø> (ø)` | `0.00 <0.00> (?)` | |
   | [...here/elasticjob/tracing/rdb/type/DatabaseType.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1589/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi10cmFjaW5nL2VsYXN0aWNqb2ItdHJhY2luZy1yZGIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvdHJhY2luZy9yZGIvdHlwZS9EYXRhYmFzZVR5cGUuamF2YQ==) | `100.00% <ø> (ø)` | `2.00 <0.00> (?)` | |
   | ... and [9 more](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1589/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1589?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1589?src=pr&el=footer). Last update [a88d5e8...e03d142](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1589?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org