You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Brian McDevitt (Code Review)" <ge...@cloudera.org> on 2019/01/30 22:19:18 UTC
[kudu-CR] KUDU-2411: Example integration test using KuduMiniCluster
Brian McDevitt has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12318
Change subject: KUDU-2411: Example integration test using KuduMiniCluster
......................................................................
KUDU-2411: Example integration test using KuduMiniCluster
Adds an example of using the Kudu binary Jar to execute integration tests
against a KuduMiniCluster.
Change-Id: Ife9103557b30b4105ef57ed36a34f3c93ba2dc6d
---
M examples/java/java-example/pom.xml
M examples/java/java-example/src/main/java/org/apache/kudu/examples/Example.java
A examples/java/java-example/src/main/test/org/apache/kudu/examples/ITExample.java
3 files changed, 49 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/18/12318/1
--
To view, visit http://gerrit.cloudera.org:8080/12318
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ife9103557b30b4105ef57ed36a34f3c93ba2dc6d
Gerrit-Change-Number: 12318
Gerrit-PatchSet: 1
Gerrit-Owner: Brian McDevitt <br...@phdata.io>
[kudu-CR] KUDU-2411: Example integration test using KuduMiniCluster
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12318 )
Change subject: KUDU-2411: Example integration test using KuduMiniCluster
......................................................................
KUDU-2411: Example integration test using KuduMiniCluster
Adds an example of using the Kudu binary Jar to execute integration tests
against a KuduMiniCluster.
Change-Id: Ife9103557b30b4105ef57ed36a34f3c93ba2dc6d
Reviewed-on: http://gerrit.cloudera.org:8080/12318
Reviewed-by: Grant Henke <gr...@apache.org>
Tested-by: Grant Henke <gr...@apache.org>
---
M examples/java/java-example/pom.xml
M examples/java/java-example/src/main/java/org/apache/kudu/examples/Example.java
A examples/java/java-example/src/test/java/org/apache/kudu/examples/ExampleTest.java
3 files changed, 87 insertions(+), 4 deletions(-)
Approvals:
Grant Henke: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/12318
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ife9103557b30b4105ef57ed36a34f3c93ba2dc6d
Gerrit-Change-Number: 12318
Gerrit-PatchSet: 12
Gerrit-Owner: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] KUDU-2411: Example integration test using KuduMiniCluster
Posted by "Brian McDevitt (Code Review)" <ge...@cloudera.org>.
Brian McDevitt has posted comments on this change. ( http://gerrit.cloudera.org:8080/12318 )
Change subject: KUDU-2411: Example integration test using KuduMiniCluster
......................................................................
Patch Set 2:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/12318/1/examples/java/java-example/pom.xml
File examples/java/java-example/pom.xml:
http://gerrit.cloudera.org:8080/#/c/12318/1/examples/java/java-example/pom.xml@85
PS1, Line 85:
> I think we need to add junit as a test dependency such as:
I added version 4.12 since that is what the kudu-test-utils project uses.
http://gerrit.cloudera.org:8080/#/c/12318/1/examples/java/java-example/src/main/test/org/apache/kudu/examples/ITExample.java
File examples/java/java-example/src/main/test/org/apache/kudu/examples/ITExample.java:
PS1:
> This file has to live in examples/java/java-example/src/test/java/org/apach
Yikes. Good catch.
http://gerrit.cloudera.org:8080/#/c/12318/1/examples/java/java-example/src/main/test/org/apache/kudu/examples/ITExample.java@10
PS1, Line 10:
> rename to ExampleTest so Maven Surefire will execute the test when we call
Done
--
To view, visit http://gerrit.cloudera.org:8080/12318
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife9103557b30b4105ef57ed36a34f3c93ba2dc6d
Gerrit-Change-Number: 12318
Gerrit-PatchSet: 2
Gerrit-Owner: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Thu, 31 Jan 2019 15:27:11 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2411: Example integration test using KuduMiniCluster
Posted by "Brian McDevitt (Code Review)" <ge...@cloudera.org>.
Hello Mike Percy, Kudu Jenkins, Adar Dembo, Grant Henke, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12318
to look at the new patch set (#10).
Change subject: KUDU-2411: Example integration test using KuduMiniCluster
......................................................................
KUDU-2411: Example integration test using KuduMiniCluster
Adds an example of using the Kudu binary Jar to execute integration tests
against a KuduMiniCluster.
Change-Id: Ife9103557b30b4105ef57ed36a34f3c93ba2dc6d
---
M examples/java/java-example/pom.xml
M examples/java/java-example/src/main/java/org/apache/kudu/examples/Example.java
A examples/java/java-example/src/test/java/org/apache/kudu/examples/ExampleTest.java
3 files changed, 87 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/18/12318/10
--
To view, visit http://gerrit.cloudera.org:8080/12318
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ife9103557b30b4105ef57ed36a34f3c93ba2dc6d
Gerrit-Change-Number: 12318
Gerrit-PatchSet: 10
Gerrit-Owner: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] KUDU-2411: Example integration test using KuduMiniCluster
Posted by "Brian McDevitt (Code Review)" <ge...@cloudera.org>.
Brian McDevitt has posted comments on this change. ( http://gerrit.cloudera.org:8080/12318 )
Change subject: KUDU-2411: Example integration test using KuduMiniCluster
......................................................................
Patch Set 8:
(2 comments)
Added comments to the example test class and the KuduTestHarness rule.
http://gerrit.cloudera.org:8080/#/c/12318/5/examples/java/java-example/src/test/java/org/apache/kudu/examples/ExampleTest.java
File examples/java/java-example/src/test/java/org/apache/kudu/examples/ExampleTest.java:
http://gerrit.cloudera.org:8080/#/c/12318/5/examples/java/java-example/src/test/java/org/apache/kudu/examples/ExampleTest.java@30
PS5, Line 30: public class ExampleTest {
> At a minimum, let's copy the comments from the documentation found here: ht
Added
http://gerrit.cloudera.org:8080/#/c/12318/8/examples/java/java-example/src/test/java/org/apache/kudu/examples/ExampleTest.java
File examples/java/java-example/src/test/java/org/apache/kudu/examples/ExampleTest.java:
http://gerrit.cloudera.org:8080/#/c/12318/8/examples/java/java-example/src/test/java/org/apache/kudu/examples/ExampleTest.java@28
PS8, Line 28: * An example integration test class that spins up a local Kudu cluster.
I was debating about adding a link to the docs: https://kudu.apache.org/releases/1.9.0/docs/developing.html#_jvm_based_integration_testing
Thoughts?
--
To view, visit http://gerrit.cloudera.org:8080/12318
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife9103557b30b4105ef57ed36a34f3c93ba2dc6d
Gerrit-Change-Number: 12318
Gerrit-PatchSet: 8
Gerrit-Owner: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 13 Mar 2019 13:54:44 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2411: Example integration test using KuduMiniCluster
Posted by "Brian McDevitt (Code Review)" <ge...@cloudera.org>.
Brian McDevitt has posted comments on this change. ( http://gerrit.cloudera.org:8080/12318 )
Change subject: KUDU-2411: Example integration test using KuduMiniCluster
......................................................................
Patch Set 1:
(1 comment)
A simple example of wiring it all together.
http://gerrit.cloudera.org:8080/#/c/12318/1/examples/java/java-example/pom.xml
File examples/java/java-example/pom.xml:
http://gerrit.cloudera.org:8080/#/c/12318/1/examples/java/java-example/pom.xml@76
PS1, Line 76: <version>1.9.0-SNAPSHOT</version>
I didn't update the other Java examples to the latest Kudu version.
--
To view, visit http://gerrit.cloudera.org:8080/12318
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife9103557b30b4105ef57ed36a34f3c93ba2dc6d
Gerrit-Change-Number: 12318
Gerrit-PatchSet: 1
Gerrit-Owner: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Wed, 30 Jan 2019 22:23:08 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2411: Example integration test using KuduMiniCluster
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has removed a vote on this change.
Change subject: KUDU-2411: Example integration test using KuduMiniCluster
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/12318
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ife9103557b30b4105ef57ed36a34f3c93ba2dc6d
Gerrit-Change-Number: 12318
Gerrit-PatchSet: 7
Gerrit-Owner: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] KUDU-2411: Example integration test using KuduMiniCluster
Posted by "Brian McDevitt (Code Review)" <ge...@cloudera.org>.
Brian McDevitt has posted comments on this change. ( http://gerrit.cloudera.org:8080/12318 )
Change subject: KUDU-2411: Example integration test using KuduMiniCluster
......................................................................
Patch Set 3:
(3 comments)
New changes are incoming.
http://gerrit.cloudera.org:8080/#/c/12318/3/examples/java/java-example/src/test/java/org/apache/kudu/examples/ExampleTest.java
File examples/java/java-example/src/test/java/org/apache/kudu/examples/ExampleTest.java:
PS3:
> Need a license header here.
Done
http://gerrit.cloudera.org:8080/#/c/12318/3/examples/java/java-example/src/test/java/org/apache/kudu/examples/ExampleTest.java@14
PS3, Line 14:
> Nit: got one extra line too many here.
Done
http://gerrit.cloudera.org:8080/#/c/12318/3/examples/java/java-example/src/test/java/org/apache/kudu/examples/ExampleTest.java@17
PS3, Line 17: public void testCreateExampleTable() throws KuduException {
> Don't you want to use the other functions you made available from the examp
Yes, eventually. This changeset was intended to be the smallest working example. I'd like to make more sophisticated test examples as a later patch.
--
To view, visit http://gerrit.cloudera.org:8080/12318
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife9103557b30b4105ef57ed36a34f3c93ba2dc6d
Gerrit-Change-Number: 12318
Gerrit-PatchSet: 3
Gerrit-Owner: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Fri, 01 Feb 2019 21:45:02 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2411: Example integration test using KuduMiniCluster
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12318 )
Change subject: KUDU-2411: Example integration test using KuduMiniCluster
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/12318/1/examples/java/java-example/pom.xml
File examples/java/java-example/pom.xml:
http://gerrit.cloudera.org:8080/#/c/12318/1/examples/java/java-example/pom.xml@85
PS1, Line 85:
I think we need to add junit as a test dependency such as:
<dependency>
<groupId>junit</groupId>
<artifactId>junit</artifactId>
<version>4.10</version>
<scope>test</scope>
</dependency>
http://gerrit.cloudera.org:8080/#/c/12318/1/examples/java/java-example/src/main/test/org/apache/kudu/examples/ITExample.java
File examples/java/java-example/src/main/test/org/apache/kudu/examples/ITExample.java:
PS1:
This file has to live in examples/java/java-example/src/test/java/org/apache/kudu/examples/ in order to be built by Maven
http://gerrit.cloudera.org:8080/#/c/12318/1/examples/java/java-example/src/main/test/org/apache/kudu/examples/ITExample.java@10
PS1, Line 10: ITExample
rename to ExampleTest so Maven Surefire will execute the test when we call "mvn test"... only certain class name patterns will work and *Test is one of them
--
To view, visit http://gerrit.cloudera.org:8080/12318
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife9103557b30b4105ef57ed36a34f3c93ba2dc6d
Gerrit-Change-Number: 12318
Gerrit-PatchSet: 1
Gerrit-Owner: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Thu, 31 Jan 2019 01:57:33 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2411: Example integration test using KuduMiniCluster
Posted by "Brian McDevitt (Code Review)" <ge...@cloudera.org>.
Hello Mike Percy, Kudu Jenkins, Adar Dembo, Grant Henke, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12318
to look at the new patch set (#11).
Change subject: KUDU-2411: Example integration test using KuduMiniCluster
......................................................................
KUDU-2411: Example integration test using KuduMiniCluster
Adds an example of using the Kudu binary Jar to execute integration tests
against a KuduMiniCluster.
Change-Id: Ife9103557b30b4105ef57ed36a34f3c93ba2dc6d
---
M examples/java/java-example/pom.xml
M examples/java/java-example/src/main/java/org/apache/kudu/examples/Example.java
A examples/java/java-example/src/test/java/org/apache/kudu/examples/ExampleTest.java
3 files changed, 87 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/18/12318/11
--
To view, visit http://gerrit.cloudera.org:8080/12318
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ife9103557b30b4105ef57ed36a34f3c93ba2dc6d
Gerrit-Change-Number: 12318
Gerrit-PatchSet: 11
Gerrit-Owner: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] KUDU-2411: Example integration test using KuduMiniCluster
Posted by "Brian McDevitt (Code Review)" <ge...@cloudera.org>.
Hello Mike Percy, Kudu Jenkins, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12318
to look at the new patch set (#2).
Change subject: KUDU-2411: Example integration test using KuduMiniCluster
......................................................................
KUDU-2411: Example integration test using KuduMiniCluster
Adds an example of using the Kudu binary Jar to execute integration tests
against a KuduMiniCluster.
Change-Id: Ife9103557b30b4105ef57ed36a34f3c93ba2dc6d
---
M examples/java/java-example/pom.xml
M examples/java/java-example/src/main/java/org/apache/kudu/examples/Example.java
A examples/java/java-example/src/test/java/org/apache/kudu/examples/ExampleTest.java
3 files changed, 56 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/18/12318/2
--
To view, visit http://gerrit.cloudera.org:8080/12318
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ife9103557b30b4105ef57ed36a34f3c93ba2dc6d
Gerrit-Change-Number: 12318
Gerrit-PatchSet: 2
Gerrit-Owner: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] KUDU-2411: Example integration test using KuduMiniCluster
Posted by "Brian McDevitt (Code Review)" <ge...@cloudera.org>.
Hello Mike Percy, Kudu Jenkins, Adar Dembo, Grant Henke, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12318
to look at the new patch set (#9).
Change subject: KUDU-2411: Example integration test using KuduMiniCluster
......................................................................
KUDU-2411: Example integration test using KuduMiniCluster
Adds an example of using the Kudu binary Jar to execute integration tests
against a KuduMiniCluster.
Change-Id: Ife9103557b30b4105ef57ed36a34f3c93ba2dc6d
---
M examples/java/java-example/pom.xml
M examples/java/java-example/src/main/java/org/apache/kudu/examples/Example.java
A examples/java/java-example/src/test/java/org/apache/kudu/examples/ExampleTest.java
3 files changed, 86 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/18/12318/9
--
To view, visit http://gerrit.cloudera.org:8080/12318
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ife9103557b30b4105ef57ed36a34f3c93ba2dc6d
Gerrit-Change-Number: 12318
Gerrit-PatchSet: 9
Gerrit-Owner: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] KUDU-2411: Example integration test using KuduMiniCluster
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12318 )
Change subject: KUDU-2411: Example integration test using KuduMiniCluster
......................................................................
Patch Set 5:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12318/5/examples/java/java-example/src/test/java/org/apache/kudu/examples/ExampleTest.java
File examples/java/java-example/src/test/java/org/apache/kudu/examples/ExampleTest.java:
http://gerrit.cloudera.org:8080/#/c/12318/5/examples/java/java-example/src/test/java/org/apache/kudu/examples/ExampleTest.java@30
PS5, Line 30: public KuduTestHarness harness = new KuduTestHarness();
I think for the purposes of an example you should vigorously and energetically document what's going on here
--
To view, visit http://gerrit.cloudera.org:8080/12318
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife9103557b30b4105ef57ed36a34f3c93ba2dc6d
Gerrit-Change-Number: 12318
Gerrit-PatchSet: 5
Gerrit-Owner: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Thu, 07 Feb 2019 23:45:23 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2411: Example integration test using KuduMiniCluster
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12318 )
Change subject: KUDU-2411: Example integration test using KuduMiniCluster
......................................................................
Patch Set 10: Code-Review+1
(1 comment)
ok looks good with a minor suggestion
http://gerrit.cloudera.org:8080/#/c/12318/10/examples/java/java-example/src/test/java/org/apache/kudu/examples/ExampleTest.java
File examples/java/java-example/src/test/java/org/apache/kudu/examples/ExampleTest.java:
http://gerrit.cloudera.org:8080/#/c/12318/10/examples/java/java-example/src/test/java/org/apache/kudu/examples/ExampleTest.java@30
PS10, Line 30: https://kudu.apache.org/releases/1.9.0/docs/developing.html#_jvm_based_integration_testing
How about a link to the latest version? https://kudu.apache.org/docs/developing.html#_jvm_based_integration_testing
--
To view, visit http://gerrit.cloudera.org:8080/12318
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife9103557b30b4105ef57ed36a34f3c93ba2dc6d
Gerrit-Change-Number: 12318
Gerrit-PatchSet: 10
Gerrit-Owner: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Thu, 14 Mar 2019 01:35:01 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2411: Example integration test using KuduMiniCluster
Posted by "Brian McDevitt (Code Review)" <ge...@cloudera.org>.
Hello Mike Percy, Kudu Jenkins, Adar Dembo, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12318
to look at the new patch set (#4).
Change subject: KUDU-2411: Example integration test using KuduMiniCluster
......................................................................
KUDU-2411: Example integration test using KuduMiniCluster
Adds an example of using the Kudu binary Jar to execute integration tests
against a KuduMiniCluster.
Change-Id: Ife9103557b30b4105ef57ed36a34f3c93ba2dc6d
---
M examples/java/java-example/pom.xml
M examples/java/java-example/src/main/java/org/apache/kudu/examples/Example.java
A examples/java/java-example/src/test/java/org/apache/kudu/examples/ExampleTest.java
3 files changed, 72 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/18/12318/4
--
To view, visit http://gerrit.cloudera.org:8080/12318
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ife9103557b30b4105ef57ed36a34f3c93ba2dc6d
Gerrit-Change-Number: 12318
Gerrit-PatchSet: 4
Gerrit-Owner: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] KUDU-2411: Example integration test using KuduMiniCluster
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12318 )
Change subject: KUDU-2411: Example integration test using KuduMiniCluster
......................................................................
Patch Set 1:
Looks good as a minimal start. Perhaps we should publish a 1.8.0 version of the binaries so we can commit with a real release version. We can think about that once the publishing code gets done.
--
To view, visit http://gerrit.cloudera.org:8080/12318
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife9103557b30b4105ef57ed36a34f3c93ba2dc6d
Gerrit-Change-Number: 12318
Gerrit-PatchSet: 1
Gerrit-Owner: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Wed, 30 Jan 2019 23:45:45 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2411: Example integration test using KuduMiniCluster
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12318 )
Change subject: KUDU-2411: Example integration test using KuduMiniCluster
......................................................................
Patch Set 3:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/12318/3/examples/java/java-example/src/test/java/org/apache/kudu/examples/ExampleTest.java
File examples/java/java-example/src/test/java/org/apache/kudu/examples/ExampleTest.java:
PS3:
Need a license header here.
http://gerrit.cloudera.org:8080/#/c/12318/3/examples/java/java-example/src/test/java/org/apache/kudu/examples/ExampleTest.java@14
PS3, Line 14:
Nit: got one extra line too many here.
http://gerrit.cloudera.org:8080/#/c/12318/3/examples/java/java-example/src/test/java/org/apache/kudu/examples/ExampleTest.java@17
PS3, Line 17: public void testCreateExampleTable() throws KuduException {
Don't you want to use the other functions you made available from the example? To do some inserting and scanning?
--
To view, visit http://gerrit.cloudera.org:8080/12318
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife9103557b30b4105ef57ed36a34f3c93ba2dc6d
Gerrit-Change-Number: 12318
Gerrit-PatchSet: 3
Gerrit-Owner: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Fri, 01 Feb 2019 19:28:23 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2411: Example integration test using KuduMiniCluster
Posted by "Brian McDevitt (Code Review)" <ge...@cloudera.org>.
Brian McDevitt has posted comments on this change. ( http://gerrit.cloudera.org:8080/12318 )
Change subject: KUDU-2411: Example integration test using KuduMiniCluster
......................................................................
Patch Set 7:
Looks like a flaky test:
http://jenkins.kudu.apache.org/job/kudu-gerrit/16694/BUILD_TYPE=DEBUG/testReport/(root)/ToolTestKerberosParameterized_ToolTestKerberosParameterized/
--
To view, visit http://gerrit.cloudera.org:8080/12318
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife9103557b30b4105ef57ed36a34f3c93ba2dc6d
Gerrit-Change-Number: 12318
Gerrit-PatchSet: 7
Gerrit-Owner: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Fri, 08 Mar 2019 15:45:36 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2411: Example integration test using KuduMiniCluster
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12318 )
Change subject: KUDU-2411: Example integration test using KuduMiniCluster
......................................................................
Patch Set 3: Code-Review+1
I think we should wait to merge until usable jars are published.
--
To view, visit http://gerrit.cloudera.org:8080/12318
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife9103557b30b4105ef57ed36a34f3c93ba2dc6d
Gerrit-Change-Number: 12318
Gerrit-PatchSet: 3
Gerrit-Owner: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Thu, 31 Jan 2019 20:55:55 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2411: Example integration test using KuduMiniCluster
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12318 )
Change subject: KUDU-2411: Example integration test using KuduMiniCluster
......................................................................
Patch Set 8:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12318/8/examples/java/java-example/src/test/java/org/apache/kudu/examples/ExampleTest.java
File examples/java/java-example/src/test/java/org/apache/kudu/examples/ExampleTest.java:
http://gerrit.cloudera.org:8080/#/c/12318/8/examples/java/java-example/src/test/java/org/apache/kudu/examples/ExampleTest.java@28
PS8, Line 28: * An example integration test class that spins up a local Kudu cluster.
> I was debating about adding a link to the docs: https://kudu.apache.org/rel
I like the idea of a link. Duplicating the docs means one of them is likely to get out of sync.
--
To view, visit http://gerrit.cloudera.org:8080/12318
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife9103557b30b4105ef57ed36a34f3c93ba2dc6d
Gerrit-Change-Number: 12318
Gerrit-PatchSet: 8
Gerrit-Owner: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 13 Mar 2019 13:55:49 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2411: Example integration test using KuduMiniCluster
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12318 )
Change subject: KUDU-2411: Example integration test using KuduMiniCluster
......................................................................
Patch Set 7:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12318/5/examples/java/java-example/src/test/java/org/apache/kudu/examples/ExampleTest.java
File examples/java/java-example/src/test/java/org/apache/kudu/examples/ExampleTest.java:
http://gerrit.cloudera.org:8080/#/c/12318/5/examples/java/java-example/src/test/java/org/apache/kudu/examples/ExampleTest.java@30
PS5, Line 30: public KuduTestHarness harness = new KuduTestHarness();
> I think for the purposes of an example you should vigorously and energetica
At a minimum, let's copy the comments from the documentation found here: https://kudu.apache.org/docs/developing.html#_using_the_kudu_binary_test_jar
--
To view, visit http://gerrit.cloudera.org:8080/12318
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife9103557b30b4105ef57ed36a34f3c93ba2dc6d
Gerrit-Change-Number: 12318
Gerrit-PatchSet: 7
Gerrit-Owner: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 13 Mar 2019 00:42:38 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2411: Example integration test using KuduMiniCluster
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12318 )
Change subject: KUDU-2411: Example integration test using KuduMiniCluster
......................................................................
Patch Set 7: Verified+1 Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/12318
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife9103557b30b4105ef57ed36a34f3c93ba2dc6d
Gerrit-Change-Number: 12318
Gerrit-PatchSet: 7
Gerrit-Owner: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Fri, 08 Mar 2019 15:57:25 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2411: Example integration test using KuduMiniCluster
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12318 )
Change subject: KUDU-2411: Example integration test using KuduMiniCluster
......................................................................
Patch Set 5:
(1 comment)
I temporarily added the snapshot repo for testing purposes.
http://gerrit.cloudera.org:8080/#/c/12318/4/examples/java/java-example/src/test/java/org/apache/kudu/examples/ExampleTest.java
File examples/java/java-example/src/test/java/org/apache/kudu/examples/ExampleTest.java:
http://gerrit.cloudera.org:8080/#/c/12318/4/examples/java/java-example/src/test/java/org/apache/kudu/examples/ExampleTest.java@33
PS4, Line 33: public void testCreateExampleTable() throws KuduException {
We may want to add a log4j.properties file to reduce the stdout noise.
--
To view, visit http://gerrit.cloudera.org:8080/12318
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife9103557b30b4105ef57ed36a34f3c93ba2dc6d
Gerrit-Change-Number: 12318
Gerrit-PatchSet: 5
Gerrit-Owner: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Thu, 07 Feb 2019 22:36:43 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2411: Example integration test using KuduMiniCluster
Posted by "Brian McDevitt (Code Review)" <ge...@cloudera.org>.
Hello Mike Percy, Kudu Jenkins, Adar Dembo, Grant Henke, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12318
to look at the new patch set (#8).
Change subject: KUDU-2411: Example integration test using KuduMiniCluster
......................................................................
KUDU-2411: Example integration test using KuduMiniCluster
Adds an example of using the Kudu binary Jar to execute integration tests
against a KuduMiniCluster.
Change-Id: Ife9103557b30b4105ef57ed36a34f3c93ba2dc6d
---
M examples/java/java-example/pom.xml
M examples/java/java-example/src/main/java/org/apache/kudu/examples/Example.java
A examples/java/java-example/src/test/java/org/apache/kudu/examples/ExampleTest.java
3 files changed, 84 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/18/12318/8
--
To view, visit http://gerrit.cloudera.org:8080/12318
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ife9103557b30b4105ef57ed36a34f3c93ba2dc6d
Gerrit-Change-Number: 12318
Gerrit-PatchSet: 8
Gerrit-Owner: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] KUDU-2411: Example integration test using KuduMiniCluster
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12318 )
Change subject: KUDU-2411: Example integration test using KuduMiniCluster
......................................................................
Patch Set 11: Verified+1 Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12318
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife9103557b30b4105ef57ed36a34f3c93ba2dc6d
Gerrit-Change-Number: 12318
Gerrit-PatchSet: 11
Gerrit-Owner: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Thu, 14 Mar 2019 14:28:12 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2411: Example integration test using KuduMiniCluster
Posted by "Brian McDevitt (Code Review)" <ge...@cloudera.org>.
Hello Mike Percy, Kudu Jenkins, Adar Dembo, Grant Henke, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12318
to look at the new patch set (#6).
Change subject: KUDU-2411: Example integration test using KuduMiniCluster
......................................................................
KUDU-2411: Example integration test using KuduMiniCluster
Adds an example of using the Kudu binary Jar to execute integration tests
against a KuduMiniCluster.
Change-Id: Ife9103557b30b4105ef57ed36a34f3c93ba2dc6d
---
M examples/java/java-example/pom.xml
M examples/java/java-example/src/main/java/org/apache/kudu/examples/Example.java
A examples/java/java-example/src/test/java/org/apache/kudu/examples/ExampleTest.java
3 files changed, 76 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/18/12318/6
--
To view, visit http://gerrit.cloudera.org:8080/12318
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ife9103557b30b4105ef57ed36a34f3c93ba2dc6d
Gerrit-Change-Number: 12318
Gerrit-PatchSet: 6
Gerrit-Owner: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] KUDU-2411: Example integration test using KuduMiniCluster
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12318 )
Change subject: KUDU-2411: Example integration test using KuduMiniCluster
......................................................................
Patch Set 3: Code-Review+1
Agreed w/ Grant
--
To view, visit http://gerrit.cloudera.org:8080/12318
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife9103557b30b4105ef57ed36a34f3c93ba2dc6d
Gerrit-Change-Number: 12318
Gerrit-PatchSet: 3
Gerrit-Owner: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Fri, 01 Feb 2019 19:24:54 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2411: Example integration test using KuduMiniCluster
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12318 )
Change subject: KUDU-2411: Example integration test using KuduMiniCluster
......................................................................
Patch Set 9:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12318/9/examples/java/java-example/src/test/java/org/apache/kudu/examples/ExampleTest.java
File examples/java/java-example/src/test/java/org/apache/kudu/examples/ExampleTest.java:
http://gerrit.cloudera.org:8080/#/c/12318/9/examples/java/java-example/src/test/java/org/apache/kudu/examples/ExampleTest.java@30
PS9, Line 30: * @see <a href="https://kudu.apache.org/releases/1.9.0/docs/developing.html#_jvm_based_integration_testing">JVM Testing Docs</a>
Not sure @see is appropriate since this isn't linking to another method.
I think you could just type out " See the JVM Testing Docs for more details" (and link the JVM Testing Docs).
--
To view, visit http://gerrit.cloudera.org:8080/12318
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife9103557b30b4105ef57ed36a34f3c93ba2dc6d
Gerrit-Change-Number: 12318
Gerrit-PatchSet: 9
Gerrit-Owner: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 13 Mar 2019 16:38:26 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2411: Example integration test using KuduMiniCluster
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has uploaded a new patch set (#5) to the change originally created by Brian McDevitt. ( http://gerrit.cloudera.org:8080/12318 )
Change subject: KUDU-2411: Example integration test using KuduMiniCluster
......................................................................
KUDU-2411: Example integration test using KuduMiniCluster
Adds an example of using the Kudu binary Jar to execute integration tests
against a KuduMiniCluster.
Change-Id: Ife9103557b30b4105ef57ed36a34f3c93ba2dc6d
---
M examples/java/java-example/pom.xml
M examples/java/java-example/src/main/java/org/apache/kudu/examples/Example.java
A examples/java/java-example/src/test/java/org/apache/kudu/examples/ExampleTest.java
3 files changed, 80 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/18/12318/5
--
To view, visit http://gerrit.cloudera.org:8080/12318
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ife9103557b30b4105ef57ed36a34f3c93ba2dc6d
Gerrit-Change-Number: 12318
Gerrit-PatchSet: 5
Gerrit-Owner: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>