[GitHub] [hbase] saintstack commented on issue #1311: HBASE-23984 [Flakey Tests] TestMasterAbortAndRSGotKilled fails in tea…

[GitBox <gi...@apache.org>]

saintstack commented on issue #1311: HBASE-23984 [Flakey Tests] TestMasterAbortAndRSGotKilled fails in tea…
URL: https://github.com/apache/hbase/pull/1311#issuecomment-601352676
 
 
   Updated the changeset comment:
   ```
   
   
       HBASE-23984 [Flakey Tests] TestMasterAbortAndRSGotKilled fails in teardown
   
       hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
        Change parameter name and add javadoc to make it more clear what the
        param actually is.
   
       hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/handler/AssignRegionHandler.java
        Move postOpenDeployTasks so if it fails to talk to the Master -- which
        can happen on cluster shutdown -- then we will do cleanup of state;
        without this the RS can get stuck and won't go down.
   
       hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/handler/CloseRegionHandler.java
        Add handleException so CRH looks more like UnassignRegionHandler and
        AssignRegionHandler around exception handling. Add a bit of doc on
        why CRH.
   
       hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/handler/UnassignRegionHandler.java
        Right shift most of the body of process so can add in a finally
        that cleans up rs.getRegionsInTransitionInRS is on exception
        (otherwise outstanding entries can stop a RS going down on cluster
        shutdown)
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services