You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "HyukjinKwon (via GitHub)" <gi...@apache.org> on 2023/08/21 01:35:35 UTC

[GitHub] [spark] HyukjinKwon commented on a diff in pull request #42548: [WIP][SPARK-44750][PYTHON][CONNECT] Apply configuration to sparksession during creation

HyukjinKwon commented on code in PR #42548:
URL: https://github.com/apache/spark/pull/42548#discussion_r1299494819


##########
python/pyspark/sql/tests/connect/test_connect_basic.py:
##########
@@ -3347,6 +3347,22 @@ def test_can_create_multiple_sessions_to_different_remotes(self):
             self.assertIn("Create a new SparkSession is only supported with SparkConnect.", str(e))
 
 
+class SparkConnectSessionWithOptionsTest(ReusedConnectTestCase):
+    def setUp(self) -> None:
+        self.spark = (
+            PySparkSession.builder.config("spark.sql.adaptive.enabled", False)

Review Comment:
   I think you can just set any config like `config("a", "b")` and `spark.conf.get("a") == "b"`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org