You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by tillrohrmann <gi...@git.apache.org> on 2018/02/12 00:01:44 UTC

[GitHub] flink pull request #5457: [FLINK-8637] [flip6] Use JobManagerSharedServices ...

GitHub user tillrohrmann opened a pull request:

    https://github.com/apache/flink/pull/5457

    [FLINK-8637] [flip6] Use JobManagerSharedServices to pass in services to JobMaster

    ## What is the purpose of the change
    
    Pass a JobManagerSharedServices instance to the JobMaster instead of the
    each service individually.
    
    This PR is based on #5443.
    
    ## Verifying this change
    
    This change is a trivial rework / code cleanup without any test coverage.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
      - The S3 file system connector: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not applicable)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/flink jobManagerSharedServices

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5457.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5457
    
----
commit 7ef623662d9fe78a3ba19fdad90b67e8b3ad848d
Author: Till Rohrmann <tr...@...>
Date:   2018-02-09T13:07:31Z

    [FLINK-8626] Introduce BackPressureStatsTracker interface
    
    Renames BackPressureStatsTracker into BackPressureStatsTrackerImpl and introduce
    a BackPressureStatsTracker interface. This will make testing easier when we don't
    have to set up all the different components.

commit 358750d2ace5feab4d4c29c92167b0a8a663fe49
Author: Till Rohrmann <tr...@...>
Date:   2018-02-10T22:26:51Z

    fixup! [FLINK-8626] Introduce BackPressureStatsTracker interface

commit d91b44af0f46c2b1fd6cb909244e0c5666cee43b
Author: Till Rohrmann <tr...@...>
Date:   2018-02-11T23:51:48Z

    [FLINK-8637] [flip6] Use JobManagerSharedServices to pass in services to JobMaster
    
    Pass a JobManagerSharedServices instance to the JobMaster instead of the
    each service individually.

----


---

[GitHub] flink issue #5457: [FLINK-8637] [flip6] Use JobManagerSharedServices to pass...

Posted by tillrohrmann <gi...@git.apache.org>.

Github user tillrohrmann commented on the issue:

    https://github.com/apache/flink/pull/5457
  
    Merging this PR.


---

[GitHub] flink pull request #5457: [FLINK-8637] [flip6] Use JobManagerSharedServices ...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/5457


---