You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "VVKot (via GitHub)" <gi...@apache.org> on 2026/10/11 13:31:21 UTC
[PR] test: sample current-process RSS before query execution [datafusion]
VVKot opened a new pull request, #26208:
URL: https://github.com/apache/datafusion/pull/26208
## Which issue does this PR close?
Local reproduction of a zero-RSS memory-validation failure. Depends on the window-expression lint prerequisite: https://github.com/apache/datafusion/pull/26207.
## Rationale for this change
A short query can finish before the asynchronous RSS monitor starts, leaving max_rss at zero and failing the memory-limit validation. System::new_all also gathers information unrelated to the current process.
## What changes are included in this PR?
Capture current-process memory before running the query, initialize the maximum from that sample, and reuse the same System in the monitor. Both refreshes exclude task enumeration. Memory thresholds are unchanged.
## What is the testing strategy for this PR?
The previously failing sort_with_mem_limit_1_runner now passes. The existing memory_limit_validation_runner_works_runner still rejects its impossible 20 MB cap. The core integration suite passed 1,227 tests with one ignored. The extended workspace run is in progress.
## Are there any user-facing changes?
None; this changes test infrastructure.
AI-assisted contribution authored with Codex.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] test: sample current-process RSS before query execution [datafusion]
Posted by "VVKot (via GitHub)" <gi...@apache.org>.
VVKot closed pull request #26208: test: sample current-process RSS before query execution
URL: https://github.com/apache/datafusion/pull/26208
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] test: sample current-process RSS before query execution [datafusion]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #26208:
URL: https://github.com/apache/datafusion/pull/26208#issuecomment-6109777457
## [Codecov](https://app.codecov.io/gh/apache/datafusion/pull/26208?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 82.80%. Comparing base ([`75ddead`](https://app.codecov.io/gh/apache/datafusion/commit/75ddead2b765ff6c574c4cc989538fabcf250c9f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`f15043c`](https://app.codecov.io/gh/apache/datafusion/commit/f15043c78f6a69205975b7daaf2e29349e5807c1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on main.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #26208 +/- ##
==========================================
- Coverage 82.80% 82.80% -0.01%
==========================================
Files 1149 1149
Lines 452205 452205
Branches 452205 452205
==========================================
- Hits 374458 374448 -10
- Misses 54950 54958 +8
- Partials 22797 22799 +2
```
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/datafusion/pull/26208?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org