You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by "scal-csimon (via GitHub)" <gi...@apache.org> on 2025/12/16 01:06:46 UTC
[PR] Add Displayname in web.xml [guacamole-client]
scal-csimon opened a new pull request, #1138:
URL: https://github.com/apache/guacamole-client/pull/1138
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Displayname in web.xml [guacamole-client]
Posted by "adb014 (via GitHub)" <gi...@apache.org>.
adb014 commented on PR #1138:
URL: https://github.com/apache/guacamole-client/pull/1138#issuecomment-5423015303
@necouchman Do you want this trivial change ? If so I'll create the jira ticket, rebase it against staging1.6.1 and try to get it closed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Displayname in web.xml [guacamole-client]
Posted by "adb014 (via GitHub)" <gi...@apache.org>.
adb014 commented on PR #1138:
URL: https://github.com/apache/guacamole-client/pull/1138#issuecomment-5438294093
In a Tomcat application, I'm not even sure where "<display-name>" is even used. Briefly, testing this it didn't seem to change anything... So, I'd say unless the original author steps up and says why they want this, this should be dropped.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Displayname in web.xml [guacamole-client]
Posted by "necouchman (via GitHub)" <gi...@apache.org>.
necouchman commented on PR #1138:
URL: https://github.com/apache/guacamole-client/pull/1138#issuecomment-3658457066
@scal-csimon Thanks for the contribution. In order to consider and move forward with this, you will first need to:
* Get a [Jira](https://issues.apache.org/jira/browse/GUACAMOLE) account and create a Jira issue for this, describing the motivation behind this change.
* Tag both your commit message and the pull request with the Jira issue (`GUACAMOLE-0000:`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Displayname in web.xml [guacamole-client]
Posted by "necouchman (via GitHub)" <gi...@apache.org>.
necouchman commented on PR #1138:
URL: https://github.com/apache/guacamole-client/pull/1138#issuecomment-5431513697
@adb014 I don't particularly care much one way or the other. If it's a useful thing to do, then, by all means, put in the Jira issue and the updated PR. It isn't something that I've ever run into needing, so I'm not entirely sure what the need is and we can also probably just close it and move on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org