[GitHub] astahlman opened a new pull request #4758: [AIRFLOW-3940] Migrate Hive Metastore plugin to FAB

[GitBox <gi...@apache.org>]

astahlman opened a new pull request #4758: [AIRFLOW-3940] Migrate Hive Metastore plugin to FAB
URL: https://github.com/apache/airflow/pull/4758
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [ X ] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-3940
     - In case you are fixing a typo in the documentation you can prepend your commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
   
   ### Description
   
   - [ X ] Here are some details about my PR, including screenshots of any UI changes:
   
   Migrate this plugin from Flask-Admin to Flask-AppBuilder. I tested the
   plugin by:
   
   1. Creating a dummy table named `foo` with a single column in a local Hive cluster
   2. Configuring the connections `metastore_default` (Thrift) and `metastore_mysql` (MySQL)
   3. Symlink `airflow/contrib/plugins/metastore_browser/` to `$AIRFLOW_HOME/plugins/`
   
   ![Screencast of usage](https://user-images.githubusercontent.com/1173394/53291981-9f4d0300-3770-11e9-978d-5c540b2fe1e9.gif)
   
   
   ### Tests
   
   - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   It'd be nice to automate this tests, but I decided not to invest the
   effort given that there's some discussion of removing this plugin
   entirely.
   
   ### Commits
   
   - [ X ] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes how to use it.
     - When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
   
   ### Code Quality
   
   - [ X ] Passes `flake8`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services