You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Hari Shreedharan <hs...@cloudera.com> on 2012/12/18 09:21:37 UTC
Review Request: SQOOP-789. Fix Hadoop-1 build
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8666/
-----------------------------------------------------------
Review request for Sqoop.
Description
-------
Fix Hadoop-1 build
This addresses bug SQOOP-789.
https://issues.apache.org/jira/browse/SQOOP-789
Diffs
-----
execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor.java 9714167
execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestSqoopOutputFormatLoadExecutor.java 4234adf
Diff: https://reviews.apache.org/r/8666/diff/
Testing
-------
Did full build, both complete successfully.
Thanks,
Hari Shreedharan
Re: Review Request: SQOOP-789. Fix Hadoop-1 build
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8666/#review14637
-----------------------------------------------------------
Ship it!
This doesn't seem to me as clean solution, however I've looked into hadoop source code and I currently do not see better solution as the underlying implementation changed a lot. That being said, I'm personally fine with committing this at the moment and try to "improve" it later.
Thank you for your hard work Hari!
Jarcec
- Jarek Cecho
On Dec. 18, 2012, 8:21 a.m., Hari Shreedharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8666/
> -----------------------------------------------------------
>
> (Updated Dec. 18, 2012, 8:21 a.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> Fix Hadoop-1 build
>
>
> This addresses bug SQOOP-789.
> https://issues.apache.org/jira/browse/SQOOP-789
>
>
> Diffs
> -----
>
> execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor.java 9714167
> execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestSqoopOutputFormatLoadExecutor.java 4234adf
>
> Diff: https://reviews.apache.org/r/8666/diff/
>
>
> Testing
> -------
>
> Did full build, both complete successfully.
>
>
> Thanks,
>
> Hari Shreedharan
>
>