You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2023/05/30 20:44:27 UTC

[GitHub] [incubator-pekko-connectors] pjfanning opened a new pull request, #130: More scala3 work (cassandra / azure)

pjfanning opened a new pull request, #130:
URL: https://github.com/apache/incubator-pekko-connectors/pull/130

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


[GitHub] [incubator-pekko-connectors] pjfanning merged pull request #130: More scala3 work (cassandra / azure)

Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning merged PR #130:
URL: https://github.com/apache/incubator-pekko-connectors/pull/130


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


[GitHub] [incubator-pekko-connectors] nvollmar commented on a diff in pull request #130: More scala3 work (cassandra / azure)

Posted by "nvollmar (via GitHub)" <gi...@apache.org>.
nvollmar commented on code in PR #130:
URL: https://github.com/apache/incubator-pekko-connectors/pull/130#discussion_r1211093040


##########
cassandra/src/test/scala/org/apache/pekko/stream/connectors/cassandra/javadsl/CassandraSessionSpec.scala:
##########
@@ -38,7 +38,7 @@ import scala.concurrent.duration._
 
 final class CassandraSessionSpec extends CassandraSpecBase(ActorSystem("CassandraSessionSpec")) {
 
-  val log = Logging(system, this.getClass)
+  val log = Logging(system, classOf[CassandraSessionSpec])

Review Comment:
   ```Logging(system, getClass)(LogSource.fromClass)``` would also work



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org