You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/02/13 06:25:29 UTC
[GitHub] asdf2014 commented on issue #7059: Use only
com.google.errorprone.annotations.concurrent.GuardedBy,
not javax.annotations.concurrent.GuardedBy
asdf2014 commented on issue #7059: Use only com.google.errorprone.annotations.concurrent.GuardedBy, not javax.annotations.concurrent.GuardedBy
URL: https://github.com/apache/incubator-druid/issues/7059#issuecomment-463075783
> There are a couple more annotations called `@GuardedBy`, including `javax.annotation.concurrent.GuardedBy` and`org.checkerframework.checker.lock.qual.GuardedBy`. The check recognizes those versions of the annotation, but we recommend using `com.google.errorprone.annotations.concurrent.GuardedBy`.
Hi, @leventov. I found the Error Prone's [doc](https://github.com/google/error-prone/blob/master/docs/bugpattern/GuardedBy.md#guardedby), from which we don't know why it's recommended to use `com.google.errorprone.annotations.concurrent.GuardedBy`, but Error Prone does recognize those versions of `GuardedBy`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org