You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/10/27 20:58:57 UTC
[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #2115: Store artifacts durring build
Ouss4 commented on a change in pull request #2115:
URL: https://github.com/apache/incubator-nuttx/pull/2115#discussion_r513026036
##########
File path: tools/testbuild.sh
##########
@@ -238,6 +246,11 @@ function configure {
function build {
echo " Building NuttX..."
makefunc
+ if [ ${SAVEARTIFACTS} -eq 1 ]; then
+ artifactconfigdir=$ARTIFACTDIR/$(echo $config | sed "s/:/\//")/
+ mkdir -p $artifactconfigdir
+ cp $(${MAKE} execname) $artifactconfigdir
Review comment:
For most, we have hard-coded names that has never changed.
##########
File path: tools/testbuild.sh
##########
@@ -238,6 +246,11 @@ function configure {
function build {
echo " Building NuttX..."
makefunc
+ if [ ${SAVEARTIFACTS} -eq 1 ]; then
+ artifactconfigdir=$ARTIFACTDIR/$(echo $config | sed "s/:/\//")/
+ mkdir -p $artifactconfigdir
+ cp $(${MAKE} execname) $artifactconfigdir
Review comment:
For most, we have hard-coded names that have never changed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org