[jira] [Commented] (TC-533) DS SSL key apis needs to have tenancy check in place

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TC-533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16131291#comment-16131291 ] 

ASF GitHub Bot commented on TC-533:
-----------------------------------

GitHub user nir-sopher opened a pull request:

    https://github.com/apache/incubator-trafficcontrol/pull/832

    [TC-533] ssl_keys - tenancy checks

    Adding tenancy checks to the DS ssl_keys API.
    Still with limited testing

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/nir-sopher/incubator-trafficcontrol tc-533

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-trafficcontrol/pull/832.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #832
    
----
commit f21c76a4aae8ce83e0f364701e87897ffa5c4249
Author: nir-sopher <ni...@qwilt.com>
Date:   2017-08-13T16:01:38Z

    ssl_keys - tenancy checks

----


> DS SSL key apis needs to have tenancy check in place
> ----------------------------------------------------
>
>                 Key: TC-533
>                 URL: https://issues.apache.org/jira/browse/TC-533
>             Project: Traffic Control
>          Issue Type: Bug
>          Components: Traffic Ops API
>    Affects Versions: 2.1.0
>            Reporter: Jeremy Mitchell
>            Assignee: Nir Sopher
>
> Tenancy was introduced in 2.1, however, by default it is turned off via the use_tenancy parameter but when activated it is used to limit the scope of delivery services that a user can act on.
> The following APIs needs to check tenancy to ensure users cannot act on ds's that they don't have access to.
> get("/api/$version/deliveryservices/xmlId/#xmlid/sslkeys
> post("/api/$version/deliveryservices/sslkeys/generate
> post("/api/$version/deliveryservices/sslkeys/add
> get("/api/$version/deliveryservices/xmlId/:xmlid/sslkeys/delete



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)