[GitHub] [shardingsphere] jingshanglu commented on a diff in pull request #17904: Fix autocommit

[GitBox <gi...@apache.org>]

jingshanglu commented on code in PR #17904:
URL: https://github.com/apache/shardingsphere/pull/17904#discussion_r880299125


##########
shardingsphere-proxy/shardingsphere-proxy-backend/src/main/java/org/apache/shardingsphere/proxy/backend/communication/jdbc/connection/JDBCBackendConnection.java:
##########
@@ -175,16 +175,12 @@ public void unmarkResourceInUse(final JDBCDatabaseCommunicationEngine databaseCo
     }
     
     @Override
-    public Void prepareForTaskExecution() throws BackendConnectionException {
+    public Void prepareForTaskExecution() throws SQLException {

Review Comment:
   I don't think it's necessary to use `BackendConnectionException` to wrap all of them. It's necessary to handle `BackendConnectionException ` where other calls are caused. In fact, it's `SQLException`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org