You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/11/06 09:44:09 UTC
[GitHub] [flink] danny0405 commented on a change in pull request #10096: [FLINK-14623][table-api] Add computed column information into TableSc…
danny0405 commented on a change in pull request #10096: [FLINK-14623][table-api] Add computed column information into TableSc…
URL: https://github.com/apache/flink/pull/10096#discussion_r342999265
##########
File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/api/TableSchema.java
##########
@@ -346,22 +318,137 @@ public static Builder builder() {
return new Builder();
}
+ //~ Tools ------------------------------------------------------------------
+
+ /**
+ * Tools method to transform arrays of table names and types
+ * into a {@link TableColumn} list.
+ */
+ private static List<TableColumn> getTableColumns(
Review comment:
This is a pure tool method which i prefer to make it static.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services