You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/06/23 13:40:23 UTC

[GitHub] [arrow-datafusion] Jimexist edited a comment on pull request #606: reuse alias map in aggregate logical planning and refactor position resolution

Jimexist edited a comment on pull request #606:
URL: https://github.com/apache/arrow-datafusion/pull/606#issuecomment-866845407


   > It looks like the PR stops (re)computing extract_aliases by doing so once and reusing the results
   
   yes
   
   > Thank you @Jimexist this looks like a nice cleanup -- can you confirm my understanding that this is a refactoring only (aka no behavior change)?
   
   yes and i believe all untouched unit tests and integration tests shall vet for that
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org