You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/12/03 06:27:20 UTC
[GitHub] [rocketmq] TakshakRamteke opened a new pull request #3575: Removing message filter impldev
TakshakRamteke opened a new pull request #3575:
URL: https://github.com/apache/rocketmq/pull/3575
**Make sure set the target branch to `develop`**
closes #3565
## What is the purpose of the change
Useless class file MessageFilterImpl
## Brief changelog
Removed the Useless class file MessageFilterImpl from examples/src/main/resources
## Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] yuz10 commented on a change in pull request #3575: Removing message filter impldev
Posted by GitBox <gi...@apache.org>.
yuz10 commented on a change in pull request #3575:
URL: https://github.com/apache/rocketmq/pull/3575#discussion_r763683370
##########
File path: example/src/main/resources/MessageFilterImpl.java
##########
@@ -1,39 +0,0 @@
-/**
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package org.apache.rocketmq.example.filter;
-
-import org.apache.rocketmq.common.filter.FilterContext;
-import org.apache.rocketmq.common.filter.MessageFilter;
-import org.apache.rocketmq.common.message.MessageExt;
-
-public class MessageFilterImpl implements MessageFilter {
Review comment:
Because org.apache.rocketmq.common.filter.MessageFilter is not used anywhere exept here, we have org.apache.rocketmq.store.MessageFilter, so org.apache.rocketmq.common.filter.MessageFilter can be deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] yuz10 commented on a change in pull request #3575: Removing message filter impldev
Posted by GitBox <gi...@apache.org>.
yuz10 commented on a change in pull request #3575:
URL: https://github.com/apache/rocketmq/pull/3575#discussion_r764588081
##########
File path: example/src/main/resources/MessageFilterImpl.java
##########
@@ -1,39 +0,0 @@
-/**
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package org.apache.rocketmq.example.filter;
-
-import org.apache.rocketmq.common.filter.FilterContext;
-import org.apache.rocketmq.common.filter.MessageFilter;
-import org.apache.rocketmq.common.message.MessageExt;
-
-public class MessageFilterImpl implements MessageFilter {
Review comment:
Ok, you can remove it later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] TakshakRamteke commented on a change in pull request #3575: Removing message filter impldev
Posted by GitBox <gi...@apache.org>.
TakshakRamteke commented on a change in pull request #3575:
URL: https://github.com/apache/rocketmq/pull/3575#discussion_r763759146
##########
File path: example/src/main/resources/MessageFilterImpl.java
##########
@@ -1,39 +0,0 @@
-/**
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package org.apache.rocketmq.example.filter;
-
-import org.apache.rocketmq.common.filter.FilterContext;
-import org.apache.rocketmq.common.filter.MessageFilter;
-import org.apache.rocketmq.common.message.MessageExt;
-
-public class MessageFilterImpl implements MessageFilter {
Review comment:
oh.. okay, should I do that in a different pr as the tittle for this one say's Removing MessageFilterImpl , I think i should what do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] yuz10 commented on a change in pull request #3575: Removing message filter impldev
Posted by GitBox <gi...@apache.org>.
yuz10 commented on a change in pull request #3575:
URL: https://github.com/apache/rocketmq/pull/3575#discussion_r763622677
##########
File path: example/src/main/resources/MessageFilterImpl.java
##########
@@ -1,39 +0,0 @@
-/**
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package org.apache.rocketmq.example.filter;
-
-import org.apache.rocketmq.common.filter.FilterContext;
-import org.apache.rocketmq.common.filter.MessageFilter;
-import org.apache.rocketmq.common.message.MessageExt;
-
-public class MessageFilterImpl implements MessageFilter {
Review comment:
the MessageFilter interface could also be removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] TakshakRamteke commented on a change in pull request #3575: Removing message filter impldev
Posted by GitBox <gi...@apache.org>.
TakshakRamteke commented on a change in pull request #3575:
URL: https://github.com/apache/rocketmq/pull/3575#discussion_r763678594
##########
File path: example/src/main/resources/MessageFilterImpl.java
##########
@@ -1,39 +0,0 @@
-/**
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package org.apache.rocketmq.example.filter;
-
-import org.apache.rocketmq.common.filter.FilterContext;
-import org.apache.rocketmq.common.filter.MessageFilter;
-import org.apache.rocketmq.common.message.MessageExt;
-
-public class MessageFilterImpl implements MessageFilter {
Review comment:
Could you please elaborate
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] guyinyou commented on pull request #3575: Removing message filter impldev
Posted by GitBox <gi...@apache.org>.
guyinyou commented on pull request #3575:
URL: https://github.com/apache/rocketmq/pull/3575#issuecomment-985371113
lgtm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] yuz10 merged pull request #3575: Removing message filter impldev
Posted by GitBox <gi...@apache.org>.
yuz10 merged pull request #3575:
URL: https://github.com/apache/rocketmq/pull/3575
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org