You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/08/24 23:37:40 UTC
[GitHub] [incubator-druid] SandishKumarHN commented on a change in pull
request #8394: 8156 : StructuralSearchInspection,
Prohibit check on Thread.getState()
SandishKumarHN commented on a change in pull request #8394: 8156 : StructuralSearchInspection, Prohibit check on Thread.getState()
URL: https://github.com/apache/incubator-druid/pull/8394#discussion_r317377461
##########
File path: .idea/inspectionProfiles/Druid.xml
##########
@@ -342,6 +342,9 @@
<ignored>
<option name="METHOD_MATCHER_CONFIG" value="java.io.PrintStream,println,java.io.PrintWriter,println,java.lang.System,identityHashCode,java.sql.PreparedStatement,set.*,java.sql.ResultSet,update.*,java.sql.SQLOutput,write.*,java.lang.Integer,compare.*,java.lang.Long,compare.*,java.lang.Short,compare,java.lang.Byte,compare,java.lang.Character,compare,java.lang.Boolean,compare,java.lang.Math,.*,java.lang.StrictMath,.*" />
</ignored>
+ <searchConfiguration name="Prohibit Thread.getState() != TERMINATED antipattern" text="while (firehose.getDelayedCloseExecutor().getState() != Thread.State.TERMINATED) { Thread.sleep(50); }" recursive="true" caseInsensitive="true" type="JAVA">
Review comment:
@gianm thanks for a quick review! made changes as per your suggestions
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org