You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/03/16 07:01:55 UTC

[GitHub] [iotdb] bigreybear opened a new pull request #5253: Enhance check statement before writing mlog

bigreybear opened a new pull request #5253:
URL: https://github.com/apache/iotdb/pull/5253


   Reason of the ISSUE:
   
   During recovery from mlog.bin, MManager::MLogWrite is not initialized since there is no need to write a new entry into mlog, which directly causes the NPE of this issue. This may be caused by nonstandard usage of Templates or originate from disharmonious implementation between MManager and TemplateManager. We will make a thorough refactor to these modules soon.
   
   To fix this issue, we enhanced the check statement before writing entry into mlog.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] HTHou merged pull request #5253: [IOTDB-2750] Enhance check statement before writing mlog

Posted by GitBox <gi...@apache.org>.

HTHou merged pull request #5253:
URL: https://github.com/apache/iotdb/pull/5253


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] coveralls commented on pull request #5253: [IOTDB-2750] Enhance check statement before writing mlog

Posted by GitBox <gi...@apache.org>.

coveralls commented on pull request #5253:
URL: https://github.com/apache/iotdb/pull/5253#issuecomment-1068860177


   
   [![Coverage Status](https://coveralls.io/builds/47408281/badge)](https://coveralls.io/builds/47408281)
   
   Coverage increased (+0.02%) to 65.368% when pulling **f8bb8104eed03849c27ab88b80d02f9edc25871c on bigreybear:i2750_master** into **5a88650415bf786ead97679874d8eea442835cf7 on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org