You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/09/13 05:41:46 UTC

[GitHub] [dubbo] DittoTool opened a new pull request #8784: Inefficient Usages of Java Collections

DittoTool opened a new pull request #8784:
URL: https://github.com/apache/dubbo/pull/8784

Hi,

We find that there are several inefficient usages of Java Collections:

1. The contains method is invoked upon a list object in a loop. We recommend replacing it with a HashSet.
2. Random access can occur at several LinkedList objects, which run in linear time complexity. We recommend replacing them with Arraylist objects.
3. There is no iteration occurring upon a LinkedHashMap and LinkedHashSet, thus the insertion order does not matter. We recommend replacing it with a HashMap and HashSet.
4. ArrayList is inserted before an iteration, while multiple memory reallocation might occur when the size of the list exceeds its capacity. We recommend replacing it with a LinkedList.

We discovered the above inefficient usage of containers by our tool Ditto. The patch is submitted. Could you please check and accept it? We have tested the patch on our PC. The patched program works well.

Bests

Ditto

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] mercyblitz merged pull request #8784: Inefficient Usages of Java Collections

Posted by GitBox <gi...@apache.org>.

mercyblitz merged pull request #8784:
URL: https://github.com/apache/dubbo/pull/8784


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8784: Inefficient Usages of Java Collections

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #8784:
URL: https://github.com/apache/dubbo/pull/8784#issuecomment-918779981


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8784?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#8784](https://codecov.io/gh/apache/dubbo/pull/8784?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2bb3ba8) into [3.0](https://codecov.io/gh/apache/dubbo/commit/5c2161aa0e9a073a51dd14e0c0edb36668d371a8?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5c2161a) will **decrease** coverage by `0.02%`.
   > The diff coverage is `52.94%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/8784/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/8784?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #8784      +/-   ##
   ============================================
   - Coverage     63.92%   63.89%   -0.03%     
   + Complexity      315      314       -1     
   ============================================
     Files          1156     1156              
     Lines         48702    48703       +1     
     Branches       7324     7324              
   ============================================
   - Hits          31134    31121      -13     
   - Misses        14175    14183       +8     
   - Partials       3393     3399       +6     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8784?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...figcenter/file/FileSystemDynamicConfiguration.java](https://codecov.io/gh/apache/dubbo/pull/8784/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vY29uZmlnL2NvbmZpZ2NlbnRlci9maWxlL0ZpbGVTeXN0ZW1EeW5hbWljQ29uZmlndXJhdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [.../apache/dubbo/config/bootstrap/DubboBootstrap.java](https://codecov.io/gh/apache/dubbo/pull/8784/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9ib290c3RyYXAvRHViYm9Cb290c3RyYXAuamF2YQ==) | `53.40% <ø> (ø)` | |
   | [...n/serialize/support/SerializableClassRegistry.java](https://codecov.io/gh/apache/dubbo/pull/8784/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vY29tbW9uL3NlcmlhbGl6ZS9zdXBwb3J0L1NlcmlhbGl6YWJsZUNsYXNzUmVnaXN0cnkuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...ate/endpoint/metadata/DubboReferencesMetadata.java](https://codecov.io/gh/apache/dubbo/pull/8784/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tc3ByaW5nLWJvb3QvZHViYm8tc3ByaW5nLWJvb3QtY29tcGF0aWJsZS9hY3R1YXRvci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vc3ByaW5nL2Jvb3QvYWN0dWF0ZS9lbmRwb2ludC9tZXRhZGF0YS9EdWJib1JlZmVyZW5jZXNNZXRhZGF0YS5qYXZh) | `5.55% <0.00%> (ø)` | |
   | [...factory/config/ServiceBeanIdConflictProcessor.java](https://codecov.io/gh/apache/dubbo/pull/8784/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tc3ByaW5nLWJvb3QvZHViYm8tc3ByaW5nLWJvb3QtY29tcGF0aWJsZS9hdXRvY29uZmlndXJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9zcHJpbmcvYm9vdC9iZWFucy9mYWN0b3J5L2NvbmZpZy9TZXJ2aWNlQmVhbklkQ29uZmxpY3RQcm9jZXNzb3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...apache/dubbo/common/extension/ExtensionLoader.java](https://codecov.io/gh/apache/dubbo/pull/8784/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vZXh0ZW5zaW9uL0V4dGVuc2lvbkxvYWRlci5qYXZh) | `81.71% <71.42%> (+0.23%)` | :arrow_up: |
   | [...c/cluster/router/mesh/rule/VsDestinationGroup.java](https://codecov.io/gh/apache/dubbo/pull/8784/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL21lc2gvcnVsZS9Wc0Rlc3RpbmF0aW9uR3JvdXAuamF2YQ==) | `100.00% <100.00%> (ø)` | |
   | [.../java/org/apache/dubbo/common/utils/TypeUtils.java](https://codecov.io/gh/apache/dubbo/pull/8784/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdXRpbHMvVHlwZVV0aWxzLmphdmE=) | `70.27% <100.00%> (ø)` | |
   | [...main/java/org/apache/dubbo/qos/textui/TLadder.java](https://codecov.io/gh/apache/dubbo/pull/8784/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcGx1Z2luL2R1YmJvLXFvcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcW9zL3RleHR1aS9UTGFkZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | |
   | [...va/org/apache/dubbo/registry/RegistryNotifier.java](https://codecov.io/gh/apache/dubbo/pull/8784/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9SZWdpc3RyeU5vdGlmaWVyLmphdmE=) | `87.17% <0.00%> (-12.83%)` | :arrow_down: |
   | ... and [14 more](https://codecov.io/gh/apache/dubbo/pull/8784/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8784?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8784?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [5c2161a...2bb3ba8](https://codecov.io/gh/apache/dubbo/pull/8784?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8784: Inefficient Usages of Java Collections

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #8784:
URL: https://github.com/apache/dubbo/pull/8784#issuecomment-918779981


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8784?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#8784](https://codecov.io/gh/apache/dubbo/pull/8784?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2bb3ba8) into [3.0](https://codecov.io/gh/apache/dubbo/commit/5c2161aa0e9a073a51dd14e0c0edb36668d371a8?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5c2161a) will **decrease** coverage by `0.00%`.
   > The diff coverage is `52.94%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/8784/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/8784?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #8784      +/-   ##
   ============================================
   - Coverage     63.92%   63.92%   -0.01%     
   + Complexity      315      314       -1     
   ============================================
     Files          1156     1156              
     Lines         48702    48703       +1     
     Branches       7324     7324              
   ============================================
     Hits          31134    31134              
   - Misses        14175    14177       +2     
   + Partials       3393     3392       -1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8784?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...figcenter/file/FileSystemDynamicConfiguration.java](https://codecov.io/gh/apache/dubbo/pull/8784/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vY29uZmlnL2NvbmZpZ2NlbnRlci9maWxlL0ZpbGVTeXN0ZW1EeW5hbWljQ29uZmlndXJhdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [.../apache/dubbo/config/bootstrap/DubboBootstrap.java](https://codecov.io/gh/apache/dubbo/pull/8784/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9ib290c3RyYXAvRHViYm9Cb290c3RyYXAuamF2YQ==) | `53.40% <ø> (ø)` | |
   | [...n/serialize/support/SerializableClassRegistry.java](https://codecov.io/gh/apache/dubbo/pull/8784/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vY29tbW9uL3NlcmlhbGl6ZS9zdXBwb3J0L1NlcmlhbGl6YWJsZUNsYXNzUmVnaXN0cnkuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...ate/endpoint/metadata/DubboReferencesMetadata.java](https://codecov.io/gh/apache/dubbo/pull/8784/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tc3ByaW5nLWJvb3QvZHViYm8tc3ByaW5nLWJvb3QtY29tcGF0aWJsZS9hY3R1YXRvci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vc3ByaW5nL2Jvb3QvYWN0dWF0ZS9lbmRwb2ludC9tZXRhZGF0YS9EdWJib1JlZmVyZW5jZXNNZXRhZGF0YS5qYXZh) | `5.55% <0.00%> (ø)` | |
   | [...factory/config/ServiceBeanIdConflictProcessor.java](https://codecov.io/gh/apache/dubbo/pull/8784/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tc3ByaW5nLWJvb3QvZHViYm8tc3ByaW5nLWJvb3QtY29tcGF0aWJsZS9hdXRvY29uZmlndXJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9zcHJpbmcvYm9vdC9iZWFucy9mYWN0b3J5L2NvbmZpZy9TZXJ2aWNlQmVhbklkQ29uZmxpY3RQcm9jZXNzb3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...apache/dubbo/common/extension/ExtensionLoader.java](https://codecov.io/gh/apache/dubbo/pull/8784/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vZXh0ZW5zaW9uL0V4dGVuc2lvbkxvYWRlci5qYXZh) | `81.71% <71.42%> (+0.23%)` | :arrow_up: |
   | [...c/cluster/router/mesh/rule/VsDestinationGroup.java](https://codecov.io/gh/apache/dubbo/pull/8784/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL21lc2gvcnVsZS9Wc0Rlc3RpbmF0aW9uR3JvdXAuamF2YQ==) | `100.00% <100.00%> (ø)` | |
   | [.../java/org/apache/dubbo/common/utils/TypeUtils.java](https://codecov.io/gh/apache/dubbo/pull/8784/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdXRpbHMvVHlwZVV0aWxzLmphdmE=) | `70.27% <100.00%> (ø)` | |
   | [...main/java/org/apache/dubbo/qos/textui/TLadder.java](https://codecov.io/gh/apache/dubbo/pull/8784/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcGx1Z2luL2R1YmJvLXFvcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcW9zL3RleHR1aS9UTGFkZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | |
   | [...ng/transport/dispatcher/all/AllChannelHandler.java](https://codecov.io/gh/apache/dubbo/pull/8784/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvZGlzcGF0Y2hlci9hbGwvQWxsQ2hhbm5lbEhhbmRsZXIuamF2YQ==) | `89.65% <0.00%> (-6.90%)` | :arrow_down: |
   | ... and [12 more](https://codecov.io/gh/apache/dubbo/pull/8784/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8784?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8784?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [5c2161a...2bb3ba8](https://codecov.io/gh/apache/dubbo/pull/8784?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] mercyblitz commented on pull request #8784: Inefficient Usages of Java Collections

Posted by GitBox <gi...@apache.org>.

mercyblitz commented on pull request #8784:
URL: https://github.com/apache/dubbo/pull/8784#issuecomment-918709633


   Please fix the checkstyle issue first, thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter commented on pull request #8784: Inefficient Usages of Java Collections

Posted by GitBox <gi...@apache.org>.

codecov-commenter commented on pull request #8784:
URL: https://github.com/apache/dubbo/pull/8784#issuecomment-918779981


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8784?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#8784](https://codecov.io/gh/apache/dubbo/pull/8784?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2bb3ba8) into [3.0](https://codecov.io/gh/apache/dubbo/commit/5c2161aa0e9a073a51dd14e0c0edb36668d371a8?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5c2161a) will **decrease** coverage by `0.16%`.
   > The diff coverage is `52.94%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/8784/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/8784?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #8784      +/-   ##
   ============================================
   - Coverage     63.92%   63.76%   -0.17%     
   + Complexity      315      313       -2     
   ============================================
     Files          1156     1156              
     Lines         48702    48656      -46     
     Branches       7324     7289      -35     
   ============================================
   - Hits          31134    31025     -109     
   - Misses        14175    14221      +46     
   - Partials       3393     3410      +17     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8784?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...figcenter/file/FileSystemDynamicConfiguration.java](https://codecov.io/gh/apache/dubbo/pull/8784/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vY29uZmlnL2NvbmZpZ2NlbnRlci9maWxlL0ZpbGVTeXN0ZW1EeW5hbWljQ29uZmlndXJhdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [.../apache/dubbo/config/bootstrap/DubboBootstrap.java](https://codecov.io/gh/apache/dubbo/pull/8784/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9ib290c3RyYXAvRHViYm9Cb290c3RyYXAuamF2YQ==) | `53.40% <ø> (ø)` | |
   | [...n/serialize/support/SerializableClassRegistry.java](https://codecov.io/gh/apache/dubbo/pull/8784/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vY29tbW9uL3NlcmlhbGl6ZS9zdXBwb3J0L1NlcmlhbGl6YWJsZUNsYXNzUmVnaXN0cnkuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...ate/endpoint/metadata/DubboReferencesMetadata.java](https://codecov.io/gh/apache/dubbo/pull/8784/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tc3ByaW5nLWJvb3QvZHViYm8tc3ByaW5nLWJvb3QtY29tcGF0aWJsZS9hY3R1YXRvci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vc3ByaW5nL2Jvb3QvYWN0dWF0ZS9lbmRwb2ludC9tZXRhZGF0YS9EdWJib1JlZmVyZW5jZXNNZXRhZGF0YS5qYXZh) | `5.55% <0.00%> (ø)` | |
   | [...factory/config/ServiceBeanIdConflictProcessor.java](https://codecov.io/gh/apache/dubbo/pull/8784/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tc3ByaW5nLWJvb3QvZHViYm8tc3ByaW5nLWJvb3QtY29tcGF0aWJsZS9hdXRvY29uZmlndXJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9zcHJpbmcvYm9vdC9iZWFucy9mYWN0b3J5L2NvbmZpZy9TZXJ2aWNlQmVhbklkQ29uZmxpY3RQcm9jZXNzb3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...apache/dubbo/common/extension/ExtensionLoader.java](https://codecov.io/gh/apache/dubbo/pull/8784/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vZXh0ZW5zaW9uL0V4dGVuc2lvbkxvYWRlci5qYXZh) | `81.32% <71.42%> (-0.16%)` | :arrow_down: |
   | [...c/cluster/router/mesh/rule/VsDestinationGroup.java](https://codecov.io/gh/apache/dubbo/pull/8784/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL21lc2gvcnVsZS9Wc0Rlc3RpbmF0aW9uR3JvdXAuamF2YQ==) | `100.00% <100.00%> (ø)` | |
   | [.../java/org/apache/dubbo/common/utils/TypeUtils.java](https://codecov.io/gh/apache/dubbo/pull/8784/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdXRpbHMvVHlwZVV0aWxzLmphdmE=) | `70.27% <100.00%> (ø)` | |
   | [...main/java/org/apache/dubbo/qos/textui/TLadder.java](https://codecov.io/gh/apache/dubbo/pull/8784/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcGx1Z2luL2R1YmJvLXFvcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcW9zL3RleHR1aS9UTGFkZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | |
   | [...ng/transport/dispatcher/all/AllChannelHandler.java](https://codecov.io/gh/apache/dubbo/pull/8784/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvZGlzcGF0Y2hlci9hbGwvQWxsQ2hhbm5lbEhhbmRsZXIuamF2YQ==) | `68.96% <0.00%> (-27.59%)` | :arrow_down: |
   | ... and [47 more](https://codecov.io/gh/apache/dubbo/pull/8784/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8784?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8784?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [5c2161a...2bb3ba8](https://codecov.io/gh/apache/dubbo/pull/8784?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8784: Inefficient Usages of Java Collections

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #8784:
URL: https://github.com/apache/dubbo/pull/8784#issuecomment-918779981


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8784?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#8784](https://codecov.io/gh/apache/dubbo/pull/8784?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2bb3ba8) into [3.0](https://codecov.io/gh/apache/dubbo/commit/5c2161aa0e9a073a51dd14e0c0edb36668d371a8?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5c2161a) will **decrease** coverage by `0.13%`.
   > The diff coverage is `52.94%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/8784/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/8784?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #8784      +/-   ##
   ============================================
   - Coverage     63.92%   63.79%   -0.14%     
   + Complexity      315      313       -2     
   ============================================
     Files          1156     1156              
     Lines         48702    48703       +1     
     Branches       7324     7324              
   ============================================
   - Hits          31134    31071      -63     
   - Misses        14175    14230      +55     
   - Partials       3393     3402       +9     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8784?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...figcenter/file/FileSystemDynamicConfiguration.java](https://codecov.io/gh/apache/dubbo/pull/8784/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vY29uZmlnL2NvbmZpZ2NlbnRlci9maWxlL0ZpbGVTeXN0ZW1EeW5hbWljQ29uZmlndXJhdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [.../apache/dubbo/config/bootstrap/DubboBootstrap.java](https://codecov.io/gh/apache/dubbo/pull/8784/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9ib290c3RyYXAvRHViYm9Cb290c3RyYXAuamF2YQ==) | `53.40% <ø> (ø)` | |
   | [...n/serialize/support/SerializableClassRegistry.java](https://codecov.io/gh/apache/dubbo/pull/8784/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vY29tbW9uL3NlcmlhbGl6ZS9zdXBwb3J0L1NlcmlhbGl6YWJsZUNsYXNzUmVnaXN0cnkuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...ate/endpoint/metadata/DubboReferencesMetadata.java](https://codecov.io/gh/apache/dubbo/pull/8784/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tc3ByaW5nLWJvb3QvZHViYm8tc3ByaW5nLWJvb3QtY29tcGF0aWJsZS9hY3R1YXRvci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vc3ByaW5nL2Jvb3QvYWN0dWF0ZS9lbmRwb2ludC9tZXRhZGF0YS9EdWJib1JlZmVyZW5jZXNNZXRhZGF0YS5qYXZh) | `5.55% <0.00%> (ø)` | |
   | [...factory/config/ServiceBeanIdConflictProcessor.java](https://codecov.io/gh/apache/dubbo/pull/8784/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tc3ByaW5nLWJvb3QvZHViYm8tc3ByaW5nLWJvb3QtY29tcGF0aWJsZS9hdXRvY29uZmlndXJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9zcHJpbmcvYm9vdC9iZWFucy9mYWN0b3J5L2NvbmZpZy9TZXJ2aWNlQmVhbklkQ29uZmxpY3RQcm9jZXNzb3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...apache/dubbo/common/extension/ExtensionLoader.java](https://codecov.io/gh/apache/dubbo/pull/8784/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vZXh0ZW5zaW9uL0V4dGVuc2lvbkxvYWRlci5qYXZh) | `81.71% <71.42%> (+0.23%)` | :arrow_up: |
   | [...c/cluster/router/mesh/rule/VsDestinationGroup.java](https://codecov.io/gh/apache/dubbo/pull/8784/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL21lc2gvcnVsZS9Wc0Rlc3RpbmF0aW9uR3JvdXAuamF2YQ==) | `100.00% <100.00%> (ø)` | |
   | [.../java/org/apache/dubbo/common/utils/TypeUtils.java](https://codecov.io/gh/apache/dubbo/pull/8784/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdXRpbHMvVHlwZVV0aWxzLmphdmE=) | `70.27% <100.00%> (ø)` | |
   | [...main/java/org/apache/dubbo/qos/textui/TLadder.java](https://codecov.io/gh/apache/dubbo/pull/8784/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcGx1Z2luL2R1YmJvLXFvcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcW9zL3RleHR1aS9UTGFkZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | |
   | [...ng/transport/dispatcher/all/AllChannelHandler.java](https://codecov.io/gh/apache/dubbo/pull/8784/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvZGlzcGF0Y2hlci9hbGwvQWxsQ2hhbm5lbEhhbmRsZXIuamF2YQ==) | `68.96% <0.00%> (-27.59%)` | :arrow_down: |
   | ... and [24 more](https://codecov.io/gh/apache/dubbo/pull/8784/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8784?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8784?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [5c2161a...2bb3ba8](https://codecov.io/gh/apache/dubbo/pull/8784?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org