You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/07/06 11:46:21 UTC
[GitHub] [incubator-nuttx] donghengqaz opened a new pull request #4082: boards/esp32c3: Support mounting SPI Flash MTD to littleFS
donghengqaz opened a new pull request #4082:
URL: https://github.com/apache/incubator-nuttx/pull/4082
## Summary
ESP32-C3 Devikit board supports mounting SPI Flash MTD to littleFS.
## Impact
## Testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #4082: boards/esp32c3: Support mounting SPI Flash MTD to littleFS
Posted by GitBox <gi...@apache.org>.
gustavonihei commented on a change in pull request #4082:
URL: https://github.com/apache/incubator-nuttx/pull/4082#discussion_r664540535
##########
File path: boards/risc-v/esp32c3/esp32c3-devkit/Kconfig
##########
@@ -65,6 +65,11 @@ choice
endchoice
+config ESP32C3_SPIFLASH_FS_MOUNT_PTR
+ string "File-system Mount Pointer"
Review comment:
```suggestion
config ESP32C3_SPIFLASH_FS_MOUNT_PT
string "File-system Mount Point"
```
nit: The correct expression would be "mount point"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #4082: boards/esp32c3: Support mounting SPI Flash MTD to littleFS
Posted by GitBox <gi...@apache.org>.
gustavonihei commented on a change in pull request #4082:
URL: https://github.com/apache/incubator-nuttx/pull/4082#discussion_r665403691
##########
File path: boards/risc-v/esp32c3/esp32c3-devkit/src/esp32c3_spiflash.c
##########
@@ -42,6 +42,14 @@
#include "esp32c3_spiflash.h"
#include "esp32c3-devkit.h"
+/****************************************************************************
+ * Pre-processor Definitions
+ ****************************************************************************/
+
+#define ESP32C3_MTD_PATH "/dev/esp32c3flash"
+
+#define ESP32C3_FS_MOUNT_PTR CONFIG_ESP32C3_SPIFLASH_FS_MOUNT_PT
Review comment:
```suggestion
#define ESP32C3_FS_MOUNT_PT CONFIG_ESP32C3_SPIFLASH_FS_MOUNT_PT
```
nit: This one should also be fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] gustavonihei merged pull request #4082: boards/esp32c3-devkit: Support mounting SPI Flash MTD to littleFS
Posted by GitBox <gi...@apache.org>.
gustavonihei merged pull request #4082:
URL: https://github.com/apache/incubator-nuttx/pull/4082
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org