You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "mailtoboggavarapu-coder (via GitHub)" <gi...@apache.org> on 2026/09/07 15:52:47 UTC
[PR] fix: close InflaterInputStream in HoodieAvroDataBlock.decompress() to prevent native memory leak [hudi]
mailtoboggavarapu-coder opened a new pull request, #19861:
URL: https://github.com/apache/hudi/pull/19861
### Describe the issue this Pull Request addresses
`HoodieAvroDataBlock.decompress()` creates an `InflaterInputStream` but never closes it. Unlike a `ByteArrayInputStream` (which holds no external resources), `InflaterInputStream` wraps a `java.util.zip.Inflater` object that allocates native (off-heap) zlib memory via JNI. This native memory is not managed by the JVM garbage collector — it must be released explicitly by calling `Inflater.end()`, which only happens through `InflaterInputStream.close()`.
Without closing the stream, native zlib memory leaks on every call — both on the normal exit path and when an `IOException` is thrown. In archived timeline reads where this method is called repeatedly, the leaked native memory accumulates and can eventually cause `OutOfMemoryError: native memory exhausted` even when heap memory is available.
Notably, the sibling `compress()` method in the same class already correctly uses try-with-resources for `DeflaterOutputStream`. This fix makes `decompress()` consistent with `compress()`.
### Summary and Changelog
Wrapped the `InflaterInputStream` in a try-with-resources statement in `HoodieAvroDataBlock.decompress()`, ensuring `close()` is always called to release the native zlib `Inflater` resources.
- `HoodieAvroDataBlock.java`: Added try-with-resources to `InflaterInputStream` in `decompress()`, consistent with the existing try-with-resources usage in `compress()`.
### Impact
No behaviour change. Prevents native memory leaks in archived timeline reads that invoke `decompress()`.
### Risk Level
low — One-line structural change; no logic change to decompression behaviour.
### Documentation Update
none
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Enough context is provided in the sections above
- [ ] Adequate tests were added if applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close InflaterInputStream in HoodieAvroDataBlock.decompress() to prevent native memory leak [hudi]
Posted by "mailtoboggavarapu-coder (via GitHub)" <gi...@apache.org>.
mailtoboggavarapu-coder commented on PR #19861:
URL: https://github.com/apache/hudi/pull/19861#issuecomment-5619247122
@voonhous this is a code-correctness fix identified through static analysis — the bug is environment-independent. `InflaterInputStream` wraps a `java.util.zip.Inflater` that holds native zlib resources explicitly documented to require `Inflater.end()` for release; that only happens via `InflaterInputStream.close()`. The asymmetry with `compress()` in the same file — which already uses try-with-resources — confirms this is simply a missing close, not a runtime-specific issue.
SPARK-41952 addresses Spark's own internal compression path. This is Hudi's `HoodieAvroDataBlock.decompress()`, a separate code path — the Spark fix doesn't cover it.
One-line structural fix, CI green, no logic change. cc @danny0405 @yihua
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close InflaterInputStream in HoodieAvroDataBlock.decompress() to prevent native memory leak [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #19861:
URL: https://github.com/apache/hudi/pull/19861#issuecomment-5574171086
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b636a882f3c22913f9df964a3267b42307baeb86",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16878",
"triggerID" : "b636a882f3c22913f9df964a3267b42307baeb86",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b636a882f3c22913f9df964a3267b42307baeb86 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16878)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close InflaterInputStream in HoodieAvroDataBlock.decompress() to prevent native memory leak [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #19861:
URL: https://github.com/apache/hudi/pull/19861#issuecomment-5573182581
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b636a882f3c22913f9df964a3267b42307baeb86",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b636a882f3c22913f9df964a3267b42307baeb86",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b636a882f3c22913f9df964a3267b42307baeb86 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close InflaterInputStream in HoodieAvroDataBlock.decompress() to prevent native memory leak [hudi]
Posted by "mailtoboggavarapu-coder (via GitHub)" <gi...@apache.org>.
mailtoboggavarapu-coder commented on PR #19861:
URL: https://github.com/apache/hudi/pull/19861#issuecomment-5611987315
Hi @voonhous, thanks for the question.
This is a static analysis finding rather than a runtime crash — the leak is structural. `InflaterInputStream` wraps a `java.util.zip.Inflater` internally, and `Inflater` allocates native (off-heap) zlib memory via JNI (`inflateInit` in native code). Releasing it requires an explicit call to `Inflater.end()`, which is only invoked through `InflaterInputStream.close()`. Without that, the native memory isn't freed until the GC eventually runs the finalizer — which is non-deterministic and increasingly unreliable in modern JVMs as finalizers are deprecated (JEP 421).
To observe it in practice, you can run a tight loop calling `decompress()` on a non-trivial compressed payload while monitoring native memory with:
```
-XX:NativeMemoryTracking=summary
jcmd <pid> VM.native_memory summary.diff
```
The "Other" segment in native memory tracking will grow unbounded without the fix. With the fix applied, it stays flat across the same number of calls.
The code-level evidence is clear:
- The `Inflater` Javadoc explicitly states: *"It is also possible to free the decompressor's native resource by explicitly calling the end method"*
- The sibling `compress()` method in this same class already wraps `DeflaterOutputStream` in try-with-resources — the asymmetry between the two methods is what surfaced this
- `ByteArrayInputStream` (the inner stream) holds no native resources, so the leak is specifically from the `InflaterInputStream` wrapper holding the `Inflater`
Happy to raise a JIRA issue with environment details if that helps track it formally. Let me know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close InflaterInputStream in HoodieAvroDataBlock.decompress() to prevent native memory leak [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #19861:
URL: https://github.com/apache/hudi/pull/19861#issuecomment-5573247944
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b636a882f3c22913f9df964a3267b42307baeb86",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16878",
"triggerID" : "b636a882f3c22913f9df964a3267b42307baeb86",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b636a882f3c22913f9df964a3267b42307baeb86 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16878)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close InflaterInputStream in HoodieAvroDataBlock.decompress() to prevent native memory leak [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #19861:
URL: https://github.com/apache/hudi/pull/19861#issuecomment-5573959672
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/19861?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 45.53%. Comparing base ([`76b4fa4`](https://app.codecov.io/gh/apache/hudi/commit/76b4fa404c724219f657cd64b788253bb31f23a4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b636a88`](https://app.codecov.io/gh/apache/hudi/commit/b636a882f3c22913f9df964a3267b42307baeb86?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 638 commits behind head on master.
> :exclamation: There is a different number of reports uploaded between BASE (76b4fa4) and HEAD (b636a88). Click for more details.
>
> <details><summary>HEAD has 27 uploads less than BASE</summary>
>
>| Flag | BASE (76b4fa4) | HEAD (b636a88) |
>|------|------|------|
>|spark-scala-tests|10|0|
>|spark-java-tests|15|0|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #19861 +/- ##
=============================================
- Coverage 68.53% 45.53% -23.01%
+ Complexity 28037 20468 -7569
=============================================
Files 2444 2620 +176
Lines 134752 143710 +8958
Branches 16292 17024 +732
=============================================
- Hits 92356 65439 -26917
- Misses 35112 73013 +37901
+ Partials 7284 5258 -2026
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/19861/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/19861/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [flink-integration-tests](https://app.codecov.io/gh/apache/hudi/pull/19861/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.65% <ø> (?)` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/19861/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.12% <ø> (-0.81%)` | :arrow_down: |
| [integration-tests](https://app.codecov.io/gh/apache/hudi/pull/19861/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `13.49% <ø> (?)` | |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/19861/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `50.58% <ø> (+2.12%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/19861/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/19861/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/19861/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/19861?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...di/common/table/log/block/HoodieAvroDataBlock.java](https://app.codecov.io/gh/apache/hudi/pull/19861?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2Fblock%2FHoodieAvroDataBlock.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL2xvZy9ibG9jay9Ib29kaWVBdnJvRGF0YUJsb2NrLmphdmE=) | `29.74% <ø> (-25.18%)` | :arrow_down: |
... and [2214 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/19861/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close InflaterInputStream in HoodieAvroDataBlock.decompress() to prevent native memory leak [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #19861:
URL: https://github.com/apache/hudi/pull/19861#issuecomment-5573955126
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/19861?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 62.26%. Comparing base ([`76b4fa4`](https://app.codecov.io/gh/apache/hudi/commit/76b4fa404c724219f657cd64b788253bb31f23a4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b636a88`](https://app.codecov.io/gh/apache/hudi/commit/b636a882f3c22913f9df964a3267b42307baeb86?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 638 commits behind head on master.
> :exclamation: There is a different number of reports uploaded between BASE (76b4fa4) and HEAD (b636a88). Click for more details.
>
> <details><summary>HEAD has 27 uploads less than BASE</summary>
>
>| Flag | BASE (76b4fa4) | HEAD (b636a88) |
>|------|------|------|
>|spark-scala-tests|10|0|
>|spark-java-tests|15|0|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #19861 +/- ##
============================================
- Coverage 68.53% 62.26% -6.28%
+ Complexity 28037 20047 -7990
============================================
Files 2444 1948 -496
Lines 134752 102517 -32235
Branches 16292 11644 -4648
============================================
- Hits 92356 63831 -28525
+ Misses 35112 33680 -1432
+ Partials 7284 5006 -2278
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/19861/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/19861/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [flink-integration-tests](https://app.codecov.io/gh/apache/hudi/pull/19861/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.65% <ø> (?)` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/19861/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.12% <ø> (-0.81%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/19861/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `50.58% <ø> (+2.12%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/19861/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/19861/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/19861/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/19861?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...di/common/table/log/block/HoodieAvroDataBlock.java](https://app.codecov.io/gh/apache/hudi/pull/19861?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2Fblock%2FHoodieAvroDataBlock.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL2xvZy9ibG9jay9Ib29kaWVBdnJvRGF0YUJsb2NrLmphdmE=) | `29.74% <ø> (-25.18%)` | :arrow_down: |
... and [2133 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/19861/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close InflaterInputStream in HoodieAvroDataBlock.decompress() to prevent native memory leak [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #19861:
URL: https://github.com/apache/hudi/pull/19861#issuecomment-5574255717
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/19861?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 76.38%. Comparing base ([`76b4fa4`](https://app.codecov.io/gh/apache/hudi/commit/76b4fa404c724219f657cd64b788253bb31f23a4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b636a88`](https://app.codecov.io/gh/apache/hudi/commit/b636a882f3c22913f9df964a3267b42307baeb86?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 638 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #19861 +/- ##
============================================
+ Coverage 68.53% 76.38% +7.84%
- Complexity 28037 34147 +6110
============================================
Files 2444 2682 +238
Lines 134752 146571 +11819
Branches 16292 17570 +1278
============================================
+ Hits 92356 111955 +19599
+ Misses 35112 26871 -8241
- Partials 7284 7745 +461
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/19861/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/19861/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `50.88% <ø> (+6.53%)` | :arrow_up: |
| [flink-integration-tests](https://app.codecov.io/gh/apache/hudi/pull/19861/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.65% <ø> (?)` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/19861/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.12% <ø> (-0.81%)` | :arrow_down: |
| [integration-tests](https://app.codecov.io/gh/apache/hudi/pull/19861/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `13.49% <ø> (?)` | |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/19861/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `50.58% <ø> (+2.12%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/19861/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `52.15% <ø> (+3.36%)` | :arrow_up: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/19861/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `46.74% <ø> (+1.11%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/19861/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `36.51% <ø> (-1.87%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/19861?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...di/common/table/log/block/HoodieAvroDataBlock.java](https://app.codecov.io/gh/apache/hudi/pull/19861?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2Fblock%2FHoodieAvroDataBlock.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL2xvZy9ibG9jay9Ib29kaWVBdnJvRGF0YUJsb2NrLmphdmE=) | `54.87% <ø> (-0.06%)` | :arrow_down: |
... and [1771 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/19861/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close InflaterInputStream in HoodieAvroDataBlock.decompress() to prevent native memory leak [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 merged PR #19861:
URL: https://github.com/apache/hudi/pull/19861
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close InflaterInputStream in HoodieAvroDataBlock.decompress() to prevent native memory leak [hudi]
Posted by "voonhous (via GitHub)" <gi...@apache.org>.
voonhous commented on PR #19861:
URL: https://github.com/apache/hudi/pull/19861#issuecomment-5574148960
Hello @mailtoboggavarapu-coder can you please share a reproduction script or diagnosis prose on a live example? It'll greatly help us visualize what is going on and expedite this fix along.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close InflaterInputStream in HoodieAvroDataBlock.decompress() to prevent native memory leak [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #19861:
URL: https://github.com/apache/hudi/pull/19861#issuecomment-5573898016
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/19861?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 54.58%. Comparing base ([`76b4fa4`](https://app.codecov.io/gh/apache/hudi/commit/76b4fa404c724219f657cd64b788253bb31f23a4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b636a88`](https://app.codecov.io/gh/apache/hudi/commit/b636a882f3c22913f9df964a3267b42307baeb86?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 638 commits behind head on master.
> :exclamation: There is a different number of reports uploaded between BASE (76b4fa4) and HEAD (b636a88). Click for more details.
>
> <details><summary>HEAD has 27 uploads less than BASE</summary>
>
>| Flag | BASE (76b4fa4) | HEAD (b636a88) |
>|------|------|------|
>|spark-scala-tests|10|0|
>|spark-java-tests|15|0|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #19861 +/- ##
=============================================
- Coverage 68.53% 54.58% -13.96%
+ Complexity 28037 17575 -10462
=============================================
Files 2444 1948 -496
Lines 134752 102517 -32235
Branches 16292 11644 -4648
=============================================
- Hits 92356 55957 -36399
- Misses 35112 41555 +6443
+ Partials 7284 5005 -2279
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/19861/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/19861/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [flink-integration-tests](https://app.codecov.io/gh/apache/hudi/pull/19861/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `36.44% <ø> (?)` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/19861/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.12% <ø> (-0.81%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/19861/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `50.58% <ø> (+2.12%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/19861/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/19861/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/19861/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/19861?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...di/common/table/log/block/HoodieAvroDataBlock.java](https://app.codecov.io/gh/apache/hudi/pull/19861?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2Fblock%2FHoodieAvroDataBlock.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL2xvZy9ibG9jay9Ib29kaWVBdnJvRGF0YUJsb2NrLmphdmE=) | `29.74% <ø> (-25.18%)` | :arrow_down: |
... and [2152 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/19861/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close InflaterInputStream in HoodieAvroDataBlock.decompress() to prevent native memory leak [hudi]
Posted by "mailtoboggavarapu-coder (via GitHub)" <gi...@apache.org>.
mailtoboggavarapu-coder commented on PR #19861:
URL: https://github.com/apache/hudi/pull/19861#issuecomment-5573065379
Pinging for committer review. `HoodieAvroDataBlock.decompress()` creates an `InflaterInputStream` but never closes it — the native zlib `Inflater` inside it leaks on every call since its native memory is not GC-managed. The sibling `compress()` method already uses try-with-resources correctly; this fix makes `decompress()` consistent with it. One file changed, no logic change.
[@danny0405](https://github.com/danny0405) [@yihua](https://github.com/yihua) [@vinothchandrasekar](https://github.com/vinothchandrasekar) [@nsivabalan](https://github.com/nsivabalan) — would appreciate a review when you get a chance. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close InflaterInputStream in HoodieAvroDataBlock.decompress() to prevent native memory leak [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #19861:
URL: https://github.com/apache/hudi/pull/19861#issuecomment-5573756769
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/19861?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 44.12%. Comparing base ([`76b4fa4`](https://app.codecov.io/gh/apache/hudi/commit/76b4fa404c724219f657cd64b788253bb31f23a4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b636a88`](https://app.codecov.io/gh/apache/hudi/commit/b636a882f3c22913f9df964a3267b42307baeb86?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 638 commits behind head on master.
> :exclamation: There is a different number of reports uploaded between BASE (76b4fa4) and HEAD (b636a88). Click for more details.
>
> <details><summary>HEAD has 28 uploads less than BASE</summary>
>
>| Flag | BASE (76b4fa4) | HEAD (b636a88) |
>|------|------|------|
>|spark-client-hadoop-common|1|0|
>|spark-scala-tests|10|0|
>|spark-java-tests|15|0|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #19861 +/- ##
=============================================
- Coverage 68.53% 44.12% -24.42%
+ Complexity 28037 9145 -18892
=============================================
Files 2444 1250 -1194
Lines 134752 68120 -66632
Branches 16292 7766 -8526
=============================================
- Hits 92356 30057 -62299
+ Misses 35112 34695 -417
+ Partials 7284 3368 -3916
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/19861/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/19861/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/19861/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.12% <ø> (-0.81%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/19861/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/19861/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/19861/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/19861/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/19861?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...di/common/table/log/block/HoodieAvroDataBlock.java](https://app.codecov.io/gh/apache/hudi/pull/19861?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2Fblock%2FHoodieAvroDataBlock.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL2xvZy9ibG9jay9Ib29kaWVBdnJvRGF0YUJsb2NrLmphdmE=) | `27.17% <ø> (-27.75%)` | :arrow_down: |
... and [2377 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/19861/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close InflaterInputStream in HoodieAvroDataBlock.decompress() to prevent native memory leak [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #19861:
URL: https://github.com/apache/hudi/pull/19861#issuecomment-5573865837
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/19861?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 55.82%. Comparing base ([`76b4fa4`](https://app.codecov.io/gh/apache/hudi/commit/76b4fa404c724219f657cd64b788253bb31f23a4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b636a88`](https://app.codecov.io/gh/apache/hudi/commit/b636a882f3c22913f9df964a3267b42307baeb86?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 638 commits behind head on master.
> :exclamation: There is a different number of reports uploaded between BASE (76b4fa4) and HEAD (b636a88). Click for more details.
>
> <details><summary>HEAD has 27 uploads less than BASE</summary>
>
>| Flag | BASE (76b4fa4) | HEAD (b636a88) |
>|------|------|------|
>|spark-scala-tests|10|0|
>|spark-java-tests|15|0|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #19861 +/- ##
=============================================
- Coverage 68.53% 55.82% -12.72%
+ Complexity 28037 14055 -13982
=============================================
Files 2444 1495 -949
Lines 134752 78148 -56604
Branches 16292 9302 -6990
=============================================
- Hits 92356 43625 -48731
+ Misses 35112 30577 -4535
+ Partials 7284 3946 -3338
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/19861/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/19861/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/19861/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.12% <ø> (-0.81%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/19861/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `50.58% <ø> (+2.12%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/19861/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/19861/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/19861/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/19861?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...di/common/table/log/block/HoodieAvroDataBlock.java](https://app.codecov.io/gh/apache/hudi/pull/19861?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2Fblock%2FHoodieAvroDataBlock.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL2xvZy9ibG9jay9Ib29kaWVBdnJvRGF0YUJsb2NrLmphdmE=) | `29.74% <ø> (-25.18%)` | :arrow_down: |
... and [2204 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/19861/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close InflaterInputStream in HoodieAvroDataBlock.decompress() to prevent native memory leak [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #19861:
URL: https://github.com/apache/hudi/pull/19861#issuecomment-5574062522
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/19861?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 66.05%. Comparing base ([`76b4fa4`](https://app.codecov.io/gh/apache/hudi/commit/76b4fa404c724219f657cd64b788253bb31f23a4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b636a88`](https://app.codecov.io/gh/apache/hudi/commit/b636a882f3c22913f9df964a3267b42307baeb86?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 638 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #19861 +/- ##
============================================
- Coverage 68.53% 66.05% -2.48%
- Complexity 28037 29738 +1701
============================================
Files 2444 2682 +238
Lines 134752 146571 +11819
Branches 16292 17570 +1278
============================================
+ Hits 92356 96824 +4468
- Misses 35112 42826 +7714
+ Partials 7284 6921 -363
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/19861/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/19861/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `50.88% <ø> (+6.53%)` | :arrow_up: |
| [flink-integration-tests](https://app.codecov.io/gh/apache/hudi/pull/19861/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.65% <ø> (?)` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/19861/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.12% <ø> (-0.81%)` | :arrow_down: |
| [integration-tests](https://app.codecov.io/gh/apache/hudi/pull/19861/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `13.49% <ø> (?)` | |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/19861/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `50.58% <ø> (+2.12%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/19861/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.12% <ø> (-16.67%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/19861/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/19861/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `36.51% <ø> (-1.87%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/19861?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...di/common/table/log/block/HoodieAvroDataBlock.java](https://app.codecov.io/gh/apache/hudi/pull/19861?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2Fblock%2FHoodieAvroDataBlock.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL2xvZy9ibG9jay9Ib29kaWVBdnJvRGF0YUJsb2NrLmphdmE=) | `54.87% <ø> (-0.06%)` | :arrow_down: |
... and [1925 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/19861/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close InflaterInputStream in HoodieAvroDataBlock.decompress() to prevent native memory leak [hudi]
Posted by "voonhous (via GitHub)" <gi...@apache.org>.
voonhous commented on PR #19861:
URL: https://github.com/apache/hudi/pull/19861#issuecomment-5613479031
@mailtoboggavarapu-coder Understand that you're facing the issue but pelase give more details on your environment. An issue would be helpful. We're trying to dig into this a little deeper as we've encountered similar issues in the past that might have been fixed. We'd need to check if this is unique/new.
For example: https://issues.apache.org/jira/browse/SPARK-41952
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org