You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/12/14 11:17:47 UTC

[GitHub] [spark] bogdanghit edited a comment on pull request #25252: [SPARK-28510][SQL] Implement Spark's own GetFunctionsOperation

bogdanghit edited a comment on pull request #25252:
URL: https://github.com/apache/spark/pull/25252#issuecomment-993437927


   Hi @dongjoon-hyun @wangyum. I checked this out with DbVisualizer and it is indeed loading the available function set for every schema in the database. I'm attaching two screenshots:
   Top of the list:
   <img width="616" alt="Screenshot 2021-12-14 at 12 12 55" src="https://user-images.githubusercontent.com/36250654/145988090-4ef88277-8a01-4cdd-8601-45d01bb37bf9.png">
   
   After scrolling down:
   <img width="627" alt="Screenshot 2021-12-14 at 12 13 14" src="https://user-images.githubusercontent.com/36250654/145988496-0696e7a7-52af-4e04-9fc0-e4227c50277f.png">
   
   If the there are many schemas, it can take a while for a GetFunctions operation to return and it also creates a poor experience because of the exhaustive and repetitive list of functions returned. 
   
   That being said, it doesn't look like a breaking change to me, more like a bug and fixing it would significantly improve UX.
   WDYT?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org