You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by mg...@apache.org on 2013/11/20 13:52:08 UTC
[5/5] git commit: WICKET-5420 Make UploadProgressBar easier to extend
WICKET-5420 Make UploadProgressBar easier to extend
Change the type of the bar and status components to MarkupContainer so they can have children if needed
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/40f00247
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/40f00247
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/40f00247
Branch: refs/heads/master
Commit: 40f00247875f91ba92cd01e075adb652510c3123
Parents: 9abb70e
Author: Martin Tzvetanov Grigorov <mg...@apache.org>
Authored: Wed Nov 20 14:51:01 2013 +0200
Committer: Martin Tzvetanov Grigorov <mg...@apache.org>
Committed: Wed Nov 20 14:51:54 2013 +0200
----------------------------------------------------------------------
.../html/form/upload/UploadProgressBar.java | 23 ++++++++++++++++----
1 file changed, 19 insertions(+), 4 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/wicket/blob/40f00247/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/form/upload/UploadProgressBar.java
----------------------------------------------------------------------
diff --git a/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/form/upload/UploadProgressBar.java b/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/form/upload/UploadProgressBar.java
index e69582d..0240319 100644
--- a/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/form/upload/UploadProgressBar.java
+++ b/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/form/upload/UploadProgressBar.java
@@ -21,6 +21,7 @@ import java.util.Formatter;
import org.apache.wicket.Application;
import org.apache.wicket.Component;
import org.apache.wicket.IInitializer;
+import org.apache.wicket.MarkupContainer;
import org.apache.wicket.extensions.ajax.markup.html.modal.ModalWindow;
import org.apache.wicket.markup.head.CssHeaderItem;
import org.apache.wicket.markup.head.IHeaderResponse;
@@ -114,9 +115,9 @@ public class UploadProgressBar extends Panel
private final Form<?> form;
- private Component statusDiv;
+ private MarkupContainer statusDiv;
- private Component barDiv;
+ private MarkupContainer barDiv;
private final FileUploadField uploadField;
@@ -175,14 +176,28 @@ public class UploadProgressBar extends Panel
add(statusDiv);
}
- protected Component newStatusComponent(String id)
+ /**
+ * Creates a component for the status text
+ *
+ * @param id
+ * The component id
+ * @return the status component
+ */
+ protected MarkupContainer newStatusComponent(String id)
{
WebMarkupContainer status = new WebMarkupContainer(id);
status.setOutputMarkupId(true);
return status;
}
- protected Component newBarComponent(String id)
+ /**
+ * Creates a component for the bar
+ *
+ * @param id
+ * The component id
+ * @return the bar component
+ */
+ protected MarkupContainer newBarComponent(String id)
{
WebMarkupContainer bar = new WebMarkupContainer(id);
bar.setOutputMarkupId(true);