[GitHub] [skywalking-rocketbot-ui] Fine0830 commented on a change in pull request #478: When creating service groups in the topology, it is better if the service names are sorted.

[GitBox <gi...@apache.org>]

Fine0830 commented on a change in pull request #478:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/478#discussion_r615597952



##########
File path: src/views/components/topology/topo-group/index.vue
##########
@@ -98,7 +98,10 @@ limitations under the License. -->
           duration: this.durationTime,
         },
       }).then((res: AxiosResponse) => {
-        this.servicesMap = res.data.data.services ? res.data.data.services : [];
+        const map = res.data.data.services ? res.data.data.services : [];
+        this.servicesMap = map.sort((a: any, b: any) => {

Review comment:
       Please Set types for `a` and `b`.  Here they are. `import { Option } from '@/types/global';`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org